Re: [PATCH] i2c: omap: fix OOPS in omap_i2c_unidle() during probe

2010-03-31 Thread Jarkko Nikula
On Wed, 31 Mar 2010 04:27:41 -0600 (MDT) Paul Walmsley wrote: > > This patch moves register shift setting before any register accesses are > > done. > > > > Signed-off-by: Mika Westerberg > > Cc: Cory Maccarrone > > Tested-by: Paul Walmsley > BTW, Tony had the same fix buried in an another

Re: [PATCH] i2c: omap: fix OOPS in omap_i2c_unidle() during probe

2010-03-31 Thread Paul Walmsley
Hi Mika, Ben, On Tue, 23 Mar 2010, Mika Westerberg wrote: > Commit d84d3ea317ce0db89ce0903b4037f800c5d4c477 added register shift to allow > also 16-bit register access. However, omap_i2c_unidle() is called before these > are set which causes the following OOPS: > > Unhandled fault: alignment