Hi Alan and Wolfram Sang
Sorry, previous patch is invalid patch.
Please refer this patch.
Thanks, Ohtake (OKISemi)
---
I2C driver of Topcliff PCH
Topcliff PCH is the platform controller hub that is going to be used in
Intel's upcoming general embedded platform. All IO peripherals in
Topcliff PC
Hi Alan and Wolfram Sang
We have updated for your indications.
Please confirm below.
Thanks, Ohtake (OKISemi)
---
I2C driver of Topcliff PCH
Topcliff PCH is the platform controller hub that is going to be used in
Intel's upcoming general embedded platform. All IO peripherals in
Topcliff PCH are
Hi Wolfram Sang,
Thank you for your comments.
We will update and resubmit soon.
Thanks, Ohtake(OKISemi)
- Original Message -
From: "Wolfram Sang"
To: "Alan Cox"
Cc: "Masayuki Ohtak" ; "Jean Delvare (PC drivers,
core)" ; "Ben Dooks
(embedded platforms)" ; "Crane Cai" ;
"Samuel Ortiz"
Hi Alan,
Thank you for your comments.
We will update and resubmit soon.
Thanks, Ohtake(OKISemi)
- Original Message -
From: "Alan Cox"
To: "Masayuki Ohtak"
Cc: "Jean Delvare (PC drivers, core)" ; "Ben Dooks
(embedded platforms)" ;
"Crane Cai" ; "Samuel Ortiz" ; "Linus
Walleij" ;
"Ralf
From: Rhyland Klein
this driver depends on I2C and uses SMBUS for communication with the host.
Addressed comments from reviews by Mark Brown and Jean Delvare.
* Cleaned up whitespace and alignment issues
* changed return codes to more appropriate values
* change Kconfig option name to b
The function has an unsigned return type, but returns a negative constant
to indicate an error condition. The result of calling the function is
always stored in a variable of type (signed) int, and thus unsigned can be
dropped from the return type.
A sematic match that finds this problem is as fo
Hi Rhyland,
On Thu, 2 Sep 2010 10:29:46 -0700, rkl...@nvidia.com wrote:
> From: Rhyland Klein
>
> this driver depends on I2C and uses SMBUS for communication with the host.
>
> Addressed comments from reviews by Mark Brown and Jean Delvare.
> * Cleaned up whitespace and alignment issues
>
On Sun, Sep 05, 2010 at 01:49:36AM -0700, Rhyland Klein wrote:
> Thanks, sorry I somehow missed that email.
No problem.
Also, please don't top post on Linux lists - it makes it much harder to
follow the thread of discussion.
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c"
Thanks, sorry I somehow missed that email.
-Original Message-
From: Mark Brown [mailto:broo...@opensource.wolfsonmicro.com]
Sent: Sunday, September 05, 2010 1:47 AM
To: Rhyland Klein
Cc: Anton Vorontsov; linux-i2c@vger.kernel.org; linux-ker...@vger.kernel.org;
o...@lixom.net; Andrew Chew
On Sat, Sep 04, 2010 at 02:00:47PM -0700, Rhyland Klein wrote:
> Mark, have you had a chance to double check my changes based on the comments
> you made?
Yes: http://lkml.org/lkml/2010/9/3/136
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to ma
10 matches
Mail list logo
