On Tue, 2010-10-05 at 15:42 -0700, rkl...@nvidia.com wrote:
> From: Rhyland Klein
Hi again.
> diff --git a/drivers/staging/iio/light/isl29018.c
> b/drivers/staging/iio/light/isl29018.c
[]
> +#define ISL29018_REG_ADD_DATA_LSB0x02
> +#define ISL29018_REG_ADD_DATA_MSB0x03
> +#define ISL290
From: Rhyland Klein
Adding support for the ISL 29018 ambient light and proximity sensor.
Addressed comments from reviews by Jonathan Cameron and Joe Perches
* Removed some excess dbg prints that only printed function name
* Renamed some properties to make them more descriptive
* Added a pr
On Wed, 29 Sep 2010 12:10:01 +0300
Samu Onkalo wrote:
> Documentation is provided as a part of the patch set.
> I created "leds" sub directory to Documentation.
> Perhaps rest of the leds* documentation should be moved
> there.
That sounds like a good idea.
--
To unsubscribe from this list: send
On Wed, 29 Sep 2010 12:10:02 +0300
Samu Onkalo wrote:
> +#define cdev_to_led(c) container_of(c, struct lp5521_led, cdev)
> +#define engine_to_lp5521(eng)container_of((eng), struct lp5521_chip,
> \
> + engines[(eng)->id - 1])
> +#d
On Tue, Oct 05, 2010 at 12:23:23PM +0100, Alan Cox wrote:
> > + chip->regs[0].supply = reg_vcc;
> > + chip->regs[1].supply = reg_vled;
> Shouldn't these come from the provided platform data ? and again if there
> isn't a platform one supplied just skip the regulators. There are going
No, don
On Tue, 2010-10-05 at 14:36 -0700, Rhyland Klein wrote:
> > -Original Message-
> > From: Joe Perches [mailto:j...@perches.com]
> > > diff --git a/drivers/staging/iio/light/isl29018.c
> > b/drivers/staging/iio/light/isl29018.c
> > > +static int isl29018_chip_init(struct i2c_client *client)
>
> -Original Message-
> From: Joe Perches [mailto:j...@perches.com]
> Sent: Tuesday, October 05, 2010 2:35 PM
> To: Rhyland Klein
> Cc: ji...@cam.ac.uk; Andrew Chew; o...@lixom.net; linux-
> i...@vger.kernel.org; linux-ker...@vger.kernel.org; linux-
> i...@vger.kernel.org; Laxman Dewangan
>
On Tue, 2010-10-05 at 14:19 -0700, rkl...@nvidia.com wrote:
> Adding support for the ISL 29018 ambient light and proximity sensor.
Trivial comments below.
> diff --git a/drivers/staging/iio/light/isl29018.c
> b/drivers/staging/iio/light/isl29018.c
[]
> +static int isl29018_set_range(struct i2c_c
From: Rhyland Klein
Adding support for the ISL 29018 ambient light and proximity sensor.
Addressed comments from Jonathan Cameron's review
* Removed some excess dbg prints that only printed function name
* Renamed some properties to make them more descriptive
* Added a property to list ava
On Tue, Oct 05, 2010 at 05:19:18PM +0100, Alan Cox wrote:
> +
> +/*
> + * Largest keycode that the chip can send, plus one,
> + * so keys can be mapped directly at the index of the
> + * TC35894XBG keycode instead of subtracting one.
> + */
> +#define TC35894XBG_KEYMAP_SIZE (0x7f + 1)
> +
> +#
On Tue, Oct 05, 2010 at 10:03:49AM +0200, Jean Delvare wrote:
> Hmm, too bad. What about the following then? It's nor exactly elegant,
> but if it works for you...
>
> ---
> drivers/i2c/Kconfig |3 ++-
> drivers/i2c/algos/Kconfig | 13 +
> 2 files changed, 15 insertions(+)
Signed-off-by: Guenter Roeck
---
drivers/i2c/muxes/Kconfig | 10 +
drivers/i2c/muxes/Makefile |1 +
drivers/i2c/muxes/pca9541.c | 419 +++
3 files changed, 430 insertions(+), 0 deletions(-)
create mode 100644 drivers/i2c/muxes/pca9541.c
diff --g
From: Jean Delvare
Subject: i2c: Discard warning message on device instantiation from user-space
The "new_device" sysfs interface has been there for quite some time
now, nobody complained about it so it must be good enough. Time to
remove the warning and call it stable.
Signed-off-by: Jean Delva
On 10/05/10 13:22, Onkalo Samu wrote:
>
> Jonathan, thanks.
>
> -Samu
>
> On Tue, 2010-10-05 at 13:53 +0200, ext Jonathan Cameron wrote:
>> On 10/05/10 10:42, Samu Onkalo wrote:
>>> Add short documentation for two ALS / proximity chip drivers.
>>
>> Hi Samu,
>>
>> Good to see the documentation a
On Tue, 2010-10-05 at 15:00 +0200, ext Alan Cox wrote:
> > > - not clear how power_state and runtime pm interact - do we in fact need
> > > power state ?
> >
> > power_state turns chip on or off. In off state runtime pm is used to
> > handle bookkeeping and also handling chip state transitions i
On Tue, 2010-10-05 at 14:01 +0200, ext Alan Cox wrote:
> On Tue, 05 Oct 2010 14:29:50 +0300
> > > > + for (i = 0; i < ARRAY_SIZE(prox_rates); i++)
> > > > + if (prox_rates[i] == rate_threshold) {
> > > > + chip->prox_rate_threshold = i;
> > > > +
> > - not clear how power_state and runtime pm interact - do we in fact need
> > power state ?
>
> power_state turns chip on or off. In off state runtime pm is used to
> handle bookkeeping and also handling chip state transitions including
> regulators. Other ideas than separate power_state for
Jonathan, thanks.
-Samu
On Tue, 2010-10-05 at 13:53 +0200, ext Jonathan Cameron wrote:
> On 10/05/10 10:42, Samu Onkalo wrote:
> > Add short documentation for two ALS / proximity chip drivers.
>
> Hi Samu,
>
> Good to see the documentation as it makes commenting on naming etc far
> simpler.
>
Thanks
-Samu
On Tue, 2010-10-05 at 13:23 +0200, ext Alan Cox wrote:
> > +static int apds990x_refresh_athres(struct apds990x_chip *chip)
> > +{
> > + int ret;
> > + /* If the chip is not in use, don't try to access it */
> > + if (pm_runtime_suspended(&chip->client->dev))
> > + ret
On 10/05/10 10:42, Samu Onkalo wrote:
> Add short documentation for two ALS / proximity chip drivers.
Hi Samu,
Good to see the documentation as it makes commenting on naming etc far simpler.
There are a lot of comments, but that's because you define a lot of new
interfaces and as ever I'm intere
On Tue, 05 Oct 2010 14:29:50 +0300
Onkalo Samu wrote:
>
> Alan, thanks for comments
>
> -Samu
>
> On Tue, 2010-10-05 at 13:21 +0200, ext Alan Cox wrote:
> > On Tue, 5 Oct 2010 12:42:55 +0300
> > Samu Onkalo wrote:
> >
> > > This is a driver for ROHM BH1770GLC and OSRAM SFH7770 combined
> >
Alan, thanks for comments
-Samu
On Tue, 2010-10-05 at 13:21 +0200, ext Alan Cox wrote:
> On Tue, 5 Oct 2010 12:42:55 +0300
> Samu Onkalo wrote:
>
> > This is a driver for ROHM BH1770GLC and OSRAM SFH7770 combined
> > ALS and proximity sensor.
>
> Same comment about regulators.
?
>
>
> >
> +static int apds990x_refresh_athres(struct apds990x_chip *chip)
> +{
> + int ret;
> + /* If the chip is not in use, don't try to access it */
> + if (pm_runtime_suspended(&chip->client->dev))
> + return 0;
> +
> + ret = apds990x_write_word(chip, APDS990X_AILTL,
> +
On Tue, 5 Oct 2010 12:42:55 +0300
Samu Onkalo wrote:
> This is a driver for ROHM BH1770GLC and OSRAM SFH7770 combined
> ALS and proximity sensor.
Same comment about regulators.
> +/* Supported stand alone rates in ms from chip data sheet */
> +static s16 prox_rates[] = {10, 20, 30, 40, 70, 10
This is a driver for ROHM BH1770GLC and OSRAM SFH7770 combined
ALS and proximity sensor.
Interface is sysfs based. The driver uses interrupts to provide new data.
The driver supports pm_runtime and regulator frameworks.
See Documentation/misc-devices/bhsfh.txt for details
Signed-off-by: Samu Onk
Patch set contains two drivers. One for BH1770GLC / SFH7770 chips and
one for APDS990X chip.
Both drivers have similar sysfs based interface. Both supports
pm_runtime and regulator frame work. There is short documentation
for both drivers.
Unfortunately I can't promise data sheets to public acces
Add short documentation for two ALS / proximity chip drivers.
Signed-off-by: Samu Onkalo
---
Documentation/misc-devices/apds990x.txt | 126 +++
Documentation/misc-devices/bhsfh.txt| 125 ++
2 files changed, 251 insertions(+), 0 deleti
Compilation support for bhsfh driver
Signed-off-by: Samu Onkalo
---
drivers/misc/Kconfig | 10 ++
drivers/misc/Makefile |1 +
2 files changed, 11 insertions(+), 0 deletions(-)
diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
index b743312..f2e8065 100644
--- a/drivers/mis
Compilation support for apds990x driver
Signed-off-by: Samu Onkalo
---
drivers/misc/Kconfig | 11 +++
drivers/misc/Makefile |1 +
2 files changed, 12 insertions(+), 0 deletions(-)
diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
index f2e8065..cc7c363 100644
--- a/drivers
This is a driver for Avago APDS990X combined ALS and proximity sensor.
Interface is sysfs based. The driver uses interrupts to provide new data.
The driver supports pm_runtime and regulator frameworks.
See Documentation/misc-devices/apds990x.txt for details
Signed-off-by: Samu Onkalo
---
drive
Hi Michal,
On Tue, 5 Oct 2010 00:30:20 +0200, Michal Marek wrote:
> (Sorry, I missed the patch in your message before)
>
> On Mon, Oct 04, 2010 at 06:03:46PM +0200, Jean Delvare wrote:
> > On Mon, 4 Oct 2010 15:31:33 +0200, Michal Marek wrote:
> > [...] selects I2C_ALGOBIT which has unmet direct
31 matches
Mail list logo
