Hi Nobuhiro (long time no see :))!
On Tue, Oct 19, 2010 at 11:45:31AM +0900, Nobuhiro Iwamatsu wrote:
> i2c->adap.name shouldn't be used in request_irq.
> Instead the driver name "i2c-pca-platform" should be used.
>
> Signed-off-by: Nobuhiro Iwamatsu
Looks good to me, thanks for fixing it (and
i2c->adap.name shouldn't be used in request_irq.
Instead the driver name "i2c-pca-platform" should be used.
Signed-off-by: Nobuhiro Iwamatsu
CC: Wolfram Sang
CC: Jean Delvare
---
drivers/i2c/busses/i2c-pca-platform.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/dri
Hi, Jean .
Thank for your comments.
Jean Delvare wrote:
Hi Nobuhiro,
On Mon, 18 Oct 2010 12:24:30 +0900, Nobuhiro Iwamatsu wrote:
In kernel which enableded this driver output The following warning,
because a slash (/) is in the i2c adapter name by the current driver.
This set another adapter
On Mon, Oct 18, 2010 at 10:33, Jean Delvare wrote:
> Why do we have set_irq_type() if we're not supposed to call it? I am
> not claiming to be an expert in the area, but it seems totally
> reasonable to me that the same piece of code instantiating an I2C
> device is also responsible for setting its
Jean Delvare wrote on 2010-10-18:
> Hi Michael, David,
>
> David, question for you below.
>
> On Mon, 18 Oct 2010 13:31:21 +0100, Hennerich, Michael wrote:
>> Jean Delvare wrote on 2010-10-18:
>>> Hi Michael,
>>>
>>> On Mon, 18 Oct 2010 10:55:57 +0100, Hennerich, Michael wrote:
Jean Delvare wr
On Mon, 2010-10-18 at 16:33 +0200, Jean Delvare wrote:
>
> This is an interesting point. David, you're the one who added irq to
> struct i2c_client, you didn't add irq_flags then, did you have a good
> reason not to?
There was no evident need to do so. The problem wasn't characterizing
the IRQ
Hi Michael, David,
David, question for you below.
On Mon, 18 Oct 2010 13:31:21 +0100, Hennerich, Michael wrote:
> Jean Delvare wrote on 2010-10-18:
> > Hi Michael,
> >
> > On Mon, 18 Oct 2010 10:55:57 +0100, Hennerich, Michael wrote:
> >> Jean Delvare wrote on 2010-10-18:
> >>> Hi Mike,
> >>>
> >
Jean Delvare wrote on 2010-10-18:
> Hi Michael,
>
> On Mon, 18 Oct 2010 10:55:57 +0100, Hennerich, Michael wrote:
>> Jean Delvare wrote on 2010-10-18:
>>> Hi Mike,
>>>
>>> On Sun, 17 Oct 2010 19:43:39 -0400, Mike Frysinger wrote:
From: Michael Hennerich
These flags can be optionally
Hi Michael,
On Mon, 18 Oct 2010 10:55:57 +0100, Hennerich, Michael wrote:
> Jean Delvare wrote on 2010-10-18:
> > Hi Mike,
> >
> > On Sun, 17 Oct 2010 19:43:39 -0400, Mike Frysinger wrote:
> >> From: Michael Hennerich
> >>
> >> These flags can be optionally defined - slave drivers may use them as
Hi I2C maintainer,
I posted the i2c patch 1 month ago.
But I haven't received any response from you.
Could you review this patch ?
Thanks, Ohtake(OKISemi)
- Original Message -
From: "Masayuki Ohtak"
To: "Jean Delvare (PC drivers, core)" ; "Ben Dooks
(embedded platforms)" ;
"Crane Cai"
Jean Delvare wrote on 2010-10-18:
> Hi Mike,
>
> On Sun, 17 Oct 2010 19:43:39 -0400, Mike Frysinger wrote:
>> From: Michael Hennerich
>>
>> These flags can be optionally defined - slave drivers may use them as
>> flags argument for request_irq(). In case they are left uninitialized
>> they will d
>-Original Message-
>From: linux-i2c-ow...@vger.kernel.org [mailto:linux-i2c-
>ow...@vger.kernel.org] On Behalf Of ext samu.p.onk...@nokia.com
>>The timeout is a symptom as the controller level. What is the root
>>cause at the LP5523 device level? What exactly happens on the wire?
>>
>
>-Original Message-
>From: ext Jean Delvare [mailto:kh...@linux-fr.org]
>Sent: 15 October, 2010 15:52
>To: Onkalo Samu.P (Nokia-MS/Tampere)
>Cc: t...@atomide.com; linux-i2c@vger.kernel.org; linux-
>ker...@vger.kernel.org
>Subject: Re: [PATCH 0/2] Short timeout for I2C transfers
>
>Hi Samu
Hi Mike,
On Sun, 17 Oct 2010 19:43:39 -0400, Mike Frysinger wrote:
> From: Michael Hennerich
>
> These flags can be optionally defined - slave drivers may use them as
> flags argument for request_irq(). In case they are left uninitialized
> they will default to zero, and therefore shouldn't cau
Hi Nobuhiro,
On Mon, 18 Oct 2010 12:24:30 +0900, Nobuhiro Iwamatsu wrote:
> In kernel which enableded this driver output The following warning,
> because a slash (/) is in the i2c adapter name by the current driver.
> This set another adapter name (i2c-pca-platform at 0x) what removed slash.
>
>
15 matches
Mail list logo
