[PATCH v2 2/2] i2c-i801: Don't depend on other kernel driver config options

2011-05-15 Thread Jean Delvare
Don't let other driver config options influence us, as it makes the code more complex and fragile for a small benefit. There's nothing wrong with instantiating I2C devices even if they don't have a driver. And we're talking about 835 extra bytes in the binary on x86-64, that's hardly worth arguing

[PATCH v2 1/2] i2c-i801: Check for vendor Fujitsu before probing for apanel

2011-05-15 Thread Jean Delvare
Scanning the BIOS memory for the apanel information is costly, so avoid doing it on non-Fujitsu machines. Signed-off-by: Jean Delvare --- drivers/i2c/busses/i2c-i801.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- linux-2.6.39-rc7.orig/drivers/i2c/busses/i2c-i801.c 2011-05-15

Re: [PATCH] i2c-i801: Don't depend on other kernel driver config options

2011-05-15 Thread Jean Delvare
Hi David, On Fri, 13 May 2011 11:23:06 +0100, Woodhouse, David wrote: > On Fri, 2011-05-13 at 11:01 +0100, Jean Delvare wrote: > > Don't let other driver config options influence us, as it makes the > > code more complex and fragile for a small benefit. There's nothing > > wrong with instantiating

Re: [PATCH 1/2] pwm: Add __weak attributed functions for pwm operations

2011-05-15 Thread Russell King - ARM Linux
On Sun, May 15, 2011 at 01:00:31AM -0700, Dmitry Torokhov wrote: > On Fri, May 13, 2011 at 06:13:21PM +0530, Mohan Pallaka wrote: > > For chip drivers that support both pwm and non-pwm modes > > would encounter compilation errors if the platform doesn't > > have support for pwm though the chip is p

Re: [PATCH 1/2] pwm: Add __weak attributed functions for pwm operations

2011-05-15 Thread Dmitry Torokhov
On Fri, May 13, 2011 at 06:13:21PM +0530, Mohan Pallaka wrote: > For chip drivers that support both pwm and non-pwm modes > would encounter compilation errors if the platform doesn't > have support for pwm though the chip is programmed to work > in non-pwm mode. Add __weak attributed pwm functions

Re: [PATCH 1/2] pwm: Add __weak attributed functions for pwm operations

2011-05-15 Thread Dmitry Torokhov
On Fri, May 13, 2011 at 06:13:21PM +0530, Mohan Pallaka wrote: > For chip drivers that support both pwm and non-pwm modes > would encounter compilation errors if the platform doesn't > have support for pwm though the chip is programmed to work > in non-pwm mode. Add __weak attributed pwm functions