[PATCH v4] OMAP4: hwmod data: I2C: add flag for context restore

2011-07-14 Thread Shubhrajyoti D
Restore of context is not done for OMAP4. This patch adds the OMAP_I2C_FLAG_RESET_REGS_POSTIDLE in the OMAP4 hwmod data which activates the restore for OMAP4. Currently the OMAP4 does not hit device off still the driver may have support for it. Signed-off-by: Shubhrajyoti D --- Applies on top of

[PATCH 2/7] at91/i2c: move register header to drivers

2011-07-14 Thread Jean-Christophe PLAGNIOL-VILLARD
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD Cc: Nicolas Ferre Cc: linux-i2c@vger.kernel.org --- drivers/i2c/busses/i2c-at91.c |3 ++- .../at91_twi.h => drivers/i2c/busses/i2c-at91.h|7 +++ 2 files changed, 5 insertions(+), 5 deletions(-) rename arch/arm/

Re: [PATCH 1/2] i2c/imx: remove init/exit hooks from platform data

2011-07-14 Thread Grant Likely
On Fri, Jul 15, 2011 at 12:03:44AM +0800, Shawn Guo wrote: > The init/exit hooks in platform data are being used nowhere, so can > be removed. > > Signed-off-by: Shawn Guo > Cc: Darius Augulis > Cc: Ben Dooks Acked-by: Grant Likely Yes, I think this is the think to do. Notifiers provide a g

Re: [PATCH 2/2] i2c/imx: add device tree probe support

2011-07-14 Thread Grant Likely
On Fri, Jul 15, 2011 at 12:03:45AM +0800, Shawn Guo wrote: > It adds device tree probe support for i2c-imx driver. > > Signed-off-by: Shawn Guo > Cc: Grant Likely > Cc: Darius Augulis > Cc: Ben Dooks > --- > .../devicetree/bindings/i2c/fsl-imx-i2c.txt| 25 > >

Re: [PATCH] i2c: Tegra: Add of_match_table

2011-07-14 Thread Grant Likely
On Thursday, July 14, 2011, Stephen Warren wrote: > From: John Bonesio > > This patch was intended to be part of 7ca2d1a105a239e300b937e9c41a10a4bd08f569 > "i2c: Tegra: Add DeviceTree support". However, an early version of that patch, > which was missing a chunk, was applied to next-i2c. This cha

[PATCH] i2c: Tegra: Add of_match_table

2011-07-14 Thread Stephen Warren
From: John Bonesio This patch was intended to be part of 7ca2d1a105a239e300b937e9c41a10a4bd08f569 "i2c: Tegra: Add DeviceTree support". However, an early version of that patch, which was missing a chunk, was applied to next-i2c. This change is that missing chunk. Signed-off-by: John Bonesio Sig

RE: [PATCH] i2c: tegra: Use engineering names in DT compatible property

2011-07-14 Thread Stephen Warren
Grant Likely wrote at Wednesday, July 13, 2011 5:34 PM: > On Thu, Jul 14, 2011 at 2:59 AM, Stephen Warren wrote: ... > > I don't believe anyone ever sent a patch to Ben to add tegra_i2c_of_match > > to the driver; the OF support patch didn't include that part of the code. > > As such, Ben can't ye

Re: [PATCH v3] OMAP4:hwmod: I2C : I2C context restore

2011-07-14 Thread Kevin Hilman
Shubhrajyoti D writes: > Restore of context is not done for OMAP4. This patch > adds the OMAP_I2C_FLAG_RESET_REGS_POSTIDLE in the OMAP4 > hwmod data which activates the restore for OMAP4. > Currently the OMAP4 does not hit device off still the > driver may have support for it. > > Signed-off-by:

Re: [PATCH v3] OMAP4:hwmod: I2C : I2C context save

2011-07-14 Thread Shubhrajyoti
Please ignore the patch sent another one with correct sub line On Thursday 14 July 2011 10:03 PM, Shubhrajyoti D wrote: Restore of context is not done for OMAP4. This patch adds the OMAP_I2C_FLAG_RESET_REGS_POSTIDLE in the OMAP4 hwmod data which activates the restore for OMAP4. Currently the OMA

[PATCH v3] OMAP4:hwmod: I2C : I2C context restore

2011-07-14 Thread Shubhrajyoti D
Restore of context is not done for OMAP4. This patch adds the OMAP_I2C_FLAG_RESET_REGS_POSTIDLE in the OMAP4 hwmod data which activates the restore for OMAP4. Currently the OMAP4 does not hit device off still the driver may have support for it. Signed-off-by: Shubhrajyoti D --- Applies on top of

[PATCH v3] OMAP4:hwmod: I2C : I2C context save

2011-07-14 Thread Shubhrajyoti D
Restore of context is not done for OMAP4. This patch adds the OMAP_I2C_FLAG_RESET_REGS_POSTIDLE in the OMAP4 hwmod data which activates the restore for OMAP4. Currently the OMAP4 does not hit device off still the driver may have support for it. Signed-off-by: Shubhrajyoti D --- Applies on top of

Re: ack/nack in write operation

2011-07-14 Thread Jean Delvare
On Thu, 14 Jul 2011 17:52:25 +0200, Michele Da Rold wrote: > Hello everybody, > I'm new to i2c development some don't kill me if my questions are stupid!! > > I'm using bitbanging i2c driver for an AT91 devices, > the AT91 is master and I have a slave that reply, during a write, with a > NAK afte

ack/nack in write operation

2011-07-14 Thread Michele Da Rold
Hello everybody, I'm new to i2c development some don't kill me if my questions are stupid!! I'm using bitbanging i2c driver for an AT91 devices, the AT91 is master and I have a slave that reply, during a write, with a NAK after last byte. The i2c specification permit this solution but i2c linux

Re: [PATCH] OMAP4: I2C : I2C context save

2011-07-14 Thread Kevin Hilman
Shubhrajyoti D writes: > Restore of context is not done for OMAP4. This patch Subject says context *save*, here says context *restore.* > adds the OMAP_I2C_FLAG_RESET_REGS_POSTIDLE in the OMAP4 > hwmod which activates the restore for OMAP4. s/hwmod/hwmod data/ > Currently the OMAP4 doesnot h

[PATCH 2/2] i2c/imx: add device tree probe support

2011-07-14 Thread Shawn Guo
It adds device tree probe support for i2c-imx driver. Signed-off-by: Shawn Guo Cc: Grant Likely Cc: Darius Augulis Cc: Ben Dooks --- .../devicetree/bindings/i2c/fsl-imx-i2c.txt| 25 drivers/i2c/busses/i2c-imx.c | 25 +++ 2

[PATCH 1/2] i2c/imx: remove init/exit hooks from platform data

2011-07-14 Thread Shawn Guo
The init/exit hooks in platform data are being used nowhere, so can be removed. Signed-off-by: Shawn Guo Cc: Darius Augulis Cc: Ben Dooks --- arch/arm/plat-mxc/include/mach/i2c.h |4 drivers/i2c/busses/i2c-imx.c | 21 +++-- 2 files changed, 3 insertions(+), 2

[PATCH 0/2] Add device tree probe for i2c-imx driver

2011-07-14 Thread Shawn Guo
The first patch removes unused init/exit hooks from platform data, and the second one actually adds the actual device tree probe support. Shawn Guo (2): i2c/imx: remove init/exit hooks from platform data i2c/imx: add device tree probe support .../devicetree/bindings/i2c/fsl-imx-i2c.t

Re: [PATCH][RFC] OMAP4: I2C : I2C context save

2011-07-14 Thread Kevin Hilman
Shubhrajyoti writes: > On Thursday 14 July 2011 02:57 AM, Hilman, Kevin wrote: >> On Wed, Jul 13, 2011 at 2:15 PM, Kevin Hilman wrote: >>> Ben Dooks writes: >>> On Tue, Jul 05, 2011 at 02:50:46PM +0530, Shubhrajyoti D wrote: > Currently the OMAP4 doesnot hit device off still the >

Re: [PATCH][RFC] OMAP4: I2C : I2C context save

2011-07-14 Thread Shubhrajyoti
On Thursday 14 July 2011 02:57 AM, Hilman, Kevin wrote: On Wed, Jul 13, 2011 at 2:15 PM, Kevin Hilman wrote: Ben Dooks writes: On Tue, Jul 05, 2011 at 02:50:46PM +0530, Shubhrajyoti D wrote: Currently the OMAP4 doesnot hit device off still the driver may have support for it.Adding support f

[PATCH 3/4] i2c/au1550: increase timeout limit

2011-07-14 Thread Manuel Lauss
The timeout waiting for various events to occur is tailored for a module clock of 50MHz. On the DB1300 board only 48MHz can be supplied to the i2c module, which results in the timeout aborting complex transfers to slaves slightly too early if they employ for example clock stretching. With this ch

[PATCH 4/4] i2c/au1550: dev_pm_ops conversion

2011-07-14 Thread Manuel Lauss
use newer dev_pm_ops for PM Signed-off-by: Manuel Lauss --- drivers/i2c/busses/i2c-au1550.c | 24 ++-- 1 files changed, 14 insertions(+), 10 deletions(-) diff --git a/drivers/i2c/busses/i2c-au1550.c b/drivers/i2c/busses/i2c-au1550.c index 36d1b29..90a79f4 100644 --- a/driv

[PATCH 2/4] i2c/au1550: remove unused ack_timeout

2011-07-14 Thread Manuel Lauss
The ack_timeout context member is unused, get rid of it. Signed-off-by: Manuel Lauss --- drivers/i2c/busses/i2c-au1550.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-au1550.c b/drivers/i2c/busses/i2c-au1550.c index 70b027c..98ee11a 100644 --- a

[PATCH 1/4] i2c/au1550: remove usage of volatile keyword

2011-07-14 Thread Manuel Lauss
Replace the usage of "volatile"s with register accessor functions. Signed-off-by: Manuel Lauss --- arch/mips/include/asm/mach-au1x00/au1xxx_psc.h | 13 -- drivers/i2c/busses/i2c-au1550.c| 252 +-- 2 files changed, 99 insertions(+), 166 deletions(-) diff --

[PATCH 0/4] i2c: i2c-au1550 updates

2011-07-14 Thread Manuel Lauss
The following patches remove some bit-rot from the i2c-au1550 driver. (Patch #3 supersedes the one I sent on 2011-06-12: "i2c-au1550: increase timeout waiting for transactions to finish"). #1 gets rid of all instances of the "volatile" keyword, #2 removes an unused context member, #3 fixes i2c on