Shubhrajyoti D writes:
> On OMAP4 we were writing 1 to IRQENABLE_CLR which cleared only
> the arbitration lost interrupt however for other ips (not
> OMAP_I2C_IP_VERSION_2)
> we clear all the interrupts at idle. The patch intends to fix the same by
> writing 0 to the
> IE register.
Please als
Hi Shubhrajyoti,
On 12/2/2011 15:37, Jon Hunter wrote:
[snip]
@@ -594,6 +545,11 @@ static int omap_i2c_xfer_msg(struct i2c_adapter
*adap,
return r;
if (r == 0) {
dev_err(dev->dev, "controller timed out\n");
+ if (dev->device_reset) {
+ r = dev->device_reset(dev->dev);
+ if (r< 0)
+ dev_err(dev-
Hi Shubhrajyoti,
On 12/2/2011 3:21, Shubhrajyoti D wrote:
- The reset in the driver at init is not needed anymore as the
hwmod framework takes care of reseting it.
- Reset is removed from omap_i2c_init, which was called
not only during probe, but also after time out and error handling.
> On Fri, Nov 25, 2011 at 09:15:20AM +0800, Shawn Guo wrote:
> > On Thu, Nov 24, 2011 at 09:37:47AM +0100, Wolfram Sang wrote:
> > > On Thu, Nov 24, 2011 at 09:29:03AM +0100, Uwe Kleine-König wrote:
> > > > Hello Shawn,
> > > >
> > > > On Thu, Nov 24, 2011 at 03:52:20PM +0800, Shawn Guo wrote:
> >
On Fri, Dec 02, 2011 at 02:24:08AM -0500, Jean Delvare wrote:
> On Wed, 30 Nov 2011 12:32:01 -0800, Guenter Roeck wrote:
> > On Wed, 2011-11-30 at 15:20 -0500, Jean Delvare wrote:
> > > Hi Guenter,
> > >
> > > On Wed, 30 Nov 2011 11:00:01 -0800, Guenter Roeck wrote:
> > > > do you have any plans t
Ben,
Please pull for 3.3. This missed 3.2 and I have rebased to the recent
plat/pci changes.
The following changes since commit caca6a03d365883564885f2c1da3e88dcf65d139:
Linux 3.2-rc3 (2011-11-23 20:20:28 -0800)
are available in the git repository at:
git://sources.calxeda.com/kernel/linux.
On Fri, Dec 02, 2011 at 07:07:14PM +0800, Richard Zhao wrote:
> Is there any body merged this patch series?
Thanks, Sascha! Just found it's in your imx-features branch.
Richard
>
> Thanks
> Richard
> On Thu, Nov 17, 2011 at 09:22:11AM +0800, Richard Zhao wrote:
> > Hi Sascha,
> >
> > Would you m
Is there any body merged this patch series?
Thanks
Richard
On Thu, Nov 17, 2011 at 09:22:11AM +0800, Richard Zhao wrote:
> Hi Sascha,
>
> Would you merge this patch series?
>
> Thanks
> Richard
>
>
> ___
> linux-arm-kernel mailing list
> linux-arm-k
- The reset in the driver at init is not needed anymore as the
hwmod framework takes care of reseting it.
- Reset is removed from omap_i2c_init, which was called
not only during probe, but also after time out and error handling.
device_reset were added in those places to effect the reset
The SYSC register should not accessed in the driver removing the
define from the driver.
Also clean up the syscstate from the omap_i2c_dev struct.
Acked-by: Santosh Shilimkar
Signed-off-by: Shubhrajyoti D
---
drivers/i2c/busses/i2c-omap.c |5 -
1 files changed, 0 insertions(+), 5 deleti
The series attempts to do the following
- The reset should not be done in the driver
have support for the same.
- Remove the sysc register access in the driver.
Incorporated review comments:
- Fix the indentation.
- Restore in the error path is not needed as we are
doing a init.
- Comb
Under some error conditions the i2c driver may do a reset.
Adding a reset field and support in the device-specific code.
Signed-off-by: Shubhrajyoti D
---
arch/arm/plat-omap/i2c.c | 18 ++
include/linux/i2c-omap.h |1 +
2 files changed, 19 insertions(+), 0 deletions(-)
dif
12 matches
Mail list logo
