Re: [PATCHv9 00/10] I2C fixes

+Neil Brown Shubhrajyoti D writes: > The patch series does the following > > - Warn fixes if CONFIG_PM_RUNTIME is not selected. > - In case of i2c remove register access was done without any > get_sync fix the same. > - Folds a patch from Tasslehoff to prevent any merge conflicts. > - Prevents

Re: [PATCHv9 00/10] I2C fixes

Shubhrajyoti D writes: > The patch series does the following > > - Warn fixes if CONFIG_PM_RUNTIME is not selected. > - In case of i2c remove register access was done without any > get_sync fix the same. > - Folds a patch from Tasslehoff to prevent any merge conflicts. > - Prevents the XDUF flag

Re: [PATCHv9 09/10] I2C: OMAP: Do not set the XUDF(Transmit underflow) if the underflow is not reached

Shubhrajyoti D writes: > Currently in the 1.153 errata handling while waiting for transmitter > underflow if NACK is got the XUDF(Transmit underflow) flag is also set. -EOVERFLOW This sentence needs a rewrite and some punctuation. It does not read well. > The flag is set after wait for the co

Re: [PATCHv9 07/10] I2C: OMAP: Handle error check for pm runtime

Shubhrajyoti D writes: > If PM runtime get_sync fails return with the error > so that no further reads/writes goes through the interface. > This will avoid possible abort. Add a error message in case > of failure with the cause of the failure. > > Signed-off-by: Shubhrajyoti D > --- > drivers/i

Re: [PATCHv9 02/10] I2C: OMAP: Fix the mismatch of pm_runtime enable and disable

Shubhrajyoti D writes: > Currently the i2c driver calls the pm_runtime_enable and never > the disable. This may cause a warning when pm_runtime_enable > checks for the count match.Attempting to fix the same by calling > pm_runtime_disable in the error and the remove path. Looks right. Can you b

Re: [PATCHv9 06/10] I2C: OMAP: Fix the crash in i2c remove

Hi Wolfram, Wolfram Sang writes: > On Wed, May 02, 2012 at 08:02:11PM +0530, Shubhrajyoti D wrote: >> In omap_i2c_remove we are accessing the I2C_CON register without >> enabling the clocks. Fix the same by enabling the clocks and disabling >> it. [...] > I'd really like a comment

Re: [PATCH 8/8] i2c: i2c-bfin-twi: Move blackfin TWI register access Macro to head file.

On Fri, May 25, 2012 at 3:42 PM, Zhang, Sonic wrote: > > >>-Original Message- >>From: Shubhrajyoti Datta [mailto:omaplinuxker...@gmail.com] >>Sent: Friday, May 25, 2012 6:10 PM >>To: Zhang, Sonic >>Cc: Ben Dooks; Wolfram Sang; linux-i2c@vger.kernel.org; LKML; uclinux-dist- >>de...@blackfin

RE: [PATCH 8/8] i2c: i2c-bfin-twi: Move blackfin TWI register access Macro to head file.

>-Original Message- >From: Shubhrajyoti Datta [mailto:omaplinuxker...@gmail.com] >Sent: Friday, May 25, 2012 6:10 PM >To: Zhang, Sonic >Cc: Ben Dooks; Wolfram Sang; linux-i2c@vger.kernel.org; LKML; uclinux-dist- >de...@blackfin.uclinux.org >Subject: Re: [PATCH 8/8] i2c: i2c-bfin-twi: Move

Re: [PATCH 8/8] i2c: i2c-bfin-twi: Move blackfin TWI register access Macro to head file.

Hi , On Fri, May 25, 2012 at 3:24 PM, Zhang, Sonic wrote: > > >>-Original Message- >>From: Shubhrajyoti Datta [mailto:omaplinuxker...@gmail.com] >>Sent: Friday, May 25, 2012 5:48 PM >>To: Zhang, Sonic >>Cc: Ben Dooks; Wolfram Sang; linux-i2c@vger.kernel.org; LKML; uclinux-dist- >>de...@bla

RE: [PATCH 8/8] i2c: i2c-bfin-twi: Move blackfin TWI register access Macro to head file.

>-Original Message- >From: Shubhrajyoti Datta [mailto:omaplinuxker...@gmail.com] >Sent: Friday, May 25, 2012 5:48 PM >To: Zhang, Sonic >Cc: Ben Dooks; Wolfram Sang; linux-i2c@vger.kernel.org; LKML; uclinux-dist- >de...@blackfin.uclinux.org >Subject: Re: [PATCH 8/8] i2c: i2c-bfin-twi: Move

Re: [PATCH 8/8] i2c: i2c-bfin-twi: Move blackfin TWI register access Macro to head file.

Hi , Some minor comments/ doubts. On Wed, May 16, 2012 at 12:50 PM, wrote: > From: Sonic Zhang > A small description may be helpful. Also the $SUBJECT says move the patch looks more like the remove. Am I missing something. > Signed-off-by: Sonic Zhang > --- >  drivers/i2c/busses/i2c-bfin-twi.