Re: [PATCH 1/2] i2c: stu300: use clk_prepare/unprepare

2012-06-12 Thread Shubhrajyoti Datta
Hi Linus, On Tue, Jun 12, 2012 at 11:03 PM, Linus Walleij wrote: > From: Linus Walleij > > Make sure we prepare/unprepare the clock for the ST U300 > I2C driver as is required by the clk API especially if you > use common clock. Not a comment rather a doubt. The transfer is still using enable a

Re: [PATCH] i2c multiplexer driver for Proliant microserver N36L

2012-06-12 Thread Eddi De Pieri
It works for me too What about including this patch in the mainline? Regards Eddi Tested-by: Eddi De Pieri On Mon, Feb 27, 2012 at 9:42 AM, Thomas Brandon wrote: > > On Sun, Feb 26, 2012 at 10:30 PM, Mike Shestyrev wrote: > > Hi Thomas, > > > > I've applied you patch to i2c-piix4.c, kern

Re: [PATCH 09/14] i2c: Add Device Tree support to the Nomadik I2C driver

2012-06-12 Thread Linus Walleij
On Tue, Jun 12, 2012 at 9:34 AM, Lee Jones wrote: > On 11/06/12 21:37, Linus Walleij wrote: >> >> So why don't we create proper device tree bindings for the above platform >> data? >>(...) >> This looks to me like a way to push the burden of doing the real >> device tree binding for the above to t

Re: lm75_remove: LM75 Device remove using sysfs delete_device

2012-06-12 Thread Guenter Roeck
On Tue, Jun 12, 2012 at 11:51:51PM -0400, Sasikanth babu wrote: > > On Sun, Jun 10, 2012 at 9:06 PM, Jean Delvare wrote: > > (Note: Frodo is out of the lm-sensors project for years, no need to Cc > him.) > > On Sun, 10 Jun 2012 07:41:03 -0700, Sasikanth babu wrote: > > when I'

Re: [PATCH 5/9] ARM: kirkwood: use devicetree for orion-spi

2012-06-12 Thread Jason Cooper
On Tue, Jun 12, 2012 at 02:04:33PM +0200, Andrew Lunn wrote: > > > + spi@10600 { > > > + compatible = "marvell,orion-spi"; > > > + #address-cells = <1>; > > > + #size-cells = <0>; > > > + cell-index = <0>; > > > +

[PATCH 2/2] i2c: stu300: use devm allocation

2012-06-12 Thread Linus Walleij
From: Linus Walleij Allocate memory for device state using devm_kzalloc() to simplify accounting. Signed-off-by: Linus Walleij --- drivers/i2c/busses/i2c-stu300.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/i2c/busses/i2c-stu300.c b/drivers/i2c/busses/i2c-

[PATCH 1/2] i2c: stu300: use clk_prepare/unprepare

2012-06-12 Thread Linus Walleij
From: Linus Walleij Make sure we prepare/unprepare the clock for the ST U300 I2C driver as is required by the clk API especially if you use common clock. Signed-off-by: Linus Walleij --- drivers/i2c/busses/i2c-stu300.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/d

Re: [PATCH] i2c: use module_pci_driver

2012-06-12 Thread Jean Delvare
On Tue, 12 Jun 2012 17:34:32 +0200, Wolfram Sang wrote: > On Tue, Jun 12, 2012 at 08:47:59PM +0800, Axel Lin wrote: > > This patch converts the drivers in drivers/i2c/buses/* to use > > module_pci_driver() macro which makes the code smaller and a bit simpler. > > > > Signed-off-by: Axel Lin > > C

Re: [PATCH V2 3/4] i2c: tegra: support for I2C_M_NOSTART functionality

2012-06-12 Thread Wolfram Sang
On Tue, Jun 12, 2012 at 04:07:30PM +0530, Laxman Dewangan wrote: > Adding support for functionality I2C_M_NOSTART. > When multiple message transfer request made through i2c > and if any message is flagged with I2C_M_NOSTART then > it will not send the start/repeat-start and address of > that messag

Re: [PATCH V2 1/4] i2c: tegra: make sure register writes completes

2012-06-12 Thread Stephen Warren
On 06/12/2012 04:37 AM, Laxman Dewangan wrote: > The Tegra PPSB (an peripheral bus) queues writes transactions. > In order to guarantee that writes have completed before a > certain time, a read transaction to a register on the same > bus must be executed. > This is necessary in situations such as

Re: [PATCH 1/4] i2c: tegra: make sure register writes completes

2012-06-12 Thread Stephen Warren
On 06/12/2012 04:16 AM, Laxman Dewangan wrote: > On Tuesday 12 June 2012 01:24 PM, Wolfram Sang wrote: >> * PGP Signed by an unknown key >> >> On Tue, Jun 05, 2012 at 06:39:57PM +0530, Laxman Dewangan wrote: >>> @@ -430,6 +430,13 @@ static irqreturn_t tegra_i2c_isr(int irq, void >>> *dev_id) >>>

Re: [PATCH 0/4] i2c: tegra: Bug fixes, cleanups and M_NOSTART support

2012-06-12 Thread Stephen Warren
On 06/12/2012 02:50 AM, Wolfram Sang wrote: > On Tue, Jun 05, 2012 at 10:37:36PM +0530, Laxman Dewangan wrote: >> On Tuesday 05 June 2012 09:44 PM, Stephen Warren wrote: >>> On 06/05/2012 07:09 AM, Laxman Dewangan wrote: This patch series having the: - Handling of late register write due

Re: [PATCH] i2c: use module_pci_driver

2012-06-12 Thread Wolfram Sang
On Tue, Jun 12, 2012 at 08:47:59PM +0800, Axel Lin wrote: > This patch converts the drivers in drivers/i2c/buses/* to use > module_pci_driver() macro which makes the code smaller and a bit simpler. > > Signed-off-by: Axel Lin > Cc: "Jean Delvare (PC drivers, core)" > Cc: "Ben Dooks (embedded pla

[PATCH] i2c: use module_pci_driver

2012-06-12 Thread Axel Lin
This patch converts the drivers in drivers/i2c/buses/* to use module_pci_driver() macro which makes the code smaller and a bit simpler. Signed-off-by: Axel Lin Cc: "Jean Delvare (PC drivers, core)" Cc: "Ben Dooks (embedded platforms)" Cc: "Wolfram Sang (embedded platforms)" Cc: Rudolf Marek C

Re: [PATCH 3/3] i2c-piix4: support aux SMBus on AMD chipsets

2012-06-12 Thread Jean Delvare
On Mon, 4 Jun 2012 21:49:24 -0400, Andrew Armenia wrote: > Some AMD chipsets, such as the SP5100, have an auxiliary SMBus with a second > set of registers. This patch adds support for the SP5100 and should work on > similar chipsets. Tested on ASUS KCMA-D8 motherboard. The SP5100 isn't even docum

Re: [PATCH 2/3] i2c-piix4: separate registration and probing code

2012-06-12 Thread Jean Delvare
On Mon, 4 Jun 2012 21:49:23 -0400, Andrew Armenia wrote: > Some chipsets have multiple sets of SMBus registers each controlling a > separate SMBus. Supporting these chipsets properly will require registering > multiple I2C adapters for one piix4. > > The code to initialize and register the i2c_ad

Re: [PATCH 5/9] ARM: kirkwood: use devicetree for orion-spi

2012-06-12 Thread Andrew Lunn
> > + spi@10600 { > > + compatible = "marvell,orion-spi"; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + cell-index = <0>; > > + reg = <0x10600 0x28>; > > + status = "di

Re: [PATCH 1/3] i2c-piix4: eliminate global I/O base address

2012-06-12 Thread Jean Delvare
Hi Andrew, On Mon, 4 Jun 2012 21:49:22 -0400, Andrew Armenia wrote: > The i2c-piix4 driver used a global variable to store the base address > of the piix4 i2c registers. Some chipsets contain multiple sets of > i2c registers; thus it is desirable to eliminate global state. > > i2c_get_adapdata()

[PATCH V2 1/4] i2c: tegra: make sure register writes completes

2012-06-12 Thread Laxman Dewangan
The Tegra PPSB (an peripheral bus) queues writes transactions. In order to guarantee that writes have completed before a certain time, a read transaction to a register on the same bus must be executed. This is necessary in situations such as when clearing an interrupt status or enable, so that when

[PATCH V2 2/4] i2c: tegra: add PROTOCOL_MANGLING as supported functionality.

2012-06-12 Thread Laxman Dewangan
The Tegra i2c driver supports the I2C_M_IGNORE_NAK and hence returning I2C_FUNC_PROTOCOL_MANGLING as supported functionality. Signed-off-by: Laxman Dewangan --- No change from V1, drivers/i2c/busses/i2c-tegra.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/i

[PATCH V2 4/4] i2c: tegra: make all resource allocation through devm_*

2012-06-12 Thread Laxman Dewangan
Use the devm_* for the memory region allocation, interrupt request, clock handler request. By doing this, it does not require to explicitly free it and hence saving some code. Signed-off-by: Laxman Dewangan --- This is rebased of earlier similar patch and sending as part of this series. No change

[PATCH V2 3/4] i2c: tegra: support for I2C_M_NOSTART functionality

2012-06-12 Thread Laxman Dewangan
Adding support for functionality I2C_M_NOSTART. When multiple message transfer request made through i2c and if any message is flagged with I2C_M_NOSTART then it will not send the start/repeat-start and address of that message i.e. sends data directly. Signed-off-by: Laxman Dewangan --- This is re

[PATCH v2 0/4] i2c: tegra: Bug fixes, cleanups and M_NOSTART support

2012-06-12 Thread Laxman Dewangan
This patch series having the: - Handling of late register write due to Tegra PPSB design. - support for I2C_M_NOSTART - Use devm_* for all allocation. Changes from V1: Taking care of review comment from Wolfram in patch 1/4. Laxman Dewangan (4): i2c: tegra: make sure register writes completes

Re: [PATCH] i2c-s3c2410: Fix pointer type passed to of_match_node()

2012-06-12 Thread Karol Lewandowski
On 11.06.2012 20:29, Wolfram Sang wrote: > On Wed, May 30, 2012 at 11:43:05AM +0200, Karol Lewandowski wrote: >> This commit fixes warning introduced in 27452498a ("i2c-s3c2410: Rework >> device type handling"): >> >> drivers/i2c/busses/i2c-s3c2410.c: In function 's3c24xx_get_device_quirks': >>

Re: [PATCH 1/4] i2c: tegra: make sure register writes completes

2012-06-12 Thread Laxman Dewangan
On Tuesday 12 June 2012 01:24 PM, Wolfram Sang wrote: * PGP Signed by an unknown key On Tue, Jun 05, 2012 at 06:39:57PM +0530, Laxman Dewangan wrote: @@ -430,6 +430,13 @@ static irqreturn_t tegra_i2c_isr(int irq, void *dev_id) if (i2c_dev->is_dvc) dvc_writel(i2c_dev, DVC

Re: [PATCH 09/14] i2c: Add Device Tree support to the Nomadik I2C driver

2012-06-12 Thread Wolfram Sang
On Tue, Jun 12, 2012 at 09:52:39AM +0100, Lee Jones wrote: > From: Lee Jones > Date: Tue, 17 Apr 2012 16:04:13 +0100 > Subject: [PATCH 09/14] i2c: Add Device Tree support to the Nomadik I2C driver > > Here we move the i2c-nomadik's default settings into the driver > rather than specifying them fr

Re: [PATCH 09/14] i2c: Add Device Tree support to the Nomadik I2C driver

2012-06-12 Thread Lee Jones
From: Lee Jones Date: Tue, 17 Apr 2012 16:04:13 +0100 Subject: [PATCH 09/14] i2c: Add Device Tree support to the Nomadik I2C driver Here we move the i2c-nomadik's default settings into the driver rather than specifying them from platform code. At the time of this writing we only have one user, th

Re: [PATCH 0/4] i2c: tegra: Bug fixes, cleanups and M_NOSTART support

2012-06-12 Thread Wolfram Sang
On Tue, Jun 05, 2012 at 10:37:36PM +0530, Laxman Dewangan wrote: > On Tuesday 05 June 2012 09:44 PM, Stephen Warren wrote: > >On 06/05/2012 07:09 AM, Laxman Dewangan wrote: > >>This patch series having the: > >>- Handling of late register write due to Tegra PPSB design. > >>- support for I2C_M_NOST

Re: [PATCH 1/4] i2c: tegra: make sure register writes completes

2012-06-12 Thread Wolfram Sang
On Tue, Jun 05, 2012 at 06:39:57PM +0530, Laxman Dewangan wrote: > The Tegra PPSB (an peripheral bus) queues writes transactions. > In order to guarantee that writes have completed before a > certain time, a read transaction to a register on the same > bus must be executed. > This is necessary in s

Re: [PATCH V3] m68knommu: driver for Freescale Coldfire I2C controller.

2012-06-12 Thread Wolfram Sang
Hi, > While they are physically similar, just as the mpc and the imx are physically > similar, the imx driver has a lot of imx'isms, device tree and OF > dependencies that aren't supported by the m68k/nommu. Devicetree/OF should be optional. If not, we need to fix it anyhow. So, the question is

Re: [PATCH 09/14] i2c: Add Device Tree support to the Nomadik I2C driver

2012-06-12 Thread Lee Jones
On 11/06/12 21:37, Linus Walleij wrote: On Mon, Jun 11, 2012 at 5:25 PM, Lee Jones wrote: As new users are added, it is expected that they will be Device Tree compliant. If this is the case, we will look up their initialisation values by compatible entry, then apply them forthwith. (...) +st

Re: [PATCH 09/14] i2c: Add Device Tree support to the Nomadik I2C driver

2012-06-12 Thread Lee Jones
On 11/06/12 20:05, Wolfram Sang wrote: On Mon, Jun 11, 2012 at 04:25:02PM +0100, Lee Jones wrote: Here we move the i2c-nomadik's default settings into the driver rather than specifying them from platform code. At the time of this writing we only have one user, the u8500. As new users are added,