Re: [PATCHv8 06/13] I2C: OMAP: Correct I2C revision for OMAP3

2012-06-20 Thread Shubhrajyoti Datta
On Wed, Jun 20, 2012 at 7:44 PM, Tony Lindgren wrote: > * Shubhrajyoti [120620 06:06]: >> On Wednesday 20 June 2012 04:02 PM, Tony Lindgren wrote: >> > * Shubhrajyoti D [120618 07:35]: >> >> From: Jon Hunter >> >> >> >> The OMAP3530 is based upon the same silicon as the OMAP3430 and so the I2C

Re: [PATCH 07/15] i2c: Add Device Tree support to the Nomadik I2C driver

2012-06-20 Thread Srinidhi Kasagar
On Wed, Jun 20, 2012 at 21:30:17 +0200, Linus Walleij wrote: > On Wed, Jun 20, 2012 at 2:56 PM, Lee Jones wrote: > > > Here we apply the bindings required for successful Device Tree > > probing of the i2c-nomadik driver. We also apply a fall-back > > configuration in case either one is not provid

Re: [PATCH 07/15] i2c: Add Device Tree support to the Nomadik I2C driver

2012-06-20 Thread Linus Walleij
On Wed, Jun 20, 2012 at 2:56 PM, Lee Jones wrote: > Here we apply the bindings required for successful Device Tree > probing of the i2c-nomadik driver. We also apply a fall-back > configuration in case either one is not provided, or a required > element is missing from the one supplied. > > Cc: l

Re: [PATCH] i2c: tegra: use clk_disable_unprepare in place of clk_disable

2012-06-20 Thread Stephen Warren
On 06/20/2012 10:26 AM, Stephen Warren wrote: > On 06/20/2012 06:56 AM, Laxman Dewangan wrote: >> Use clk_disable_unprepare() inplace of clk_disable(). >> This was missed as part of moving clock enable/disable to >> prepare/unprepare for using the common clock framework. ... > I see no reason not t

Re: [PATCH] i2c: tegra: use clk_disable_unprepare in place of clk_disable

2012-06-20 Thread Stephen Warren
On 06/20/2012 06:56 AM, Laxman Dewangan wrote: > Use clk_disable_unprepare() inplace of clk_disable(). > This was missed as part of moving clock enable/disable to > prepare/unprepare for using the common clock framework. Wolfram, Since I've taken the other I2C patch on this topic through the Tegr

Re: [PATCHv8 06/13] I2C: OMAP: Correct I2C revision for OMAP3

2012-06-20 Thread Tony Lindgren
* Shubhrajyoti [120620 06:06]: > On Wednesday 20 June 2012 04:02 PM, Tony Lindgren wrote: > > * Shubhrajyoti D [120618 07:35]: > >> From: Jon Hunter > >> > >> The OMAP3530 is based upon the same silicon as the OMAP3430 and so the I2C > >> revision is the same for 3430 and 3530. However, the OMAP

Re: [PATCH 3/3 v2] i2c: i801: enable irq for byte_by_byte transactions

2012-06-20 Thread Jean Delvare
Hi Daniel, On Fri, 6 Jan 2012 18:58:22 +0800, Daniel Kurtz wrote: > Byte-by-byte transactions are used primarily for accessing i2c devices > with an smbus controller. For these transactions, for each byte that is On recent chips, yes. On older chips (ICH3 and older), the block buffer didn't exi

Re: [PATCHv8 06/13] I2C: OMAP: Correct I2C revision for OMAP3

2012-06-20 Thread Shubhrajyoti
On Wednesday 20 June 2012 04:02 PM, Tony Lindgren wrote: > * Shubhrajyoti D [120618 07:35]: >> From: Jon Hunter >> >> The OMAP3530 is based upon the same silicon as the OMAP3430 and so the I2C >> revision is the same for 3430 and 3530. However, the OMAP3630 device has the >> same I2C revision as

[PATCH 07/15] i2c: Add Device Tree support to the Nomadik I2C driver

2012-06-20 Thread Lee Jones
Here we apply the bindings required for successful Device Tree probing of the i2c-nomadik driver. We also apply a fall-back configuration in case either one is not provided, or a required element is missing from the one supplied. Cc: linux-i2c@vger.kernel.org Signed-off-by: Lee Jones --- drivers

[PATCH] i2c: tegra: use clk_disable_unprepare in place of clk_disable

2012-06-20 Thread Laxman Dewangan
Use clk_disable_unprepare() inplace of clk_disable(). This was missed as part of moving clock enable/disable to prepare/unprepare for using the common clock framework. Signed-off-by: Laxman Dewangan --- drivers/i2c/busses/i2c-tegra.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) d

[PATCH] i2c: tegra: remove unused member variable.

2012-06-20 Thread Laxman Dewangan
Remove unused member variable "iomem" of the i2c device structure. Signed-off-by: Laxman Dewangan --- drivers/i2c/busses/i2c-tegra.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c index f15cd49..00cdc10 10

Re: [PATCH 2/3 v2] i2c: i801: enable irq for i801 smbus transactions

2012-06-20 Thread Jean Delvare
On Wed, 20 Jun 2012 18:21:47 +0800, Daniel Kurtz wrote: > Thanks for taking a look at these patches... and for testing them! Thanks a lot for your patience! > They were from more than 7 months ago, so it will take me a little > time to context switch back to the point where I can really digest >

Re: [PATCHv8 06/13] I2C: OMAP: Correct I2C revision for OMAP3

2012-06-20 Thread Tony Lindgren
* Shubhrajyoti D [120618 07:35]: > From: Jon Hunter > > The OMAP3530 is based upon the same silicon as the OMAP3430 and so the I2C > revision is the same for 3430 and 3530. However, the OMAP3630 device has the > same I2C revision as OMAP4. Correct the revision definition to reflect this. > > Th

Re: [PATCHv8 03/13] I2C: OMAP: Remove reset at init

2012-06-20 Thread Tony Lindgren
* Shubhrajyoti D [120618 07:35]: > The reset in the driver at init is not needed anymore as the > following patch has removed the HWMOD_INIT_NO_RESET flag. > 6d3c55f [OMAP: hwmod: fix the i2c-reset timeout during bootup] > > This patch does the following > -removes the reset from the probe and im

Re: [PATCH 2/3 v2] i2c: i801: enable irq for i801 smbus transactions

2012-06-20 Thread Daniel Kurtz
On Wed, Jun 20, 2012 at 4:58 PM, Jean Delvare wrote: > On Tue, 19 Jun 2012 20:47:04 +0200, Jean Delvare wrote: >> On Fri,  6 Jan 2012 18:58:21 +0800, Daniel Kurtz wrote: >> > @@ -879,8 +953,24 @@ static int __devinit i801_probe(struct pci_dev *dev, >> >     i801_probe_optional_slaves(priv); >> > >

Re: [PATCH 2/3 v2] i2c: i801: enable irq for i801 smbus transactions

2012-06-20 Thread Jean Delvare
On Tue, 19 Jun 2012 20:47:04 +0200, Jean Delvare wrote: > On Fri, 6 Jan 2012 18:58:21 +0800, Daniel Kurtz wrote: > > @@ -879,8 +953,24 @@ static int __devinit i801_probe(struct pci_dev *dev, > > i801_probe_optional_slaves(priv); > > > > pci_set_drvdata(dev, priv); > > + > > + if (priv-

Re: [PATCH 2/3 v2] i2c: i801: enable irq for i801 smbus transactions

2012-06-20 Thread Jean Delvare
One more note on this... On Fri, 6 Jan 2012 18:58:21 +0800, Daniel Kurtz wrote: > Add a new 'feature' to i2c-i801 to enable using i801 interrupts. > When the feature is enabled, then an isr is installed for the device's > pci irq. What if bit 1 of host configuration register (SMB_SMI_EN) is set?