Re: [PATCH v2] i2c: add Renesas R-Car I2C driver

2012-09-28 Thread Shubhrajyoti Datta
On Fri, Sep 28, 2012 at 11:26 AM, Kuninori Morimoto kuninori.morimoto...@renesas.com wrote: Dear Shubhrajyoti Thank you for your comment. Hi A few suggestions, On Tue, Aug 28, 2012 at 2:07 PM, Kuninori Morimoto kuninori.morimoto...@renesas.com wrote: R-Car I2C is similar with SH7760

[PATCH v3] i2c: add Renesas R-Car I2C driver

2012-09-28 Thread Kuninori Morimoto
R-Car I2C is similar with SH7760 I2C. But the SH7760 I2C driver had many workaround operations, since H/W had bugs. Thus, it was pointless to keep compatible between SH7760 and R-Car I2C drivers. This patch creates new Renesas R-Car I2C driver. Signed-off-by: Kuninori Morimoto

Re: [PATCH V4 Resend 1/2] i2c/adapter: Add bus recovery infrastructure

2012-09-28 Thread Wolfram Sang
Hi, But before i send another version of this patchset, need some inputs from Wolfram. I am trying to have another I2C weekend this weekend. And your patches have been scheduled for that. The generic feeling is: Very useful but the interface could probably be simplified. This is why it takes

Re: [PATCH V4 Resend 1/2] i2c/adapter: Add bus recovery infrastructure

2012-09-28 Thread Viresh Kumar
On 28 September 2012 12:30, Wolfram Sang w.s...@pengutronix.de wrote: I am trying to have another I2C weekend this weekend. And your patches have been scheduled for that. The generic feeling is: Very useful but the interface could probably be simplified. This is why it takes me so long,

Re: [PATCH V4 Resend 1/2] i2c/adapter: Add bus recovery infrastructure

2012-09-28 Thread Viresh Kumar
Hi Uwe, On 28 September 2012 12:57, Uwe Kleine-König u.kleine-koe...@pengutronix.de wrote: On Fri, Sep 28, 2012 at 09:11:34AM +0530, viresh kumar wrote: This was done, because few platforms may not have configuration bits to read status of sda line.. For them skip_sda_polling was required.

[RFC PATCH 1/6] Introduce acpi_match_device_id().

2012-09-28 Thread Zhang Rui
From 72df5d1f51fb27a4ba7f70a3b07df759d32b8288 Mon Sep 17 00:00:00 2001 From: Zhang Rui rui.zh...@intel.com Date: Thu, 27 Sep 2012 15:11:55 +0800 Subject: [RFC PATCH 1/6] Introduce acpi_match_device_id(). This API is used to check if a device id string is compatible with an ACPI device, either PNP

[RFC PATCH 3/6] ACPI: introduce acpi_get_generic_resources

2012-09-28 Thread Zhang Rui
From 9a851d177794129a89f720c7122cb39fd163126b Mon Sep 17 00:00:00 2001 From: Zhang Rui rui.zh...@intel.com Date: Fri, 28 Sep 2012 08:34:05 +0800 Subject: [RFC PATCH 3/6] ACPI: introduce acpi_get_generic_resources Introduce acpi_get_generic_resources() to convert ACPI style resources to struct

[RFC PATCH 4/6] Change i2c_register_board_info from __init to __devinit

2012-09-28 Thread Zhang Rui
From 34aa38e12c04544d89af2eae46de284dc8a03b8d Mon Sep 17 00:00:00 2001 From: Zhang Rui rui.zh...@intel.com Date: Thu, 27 Sep 2012 15:42:23 +0800 Subject: [RFC PATCH 4/6] Change i2c_register_board_info from __init to __devinit. ACPI 5 supports enumerating I2C adapter and its slaves via ACPI

[RFC PATCH 5/6] ACPI: Introduce ACPI I2C controller enumeration driver

2012-09-28 Thread Zhang Rui
From 6077a62f2865201ab6727ca7d628ee5e43aa57e1 Mon Sep 17 00:00:00 2001 From: Zhang Rui rui.zh...@intel.com Date: Fri, 24 Aug 2012 15:18:25 +0800 Subject: [RFC PATCH 5/6] ACPI: Introduce ACPI I2C controller enumeration driver This driver is able to 1) enumerate I2C controller via ACPI namespace

[RFC PATCH 6/6] Introduce INT33B1 I2C controller driver

2012-09-28 Thread Zhang Rui
From 817d814ecae91862f42a0447f455dae7f74cba27 Mon Sep 17 00:00:00 2001 From: Zhang Rui rui.zh...@intel.com Date: Fri, 24 Aug 2012 15:20:38 +0800 Subject: [RFC PATCH 6/6] Introduce INT33B1 I2C controller driver This is a dummy platform device driver to illustrate my idea about how a really I2C

Re: [PATCH V4 Resend 1/2] i2c/adapter: Add bus recovery infrastructure

2012-09-28 Thread Viresh Kumar
On 28 September 2012 12:57, Uwe Kleine-König u.kleine-koe...@pengutronix.de wrote: Why do you default to GPIOF_OUT_INIT_LOW? The idle state of scl is high. Using low here introduces an additional clk pulse. Went deep into the code i wrote ages ago to check why i did so :) My initial idea was,

[PATCH V5 1/2] i2c/adapter: Add bus recovery infrastructure

2012-09-28 Thread Viresh Kumar
From: Viresh Kumar viresh.ku...@st.com Add i2c bus recovery infrastructure to i2c adapters as specified in the i2c protocol Rev. 03 section 3.1.16 titled Bus clear. http://www.nxp.com/documents/user_manual/UM10204.pdf Sometimes during operation i2c bus hangs and we need to give dummy clocks to

[PATCH V5 2/2] i2c/designware: Provide i2c bus recovery support

2012-09-28 Thread Viresh Kumar
From: Viresh Kumar viresh.ku...@st.com Add bus recovery support for designware_i2c controller. It uses generic gpio based i2c_gpio_recover_bus() routine. Signed-off-by: Vincenzo Frascino vincenzo.frasc...@st.com Signed-off-by: Shiraz Hashim shiraz.has...@st.com Signed-off-by: Viresh Kumar

Re: [RFC PATCH 5/6] ACPI: Introduce ACPI I2C controller enumeration driver

2012-09-28 Thread Alan Cox
On Fri, 28 Sep 2012 15:40:32 +0800 Zhang Rui rui.zh...@intel.com wrote: From 6077a62f2865201ab6727ca7d628ee5e43aa57e1 Mon Sep 17 00:00:00 2001 From: Zhang Rui rui.zh...@intel.com Date: Fri, 24 Aug 2012 15:18:25 +0800 Subject: [RFC PATCH 5/6] ACPI: Introduce ACPI I2C controller enumeration

[PATCH v2] i2c: nomadik: adopt pinctrl support

2012-09-28 Thread Linus Walleij
From: Patrice Chotard patrice.chot...@stericsson.com Amend the I2C nomadik pin controller to optionally take a pin control handle and set the state of the pins to: - default on boot, resume and before performing an i2c transfer - idle after initial default, after resume default, and after each

Re: [RFC PATCH 1/6] Introduce acpi_match_device_id().

2012-09-28 Thread Mika Westerberg
On Fri, Sep 28, 2012 at 03:38:30PM +0800, Zhang Rui wrote: From 72df5d1f51fb27a4ba7f70a3b07df759d32b8288 Mon Sep 17 00:00:00 2001 From: Zhang Rui rui.zh...@intel.com Date: Thu, 27 Sep 2012 15:11:55 +0800 Subject: [RFC PATCH 1/6] Introduce acpi_match_device_id(). This API is used to check if