Re: [PATCH v2] i2c: omap: Prevent NULL pointer dereference in remove

2012-10-03 Thread Shubhrajyoti Datta
On Thu, Sep 6, 2012 at 5:51 PM, Jean Delvare wrote: > On Thu, 6 Sep 2012 17:31:56 +0530, Shubhrajyoti D wrote: >> Prevent the NULL pointer access by moving the platform_set_drvdata function >> after the access of the pdev. >> >> [ 654.961761] Unable to handle kernel NULL pointer dereference at vi

Re: [PATCH V5 Resend 1/2] i2c/adapter: Add bus recovery infrastructure

2012-10-03 Thread Viresh Kumar
On 28 September 2012 16:58, Viresh Kumar wrote: > Add i2c bus recovery infrastructure to i2c adapters as specified in the i2c > protocol Rev. 03 section 3.1.16 titled "Bus clear". > > http://www.nxp.com/documents/user_manual/UM10204.pdf > > Sometimes during operation i2c bus hangs and we need to g

Re: [PATCH V4 Resend 1/2] i2c/adapter: Add bus recovery infrastructure

2012-10-03 Thread Viresh Kumar
On 28 September 2012 12:30, Wolfram Sang wrote: > I am trying to have another I2C weekend this weekend. And your patches > have been scheduled for that. The generic feeling is: > > Very useful but the interface could probably be simplified. This is why > it takes me so long, working on interfaces

[PATCH] i2c: correct struct i2c_driver doc about detection

2012-10-03 Thread Vivien Didelot
s/address_data/address_list/ in addition to c3813d6. Signed-off-by: Vivien Didelot --- include/linux/i2c.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/i2c.h b/include/linux/i2c.h index 8e25a91..8d87329 100644 --- a/include/linux/i2c.h +++ b/include/linux/i2c

Re: [PATCH v1] i2c-hid: introduce HID over i2c specification implementation

2012-10-03 Thread Dmitry Torokhov
Hi Benjamin, A few random comments... On Fri, Sep 14, 2012 at 03:41:43PM +0200, benjamin.tissoires wrote: > From: Benjamin Tissoires > > Microsoft published the protocol specification of HID over i2c: > http://msdn.microsoft.com/en-us/library/windows/hardware/hh852380.aspx > > This patch intro

Re: [PATCH v1] i2c-hid: introduce HID over i2c specification implementation

2012-10-03 Thread Shubhrajyoti Datta
On Wed, Oct 3, 2012 at 9:03 PM, Benjamin Tissoires wrote: > Hi, > > thanks also for the review. Two in the same day! I was about to send a > ping on that patch ;-) > > On Wed, Oct 3, 2012 at 8:05 AM, Shubhrajyoti Datta > wrote: >> On Fri, Sep 14, 2012 at 7:11 PM, benjamin.tissoires >> wrote:

Re: [PATCH v1] i2c-hid: introduce HID over i2c specification implementation

2012-10-03 Thread Benjamin Tissoires
Hi, thanks also for the review. Two in the same day! I was about to send a ping on that patch ;-) On Wed, Oct 3, 2012 at 8:05 AM, Shubhrajyoti Datta wrote: > On Fri, Sep 14, 2012 at 7:11 PM, benjamin.tissoires > wrote: >> From: Benjamin Tissoires >> >> Microsoft published the protocol spec

Re: [PATCH v1] i2c-hid: introduce HID over i2c specification implementation

2012-10-03 Thread Benjamin Tissoires
Hi JJ, On Wed, Oct 3, 2012 at 5:08 AM, Jian-Jhong Ding wrote: > Hi Benjamin, > > I have one little question about __i2chid_command(), please see below. > > "benjamin.tissoires" writes: >> From: Benjamin Tissoires >> >> Microsoft published the protocol specification of HID over i2c: >> http://ms