Re: [PATCH] i2c: mxs: Add PIO and mixed-DMA support

2012-11-22 Thread Wolfram Sang
On Thu, Nov 22, 2012 at 01:50:37AM +0100, Marek Vasut wrote: Dear Marek Vasut, Add support for the PIO mode and mixed PIO/DMA mode support. The mixed PIO/DMA is the default mode of operation. This shall leverage overhead that the driver creates due to setting up DMA descriptors even for

Re: [PATCH] i2c: mxs: Add PIO and mixed-DMA support

2012-11-22 Thread Marek Vasut
Dear Wolfram Sang, On Thu, Nov 22, 2012 at 01:50:37AM +0100, Marek Vasut wrote: Dear Marek Vasut, Add support for the PIO mode and mixed PIO/DMA mode support. The mixed PIO/DMA is the default mode of operation. This shall leverage overhead that the driver creates due to setting up

RE: [PATCH 2/2] i2c: s3c2410: Get the i2c bus number from alias id

2012-11-22 Thread Kukjin Kim
Doug Anderson wrote: On Tue, Nov 20, 2012 at 8:09 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Tue, Nov 20, 2012 at 02:27:04PM -0800, Doug Anderson wrote: From: Padmavathi Venna padm...@samsung.com Get the i2c bus number that the device is connected to using the alias

Re: [PATCH] i2c: mxs: Add PIO and mixed-DMA support

2012-11-22 Thread Marek Vasut
Dear Marek Vasut, Add support for the PIO mode and mixed PIO/DMA mode support. The mixed PIO/DMA is the default mode of operation. This shall leverage overhead that the driver creates due to setting up DMA descriptors even for very short transfers. The current boundary between PIO/DMA 8

Re: [PATCH] i2c: i2c-ocores: Move grlib set/get functions into #ifdef CONFIG_OF block

2012-11-22 Thread Wolfram Sang
On Mon, Nov 19, 2012 at 01:17:48PM +0100, Andreas Larsson wrote: This moves the grlib set and get functions into the #ifdef CONFIG_OF block to avoid warnings of unimplemented functions when compiling with -Wunused-function when CONFIG_OF is not defined. Signed-off-by: Andreas Larsson

Re: [PATCH] i2c: i2c-s3c2410: Remove recently introduced performance overheads

2012-11-22 Thread Wolfram Sang
On Wed, Nov 21, 2012 at 01:12:11PM +0900, Mark Brown wrote: The changes in i2c-s3c2410: use exponential back off while polling for bus idle remove the initial busy wait for I2C transfers to complete and replace it with usleep_range() calls which will schedule. Since for older SoCs I2C

Re: [PATCH 1/2] i2c: mxs: Handle i2c DMA failure properly

2012-11-22 Thread Wolfram Sang
On Sun, Nov 18, 2012 at 06:25:07AM +0100, Marek Vasut wrote: Properly terminate the DMA transfer in case the DMA PIO transfer or setup fails for any reason. Signed-off-by: Marek Vasut ma...@denx.de Applied to for-current, thanks! -- Pengutronix e.K. | Wolfram Sang

[PATCH 0/7] i2c: s3c2410: Add devm_* apis and cleanup

2012-11-22 Thread Tushar Behera
This patchset cleans up the probe function of i2c-s3c2410 driver. These have been tested on Exynos4210 based Origen board. Tushar Behera (7): i2c: s3c2410: Remove unnecessary label err_noclk i2c: s3c2410: Convert to use devm_clk_get() i2c: s3c2410: Convert to use devm_request_mem_region()

[PATCH 5/7] i2c: s3c2410: Convert to use devm_request_irq()

2012-11-22 Thread Tushar Behera
Signed-off-by: Tushar Behera tushar.beh...@linaro.org --- drivers/i2c/busses/i2c-s3c2410.c | 10 +++--- 1 files changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c index 3446af2..3e4143c 100644 ---

[PATCH 6/7] i2c: s3c2410: Move location of clk_prepare_enable() call in probe function

2012-11-22 Thread Tushar Behera
In probe call, only s3c24xx_i2c_init() needs the I2C clock to be enabled. Moving clk_prepare_enable() and clk_disable_unprepare() calls to around this function simplifies the return path of probe call. Signed-off-by: Tushar Behera tushar.beh...@linaro.org --- drivers/i2c/busses/i2c-s3c2410.c |

[PATCH 1/7] i2c: s3c2410: Remove unnecessary label err_noclk

2012-11-22 Thread Tushar Behera
err_noclk label redirects to a simple return statement. Move the return statement to the caller location and remove the label. Signed-off-by: Tushar Behera tushar.beh...@linaro.org --- drivers/i2c/busses/i2c-s3c2410.c |9 +++-- 1 files changed, 3 insertions(+), 6 deletions(-) diff --git

Re: [PATCH 4/7] i2c: s3c2410: Convert to use devm_ioremap()

2012-11-22 Thread Sachin Kamat
Hi Tushar, On 23 November 2012 11:29, Tushar Behera tushar.beh...@linaro.org wrote: Signed-off-by: Tushar Behera tushar.beh...@linaro.org --- drivers/i2c/busses/i2c-s3c2410.c | 13 - 1 files changed, 4 insertions(+), 9 deletions(-) diff --git

Re: [PATCH 0/7] i2c: s3c2410: Add devm_* apis and cleanup

2012-11-22 Thread Shubhrajyoti Datta
On Fri, Nov 23, 2012 at 11:29 AM, Tushar Behera tushar.beh...@linaro.org wrote: This patchset cleans up the probe function of i2c-s3c2410 driver. These have been tested on Exynos4210 based Origen board. Tushar Behera (7): i2c: s3c2410: Remove unnecessary label err_noclk i2c: s3c2410:

Re: [PATCH 4/7] i2c: s3c2410: Convert to use devm_ioremap()

2012-11-22 Thread Tushar Behera
On 11/23/2012 11:44 AM, Sachin Kamat wrote: Hi Tushar, On 23 November 2012 11:29, Tushar Behera tushar.beh...@linaro.org wrote: Signed-off-by: Tushar Behera tushar.beh...@linaro.org --- drivers/i2c/busses/i2c-s3c2410.c | 13 - 1 files changed, 4 insertions(+), 9 deletions(-)

Re: [PATCH 0/7] i2c: s3c2410: Add devm_* apis and cleanup

2012-11-22 Thread Tushar Behera
On 11/23/2012 11:45 AM, Shubhrajyoti Datta wrote: On Fri, Nov 23, 2012 at 11:29 AM, Tushar Behera tushar.beh...@linaro.org wrote: This patchset cleans up the probe function of i2c-s3c2410 driver. These have been tested on Exynos4210 based Origen board. Tushar Behera (7): i2c: s3c2410: