Re: [PATCH 2/2] i2c-s3c2410: Add bus arbitration implementation

2012-12-03 Thread Naveen Krishna Ch
On 4 December 2012 05:41, Olof Johansson wrote: > On Sat, Dec 1, 2012 at 5:26 AM, Mark Brown > wrote: >> On Thu, Nov 29, 2012 at 10:14:58PM -0800, Olof Johansson wrote: >>> On Thu, Nov 29, 2012 at 6:13 PM, Simon Glass wrote: >> >>> > It was originally done separately but I think it was felt that

Re: [PATCH 2/2] i2c-s3c2410: Add bus arbitration implementation

2012-12-03 Thread Olof Johansson
On Sat, Dec 1, 2012 at 5:26 AM, Mark Brown wrote: > On Thu, Nov 29, 2012 at 10:14:58PM -0800, Olof Johansson wrote: >> On Thu, Nov 29, 2012 at 6:13 PM, Simon Glass wrote: > >> > It was originally done separately but I think it was felt that this >> > was overly complex. Olof can you please commen

Re: [PATCH] I2C: EXYNOS: Add slave support to i2c

2012-12-03 Thread Giridhar Maruthy
Thank you Kyungmin Park for the review. On 3 December 2012 22:28, Kyungmin Park wrote: > > Hi, > > On Mon, Dec 3, 2012 at 9:16 PM, Giridhar Maruthy > wrote: > > This patch adds slave support to i2c. The dt entry i2c-mode > > decides at probe time if the controller needs to work in > > slave mode

Re: [PATCH v3] i2c-hid: introduce HID over i2c specification implementation

2012-12-03 Thread Benjamin Tissoires
On Mon, Dec 3, 2012 at 2:02 PM, Jean Delvare wrote: > Hi Benjamin, > > On Mon, 3 Dec 2012 12:32:03 +0100, Benjamin Tissoires wrote: >> Hi Jean, >> >> On Fri, Nov 30, 2012 at 3:56 PM, Jean Delvare wrote: >> > Hi Benjamin, Jiri, >> > >> > Sorry for the late review. But better late than never I gues

Re: [PATCH] I2C: EXYNOS: Add slave support to i2c

2012-12-03 Thread Kyungmin Park
Hi, On Mon, Dec 3, 2012 at 9:16 PM, Giridhar Maruthy wrote: > This patch adds slave support to i2c. The dt entry i2c-mode > decides at probe time if the controller needs to work in > slave mode and the controller is accordingly programmed. > > Signed-off-by: Giridhar Maruthy > --- > drivers/i2c

Re: [PATCH v3] i2c-hid: introduce HID over i2c specification implementation

2012-12-03 Thread Jean Delvare
Hi Benjamin, On Mon, 3 Dec 2012 12:32:03 +0100, Benjamin Tissoires wrote: > Hi Jean, > > On Fri, Nov 30, 2012 at 3:56 PM, Jean Delvare wrote: > > Hi Benjamin, Jiri, > > > > Sorry for the late review. But better late than never I guess... > > Sure! Thanks for the review. As the driver is already

Re: [PATCH v3] i2c-hid: introduce HID over i2c specification implementation

2012-12-03 Thread Benjamin Tissoires
Hi Jean, On Fri, Nov 30, 2012 at 3:56 PM, Jean Delvare wrote: > Hi Benjamin, Jiri, > > Sorry for the late review. But better late than never I guess... Sure! Thanks for the review. As the driver is already in Jiri's tree, I'll do small incremental patches based on this release. I'll try to addr