[PATCH V2 REPOST] i2c: add bcm2835 driver

2013-01-28 Thread Stephen Warren
This implements a very basic I2C host driver for the BCM2835 SoC. Missing features so far are: * 10-bit addressing. * DMA. Signed-off-by: Stephen Warren --- v2: * Implemented clock divider configuration based on desired bus rate. * Make use of module_platform_driver(). * Removed use of devinit.

[PATCH v3 6/6] Cleanup

2013-01-28 Thread Amaury Decrême
This patch corrects checkpatch errors. The changes has also been removed as it has less meaning with version control tools. Signed-off-by: Amaury Decrême --- drivers/i2c/busses/i2c-sis630.c | 210 1 file changed, 106 insertions(+), 104 deletions(-) diff

[PATCH v3 5/6] Misc: display unsigned hex

2013-01-28 Thread Amaury Decrême
This patch corrects the display of the acpi_base unsigned hex value. Signed-off-by: Amaury Decrême --- drivers/i2c/busses/i2c-sis630.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-sis630.c b/drivers/i2c/busses/i2c-sis630.c index b2fa741..424545b 1006

[PATCH v3 4/6] Cosmetics: hex to constants for SMBus commands

2013-01-28 Thread Amaury Decrême
This patch replaces hexadecimal values by constants for SMBus commands. Signed-off-by: Amaury Decrême --- drivers/i2c/busses/i2c-sis630.c | 45 - 1 file changed, 31 insertions(+), 14 deletions(-) diff --git a/drivers/i2c/busses/i2c-sis630.c b/drivers/i2c/

[PATCH v3 3/6] Bugfix: behavior after collision

2013-01-28 Thread Amaury Decrême
Datasheet on collision: SMBus Collision (SMBCOL_STS) This bit is set when a SMBus Collision condition occurs and SMBus Host loses in the bus arbitration. The software should clear this bit and re-start SMBus operation. As the status will be cleared in transaction_en

[PATCH v3 2/6] Bugfix: clear sticky bits

2013-01-28 Thread Amaury Decrême
The sticky bits must be cleared at the end of the transaction by writing a 1 to all fields. Datasheet: SMBus Status (SMB_STS) The following registers are all sticky bits and only can be cleared by writing a one to their corresponding fields. Signed-off-by: Amaury Decrême

[PATCH v3 1/6] Add SIS964 bus support to i2c-sis630.

2013-01-28 Thread Amaury Decrême
Signed-off-by: Amaury Decrême --- Documentation/i2c/busses/i2c-sis630 | 9 drivers/i2c/busses/Kconfig | 4 +- drivers/i2c/busses/i2c-sis630.c | 88 - 3 files changed, 69 insertions(+), 32 deletions(-) diff --git a/Documentation/i2c/busses/i

[PATCH v3 0/6] I2C: sis630: add sis964 support

2013-01-28 Thread Amaury Decrême
Those patches add sis964 support to i2c-sis630. The SiS datasheets have been used. The SiS964 isn't part of the SIS96X family and behaves like the SiS630 chip family. For I2C, this array show the differences between a SiS630 and a SiS964. +++-

Re: [PATCH v2 6/6] Cleanup

2013-01-28 Thread Amaury Decrême
On Mon, Jan 28, 2013 at 07:40:07PM +0100, Jean Delvare wrote: > > Some "80 columns" warnings have been expressly omitted to keep reading > > easy. > > You can get rid of these too by splitting the affected lines. You do > not have to split the strings themselves, but the other parameters can > be

Re: [PATCH v2 5/6] Misc: display unsigned hex

2013-01-28 Thread Amaury Decrême
On Mon, Jan 28, 2013 at 07:33:04PM +0100, Jean Delvare wrote: > > - dev_dbg(&adap->dev, "SMBus busy (%02x). Resetting...\n", temp); > > + dev_dbg(&adap->dev, "SMBus busy (%02hx). Resetting...\n", temp); > > %hx is for shorts, not bytes. There is no format specifier for shorts,

Re: [PATCH v2 4/6] Cosmetics: hex to constants for SMBus commands

2013-01-28 Thread Amaury Decrême
On Mon, Jan 28, 2013 at 06:42:33PM +0100, Jean Delvare wrote: > > Good idea, however you missed one occurrence of BYTE_DONE_STS in > sis630_transaction_wait(). > Thanks, corrected. -- Amaury Decrême -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a messag

[PATCH v5] i2c: Adding support for Intel iSMT SMBus 2.0 host controller

2013-01-28 Thread Neil Horman
The iSMT (Intel SMBus Message Transport) supports multi-master I2C/SMBus, as well as IPMI. It's operation is DMA-based and utilizes descriptors to initiate transactions on the bus. The iSMT hardware can act as both a master and a target, although this driver only supports being a master. Signed-

Re: [PATCH v2 6/6] Cleanup

2013-01-28 Thread Jean Delvare
On Fri, 4 Jan 2013 14:13:35 +0100, Amaury Decrême wrote: > This patch corrects checkpatch errors. > Some "80 columns" warnings have been expressly omitted to keep reading > easy. You can get rid of these too by splitting the affected lines. You do not have to split the strings themselves, but the

Re: [PATCH v2 5/6] Misc: display unsigned hex

2013-01-28 Thread Jean Delvare
On Fri, 4 Jan 2013 14:13:34 +0100, Amaury Decrême wrote: > This patch corrects the display of unsigned hex values. > > Signed-off-by: Amaury Decrême > --- > drivers/i2c/busses/i2c-sis630.c | 25 ++--- > 1 files changed, 14 insertions(+), 11 deletions(-) > > diff --git a/dr

Re: [PATCH v2 4/6] Cosmetics: hex to constants for SMBus commands

2013-01-28 Thread Jean Delvare
On Fri, 4 Jan 2013 14:13:33 +0100, Amaury Decrême wrote: > This patch replaces hexadecimal values by constants for SMBus commands > and bit masks. > > Signed-off-by: Amaury Decrême > --- > drivers/i2c/busses/i2c-sis630.c | 45 ++ > 1 files changed, 31 inser

Re: [PATCH v2 3/6] Bugfix: behavior after collision

2013-01-28 Thread Jean Delvare
On Fri, 4 Jan 2013 14:13:32 +0100, Amaury Decrême wrote: > Datasheet on collision: > SMBus Collision (SMBCOL_STS) > This bit is set when a SMBus Collision condition occurs and > SMBus Host loses in the bus arbitration. The software should > clear this bit and re-start SMBus

Re: [PATCH v2 2/6] Bugfix: clear sticky bits

2013-01-28 Thread Jean Delvare
On Fri, 4 Jan 2013 14:13:31 +0100, Amaury Decrême wrote: > The sticky bits must be cleared at the end of the transaction by writing > a 1 to all fields. > > Datasheet: > SMBus Status (SMB_STS) > The following registers are all sticky bits and only can be > cleared by writing a o

Re: [PATCH v2 1/6] Add SIS964 bus support to i2c-sis630.

2013-01-28 Thread Jean Delvare
On Fri, 4 Jan 2013 14:13:30 +0100, Amaury Decrême wrote: > Signed-off-by: Amaury Decrême > --- > Documentation/i2c/busses/i2c-sis630 |9 > drivers/i2c/busses/Kconfig |4 +- > drivers/i2c/busses/i2c-sis630.c | 88 > +++ > 3 files change

Re: [PATCH v2] i2c-isch: Add module parameter for backbone clock rate if divider is unset

2013-01-28 Thread Jean Delvare
On Mon, 28 Jan 2013 10:44:12 +0100, Alexander Stein wrote: > It was observed the Host Clock Divider was not written by the driver. It > was still set to (default) 0, if not already set by BIOS, which caused > garbage on SMBus. > This driver adds a parameters which is used to calculate the divider >

Re: [PATCH RFC] misc/at24: distinguish between eeprom and fram chips

2013-01-28 Thread Lars Poeschel
On Thursday 24 January 2013 at 08:27:01, Wolfram Sang wrote: > > > > > > I wanted to use a fm24c04 i2c fram chip with linux. I grepped > > > > > > the source and found nothing. I later found that my chip can be > > > > > > handled by at24 eeprom driver. It creates a sysfs file called > > > > > > ee

[PATCH v2] i2c-isch: Add module parameter for backbone clock rate if divider is unset

2013-01-28 Thread Alexander Stein
It was observed the Host Clock Divider was not written by the driver. It was still set to (default) 0, if not already set by BIOS, which caused garbage on SMBus. This driver adds a parameters which is used to calculate the divider appropriately for a default bitrate of 100 KHz. This new divider is