Re: [PATCH] i2c: sh_mobile: Don't start transfers when suspending

2013-02-15 Thread Magnus Damm
On Fri, Feb 15, 2013 at 2:17 AM, Bastian Hecht wrote: > Currently we provoke i2c timeouts by allowing transfers when > suspending. This patch adds awareness to suspending and fixes these > issues. > The patch follows the style used in i2c-tegra.c - thanks. > > Signed-off-by: Bastian Hecht > --- >

[PATCH] I2C: add i2c_master_send_exact() and friends

2013-02-15 Thread Dmitry Torokhov
Many i2c users consider short transfers to be an error and would prefer getting -EIO instead of a positive return value and having to convert it to error code by themselves. So let's add the following new helpers: i2c_master_send_exact() i2c_master_recv_exact() i2c_transfer

[PATCH] I2C: add i2c_master_send_exact() and friends

2013-02-15 Thread Dmitry Torokhov
Many i2c users consider short transfers to be an error and would prefer getting -EIO instead of a positive return value and having to convert it to error code by themselves. So let's add the following new helpers: i2c_master_send_exact() i2c_master_recv_exact() i2c_transfer

Re: [PATCH] i2c: sh_mobile: Don't start transfers when suspending

2013-02-15 Thread Simon Horman
On Thu, Feb 14, 2013 at 11:17:37AM -0600, Bastian Hecht wrote: > Currently we provoke i2c timeouts by allowing transfers when > suspending. This patch adds awareness to suspending and fixes these > issues. > The patch follows the style used in i2c-tegra.c - thanks. Hi, at this stage I do not expe

Re: [PATCH] i2c: mux: Remove unneeded platform_set_drvdata to NULL in remove

2013-02-15 Thread Doug Anderson
Wolfram, On Fri, Feb 15, 2013 at 11:53 AM, Wolfram Sang wrote: > >> I'll re-send with I2C subsystem wide. I probably won't attempt the >> whole kernel wide at this point, but would be very happy if someone >> else wanted to! :) > > Thanks. Please double check that setting NULL is really unneede

[PATCH] i2c: tegra: assume CONFIG_OF, remove platform data

2013-02-15 Thread Stephen Warren
From: Stephen Warren Tegra only supports, and always enables, device tree. Remove all ifdefs and runtime checks for DT support from the driver. Platform data is therefore no longer required. Delete the header that defines it. Signed-off-by: Stephen Warren --- arch/arm/mach-tegra/board-dt-tegra

Re: [PATCH v3 1/3] i2c: mux: Add i2c-arbitrator-cros-ec 'mux' driver

2013-02-15 Thread Stephen Warren
On 02/15/2013 12:46 PM, Doug Anderson wrote: > The i2c-arbitrator-cros-ec driver implements the arbitration scheme > that the Embedded Controller (EC) on the ARM Chromebook expects to use > for bus multimastering. This i2c-arbitrator-cros-ec driver could also > be used in other places where standa

Re: [PATCH] i2c: tegra: remove warning dump if timeout happen in transfer

2013-02-15 Thread Wolfram Sang
On Fri, Feb 15, 2013 at 12:40:47PM -0700, Stephen Warren wrote: > On 02/15/2013 12:18 PM, Wolfram Sang wrote: > > On Thu, Feb 14, 2013 at 06:13:33PM +0530, Laxman Dewangan wrote: > >> If timeout error occurs in the i2c transfer then it was dumping warning > >> of call stack. > >> > >> Remove the wa

Re: [PATCH 1/2] i2c: s3c2410: move mach/regs-iic.h into i2c-s3c2410 device driver

2013-02-15 Thread Wolfram Sang
Hi Kukjin, (please don't quote the whole patch for those few lines) > Looks good to me on this series: > Acked-by: Kukjin Kim > > Hi Wolfram, if you're ok on this, please pick up into your tree with my ack. Will do, but not for 3.9 anymore. Thanks! -- To unsubscribe from this list: send the l

Re: [PATCH] i2c: mux: Remove unneeded platform_set_drvdata to NULL in remove

2013-02-15 Thread Wolfram Sang
> I'll re-send with I2C subsystem wide. I probably won't attempt the > whole kernel wide at this point, but would be very happy if someone > else wanted to! :) Thanks. Please double check that setting NULL is really unneeded for the non-platform-bus variants, too, or skip those if you are unsur

[PATCH v3 1/3] i2c: mux: Add i2c-arbitrator-cros-ec 'mux' driver

2013-02-15 Thread Doug Anderson
The i2c-arbitrator-cros-ec driver implements the arbitration scheme that the Embedded Controller (EC) on the ARM Chromebook expects to use for bus multimastering. This i2c-arbitrator-cros-ec driver could also be used in other places where standard I2C bus arbitration can't be used and two extra GP

Re: [PATCH -next] i2c: fix i2c-ismt.c printk format warning

2013-02-15 Thread Wolfram Sang
On Fri, Feb 15, 2013 at 10:51:40AM -0800, Randy Dunlap wrote: > From: Randy Dunlap > > Fix printk format warning. dma_addr_t can be 32-bit or 64-bit, > so cast it to long long for printing. This also matches the > printk format specifier that is already used. > > drivers/i2c/busses/i2c-ismt.c:

Re: [PATCH] i2c: mux: Remove unneeded platform_set_drvdata to NULL in remove

2013-02-15 Thread Doug Anderson
Wolfram, On Fri, Feb 15, 2013 at 11:37 AM, Wolfram Sang wrote: > I think we should do this at least I2C subsystem wide (51 occasions of > setting some *_drvdata to NULL), even better kernel-wide. Patching > individual drivers won't cut the confusion around this issue, I am > afraid. I did it "mu

Re: [PATCH] i2c: tegra: remove warning dump if timeout happen in transfer

2013-02-15 Thread Stephen Warren
On 02/15/2013 12:18 PM, Wolfram Sang wrote: > On Thu, Feb 14, 2013 at 06:13:33PM +0530, Laxman Dewangan wrote: >> If timeout error occurs in the i2c transfer then it was dumping warning >> of call stack. >> >> Remove the warning dump as there is may be possibility that some slave >> devices are bus

Re: [PATCH] i2c: mux: Remove unneeded platform_set_drvdata to NULL in remove

2013-02-15 Thread Wolfram Sang
On Fri, Feb 15, 2013 at 10:41:22AM -0800, Doug Anderson wrote: > Stephen Warren pointed out as part of a code review of another mux > driver that there should be no need to have > "platform_set_drvdata(pdev, NULL)" in the remove function. Get rid of > it in the i2c-mux-gpio driver. > > See Stephe

Re: [PATCH] i2c: tegra: remove warning dump if timeout happen in transfer

2013-02-15 Thread Wolfram Sang
On Thu, Feb 14, 2013 at 06:13:33PM +0530, Laxman Dewangan wrote: > If timeout error occurs in the i2c transfer then it was dumping warning > of call stack. > > Remove the warning dump as there is may be possibility that some slave > devices are busy and not responding the i2c communication. > > S

Re: [PATCH V3] i2c: davinci: update to devm_* API

2013-02-15 Thread Wolfram Sang
On Thu, Feb 07, 2013 at 06:22:00PM +0530, Vishwanathrao Badarkhe, Manish wrote: > Update the code to use devm_* API so that driver > core will manage resources. > Also, if "devm_request_and_ioremap" fails return -EADDRNOTAVAIL > instead of -EBUSY. > > Signed-off-by: Vishwanathrao Badarkhe, Manish

Re: [PATCH -next] i2c: fix i2c-ismt.c printk format warning

2013-02-15 Thread Neil Horman
>Fix printk format warning. dma_addr_t can be 32-bit or 64-bit, >so cast it to long long for printing. This also matches the >printk format specifier that is already used. > >drivers/i2c/busses/i2c-ismt.c:532:3: warning: format '%llX' expects argument >of type \ >'long long unsigned int', but ar

Re: i2c/i2c-mxs: use devm_request_and_ioremap

2013-02-15 Thread Wolfram Sang
On Sat, Feb 02, 2013 at 02:14:57PM -, =?utf-8?q?Peter_H=C3=BCwe_=3CPeterHuewe=40gmx=2Ede=3E?= wrote: > Replace a call to devm_request_mem_region followed by a call to > dev_ioremap_nocache with devm_request_and_ioremap which does the same. > And since res_size isn't needed anymore we can remo

[PATCH -next] i2c: fix i2c-ismt.c printk format warning

2013-02-15 Thread Randy Dunlap
c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-20130215.orig/drivers/i2c/busses/i2c-ismt.c +++ linux-next-20130215/drivers/i2c/busses/i2c-ismt.c @@ -530,7 +530,7 @@ static int ismt_access(struct i2c_adapte } dev_dbg

[PATCH] i2c: mux: Remove unneeded platform_set_drvdata to NULL in remove

2013-02-15 Thread Doug Anderson
Stephen Warren pointed out as part of a code review of another mux driver that there should be no need to have "platform_set_drvdata(pdev, NULL)" in the remove function. Get rid of it in the i2c-mux-gpio driver. See Stephen's comment at: http://www.gossamer-threads.com/lists/linux/kernel/16786

Re: [PATCH v2 1/3] i2c: mux: Add i2c-arbitrator-cros-ec 'mux' driver

2013-02-15 Thread Mark Brown
On Fri, Feb 15, 2013 at 10:38:29AM -0700, Stephen Warren wrote: > Either way though, I believe that upstream, no driver should be relying > on specific initcall levels in order to get dependencies/initialization > ordering correct. Right, in the past we did bodges like this but in the glorious ne

Re: [PATCH] i2c-designware: Interrupt sharing and SDA hold time

2013-02-15 Thread Mika Westerberg
On Fri, Feb 15, 2013 at 02:05:10PM +0100, Christian Ruppert wrote: > On Fri, Feb 15, 2013 at 01:50:37PM +0200, Mika Westerberg wrote: > > On Fri, Feb 15, 2013 at 11:11:50AM +0100, Christian Ruppert wrote: > > > This patch implements interrupt sharing and SDA hold time configuration in > > > the des

Re: [PATCH v2 1/3] i2c: mux: Add i2c-arbitrator-cros-ec 'mux' driver

2013-02-15 Thread Stephen Warren
On 02/14/2013 05:21 PM, Doug Anderson wrote: > The i2c-arbitrator-cros-ec driver implements the arbitration scheme > that the Embedded Controller (EC) on the ARM Chromebook expects to use > for bus multimastering. This i2c-arbitrator-cros-ec driver could also > be used in other places where standa

Re: [PATCH] i2c-designware: Interrupt sharing and SDA hold time

2013-02-15 Thread Christian Ruppert
On Fri, Feb 15, 2013 at 01:50:37PM +0200, Mika Westerberg wrote: > On Fri, Feb 15, 2013 at 11:11:50AM +0100, Christian Ruppert wrote: > > This patch implements interrupt sharing and SDA hold time configuration in > > the designware i2c driver. Both functions are enabled through platform data > > or

Re: [PATCH] i2c: tegra: remove warning dump if timeout happen in transfer

2013-02-15 Thread Wolfram Sang
On Fri, Feb 15, 2013 at 06:31:07PM +0530, Shubhrajyoti Datta wrote: > On Thu, Feb 14, 2013 at 6:13 PM, Laxman Dewangan wrote: > > If timeout error occurs in the i2c transfer then it was dumping warning > > of call stack. > > > > Remove the warning dump as there is may be possibility that some slav

Re: [PATCH] i2c: tegra: remove warning dump if timeout happen in transfer

2013-02-15 Thread Shubhrajyoti Datta
On Thu, Feb 14, 2013 at 6:13 PM, Laxman Dewangan wrote: > If timeout error occurs in the i2c transfer then it was dumping warning > of call stack. > > Remove the warning dump as there is may be possibility that some slave > devices are busy and not responding the i2c communication. > > Signed-off-

Re: [PATCH 10/11] ARM: s3c: i2c: add platform_device forward declaration

2013-02-15 Thread Wolfram Sang
On Thu, Feb 14, 2013 at 02:49:26PM +0100, Arnd Bergmann wrote: > A recent cleanup to the mach-osiris.c file is causing build errors > because the i2c-s3c2410.h header file is included before we see > the definition for platform_device. The fix is to make the header file > more robust against inclus

Re: [PATCH] i2c-designware: Interrupt sharing and SDA hold time

2013-02-15 Thread Mika Westerberg
On Fri, Feb 15, 2013 at 11:11:50AM +0100, Christian Ruppert wrote: > This patch implements interrupt sharing and SDA hold time configuration in > the designware i2c driver. Both functions are enabled through platform data > or device tree. Tested with Linux-3.8rc4 (Synopsys ARC port, see > https://

[PATCH] i2c-designware: Interrupt sharing and SDA hold time

2013-02-15 Thread Christian Ruppert
This patch implements interrupt sharing and SDA hold time configuration in the designware i2c driver. Both functions are enabled through platform data or device tree. Tested with Linux-3.8rc4 (Synopsys ARC port, see https://github.com/foss-for-synopsys-dwc-arc-processors/linux/commits/arc-3.8-basel