Re: [PATCH v2 1/2] i2c: mxs: remove races in PIO code

On Mon, Apr 15, 2013 at 12:16:54PM +0200, Lucas Stach wrote: > This commit fixes the three following races in PIO code: > > - The CTRL0 register is racy in itself, when programming transfer state and > run bit in the same cycle the hardware sometimes ends up using the state > from the last tra

Re: [PATCH v2 1/7] i2c-designware: move to managed functions (devm_*)

On Wed, Apr 10, 2013 at 01:36:36PM +0300, Mika Westerberg wrote: > From: Andy Shevchenko > > This makes the error handling much more simpler than open-coding everything > and in addition makes the probe function smaller and tidier. > > Signed-off-by: Andy Shevchenko > Signed-off-by: Mika Wester

Re: [PATCH] i2c: s3c2410: Add SMBus emulation for block read

> I don't know if that can happen, but if the block has length 0 (that is, > only consists of a single byte that is read as 0) the is_msglast() test > returns 0 which might be wrong. Maybe even if it cannot regularily > happen handle it in a sane way? Length of 0 is illegal according to the specs

Re: [PATCH 0/3] ARM: at91: move to generic DMA device tree bindings

On 14:16 Mon 15 Apr , ludovic.desroc...@atmel.com wrote: > From: Ludovic Desroches > > Hi, > > This set of patches introduces DMA device tree bindings support for the atmel > DMA controller and first driver conversions. > > I'll send an update of dts file in the next version if there is no

[PATCH 3/3] mci: at91: convert to dma_request_slave_channel_compat()

From: Ludovic Desroches Use generic DMA DT helper. Platforms booting with or without DT populated are both supported. Signed-off-by: Ludovic Desroches --- drivers/mmc/host/atmel-mci.c | 25 - 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/drivers/mmc/ho

[PATCH 2/3] i2c: at91: convert to dma_request_slave_channel_compat()

From: Ludovic Desroches Use generic DMA DT helper. Platforms booting with or without DT populated are both supported. Signed-off-by: Ludovic Desroches --- drivers/i2c/busses/i2c-at91.c | 49 ++- 1 file changed, 25 insertions(+), 24 deletions(-) diff --g

[PATCH 1/3] at_hdmac: move to generic DMA binding

From: Ludovic Desroches Update at_hdmac driver to support generic DMA device tree binding. Devices can still request channel with dma_request_channel() then it doesn't break DMA for non DT boards. Signed-off-by: Ludovic Desroches --- .../devicetree/bindings/dma/atmel-dma.txt | 26

[PATCH 0/3] ARM: at91: move to generic DMA device tree bindings

From: Ludovic Desroches Hi, This set of patches introduces DMA device tree bindings support for the atmel DMA controller and first driver conversions. I'll send an update of dts file in the next version if there is no major issue with the bindings. Regards Ludovic Desroches (3): at_hdmac:

[PATCH v2 2/2] i2c: mxs: do error checking and handling in PIO mode

In PIO mode we can end up with the same errors as in DMA mode, but as IRQs are disabled there we have to check for them manually after each command. Also don't use the big controller reset hammer when receiving a NAK from a slave. It's sufficient to tell the controller to continue at a clean state

[PATCH v2 1/2] i2c: mxs: remove races in PIO code

This commit fixes the three following races in PIO code: - The CTRL0 register is racy in itself, when programming transfer state and run bit in the same cycle the hardware sometimes ends up using the state from the last transfer. Fix this by programming state in one cycle, make sure the writ

Re: [PATCH 1/3] i2c: mxs: always end a transfer with a proper STOP

Hi Wolfram, Am Dienstag, den 09.04.2013, 10:32 +0200 schrieb Wolfram Sang: > Hi, > > > A restart transfer is when you just repeat the START condition, without > > putting the device address on the bus again. > > Well, never heard this term before. Where did you get it from? > > > In the MXS dri