Re: [PATCH v2] i2c: core: make it possible to match a pure device tree driver

2013-06-18 Thread Wolfram Sang
On Mon, Jun 17, 2013 at 11:15:30PM +0100, Grant Likely wrote: On Mon, Jun 17, 2013 at 5:33 PM, Linus Walleij linus.wall...@linaro.org wrote: On Mon, Jun 17, 2013 at 5:48 PM, Stephen Warren swar...@wwwdotorg.org wrote: This has just shown up in next-20130617, and breaks at least the

Re: [PATCH v2] i2c: core: make it possible to match a pure device tree driver

2013-06-18 Thread Linus Walleij
On Tue, Jun 18, 2013 at 9:33 AM, Wolfram Sang w...@the-dreams.de wrote: On Mon, Jun 17, 2013 at 11:15:30PM +0100, Grant Likely wrote: On Mon, Jun 17, 2013 at 5:33 PM, Linus Walleij linus.wall...@linaro.org wrote: OK that works for me, I'm not in any hurry. Deferring by a merge window isn't

[PATCH v8] i2c-designware: make SDA hold time configurable

2013-06-18 Thread Christian Ruppert
This patch makes the SDA hold time configurable through device tree. Signed-off-by: Christian Ruppert christian.rupp...@abilis.com Signed-off-by: Pierrick Hascoet pierrick.hasc...@abilis.com --- .../devicetree/bindings/i2c/i2c-designware.txt | 14 ++

Re: [PATCH 0/2] Fix kernel panics with certain I2C tps6* chips

2013-06-18 Thread Linus Walleij
On Mon, Jun 17, 2013 at 7:47 PM, Tuomas Tynkkynen ttynkky...@nvidia.com wrote: Hi, Latest linux-next head (next-20130617) seems to have some backwards-incompatible changes to the i2c core, which breaks the tps* drivers in our boards and cause panics on boot. You should probably put

Re: [PATCH 2/2] i2c: imx: Add Vybrid VF610 I2C controller support

2013-06-18 Thread Shawn Guo
On Tue, Jun 18, 2013 at 10:10:18AM +0800, Jingchang Lu wrote: Add Freescale Vybrid VF610 I2C controller support to imx I2C driver framework. Some operation is different from imx I2C controller. The register offset, the i2c clock divider value table, the module enabling(I2CR_IEN) which is

RE: [PATCH 2/2] i2c: imx: Add Vybrid VF610 I2C controller support

2013-06-18 Thread Lu Jingchang-B35083
-Original Message- From: Shawn Guo [mailto:shawn@linaro.org] Sent: Tuesday, June 18, 2013 4:46 PM To: Lu Jingchang-B35083 Cc: w...@the-dreams.de; Estevam Fabio-R49496; s.ha...@pengutronix.de; linux-i2c@vger.kernel.org; linux-arm-ker...@lists.infradead.org; Jin Zhengxiong-R64188; Li

Re: [PATCH 1/2] mfd: tps65910: Fix crash in i2c_driver .probe

2013-06-18 Thread Samuel Ortiz
On Mon, Jun 17, 2013 at 12:16:33PM -0600, Stephen Warren wrote: On 06/17/2013 11:47 AM, Tuomas Tynkkynen wrote: Commit i2c: core: make it possible to match a pure device tree driver changed semantics of the i2c probing for device tree devices. Device tree probed devices now get a NULL

[PATCH v2 2/2] i2c: imx: Add Vybrid VF610 I2C controller support

2013-06-18 Thread Jingchang Lu
Add Freescale Vybrid VF610 I2C controller support to imx I2C driver framework. Some operation is different from imx I2C controller. The register offset, the i2c clock divider value table, the module enabling(I2CR_IEN) which is just invert with imx, and the interrupt flag(I2SR) clearing opcode

Re: [PATCH 1/2] mfd: tps65910: Fix crash in i2c_driver .probe

2013-06-18 Thread Tuomas Tynkkynen
On 06/17/2013 09:07 PM, Stephen Warren wrote: On 06/17/2013 11:47 AM, Tuomas Tynkkynen wrote: Commit i2c: core: make it possible to match a pure device tree driver changed semantics of the i2c probing for device tree devices. Device tree probed devices now get a NULL i2c_device_id pointer.

[PATCH v2 1/2] mfd: tps65910: Fix crash in i2c_driver .probe

2013-06-18 Thread Tuomas Tynkkynen
Commit i2c: core: make it possible to match a pure device tree driver changed semantics of the i2c probing for device tree devices. Device tree probed devices now get a NULL i2c_device_id pointer. This caused kernel panics due to NULL dereference. Moves the of_match_device call from

[PATCH v2 2/2] regulator: tps62360: Fix crash in i2c_driver .probe

2013-06-18 Thread Tuomas Tynkkynen
Commit i2c: core: make it possible to match a pure device tree driver changed semantics of the i2c probing for device tree devices. Device tree probed devices now get a NULL i2c_device_id pointer. This caused kernel panics due to NULL dereference. Tested-by: Stephen Warren swar...@nvidia.com

Re: [PATCH REBASE] i2c-designware: make SDA hold time configurable

2013-06-18 Thread Andy Shevchenko
On Mon, Jun 17, 2013 at 11:55 PM, Rob Herring robherri...@gmail.com wrote: +Optional properties : + - sda-hold-time : should contain the SDA hold time in nanoseconds. Please specify time units in the property name. Perhaps i2c-sda-hold-time-ns. Based on reading the discussion, there is one

[PATCH] regulator: tps51632: Get regulator name from i2c_client

2013-06-18 Thread Mikko Perttunen
Commit i2c: core: make it possible to match a pure device tree driver changed semantics of the i2c probing for device tree devices. Device tree probed devices now get a NULL i2c_device_id pointer. This causes the regulator name to be set to NULL and the regulator registration to fail.

Re: [PATCH] regulator: tps51632: Get regulator name from i2c_client

2013-06-18 Thread Mark Brown
On Tue, Jun 18, 2013 at 01:30:13PM +0300, Mikko Perttunen wrote: Commit i2c: core: make it possible to match a pure device tree driver changed semantics of the i2c probing for device tree devices. Device tree probed devices now get a NULL i2c_device_id pointer. This causes the regulator name

i2c core: issue in of_i2c_register_devices()

2013-06-18 Thread Alexandre Belloni
Hi, I think I have a corner case and I don't immediately see how to solve the issue. On the cfa-10049, we have 3 nau7802 ADCs. As they are sharing the same address, they are behind a gpio based i2c muxer. Those ADCs are able to send interrupts. So, the interrupts lines are connected to a

Re: i2c core: issue in of_i2c_register_devices()

2013-06-18 Thread Alexandre Belloni
Take 2 of my nice ascii-art: ++ ||--+ i2c0 || | gpio i2c muxer | ||--+ gpios || ++---+ |+--+ ||

Re: [PATCH v2 1/2] mfd: tps65910: Fix crash in i2c_driver .probe

2013-06-18 Thread Stephen Warren
On 06/18/2013 04:14 AM, Tuomas Tynkkynen wrote: Commit i2c: core: make it possible to match a pure device tree driver changed semantics of the i2c probing for device tree devices. Device tree probed devices now get a NULL i2c_device_id pointer. This caused kernel panics due to NULL

[PATCH v2 1/2] i2c-mv64xxx: Fix timing issue on Armada XP (errata FE-8471889)

2013-06-18 Thread Gregory CLEMENT
From: Zbigniew Bodek z...@semihalf.com All the Armada XP (mv78230, mv78260 and mv78460) have a silicon issue in the I2C controller which violate the i2c repeated start timing. The I2C standard requires a minimum of 4.7us for the repeated start condition whereas the I2C controller of the Armada XP

[PATCH v2 0/2] i2c-mv64xxx: Various fixes

2013-06-18 Thread Gregory CLEMENT
Hello, This series contains a real fix for the I2C controller of the Armada XP SoC and a patch closer to a improvement than a fix. They are independent and are only in the same series because they are kind of fixes. I kept the test on the compatible string armadaxp because I am not convinced

[PATCH v2 2/2] i2c-mv64xxx: Abort the mv64xxx_of_config if clock-frequency is not provided

2013-06-18 Thread Gregory CLEMENT
From: Zbigniew Bodek z...@semihalf.com This commit adds checking whether clock-frequency property acquisition has succeeded. Do not waste time to find baud factors if there is no information about the desired bus frequency in dts. [gregory.clem...@free-electrons.com: Reword the commit log]

Re: [PATCH v2] i2c: core: make it possible to match a pure device tree driver

2013-06-18 Thread Wolfram Sang
On Tue, Jun 18, 2013 at 09:44:17AM +0200, Linus Walleij wrote: On Tue, Jun 18, 2013 at 9:33 AM, Wolfram Sang w...@the-dreams.de wrote: On Mon, Jun 17, 2013 at 11:15:30PM +0100, Grant Likely wrote: On Mon, Jun 17, 2013 at 5:33 PM, Linus Walleij linus.wall...@linaro.org wrote: OK that

Re: [PATCH 0/2] Fix kernel panics with certain I2C tps6* chips

2013-06-18 Thread Wolfram Sang
On Mon, Jun 17, 2013 at 08:47:35PM +0300, Tuomas Tynkkynen wrote: Hi, Latest linux-next head (next-20130617) seems to have some backwards-incompatible changes to the i2c core, which breaks the tps* drivers in our boards and cause panics on boot. Thanks for pointing out. I am going to

Re: [PATCH] regulator: tps51632: Get regulator name from i2c_client

2013-06-18 Thread Wolfram Sang
On Tue, Jun 18, 2013 at 01:30:13PM +0300, Mikko Perttunen wrote: Commit i2c: core: make it possible to match a pure device tree driver changed semantics of the i2c probing for device tree devices. Device tree probed devices now get a NULL i2c_device_id pointer. This causes the regulator name

Re: [PATCH v2 0/2] Fix kernel panics with certain I2C tps6* chips

2013-06-18 Thread Wolfram Sang
On Tue, Jun 18, 2013 at 01:14:39PM +0300, Tuomas Tynkkynen wrote: Hi, Latest linux-next head (next-20130617) seems to have some backwards-incompatible changes to the i2c core, which breaks the tps* drivers in our boards and cause panics on boot. v2 changes: Don't override platform data

Re: [PATCH v2] i2c-pxa: prepare clock before use

2013-06-18 Thread Wolfram Sang
On Mon, Jun 17, 2013 at 11:30:36AM -0400, Daniel Drake wrote: On OLPC XO-1.75 (MMP2), a WARN_ON() was occurring during boot since the clock being enabled by i2c-pxa had not been prepared. Use clk_prepare_enable() to ensure that the prepare operation has taken place, and use

[PATCH v2 0/4] Kontron PLD drivers

2013-06-18 Thread Kevin Strasser
mfd changes since v1: - Use a mutex instead of spinlock - Poll for hardware mutex without timeout - Restructure mfd cell structs, only call mfd_add_devices once - Drop pointless BUG_ONs - EXPORT_SYMBOL - EXPORT_SYMBOL_GPL - kempld_*_mutex_set_index - kempld_*_mutex - Removed kempld_try_get_mutex -

[PATCH v2 2/4] i2c: Kontron PLD i2c bus driver

2013-06-18 Thread Kevin Strasser
Add i2c support for the on-board PLD found on some Kontron embedded modules. Signed-off-by: Kevin Strasser kevin.stras...@linux.intel.com Signed-off-by: Michael Brunner michael.brun...@kontron.com Acked-by: Guenter Roeck li...@roeck-us.net Acked-by: Darren Hart dvh...@linux.intel.com ---