[PATCH 3/4] i2c-i801: SMBus patch for Intel Coleto Creek DeviceIDs

2013-06-19 Thread Seth Heasley
This patch adds the i801 SMBus Controller DeviceIDs for the Intel Coleto Creek PCH. Signed-off-by: Seth Heasley --- Documentation/i2c/busses/i2c-i801 |1 + drivers/i2c/busses/Kconfig|1 + drivers/i2c/busses/i2c-i801.c |3 +++ 3 files changed, 5 insertions(+), 0 deletions

[PATCH] i2c: mv64xxx: Fix transfer error code

2013-06-19 Thread Guenter Roeck
The driver returns -ENODEV as error code if it did not get an ACK from the device. Per Documentation/i2c/fault-codes, it should return -ENXIO. Signed-off-by: Guenter Roeck --- drivers/i2c/busses/i2c-mv64xxx.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/buss

Re: [PATCH 1/5] i2c: omap: fix spurious IRQs: disable/enable IRQ at INTC when idle

2013-06-19 Thread Felipe Balbi
Hi, On Wed, Jun 19, 2013 at 01:01:28PM -0700, Kevin Hilman wrote: > Felipe Balbi writes: > > [...] > > > If you have 200 pm_runtime_get() followed by 200 pm_runtime_put() (put > > is called only after 200 gets, no put-get ping-pong), your > > ->runtime_resume() gets called once, your ->runtime_

Re: [PATCH 1/5] i2c: omap: fix spurious IRQs: disable/enable IRQ at INTC when idle

2013-06-19 Thread Kevin Hilman
Felipe Balbi writes: [...] > If you have 200 pm_runtime_get() followed by 200 pm_runtime_put() (put > is called only after 200 gets, no put-get ping-pong), your > ->runtime_resume() gets called once, your ->runtime_suspend() gets > called once but your ->runtime_idle() will get called 200 times.

Re: [PATCH 5/5] i2c: omap: remove omap_i2c_isr() hw irq handler

2013-06-19 Thread Felipe Balbi
On Wed, Jun 19, 2013 at 09:43:17PM +0300, Grygorii Strashko wrote: > Hi Felipe, > > On 06/07/2013 10:07 PM, Felipe Balbi wrote: > >Hi, > > > >On Fri, Jun 07, 2013 at 09:46:08PM +0300, Grygorii Strashko wrote: > >>The omap_i2c_isr() does the irq check and schedules threaded handler if any > >>of >

Re: [PATCH 3/5] i2c: omap: handle all irqs befor unblocking omap_i2c_xfer_msg()

2013-06-19 Thread Felipe Balbi
On Wed, Jun 19, 2013 at 09:43:04PM +0300, Grygorii Strashko wrote: > Hi Felipe, > On 06/07/2013 10:05 PM, Felipe Balbi wrote: > >Hi, > > > >On Fri, Jun 07, 2013 at 09:46:06PM +0300, Grygorii Strashko wrote: > >>ARDY|NACK and ARDY|AL are set together in OMAP_I2C_STAT_REG, which will be > >Have you s

Re: [PATCH 2/5] i2c: omap: add runtime check in isr to be sure that i2c is enabled

2013-06-19 Thread Felipe Balbi
On Wed, Jun 19, 2013 at 09:42:25PM +0300, Grygorii Strashko wrote: > Hi Felipe, > On 06/07/2013 10:02 PM, Felipe Balbi wrote: > >Hi, > > > >On Fri, Jun 07, 2013 at 09:46:05PM +0300, Grygorii Strashko wrote: > >>Add runtime check at the beginning of omap_i2c_isr/omap_i2c_isr_thread > >>to be sure th

Re: [PATCH 1/5] i2c: omap: fix spurious IRQs: disable/enable IRQ at INTC when idle

2013-06-19 Thread Felipe Balbi
Hi, On Wed, Jun 19, 2013 at 09:35:38PM +0300, Grygorii Strashko wrote: > On 06/07/2013 11:51 PM, Kevin Hilman wrote: > >Grygorii Strashko writes: > > > >>From: Kevin Hilman > >> > >>Currently, runtime PM is used to keep the device enabled only during > >>active transfers and for a configurable r

Re: [PATCH 1/5] i2c: omap: fix spurious IRQs: disable/enable IRQ at INTC when idle

2013-06-19 Thread Grygorii Strashko
On 06/07/2013 11:51 PM, Kevin Hilman wrote: Grygorii Strashko writes: From: Kevin Hilman Currently, runtime PM is used to keep the device enabled only during active transfers and for a configurable runtime PM autosuspend timout after an xfer. In addition to idling the device, driver's ->run

Re: [PATCH 2/5] i2c: omap: add runtime check in isr to be sure that i2c is enabled

2013-06-19 Thread Grygorii Strashko
Hi Felipe, On 06/07/2013 10:02 PM, Felipe Balbi wrote: Hi, On Fri, Jun 07, 2013 at 09:46:05PM +0300, Grygorii Strashko wrote: Add runtime check at the beginning of omap_i2c_isr/omap_i2c_isr_thread to be sure that i2c is enabled, before performing IRQ handling and accessing I2C IP registers:

Re: [PATCH 5/5] i2c: omap: remove omap_i2c_isr() hw irq handler

2013-06-19 Thread Grygorii Strashko
Hi Felipe, On 06/07/2013 10:07 PM, Felipe Balbi wrote: Hi, On Fri, Jun 07, 2013 at 09:46:08PM +0300, Grygorii Strashko wrote: The omap_i2c_isr() does the irq check and schedules threaded handler if any of enabled IRQs is active, but currently the I2C IRQs are enabled just once, when I2C IP is

Re: [PATCH 3/5] i2c: omap: handle all irqs befor unblocking omap_i2c_xfer_msg()

2013-06-19 Thread Grygorii Strashko
Hi Felipe, On 06/07/2013 10:05 PM, Felipe Balbi wrote: Hi, On Fri, Jun 07, 2013 at 09:46:06PM +0300, Grygorii Strashko wrote: ARDY|NACK and ARDY|AL are set together in OMAP_I2C_STAT_REG, which will be Have you seen that happen ever ? AL is Arbitration Lost, we never put OMAP in a multi-master

[RFC 2/2] i2c: gpio: drop class based instantiation of slaves

2013-06-19 Thread Grygorii Strashko
Class based instantiation mechanism can cause huge delays when booting. For example: when CONFIG_SENSORS_LM75 option is enabled for or omap5-uevm board, where i2c-gpio is used for HDMI edid reading - it introduces up to 5 sec boot delay. It's not recommended to use this mechanism with embedded I2C,

[RFC 1/2] i2c: omap: drop class based instantiation of slaves

2013-06-19 Thread Grygorii Strashko
Class based instantiation mechanism can cause huge delays when booting. For example: when CONFIG_SENSORS_LM75 option is enabled for omap4-sdp board - it introduces 5-6 ms boot delay. It's not recommended to use this mechanism with embedded I2C, so disable it by leaving I2C adapter "class" field und

Re: [RFC] i2c: add deprecation warning for class based instantiation

2013-06-19 Thread Grygorii Strashko
On 06/07/2013 12:09 PM, Wolfram Sang wrote: Class based instantiation can cause huge delays when booting. This mechanism was used when it was not possible to describe slaves on I2C busses. We now have other mechanisms, so most embedded I2C will not need classes and it was explicitly not recommend

Re: [RFC] i2c: add deprecation warning for class based instantiation

2013-06-19 Thread Grygorii Strashko
Hi Wolfram, On 06/19/2013 01:15 PM, Wolfram Sang wrote: On Fri, Jun 07, 2013 at 11:09:26AM +0200, Wolfram Sang wrote: Class based instantiation can cause huge delays when booting. This mechanism was used when it was not possible to describe slaves on I2C busses. We now have other mechanisms, so

Re: [PATCH REBASE] i2c-designware: make SDA hold time configurable

2013-06-19 Thread Wolfram Sang
Hi Christian, > > So, I looked around and found: > > http://www.maximintegrated.com/app-notes/index.mvp/id/3268 > > > > which after thinking further about it gives me the following > > conclusions: > > > > - sda-hold-time is a property/requirement of a device not following > > the I2C spec. It

Re: [PATCH REBASE] i2c-designware: make SDA hold time configurable

2013-06-19 Thread Christian Ruppert
On Wed, Jun 19, 2013 at 11:45:40AM +0200, Wolfram Sang wrote: > Hi, > > On Wed, Jun 12, 2013 at 04:47:45PM +0200, Christian Ruppert wrote: > > On Mon, Jun 10, 2013 at 05:29:55PM +0200, Wolfram Sang wrote: > > > On Tue, May 14, 2013 at 03:04:02PM +0200, Christian Ruppert wrote: > > > > This patch m

[PATCH v10] i2c: exynos5: add High Speed I2C controller driver

2013-06-19 Thread Naveen Krishna Chatradhi
Adds support for High Speed I2C driver found in Exynos5 and later SoCs from Samsung. Driver only supports Device Tree method. Changes since v1: 1. Added FIFO functionality 2. Added High speed mode functionality 3. Remove SMBUS_QUICK 4. Remove the debugfs functionality 5. Use devm_* functions wher

Re: [PATCH v2 1/2] i2c-mv64xxx: Fix timing issue on Armada XP (errata FE-8471889)

2013-06-19 Thread Wolfram Sang
On Tue, Jun 18, 2013 at 05:40:23PM +0200, Gregory CLEMENT wrote: > From: Zbigniew Bodek > > All the Armada XP (mv78230, mv78260 and mv78460) have a silicon issue > in the I2C controller which violate the i2c repeated start > timing. The I2C standard requires a minimum of 4.7us for the repeated >

Re: [PATCH v2 2/2] i2c-mv64xxx: Abort the mv64xxx_of_config if clock-frequency is not provided

2013-06-19 Thread Wolfram Sang
On Tue, Jun 18, 2013 at 05:40:24PM +0200, Gregory CLEMENT wrote: > From: Zbigniew Bodek > > This commit adds checking whether clock-frequency property acquisition > has succeeded. Do not waste time to find baud factors if there is no > information about the desired bus frequency in dts. > > [gre

Re: [RFC] i2c: add deprecation warning for class based instantiation

2013-06-19 Thread Wolfram Sang
On Fri, Jun 07, 2013 at 11:09:26AM +0200, Wolfram Sang wrote: > Class based instantiation can cause huge delays when booting. This > mechanism was used when it was not possible to describe slaves on I2C > busses. We now have other mechanisms, so most embedded I2C will not need > classes and it was

Re: i2c: introduce i2c helper i2c_find_client_by_name()

2013-06-19 Thread Wolfram Sang
> Even you prefer to extend v4l2, you still need this helper. > The idea is just to move the unregister/register from a specific ISP driver > to v4l2. > > I think you misunderstood my pionts somehow. Let me clarfiy a little bit: > > Current solution: > 1. Platform codes(on top of DT/ACPI5/SFI) d

Re: [PATCH v2 1/2] mfd: tps65910: Fix crash in i2c_driver .probe

2013-06-19 Thread Samuel Ortiz
Hi Wolfram, On Wed, Jun 19, 2013 at 12:00:20PM +0200, Wolfram Sang wrote: > > > Applied with Stephen's Reviewed-by, thanks. > > According to Wolfgang, this is not needed as he will revert the i2c > > commits that are causing those crashes. > > I would not take it for now. > > "Wolfram", please ;)

Re: [PATCH v5] i2c: omap: correct usage of the interrupt enable register

2013-06-19 Thread Wolfram Sang
On Mon, Jun 03, 2013 at 10:37:20AM +0300, Oleksandr Dmytryshyn wrote: > We've been lucky not to have any interrupts fire during the suspend > path, otherwise we would have unpredictable behaviour in the kernel. > > Based on the logic of the kernel code interrupts from i2c should be > prohibited du

Re: [PATCH v2 1/2] mfd: tps65910: Fix crash in i2c_driver .probe

2013-06-19 Thread Wolfram Sang
On Wed, Jun 19, 2013 at 10:27:40AM +0200, Samuel Ortiz wrote: > Hi Lee, > > On Wed, Jun 19, 2013 at 09:18:59AM +0100, Lee Jones wrote: > > On Tue, 18 Jun 2013, Tuomas Tynkkynen wrote: > > > > > Commit "i2c: core: make it possible to match a pure device tree driver" > > > changed semantics of the

Re: [PATCH] i2c-piix4 - Add support for secondary SMBus on AMD SB800 and AMD FCH chipsets

2013-06-19 Thread Wolfram Sang
Hi Rudolf, On Mon, Jun 17, 2013 at 11:37:08PM +0200, Rudolf Marek wrote: > Hi all, > > I added just a few lines to the documentation file, the code part of > the patch in unchanged. > > Signed-off-by: Rudolf Marek Thanks for adding the docs, but please resend in canonical patch format. See Doc

Re: [PATCH v2 1/2] mfd: tps65910: Fix crash in i2c_driver .probe

2013-06-19 Thread Lee Jones
On Wed, 19 Jun 2013, Samuel Ortiz wrote: > Hi Lee, > > On Wed, Jun 19, 2013 at 09:18:59AM +0100, Lee Jones wrote: > > On Tue, 18 Jun 2013, Tuomas Tynkkynen wrote: > > > > > Commit "i2c: core: make it possible to match a pure device tree driver" > > > changed semantics of the i2c probing for devi

Re: [PATCH REBASE] i2c-designware: make SDA hold time configurable

2013-06-19 Thread Wolfram Sang
Hi, On Wed, Jun 12, 2013 at 04:47:45PM +0200, Christian Ruppert wrote: > On Mon, Jun 10, 2013 at 05:29:55PM +0200, Wolfram Sang wrote: > > On Tue, May 14, 2013 at 03:04:02PM +0200, Christian Ruppert wrote: > > > This patch makes the SDA hold time configurable through device tree. > > > > > > [reb

Re: [PATCH v2 2/2] i2c: imx: Add Vybrid VF610 I2C controller support

2013-06-19 Thread Shawn Guo
On Tue, Jun 18, 2013 at 04:48:47PM +0800, Jingchang Lu wrote: > Add Freescale Vybrid VF610 I2C controller support to > imx I2C driver framework. > Some operation is different from imx I2C controller. > The register offset, the i2c clock divider value table, > the module enabling(I2CR_IEN) which

Re: [PATCH v2 1/2] mfd: tps65910: Fix crash in i2c_driver .probe

2013-06-19 Thread Samuel Ortiz
Hi Lee, On Wed, Jun 19, 2013 at 09:18:59AM +0100, Lee Jones wrote: > On Tue, 18 Jun 2013, Tuomas Tynkkynen wrote: > > > Commit "i2c: core: make it possible to match a pure device tree driver" > > changed semantics of the i2c probing for device tree devices. > > Device tree probed devices now get

Re: [PATCH v2 1/2] mfd: tps65910: Fix crash in i2c_driver .probe

2013-06-19 Thread Lee Jones
On Tue, 18 Jun 2013, Tuomas Tynkkynen wrote: > Commit "i2c: core: make it possible to match a pure device tree driver" > changed semantics of the i2c probing for device tree devices. > Device tree probed devices now get a NULL i2c_device_id pointer. > This caused kernel panics due to NULL derefere