Re: [PATCH 1/2] i2c-designware: make *CNT values configurable

2013-08-23 Thread Shinya Kuribayashi
On 8/21/13 11:39 PM, Christian Ruppert wrote: On Fri, Aug 16, 2013 at 11:15:12AM +0900, Shinya Kuribayashi wrote: On 8/5/13 6:31 PM, Christian Ruppert wrote: On Wed, Jul 24, 2013 at 11:31:44PM +0900, Shinya Kuribayashi wrote: As said before, all t_SCL things should go away. Please forget abou

Re: [PATCH] misc: (at24) move header to linux/platform_data/

2013-08-23 Thread Vivien Didelot
Wolfram wrote: > > IMHO it makes sense. Why wouldn't we want all platform_data in > > include/linux/platform_data/? > > For the same reason we don't want all driver source files in one > directory? It's a mess. Well, that's different. Not all drivers expose platform data, but many subsystems hav

Re: [PATCH] misc: (at24) move header to linux/platform_data/

2013-08-23 Thread Wolfram Sang
> > This message explains what the patch does but not why the change is > > wanted. I'd be surprised if we really want *all* platform_data in one > > single directory? > > IMHO it makes sense. Why wouldn't we want all platform_data in > include/linux/platform_data/? For the same reason we don't

Re: [PATCH] misc: (at24) move header to linux/platform_data/

2013-08-23 Thread Vivien Didelot
Hi, Alexander wrote: > Can this file be additionally renamed to misc-at24.h to reflect > belongs to a particular subsystem? I'm not sure about that. Having the subsystem name at the beginning of the file doesn't seem to be a convention for all subsystems. For instance, this is true for gpio, spi

Re: [PATCH] misc: (at24) move header to linux/platform_data/

2013-08-23 Thread Alexander Shiyan
> Wolfram wrote: > > > On Fri, Aug 23, 2013 at 02:38:20PM -0400, Vivien Didelot wrote: > > > This patch moves the at24.h header from include/linux/i2c to > > > include/linux/platform_data and updates existing support > > > accordingly. > > > > This message explains what the patch does but not why

Re: [PATCH] misc: (at24) move header to linux/platform_data/

2013-08-23 Thread Vivien Didelot
Wolfram wrote: > On Fri, Aug 23, 2013 at 02:38:20PM -0400, Vivien Didelot wrote: > > This patch moves the at24.h header from include/linux/i2c to > > include/linux/platform_data and updates existing support > > accordingly. > > This message explains what the patch does but not why the change is >

Re: [PATCH] misc: (at24) move header to linux/platform_data/

2013-08-23 Thread Wolfram Sang
On Fri, Aug 23, 2013 at 02:38:20PM -0400, Vivien Didelot wrote: > This patch moves the at24.h header from include/linux/i2c to > include/linux/platform_data and updates existing support accordingly. This message explains what the patch does but not why the change is wanted. I'd be surprised if we

[PATCH] misc: (at24) move header to linux/platform_data/

2013-08-23 Thread Vivien Didelot
This patch moves the at24.h header from include/linux/i2c to include/linux/platform_data and updates existing support accordingly. It also fixes the following checkpatch warning: WARNING: please, no space before tabs #436: FILE: include/linux/platform_data/at24.h:31: + * ^Iu8 *mac_add

Re: [PATCH v7] ARM: dts: mvebu: Introduce a new compatible string for mv64xxx-i2c

2013-08-23 Thread Mark Rutland
On Fri, Aug 23, 2013 at 08:32:54AM +0100, Gregory CLEMENT wrote: > The mv64xxx-i2c embedded in the Armada XP have a new feature to > offload i2c transaction. This new version of the IP come also with > some errata. This lead to the introduction to a another compatible > string. > > This commit upd

[PATCH] i2c: mpc: cleanup clock API use

2013-08-23 Thread Anatolij Gustschin
From: Gerhard Sittig make the MPC I2C driver get, prepare and enable the gated clock item for register access during probe; disable and unprepare the clock upon remove(), put is done by the devm approach; hold a reference to the clock over the period of use clock lookup is non-fatal in this impl

Re: [PATCH] i2c: ismt: add error return code in probe()

2013-08-23 Thread Neil Horman
On Fri, Aug 23, 2013 at 11:30:14AM +0200, Wolfram Sang wrote: > Return error code in the error case, and not success. > > Signed-off-by: Wolfram Sang Acked-by: Neil Horman -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majord...@vger.kernel.or

Re: [PATCH v2] i2c: imx: use exact SoC revision to document binding

2013-08-23 Thread Wolfram Sang
On Wed, Aug 21, 2013 at 10:11:59AM +0800, Jingchang Lu wrote: > use exact SoC revision instead of wildcard describing > the compatible property requirement in the binding > document. This will make the binding more clearer. > > Signed-off-by: Jingchang Lu Applied to for-next, thanks! signatur

[PATCH] i2c: ismt: add error return code in probe()

2013-08-23 Thread Wolfram Sang
Return error code in the error case, and not success. Signed-off-by: Wolfram Sang --- Error code itself is probably not perfect, but consistent :/ Improving the return values might be considered for a later patch. Based on 3.11-rc6. drivers/i2c/busses/i2c-ismt.c |1 + 1 file changed, 1 ins

Re: [PATCH] i2c-pnx: fix error return code in i2c_pnx_probe()

2013-08-23 Thread Wolfram Sang
On Fri, Aug 23, 2013 at 10:55:51AM +0800, Wei Yongjun wrote: > From: Wei Yongjun > > Fix to return a negative error code in the irq get error handling > case instead of 0, as done elsewhere in this function. > > Signed-off-by: Wei Yongjun Applied to for-current, thanks! signature.asc Descri

Re: [PATCH V3] i2c: move of helpers into the core

2013-08-23 Thread Wolfram Sang
On Thu, Aug 22, 2013 at 06:00:14PM +0200, Wolfram Sang wrote: > I2C of helpers used to live in of_i2c.c but experience (from SPI) shows > that it is much cleaner to have this in the core. This also removes a > circular dependency between the helpers and the core, and so we can > finally register ch

Re: [PATCH v2] i2c: move ACPI helpers into the core

2013-08-23 Thread Wolfram Sang
On Wed, Aug 21, 2013 at 05:28:23PM +0300, Mika Westerberg wrote: > This follows what has already been done for the DeviceTree helpers. Move > the ACPI helpers from drivers/acpi/acpi_i2c.c to the I2C core and update > documentation accordingly. > > This also solves a problem reported by Jerry Snits

Re: [PATCH v7] ARM: dts: mvebu: Introduce a new compatible string for mv64xxx-i2c

2013-08-23 Thread Wolfram Sang
On Fri, Aug 23, 2013 at 09:32:54AM +0200, Gregory CLEMENT wrote: > The mv64xxx-i2c embedded in the Armada XP have a new feature to > offload i2c transaction. This new version of the IP come also with > some errata. This lead to the introduction to a another compatible > string. > > This commit upd

[PATCH v7] ARM: dts: mvebu: Introduce a new compatible string for mv64xxx-i2c

2013-08-23 Thread Gregory CLEMENT
The mv64xxx-i2c embedded in the Armada XP have a new feature to offload i2c transaction. This new version of the IP come also with some errata. This lead to the introduction to a another compatible string. This commit updates the Device Tree binding documentation accordingly. Signed-off-by: Grego

Re: [PATCH v6 3/4] ARM: dts: mvebu: Introduce a new compatible string for mv64xxx-i2c

2013-08-23 Thread Gregory CLEMENT
On 22/08/2013 18:22, Wolfram Sang wrote: > >> --- a/Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt >> +++ b/Documentation/devicetree/bindings/i2c/i2c-mv64xxx.txt >> @@ -5,6 +5,8 @@ Required properties : >> >> - reg : Offset and length of the register set for the device >>