Re: [PATCH v2 1/9] i2c: prepare runtime PM support for I2C client devices

2013-09-13 Thread Kevin Hilman
Mika Westerberg writes: > On Fri, Sep 13, 2013 at 05:50:22PM +0300, Mika Westerberg wrote: >> On Fri, Sep 13, 2013 at 07:30:55AM -0700, Kevin Hilman wrote: >> > Mika Westerberg writes: >> > >> > > On Thu, Sep 12, 2013 at 02:34:21PM -0700, Kevin Hilman wrote: >> > >> > diff --git a/drivers/i2c/i

Re: [PATCH v2 1/9] i2c: prepare runtime PM support for I2C client devices

2013-09-13 Thread Mika Westerberg
On Fri, Sep 13, 2013 at 05:50:22PM +0300, Mika Westerberg wrote: > On Fri, Sep 13, 2013 at 07:30:55AM -0700, Kevin Hilman wrote: > > Mika Westerberg writes: > > > > > On Thu, Sep 12, 2013 at 02:34:21PM -0700, Kevin Hilman wrote: > > >> > diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.

Re: [PATCH v2 1/9] i2c: prepare runtime PM support for I2C client devices

2013-09-13 Thread Mika Westerberg
On Fri, Sep 13, 2013 at 05:14:56PM +0200, Sylwester Nawrocki wrote: > On 09/13/2013 08:54 AM, Mika Westerberg wrote: > > On Thu, Sep 12, 2013 at 02:34:21PM -0700, Kevin Hilman wrote: > >>> > > diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c > >>> > > index f32ca29..44374b4 100644 > >>>

Re: [PATCH v2 1/9] i2c: prepare runtime PM support for I2C client devices

2013-09-13 Thread Sylwester Nawrocki
On 09/13/2013 08:54 AM, Mika Westerberg wrote: > On Thu, Sep 12, 2013 at 02:34:21PM -0700, Kevin Hilman wrote: >>> > > diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c >>> > > index f32ca29..44374b4 100644 >>> > > --- a/drivers/i2c/i2c-core.c >>> > > +++ b/drivers/i2c/i2c-core.c >>> > >

Re: [PATCH v2 1/9] i2c: prepare runtime PM support for I2C client devices

2013-09-13 Thread Mika Westerberg
On Fri, Sep 13, 2013 at 07:30:55AM -0700, Kevin Hilman wrote: > Mika Westerberg writes: > > > On Thu, Sep 12, 2013 at 02:34:21PM -0700, Kevin Hilman wrote: > >> > diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c > >> > index f32ca29..44374b4 100644 > >> > --- a/drivers/i2c/i2c-core.c

Re: [PATCH v2 1/9] i2c: prepare runtime PM support for I2C client devices

2013-09-13 Thread Kevin Hilman
Mika Westerberg writes: > On Thu, Sep 12, 2013 at 02:34:21PM -0700, Kevin Hilman wrote: >> > diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c >> > index f32ca29..44374b4 100644 >> > --- a/drivers/i2c/i2c-core.c >> > +++ b/drivers/i2c/i2c-core.c >> > @@ -248,11 +248,30 @@ static int i2

Re: [PATCH v2 1/9] i2c: prepare runtime PM support for I2C client devices

2013-09-13 Thread Mark Brown
On Fri, Sep 13, 2013 at 02:50:35PM +0300, Mika Westerberg wrote: > On Fri, Sep 13, 2013 at 11:31:52AM +0100, Mark Brown wrote: > > Right, but this probably needs to be highlighted more since it's a very > > surprising thing for I2C and is causing confusion. > By highlighted more, do you mean some

Re: [PATCH v2 1/9] i2c: prepare runtime PM support for I2C client devices

2013-09-13 Thread Mika Westerberg
On Fri, Sep 13, 2013 at 11:31:52AM +0100, Mark Brown wrote: > On Fri, Sep 13, 2013 at 01:16:11PM +0300, Mika Westerberg wrote: > > On Fri, Sep 13, 2013 at 10:59:50AM +0100, Mark Brown wrote: > > > > Accessing the bus isn't an issue for I2C outside of ACPI, the power > > > management of the device

Re: [PATCH v2 1/9] i2c: prepare runtime PM support for I2C client devices

2013-09-13 Thread Mark Brown
On Fri, Sep 13, 2013 at 01:16:11PM +0300, Mika Westerberg wrote: > On Fri, Sep 13, 2013 at 10:59:50AM +0100, Mark Brown wrote: > > Accessing the bus isn't an issue for I2C outside of ACPI, the power > > management of the device is totally disassociated from the bus and the > > controller is respon

Re: [PATCH v2 1/9] i2c: prepare runtime PM support for I2C client devices

2013-09-13 Thread Mika Westerberg
On Fri, Sep 13, 2013 at 10:59:50AM +0100, Mark Brown wrote: > On Fri, Sep 13, 2013 at 09:54:34AM +0300, Mika Westerberg wrote: > > On Thu, Sep 12, 2013 at 02:34:21PM -0700, Kevin Hilman wrote: > > > > For hardware that is disabled/powered-off on startup, there will now be > > > a mismatch between

Re: [PATCH v2 1/9] i2c: prepare runtime PM support for I2C client devices

2013-09-13 Thread Mark Brown
On Fri, Sep 13, 2013 at 09:14:20AM +0800, Aaron Lu wrote: > On 09/13/2013 06:06 AM, Sylwester Nawrocki wrote: > > So there is currently no way to avoid this behaviour, i.e. to have the > > adapter > > not activated before any of its client devices is probed, but only later on, > > after explicit

Re: [PATCH v2 1/9] i2c: prepare runtime PM support for I2C client devices

2013-09-13 Thread Mark Brown
On Fri, Sep 13, 2013 at 09:54:34AM +0300, Mika Westerberg wrote: > On Thu, Sep 12, 2013 at 02:34:21PM -0700, Kevin Hilman wrote: > > For hardware that is disabled/powered-off on startup, there will now be > > a mismatch between the hardware state an the RPM core state. > The call to pm_runtime_ge

Re: [PATCH 1/2] i2c: qup: Add device tree bindings information

2013-09-13 Thread Ivan T. Ivanov
Hi Mark, On Thu, 2013-09-12 at 17:28 +0100, Mark Rutland wrote: > On Thu, Aug 29, 2013 at 02:27:52PM +0100, Ivan T. Ivanov wrote: > > From: "Ivan T. Ivanov" > > > > The Qualcomm Universal Peripherial (QUP) wraps I2C mini-core and > > provide input and output FIFO's for it. I2C controller can o