Re: [PATCH 2/2] i2c-mux-gpio: eliminate i2c channel order assumptions

2013-10-11 Thread Ionut Nicu
Hi, On 10.10.2013 12:34, Alexander Sverdlin wrote: Hi! On 10/10/2013 10:39 AM, Ionut Nicu wrote: The i2c-mux driver uses the chan_id parameter provided in i2c_add_mux_adapter as a parameter to the select and deselect callbacks while the i2c-mux-gpio driver uses the chan_id as an index in

[PATCH 1/2] i2c-mux-gpio: use gpio_set_value_cansleep()

2013-10-11 Thread Ionut Nicu
Some gpio chips may have get/set operations that can sleep. gpio_set_value() only works for chips which do not sleep, for the others we will get a kernel warning. Using gpio_set_value_cansleep() will work for both chips that do sleep and those who don't. Signed-off-by: Ionut Nicu

[PATCH 2/2] i2c-mux-gpio: use reg value for i2c_add_mux_adapter

2013-10-11 Thread Ionut Nicu
The i2c-mux driver requires that the chan_id parameter passed to the i2c_add_mux_adapter() function is equal to the reg value for that adapter: for_each_child_of_node(mux_dev-of_node, child) { ret = of_property_read_u32(child, reg, reg); if (ret) continue;

Re: [PATCH 1/2] i2c-mux-gpio: use gpio_set_value_cansleep()

2013-10-11 Thread Peter Korsgaard
IN == Ionut Nicu ioan.nicu@nsn.com writes: IN Some gpio chips may have get/set operations that IN can sleep. gpio_set_value() only works for chips IN which do not sleep, for the others we will get a IN kernel warning. Using gpio_set_value_cansleep() IN will work for both chips that do sleep

[PATCH] i2c: s3c2410: dont need CPU_FREQ transitions for exynos series

2013-10-11 Thread Naveen Krishna Chatradhi
The exynos5 i2c clock is based on a fixed 66 MHz peripheral clock, and therefore is completely independent of the cpu frequency. Thus, registering for a CPU freq notifier is very wasteful. This patch modifes the code such that, i2c bus registers to cpu_freq_transition only for non Exynos SoCs.

[PATCH 1/2] i2c-mux-gpio: use gpio_set_value_cansleep()

2013-10-11 Thread Ionut Nicu
Some gpio chips may have get/set operations that can sleep. gpio_set_value() only works for chips which do not sleep, for the others we will get a kernel warning. Using gpio_set_value_cansleep() will work for both chips that do sleep and those who don't. Signed-off-by: Ionut Nicu

Re: [PATCH] i2c: Fix modalias for ACPI enumerated I2C devices

2013-10-11 Thread Rafael J. Wysocki
On Friday, October 11, 2013 05:49:46 PM Mika Westerberg wrote: +Rafael On Thu, Oct 10, 2013 at 05:17:49PM +0300, Jarkko Nikula wrote: There is a minor fault about ACPI enumerated I2C devices with their modalias attribute. Now modalias is set by device instance not by hardware ID. For

Re: [PATCH] i2c: s3c2410: dont need CPU_FREQ transitions for exynos series

2013-10-11 Thread Tomasz Figa
Hi Naveen, On Friday 11 of October 2013 16:56:54 Naveen Krishna Chatradhi wrote: The exynos5 i2c clock is based on a fixed 66 MHz peripheral clock, and therefore is completely independent of the cpu frequency. Thus, registering for a CPU freq notifier is very wasteful. This patch modifes

Re: [PATCH] i2c: s3c2410: dont need CPU_FREQ transitions for exynos series

2013-10-11 Thread Tomasz Figa
[Fixing incorrent mail addresses and dropping the old DT ML.] On Saturday 12 of October 2013 04:22:04 Tomasz Figa wrote: Hi Naveen, On Friday 11 of October 2013 16:56:54 Naveen Krishna Chatradhi wrote: The exynos5 i2c clock is based on a fixed 66 MHz peripheral clock, and therefore is

Re: [PATCH] i2c: Fix modalias for ACPI enumerated I2C devices

2013-10-11 Thread Mika Westerberg
On Sat, Oct 12, 2013 at 12:16:02AM +0200, Rafael J. Wysocki wrote: I think that this is intentional. We don't want that the i2c modalias matches with the ACPI device (like with the i2c:INTABCD). Instead use ACPI IDs that are added to the driver to match with the ACPI device. Well, I'm not

Re: [PATCH] i2c: s3c2410: dont need CPU_FREQ transitions for exynos series

2013-10-11 Thread Tomasz Figa
On Saturday 12 of October 2013 04:28:51 Tomasz Figa wrote: [Fixing incorrent mail addresses and dropping the old DT ML.] On Saturday 12 of October 2013 04:22:04 Tomasz Figa wrote: Hi Naveen, On Friday 11 of October 2013 16:56:54 Naveen Krishna Chatradhi wrote: The exynos5 i2c clock