Re: [PATCH 1/1] i2c: exynos5: Remove incorrect clk_disable_unprepare

2013-11-07 Thread Naveen Krishna Ch
On 6 November 2013 15:09, Sachin Kamat wrote: > clk_disable_unprepare in remove causes an imbalance and hence gives > the below crash on module remove. While at it also remove some > duplicate code from probe. > > / $ rmmod i2c-exynos5 > [6.996374] [ cut here ] > [6

Re: [RESEND PATCH 2/4] i2c: i2c-bcm-kona: Add support for high-speed mode

2013-11-07 Thread Tim Kryger
On Thu, Nov 7, 2013 at 12:13 PM, Wolfram Sang wrote: > OK. Then please change the error message for unsupported bus speeds to > contain the supported ones. I don't think it is good practice to force > users to look into the sourcecode to find this information. That works for me. Thanks. -Tim -

Re: [RESEND PATCH 2/4] i2c: i2c-bcm-kona: Add support for high-speed mode

2013-11-07 Thread Wolfram Sang
> While the bus speed property is really a configuration parameter (and > not a true description of of the hardware) it seems improper to put > driver specific details into the binding document. OK. Then please change the error message for unsupported bus speeds to contain the supported ones. I d

Re: [RESEND PATCH 2/4] i2c: i2c-bcm-kona: Add support for high-speed mode

2013-11-07 Thread Tim Kryger
On Fri, Nov 1, 2013 at 6:08 AM, Wolfram Sang wrote: > On Wed, Oct 16, 2013 at 03:01:47PM -0700, Tim Kryger wrote: >> Add support for I2C high-speed mode (3.4 MHz). >> >> Signed-off-by: Tim Kryger >> Reviewed-by: Matt Porter >> Reviewed-by: Markus Mayer > > Mostly good as well: > >> +enum hs_bus

Re: [PATCHv2 1/3] ACPI: Expose struct acpi_device and acpi_bus_get_device() to non-ACPI builds

2013-11-07 Thread Rafael J. Wysocki
On Monday, November 04, 2013 11:15:59 PM Jarkko Nikula wrote: > On Mon, Nov 04, 2013 at 02:00:45AM +0100, Rafael J. Wysocki wrote: > > On Saturday, November 02, 2013 11:18:31 PM Rafael J. Wysocki wrote: > > > This turns out the cause build problems to happen on some architectures. > > > > > > I gu