Re: [PATCH 3/4] fix module autoloading for ACPI enumerated devices

2014-01-14 Thread Zhang Rui
On Mon, 2014-01-13 at 17:35 +, Mark Brown wrote: On Mon, Jan 13, 2014 at 09:48:31PM +0800, Zhang Rui wrote: ACPI enumerated devices has ACPI style _HID and _CID strings, all of these strings can be used for both driver loading and matching. But currently, in Platform, I2C and SPI bus,

Re: [PATCH v5 0/4] Fix i2c bus hang on A0 version of the Armada XP SoCs

2014-01-14 Thread Gregory CLEMENT
On 14/01/2014 03:14, Jason Cooper wrote: Gregory, On Wed, Jan 08, 2014 at 04:06:25PM +0100, Gregory CLEMENT wrote: Hi, Here come the 5th version of the series fixing the i2c bus hang on A0 version of the Armada XP SoCs. It occurred on the early release of the OpenBlocks AX3-4 boards.

[PATCH 0/4] module autoloading fixes

2014-01-14 Thread Zhang Rui
Hi, all, This patch set fixes a couple of module autoloading problem. Patch 1/4 fixes a bug in ACPI device 'modalias' and 'uevent' attributes, although the bug can rarely be reproduced (only if there is an output error of snprintf, or the ids are longer than 1024 bytes) Patch

[PATCH 3/4] fix module autoloading for ACPI enumerated devices

2014-01-14 Thread Zhang Rui
ACPI enumerated devices has ACPI style _HID and _CID strings, all of these strings can be used for both driver loading and matching. Currently, in Platform, I2C and SPI bus, the ACPI style driver matching is supported by invoking acpi_driver_match_device() in bus .match() callback. But, the

[PATCH 1/4] ACPI: fix create_modalias() return value handling

2014-01-14 Thread Zhang Rui
Currently, create_modalias() handles the output truncated case in an improper way (return -EINVAL). Plus, acpi_device_uevent() and acpi_device_modalias_show() do improper check for the create_modalias() return value as well. This patch fixes create_modalias() to return -EINVAL if there is an

[PATCH 4/4] OF: introduce OF style 'modalias' support for platform bus.

2014-01-14 Thread Zhang Rui
Fix a problem that, the platform bus supports the OF style modalias in .uevent() call, but not in its device 'modalias' sysfs attribute. cc: devicet...@vger.kernel.org Signed-off-by: Zhang Rui rui.zh...@intel.com --- drivers/base/platform.c |4 drivers/of/device.c |3 +++

[PATCH 2/4] ACPI: add module autoloading support for ACPI enumerated devices

2014-01-14 Thread Zhang Rui
An ACPI enumerated device may have its compatible id strings. To support the compatible ACPI ids (acpi_device-pnp.ids), we introduced acpi_driver_match_device() to match the driver-acpi_match_table and acpi_device-pnp.ids. For those drivers, MODULE_DEVICE_TABLE(acpi, xxx) is used to exports the

Re: [PATCH v2 1/2] i2c: qup: Add device tree bindings information

2014-01-14 Thread Ivan T. Ivanov
Thanks Bjorn, I have prepared second version, but never send it out :-). One thing suggested by Mark was missed in this version. On Mon, 2014-01-13 at 16:30 -0800, Bjorn Andersson wrote: From: Ivan T. Ivanov iiva...@mm-sol.com The Qualcomm Universal Peripherial (QUP) wraps I2C mini-core

Re: [PATCH v2 2/2] i2c: New bus driver for the QUP I2C controller

2014-01-14 Thread Ivan T. Ivanov
Hi Bjorn, Just two comments. On Mon, 2014-01-13 at 16:30 -0800, Bjorn Andersson wrote: From: Ivan T. Ivanov iiva...@mm-sol.com This bus driver supports the QUP i2c hardware controller in the Qualcomm MSM SOCs. The Qualcomm Universal Peripheral Engine (QUP) is a general purpose data

Re: [PATCH 3/4] fix module autoloading for ACPI enumerated devices

2014-01-14 Thread Mark Brown
On Tue, Jan 14, 2014 at 04:00:17PM +0800, Zhang Rui wrote: On Mon, 2014-01-13 at 17:35 +, Mark Brown wrote: On Mon, Jan 13, 2014 at 09:48:31PM +0800, Zhang Rui wrote: ACPI enumerated devices has ACPI style _HID and _CID strings, all of these strings can be used for both driver loading

Re: [PATCH] i2c: Re-instate body of i2c_parent_is_i2c_adapter()

2014-01-14 Thread Wolfram Sang
On Mon, Jan 13, 2014 at 02:29:04PM -0700, Stephen Warren wrote: From: Stephen Warren swar...@nvidia.com The body of i2c_parent_is_i2c_adapter() is currently guarded by CONFIG_I2C_MUX instead. This paragraph sounds strange to me. I'll update it a little. After that I'll go looking for a brown

Re: [PATCH 1/3] i2c: i2c-core: fix paranthesis coding style issue in, i2c-core.c

2014-01-14 Thread Wolfram Sang
On Mon, Oct 14, 2013 at 08:51:38PM +0530, RAGHAVENDRA GANIGA wrote: From 46aed97f5e5a434e8ec24c14e085a138958ba559 Mon Sep 17 00:00:00 2001 From: Raghavendra Ganiga ravi23gan...@gmail.com Date: Sun, 13 Oct 2013 19:13:46 +0530 Subject: [PATCH 1/3] i2c: i2c-core: fix paranthesis coding style

Re: [PATCH 2/3] i2c: i2c-core: fix coding style issues in i2c-core.c

2014-01-14 Thread Wolfram Sang
On Mon, Oct 14, 2013 at 08:53:07PM +0530, RAGHAVENDRA GANIGA wrote: From b21e6a52aa9c36e8c01173cff13bbfd2a380d0bd Mon Sep 17 00:00:00 2001 From: Raghavendra Ganiga ravi23gan...@gmail.com Date: Mon, 14 Oct 2013 00:29:08 +0530 Subject: [PATCH 2/3] i2c: i2c-core: fix coding style issues in

Re: [PATCH 3/3] i2c: i2c-core: fix coding style issues in i2c-core.c

2014-01-14 Thread Wolfram Sang
--- a/drivers/i2c/i2c-core.c +++ b/drivers/i2c/i2c-core.c @@ -1737,9 +1737,9 @@ int i2c_transfer(struct i2c_adapter *adap, struct i2c_msg *msgs, int num) for (ret = 0; ret num; ret++) { dev_dbg(adap-dev, master_xfer[%d] %c, addr=0x%02x, len=%d%s\n,

Re: [PATCH 1/1] drivers: i2c: silence a compile warning in i2c-s3c2410.c

2014-01-14 Thread Wolfram Sang
On Fri, Jan 10, 2014 at 12:03:45PM +0900, Pankaj Dubey wrote: If used 64 bit compiler GCC warns that: drivers/i2c/busses/i2c-s3c2410.c: In function ‘s3c24xx_get_device_quirks’: drivers/i2c/busses/i2c-s3c2410.c:168:10: warning: cast from pointer to integer of different size