Re: [PATCH 3/4] fix module autoloading for ACPI enumerated devices

2014-01-16 Thread Zhang Rui
On Wed, 2014-01-15 at 17:08 +0200, Mika Westerberg wrote: On Tue, Jan 14, 2014 at 04:46:37PM +0800, Zhang Rui wrote: diff --git a/drivers/base/platform.c b/drivers/base/platform.c index 3a94b79..2f4aea2 100644 --- a/drivers/base/platform.c +++ b/drivers/base/platform.c @@ -677,7 +677,13

Re: [PATCH repost] at91: dt: i2c: add a new compatibility string for the at91sam9261

2014-01-16 Thread Wolfram Sang
On Wed, Jan 15, 2014 at 02:17:13PM +0100, Jean-Jacques Hiblot wrote: Signed-off-by: Jean-Jacques Hiblot jjhib...@traphandler.com Applied to for-next, thanks! signature.asc Description: Digital signature

Re: [PATCH V3] i2c: pnx: Use devm_*() functions

2014-01-16 Thread Wolfram Sang
On Tue, Jan 14, 2014 at 09:19:30AM +0900, Jingoo Han wrote: Use devm_*() functions to make cleanup paths simpler, and remove redundant return value check of platform_get_resource() because the value is checked by devm_ioremap_resource(). Signed-off-by: Jingoo Han jg1@samsung.com Applied

Re: [PATCH v2] drivers: i2c: silence a compile warning in i2c-s3c2410.c

2014-01-16 Thread Wolfram Sang
On Wed, Jan 15, 2014 at 10:42:42AM +0900, y...@samsung.com wrote: Note that your email address is wrong here. I also fixed the description to i2c: s3c2410: fix quirk usage for 64-bit which is more apropriate. Other than that: Applied to for-next, thanks! signature.asc Description: Digital

Re: [lm-sensors] I2C support for AMD Hudson-1

2014-01-16 Thread Jean Delvare
Hi Christian, On Thu, 9 Jan 2014 17:24:22 +0100, Christian Herzog wrote: sorry to bother you again, but this might save you some work: I just compiled 3.13.0-rc7 on the apu board and i2c works out of the box. I'm pretty stumped as I'm pretty sure it didn't work OOTB on -rc3, but now it does..

Re: [PATCH 3/4] fix module autoloading for ACPI enumerated devices

2014-01-16 Thread Wolfram Sang
diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c index d74c0b3..c4c5588 100644 --- a/drivers/i2c/i2c-core.c +++ b/drivers/i2c/i2c-core.c @@ -104,6 +104,11 @@ static int i2c_device_match(struct device *dev, struct device_driver *drv) static int i2c_device_uevent(struct device

Re: [PATCH 3/4] fix module autoloading for ACPI enumerated devices

2014-01-16 Thread Mark Brown
On Tue, Jan 14, 2014 at 04:46:37PM +0800, Zhang Rui wrote: ACPI enumerated devices has ACPI style _HID and _CID strings, all of these strings can be used for both driver loading and matching. Currently, in Platform, I2C and SPI bus, the ACPI style driver matching is supported by invoking

Re: [PATCH 3/4] fix module autoloading for ACPI enumerated devices

2014-01-16 Thread Zhang Rui
On Thu, 2014-01-16 at 12:28 +, Mark Brown wrote: On Tue, Jan 14, 2014 at 04:46:37PM +0800, Zhang Rui wrote: ACPI enumerated devices has ACPI style _HID and _CID strings, all of these strings can be used for both driver loading and matching. Currently, in Platform, I2C and SPI bus,

Re: [PATCH 3/4] fix module autoloading for ACPI enumerated devices

2014-01-16 Thread Zhang Rui
On Thu, 2014-01-16 at 13:27 +0100, Wolfram Sang wrote: diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c index d74c0b3..c4c5588 100644 --- a/drivers/i2c/i2c-core.c +++ b/drivers/i2c/i2c-core.c @@ -104,6 +104,11 @@ static int i2c_device_match(struct device *dev, struct

Re: [PATCH v2 2/2] i2c: New bus driver for the QUP I2C controller

2014-01-16 Thread Ivan T. Ivanov
Hi, On Wed, 2014-01-15 at 08:46 -0800, Stephen Boyd wrote: On 01/13, Bjorn Andersson wrote: +/* + * QUP driver for Qualcomm MSM platforms + * + */ This comment seems redundant, we know what file we're looking at. + +struct qup_i2c_dev { + struct device *dev; +

Re: [PATCH] i2c: Re-instate body of i2c_parent_is_i2c_adapter()

2014-01-16 Thread Stephen Warren
On 01/14/2014 09:12 AM, Wolfram Sang wrote: On Mon, Jan 13, 2014 at 02:29:04PM -0700, Stephen Warren wrote: From: Stephen Warren swar...@nvidia.com The body of i2c_parent_is_i2c_adapter() is currently guarded by CONFIG_I2C_MUX instead. This paragraph sounds strange to me. I'll update it a

Re: [PATCH] i2c: Re-instate body of i2c_parent_is_i2c_adapter()

2014-01-16 Thread Wolfram Sang
I do see this in for-current, but it looks like that branch isn't part of linux-next. Should it be, or perhaps for-current should be merged into for-next? It is upstream already. signature.asc Description: Digital signature

Re: [PATCH 3/4] fix module autoloading for ACPI enumerated devices

2014-01-16 Thread Wolfram Sang
On Thu, Jan 16, 2014 at 12:28:19PM +, Mark Brown wrote: On Tue, Jan 14, 2014 at 04:46:37PM +0800, Zhang Rui wrote: ACPI enumerated devices has ACPI style _HID and _CID strings, all of these strings can be used for both driver loading and matching. Currently, in Platform, I2C and SPI

Re: [PATCH 2/2] i2c designware add support of I2C standard mode

2014-01-16 Thread Wolfram Sang
On Tue, Oct 08, 2013 at 05:00:55PM +0200, Romain Baeriswyl wrote: Some legacy devices support ony I2C standard mode at 100kHz. This patch allows to select the standard mode through the DTS with the use of the existing clock-frequency parameter. When clock-frequency parameter is not set,

Re: [PATCH 1/2] i2c designware make SCL and SDA falling time configurable

2014-01-16 Thread Wolfram Sang
You can also use the gcc-ism, which is a bit more concise: sda_falling_time = dev-sda_falling_time ?: 300; +1 ditto signature.asc Description: Digital signature

Re: [PATCH 3/4] fix module autoloading for ACPI enumerated devices

2014-01-16 Thread Mark Brown
On Thu, Jan 16, 2014 at 09:05:09PM +0800, Zhang Rui wrote: On Thu, 2014-01-16 at 13:27 +0100, Wolfram Sang wrote: I wonder why we don't have/need that with CONFIG_OF? Because probably nobody is using modules with i2c devices there? This seems a gap to me but I'm not 100% sure. I saw Grant

Re: [PATCH 2/2] i2c-designware-pci: Index Haswell ULT bus names from 0

2014-01-16 Thread Wolfram Sang
Our devices and our platforms have some other requirements which turned me away from using i2c_register_board_info. Okay, so I'll drop these patches. signature.asc Description: Digital signature

Re: [PATCH 4/4] OF: introduce OF style 'modalias' support for platform bus.

2014-01-16 Thread Rob Herring
On Thu, Jan 16, 2014 at 1:04 AM, Zhang, Rui rui.zh...@intel.com wrote: -Original Message- From: Rob Herring [mailto:robherri...@gmail.com] Sent: Wednesday, January 15, 2014 9:45 PM To: Zhang, Rui Cc: linux-ker...@vger.kernel.org; linux-a...@vger.kernel.org; linux-

Re: [PATCH v2 1/2] i2c: qup: Add device tree bindings information

2014-01-16 Thread Bjorn Andersson
On Tue 14 Jan 00:57 PST 2014, Ivan T. Ivanov wrote: Thanks Bjorn, I have prepared second version, but never send it out :-). One thing suggested by Mark was missed in this version. Yeah, Mattew told me you we're assigned to other things and asked me to send out an update as I had gotten

Re: [PATCH 3/4] fix module autoloading for ACPI enumerated devices

2014-01-16 Thread Rafael J. Wysocki
On Thursday, January 16, 2014 04:04:35 PM Zhang Rui wrote: On Wed, 2014-01-15 at 17:08 +0200, Mika Westerberg wrote: On Tue, Jan 14, 2014 at 04:46:37PM +0800, Zhang Rui wrote: diff --git a/drivers/base/platform.c b/drivers/base/platform.c index 3a94b79..2f4aea2 100644 ---

Re: [PATCH 3/4] fix module autoloading for ACPI enumerated devices

2014-01-16 Thread Zhang Rui
On Fri, 2014-01-17 at 02:28 +0100, Rafael J. Wysocki wrote: On Thursday, January 16, 2014 04:04:35 PM Zhang Rui wrote: On Wed, 2014-01-15 at 17:08 +0200, Mika Westerberg wrote: On Tue, Jan 14, 2014 at 04:46:37PM +0800, Zhang Rui wrote: diff --git a/drivers/base/platform.c

Re: [lm-sensors] I2C support for AMD Hudson-1

2014-01-16 Thread Christian Herzog
Dear Jean, thanks for your reply. The git history tells that there was no change to the i2c-piix4 driver since kernel version 3.12-rc1. This is when support for secondary SMBus on AMD SB800 and AMD FCH chipsets was added. I think FCH and Hudson-2 are the same thing, not sure how Hudson-1

Re: [PATCH 3/4] fix module autoloading for ACPI enumerated devices

2014-01-16 Thread Jarkko Nikula
On 01/16/2014 09:46 PM, Mark Brown wrote: On Thu, Jan 16, 2014 at 09:05:09PM +0800, Zhang Rui wrote: On Thu, 2014-01-16 at 13:27 +0100, Wolfram Sang wrote: This seems a gap to me but I'm not 100% sure. I saw Grant Likely introduced the OF style MODALIAS to platform bus, and OF style

Re: [PATCH v2 1/2] i2c: qup: Add device tree bindings information

2014-01-16 Thread Ivan T. Ivanov
Hi, On Thu, 2014-01-16 at 15:20 -0800, Bjorn Andersson wrote: On Tue 14 Jan 00:57 PST 2014, Ivan T. Ivanov wrote: Thanks Bjorn, I have prepared second version, but never send it out :-). One thing suggested by Mark was missed in this version. Yeah, Mattew told me you we're