On Tue, Jan 21, 2014 at 3:55 AM, Alexandre Courbot gnu...@gmail.com wrote:
On Sat, Jan 18, 2014 at 7:43 AM, Linus Walleij linus.wall...@linaro.org
wrote:
1. Today this OPEN_DRAIN flag is not even passed down to
the driver so how could it say anything about it :-( it's a pure gpiolib
Commit 0998d0631001 (device-core: Ensure drvdata = NULL when no driver
is bound) modified the driver core to always clear .driver and .drvdata
on remove or probe error. No need for the I2C core to do it.
Reported-by: Linus Torvalds torva...@linux-foundation.org
Reported-by: Mika Westerberg
Hi Shane,
Sorry for the late review. Here we go...
On Wed, 15 Jan 2014 23:34:28 -0800, Shane Huang wrote:
This patch is to support AMD new SMBus with different base address location.
This description is too vague. Which new SMBus? The patch doesn't add
any new PCI device ID. What devices (and
None of these files are actually using any __init type directives
and hence don't need to include linux/init.h. Most are just a
left over from __devinit and __cpuinit removal, or simply due to
code getting copied from one driver to the next.
Cc: Wolfram Sang w...@the-dreams.de
Cc: Jean Delvare
This file is controlled by a tristate Kconfig option, and hence
needs to include module.h so that it can get module_init() once
we relocate it from init.h into module.h in the future.
Note that module_exit() appears to be missing from the driver, so
it is questionable whether it would actually
Hi Jean,
Sorry for the late review. Here we go...
Thanks for your comments, I agree with all of them and will submit V2 later.
Regards,
Shane
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at