Re: More GPIO madness on iMX6 - and the crappy ARM port of Linux

2014-01-21 Thread Linus Walleij
On Tue, Jan 21, 2014 at 3:55 AM, Alexandre Courbot gnu...@gmail.com wrote: On Sat, Jan 18, 2014 at 7:43 AM, Linus Walleij linus.wall...@linaro.org wrote: 1. Today this OPEN_DRAIN flag is not even passed down to the driver so how could it say anything about it :-( it's a pure gpiolib

[PATCH] i2c: rely on driver core when sanitizing devices

2014-01-21 Thread Wolfram Sang
Commit 0998d0631001 (device-core: Ensure drvdata = NULL when no driver is bound) modified the driver core to always clear .driver and .drvdata on remove or probe error. No need for the I2C core to do it. Reported-by: Linus Torvalds torva...@linux-foundation.org Reported-by: Mika Westerberg

Re: [PATCH RESEND] i2c-piix4: AMD new SMBus base address location changed

2014-01-21 Thread Jean Delvare
Hi Shane, Sorry for the late review. Here we go... On Wed, 15 Jan 2014 23:34:28 -0800, Shane Huang wrote: This patch is to support AMD new SMBus with different base address location. This description is too vague. Which new SMBus? The patch doesn't add any new PCI device ID. What devices (and

[PATCH 51/73] drivers/i2c: delete non-required instances of include linux/init.h

2014-01-21 Thread Paul Gortmaker
None of these files are actually using any __init type directives and hence don't need to include linux/init.h. Most are just a left over from __devinit and __cpuinit removal, or simply due to code getting copied from one driver to the next. Cc: Wolfram Sang w...@the-dreams.de Cc: Jean Delvare

[PATCH 30/73] drivers/i2c: busses/i2c-acorn.c is tristate and should use module.h

2014-01-21 Thread Paul Gortmaker
This file is controlled by a tristate Kconfig option, and hence needs to include module.h so that it can get module_init() once we relocate it from init.h into module.h in the future. Note that module_exit() appears to be missing from the driver, so it is questionable whether it would actually

RE: [PATCH RESEND] i2c-piix4: AMD new SMBus base address location changed

2014-01-21 Thread Huang, Shane
Hi Jean, Sorry for the late review. Here we go... Thanks for your comments, I agree with all of them and will submit V2 later. Regards, Shane -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org More majordomo info at