Re: [PATCH 1/2] i2c-piix4: Add support for AMD ML and CZ SMBus changes

2014-01-23 Thread Jean Delvare
Hi Shane, On Thu, 23 Jan 2014 22:26:49 +, Huang, Shane wrote: > > As the mask used for smb_en_status doesn't depend on the value of > > "aux", this implies that on the Hudson-2, a single bit controls if both > > SMBus controllers are enabled. It's not possible to enable one and > > disable the

Re: [PATCH v3 2/2] i2c: New bus driver for the QUP I2C controller

2014-01-23 Thread Philip Elcan
On 01/17/2014 06:03 PM, Bjorn Andersson wrote: > From: "Ivan T. Ivanov" > > This bus driver supports the QUP i2c hardware controller in the Qualcomm > MSM SOCs. The Qualcomm Universal Peripheral Engine (QUP) is a general > purpose data path engine with input/output FIFOs and an embedded i2c > mi

RE: [PATCH 1/2] i2c-piix4: Add support for AMD ML and CZ SMBus changes

2014-01-23 Thread Huang, Shane
Hi Jean, > As the mask used for smb_en_status doesn't depend on the value of > "aux", this implies that on the Hudson-2, a single bit controls if both > SMBus controllers are enabled. It's not possible to enable one and > disable the other. Is it correct, or is it an overlook? Good question. This

[PATCH v2 2/2] Add at24 based EEPROMs to the eeprom_dev hardware class

2014-01-23 Thread Curt Brune
During device instantiation have the at24 driver add the new device to the eeprom_dev hardware class. The functionality is enabled by CONFIG_EEPROM_CLASS. Signed-off-by: Curt Brune --- drivers/misc/eeprom/at24.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers

[PATCH v2 1/2] Create eeprom_dev hardware class for EEPROM devices

2014-01-23 Thread Curt Brune
Create a new hardware class under /sys/class/eeprom_dev EEPROM drivers can register their devices with the eeprom_dev class during instantiation. The registered devices show up as: /sys/class/eeprom_dev/eeprom0 /sys/class/eeprom_dev/eeprom1 ... /sys/class/eeprom_dev/eeprom[N] Each membe

Re: [PATCH 2/2] Add at24 based EEPROMs to the eeprom_dev hardware class

2014-01-23 Thread Curt Brune
On Thu Jan 23 19:15, Wolfram Sang wrote: > > > Well, it is not the Copyrights section, or you are saying the same > > people should go to MODULE_AUTHOR as in the Copyrights section, even > > if it is potentially several names? I thought this would be the name > > of the person who put the file tog

Re: [PATCH 2/2] Add at24 based EEPROMs to the eeprom_dev hardware class

2014-01-23 Thread Wolfram Sang
> Well, it is not the Copyrights section, or you are saying the same > people should go to MODULE_AUTHOR as in the Copyrights section, even > if it is potentially several names? I thought this would be the name > of the person who put the file together even if from existing sources. You may be ri

Re: [PATCH 2/2] Add at24 based EEPROMs to the eeprom_dev hardware class

2014-01-23 Thread Laszlo Papp
On Thu, Jan 23, 2014 at 5:25 PM, Wolfram Sang wrote: > Hi, > > No need to quote the whole message if you reply only to a bit of it. > >> > module_init(at24_init); >> > >> > static void __exit at24_exit(void) >> > { >> > i2c_del_driver(&at24_driver); >> > } >> > module_exit(at24_exit);

Re: [PATCH 2/2] Add at24 based EEPROMs to the eeprom_dev hardware class

2014-01-23 Thread Wolfram Sang
Hi, No need to quote the whole message if you reply only to a bit of it. > > module_init(at24_init); > > > > static void __exit at24_exit(void) > > { > > i2c_del_driver(&at24_driver); > > } > > module_exit(at24_exit); > > Couldn't you use module_i2c_driver() instead of this? He did

Re: [PATCH 2/2] Add at24 based EEPROMs to the eeprom_dev hardware class

2014-01-23 Thread Laszlo Papp
On Thu, Jan 23, 2014 at 3:05 PM, Curt Brune wrote: > On Thu Jan 23 07:44, Laszlo Papp wrote: >> On Wed, Jan 22, 2014 at 5:23 PM, Curt Brune wrote: >> > During device instantiation have the at24 driver add the new device to >> > the eeprom_dev hardware class. The functionality is enabled by >> >

[PATCH] i2c-i801: Standardize log messages

2014-01-23 Thread Jean Delvare
Use exactly the same log messages in the legacy setup function and the SB800+ setup function. This way strings can be reused, which saves some bytes in the generated binary. Signed-off-by: Jean Delvare Cc: Shane Huang --- Inspired by Shane's recent patch, on top of which it applies. drivers/i2

Re: [PATCH 2/2] Add at24 based EEPROMs to the eeprom_dev hardware class

2014-01-23 Thread Curt Brune
On Thu Jan 23 07:44, Laszlo Papp wrote: > On Wed, Jan 22, 2014 at 5:23 PM, Curt Brune wrote: > > During device instantiation have the at24 driver add the new device to > > the eeprom_dev hardware class. The functionality is enabled by > > CONFIG_EEPROM_CLASS. [snip] > > static void __exit at24_e

Re: [PATCH 1/2] Create eeprom_dev hardware class for EEPROM devices

2014-01-23 Thread Curt Brune
On Thu Jan 23 07:34, Laszlo Papp wrote: > On Thu, Jan 23, 2014 at 7:31 AM, Laszlo Papp wrote: > > On Wed, Jan 22, 2014 at 5:23 PM, Curt Brune > > wrote: > >> Create a new hardware class under /sys/class/eeprom_dev > > > > I would also explain why it is called "eeprom_dev", and not "eeprom" > > a

Re: [PATCH 2/2] i2c-piix4: Use different message for AMD Auxiliary SMBus Controller

2014-01-23 Thread Jean Delvare
On Wed, 22 Jan 2014 14:06:52 -0800, Shane Huang wrote: > Same messages for AMD main and auxiliary SMBus controllers lead to confusion, > this patch is to remove confusion and keep consistent with non-AMD products. > > Signed-off-by: Shane Huang > --- > drivers/i2c/busses/i2c-piix4.c |3 ++- >

Re: [PATCH 1/2] i2c-piix4: Add support for AMD ML and CZ SMBus changes

2014-01-23 Thread Jean Delvare
Hi Shane, hi Wolfram, On Wed, 22 Jan 2014 14:05:46 -0800, Shane Huang wrote: > The locations of SMBus register base address and enablement bit are changed > from AMD ML, which need this patch to be supported. > > Signed-off-by: Shane Huang > --- > Documentation/i2c/busses/i2c-piix4 |2 +- >