Re: [PATCH 1/2] i2c: Add message transfer tracepoints for I2C

2014-02-28 Thread David Howells
Wolfram Sang wrote: > > > And for the buffer: %*phN is difficult to read IMO. What about %*ph? Or > > > %*phD at least? > > > > My problem with that is that it increases the length of the output by 50% > > and there's a hard limit on how much output we may produce. > > Is it PAGE_SIZE? How is t

Re: [PATCH 2/2] i2c: Add message transfer tracepoints for SMBUS

2014-02-28 Thread David Howells
Wolfram Sang wrote: > > > Can we have something like this for 'flags'? > > > > There's a __print_flags() which should work. One thing I'm concerned about > > there is how do we handle more flags being added - does that count as an ABI > > break if the printed format changes? > > Not sure, I me

Re: [PATCH 1/2] i2c: Add driver for Cadence I2C controller

2014-02-28 Thread Sören Brinkmann
On Fri, 2014-02-28 at 04:00PM -0800, Soren Brinkmann wrote: > Add a driver for the Cadence I2C controller. This controller is for > example found in Xilinx Zynq. > > Signed-off-by: Soren Brinkmann > --- > .../devicetree/bindings/i2c/i2c-cadence.txt| 21 + > MAINTAINERS

Re: [PATCH 2/2] ARM: zynq: dt: Add I2C nodes to Zynq device tree

2014-02-28 Thread Sören Brinkmann
On Fri, 2014-02-28 at 04:00PM -0800, Soren Brinkmann wrote: > Signed-off-by: Soren Brinkmann > --- > arch/arm/boot/dts/zynq-7000.dtsi | 22 > arch/arm/boot/dts/zynq-zc702.dts | 76 > > arch/arm/boot/dts/zynq-zc706.dts | 68 +++

[PATCH 2/2] ARM: zynq: dt: Add I2C nodes to Zynq device tree

2014-02-28 Thread Soren Brinkmann
Signed-off-by: Soren Brinkmann --- arch/arm/boot/dts/zynq-7000.dtsi | 22 arch/arm/boot/dts/zynq-zc702.dts | 76 arch/arm/boot/dts/zynq-zc706.dts | 68 +++ 3 files changed, 166 insertions(+) diff --git a/arch/a

[PATCH 1/2] i2c: Add driver for Cadence I2C controller

2014-02-28 Thread Soren Brinkmann
Add a driver for the Cadence I2C controller. This controller is for example found in Xilinx Zynq. Signed-off-by: Soren Brinkmann --- .../devicetree/bindings/i2c/i2c-cadence.txt| 21 + MAINTAINERS| 1 + drivers/i2c/busses/Kconfig

CONTACT KENYA COMMERCIAL BANK LTD IMMEDIATELY FOR YOUR PAYMENT (3MILLION UNITED STATE DOLLARS)

2014-02-28 Thread Jantima Khuntaraksa
Attention: Please, Kindly contact KENYA COMMERCIAL BANK immediately for your compensation payment of (3MILLION UNITED STATE DOLLARS) via email: Email:(servic...@kenya.ncommercialbnk.com) quote your payment Ref No:KCB/00Y/2014 For purposes of immediate payment. -- To unsubscribe from this li

Re: [PATCH 2/2] i2c: Add message transfer tracepoints for SMBUS

2014-02-28 Thread Wolfram Sang
> > Also, the I2C tracing has first 'f' then 'a', that should be consistent, > > too. > > Flags first or address first? Do you have a preference (for both)? I'd say address first, yet no strong preference. > > Can we have something like this for 'flags'? > > There's a __print_flags() which sh

Re: [PATCH 1/2] i2c: Add message transfer tracepoints for I2C

2014-02-28 Thread Wolfram Sang
> > And for the buffer: %*phN is difficult to read IMO. What about %*ph? Or > > %*phD at least? > > My problem with that is that it increases the length of the output by 50% and > there's a hard limit on how much output we may produce. Is it PAGE_SIZE? How is this handled when the buffer is so b

Re: [PATCH v6 4/4] i2c, i2c_imc: Add DIMM bus code

2014-02-28 Thread Andy Lutomirski
On Feb 28, 2014 11:15 AM, "Mauro Carvalho Chehab" wrote: > > Em Wed, 19 Feb 2014 17:39:07 -0800 > Andy Lutomirski escreveu: > > > On Wed, Feb 19, 2014 at 11:03 AM, Luck, Tony wrote: > > >> (I'm c/c Tony here, as he also shared the same concern that I had on a > > >> previous feedback about using

Re: [PATCH v6 4/4] i2c, i2c_imc: Add DIMM bus code

2014-02-28 Thread Mauro Carvalho Chehab
Em Wed, 19 Feb 2014 17:39:07 -0800 Andy Lutomirski escreveu: > On Wed, Feb 19, 2014 at 11:03 AM, Luck, Tony wrote: > >> (I'm c/c Tony here, as he also shared the same concern that I had on a > >> previous feedback about using I2C to talk with the DIMM). > > > > Correct - I've heard the same issu

[PATCH] drivers: i2c: i2c-st: Fix return in case of arbitration lost

2014-02-28 Thread Maxime COQUELIN
This patch fixes the error returned to the i2c_transfer function to -EAGAIN in case of arbitratin lost, so that the retry mechanism can be used. Signed-off-by: Maxime Coquelin --- drivers/i2c/busses/i2c-st.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i

Re: [PATCH 1/3] i2c: add DMA support for freescale i2c driver

2014-02-28 Thread Marek Vasut
On Friday, February 28, 2014 at 12:36:01 PM, Yao Yuan wrote: > Hi Marek, > > > On Friday, February 28, 2014 at 06:19:18 AM, Yao Yuan wrote: > > > > [...] > > > > > > > @@ -213,6 +238,7 @@ static struct imx_i2c_hwdata vf610_i2c_hwdata > > > > > = { > > > > > > > > > > .ndivs

Re: [PATCH 1/3] i2c: add DMA support for freescale i2c driver

2014-02-28 Thread Marek Vasut
On Friday, February 28, 2014 at 11:59:25 AM, Lothar Waßmann wrote: > Hi, > > Marek Vasut wrote: > > On Friday, February 28, 2014 at 06:19:18 AM, Yao Yuan wrote: > > > > [...] > > > > > Yes, here have two dma channels, one for RX and the other one for TX. > > > When we request the channel we shou

RE: [PATCH 1/3] i2c: add DMA support for freescale i2c driver

2014-02-28 Thread Yao Yuan
Hi Marek, > On Friday, February 28, 2014 at 06:19:18 AM, Yao Yuan wrote: > > [...] > > > > > @@ -213,6 +238,7 @@ static struct imx_i2c_hwdata vf610_i2c_hwdata > > > > = { > > > > > > > > .ndivs = ARRAY_SIZE(vf610_i2c_clk_div), > > > > .i2sr_clr_opcode= I2S

Re: [PATCH v2] i2c:at91: Add device tree property to set clock-frequency

2014-02-28 Thread Ludovic Desroches
On Mon, Feb 24, 2014 at 08:50:45PM -0500, Marek Roszko wrote: > This adds the ability to set "clock-frequency" in the device tree for the i2c > bus following > the naming of other i2c bus implementations. If the property is not set, the > clock > frequency will default to the previously used defi

Re: [PATCH 1/3] i2c: add DMA support for freescale i2c driver

2014-02-28 Thread Lothar Waßmann
Hi, Marek Vasut wrote: > On Friday, February 28, 2014 at 06:19:18 AM, Yao Yuan wrote: > > [...] > > Yes, here have two dma channels, one for RX and the other one for TX. > > When we request the channel we should determine it for TX or RX. > > Sorry, I don't quite understand this. If you have two

[PATCH] i2c-davinci: Implement a bus recovery that actually works

2014-02-28 Thread mike . looijmans
From: Mike Looijmans Having a board where the I2C bus locks up occasionally made it clear that the bus recovery in the i2c-davinci driver will only work on some boards, because on regular boards, this will only toggle GPIO lines that aren't muxed to the actual pins. The I2C controller has the bu

Re: [PATCH 1/3] i2c: add DMA support for freescale i2c driver

2014-02-28 Thread Marek Vasut
On Friday, February 28, 2014 at 03:23:52 AM, Shawn Guo wrote: > On Fri, Feb 28, 2014 at 10:13:02AM +0800, Shawn Guo wrote: > > On Thu, Feb 27, 2014 at 09:39:35PM +0100, Marek Vasut wrote: > > > > @@ -193,6 +216,7 @@ static const struct imx_i2c_hwdata > > > > imx1_i2c_hwdata = { > > > > > > > >

Re: [PATCH 1/3] i2c: add DMA support for freescale i2c driver

2014-02-28 Thread Marek Vasut
On Friday, February 28, 2014 at 06:19:18 AM, Yao Yuan wrote: [...] > > > @@ -213,6 +238,7 @@ static struct imx_i2c_hwdata vf610_i2c_hwdata = { > > > > > > .ndivs = ARRAY_SIZE(vf610_i2c_clk_div), > > > .i2sr_clr_opcode= I2SR_CLR_OPCODE_W1C, > > > .i2cr_ien_opcode

[PATCH] i2c: i801: enable Intel BayTrail SMBUS

2014-02-28 Thread Chew Chiau Ee
From: Chew, Kean ho Add Device ID of Intel BayTrail SMBus Controller. Signed-off-by: Chew, Kean ho Signed-off-by: Chew, Chiau Ee --- Documentation/i2c/busses/i2c-i801 |1 + drivers/i2c/busses/Kconfig|1 + drivers/i2c/busses/i2c-i801.c |3 +++ 3 files changed, 5 inserti