Re: [PATCH] i2c-designware: Mask interrupts during i2c controller enable

2014-04-10 Thread Westerberg, Mika
On Thu, Apr 10, 2014 at 02:45:54AM +0300, Du, Wenkai wrote: -Original Message- From: Westerberg, Mika Sent: Tuesday, April 08, 2014 3:30 AM To: Du, Wenkai Cc: One Thousand Gnomes; linux-i2c@vger.kernel.org; Wolfram Sang; linux- ker...@vger.kernel.org Subject: Re: [PATCH]

Re: [PATCHv2] i2c: omap: Disable default probing of i2c devices for omap i2c.

2014-04-10 Thread sourav
Hi Wolfram, On Wednesday 09 April 2014 06:07 PM, Wolfram Sang wrote: On Wed, Apr 09, 2014 at 04:06:48PM +0530, Sourav Poddar wrote: I2c core supports defualt probing functionality for devices not registered through dt/board files. If there are any client driver registered, i2c core will try

[PATCH] i2c: nomadik: Fixup system suspend

2014-04-10 Thread Ulf Hansson
For !CONFIG_PM_RUNTIME, the device were never put back into active state while resuming. For CONFIG_PM_RUNTIME, we blindly trusted the device to be inactive while we were about to handle it at suspend late, which is just too optimistic. Even if the driver uses pm_runtime_put_sync() after each

[PATCH] i2c: nomadik: Don't use IS_ERR for devm_ioremap

2014-04-10 Thread Ulf Hansson
devm_ioremap() returns NULL on error, not an error. Cc: Alessandro Rubini rub...@unipv.it Cc: Linus Walleij linus.wall...@linaro.org Signed-off-by: Ulf Hansson ulf.hans...@linaro.org --- drivers/i2c/busses/i2c-nomadik.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] i2c: busses: ali1563: fix checkpatch.pl issues

2014-04-10 Thread Richard Leitner
Fixed most checkpatch.pl issues Signed-off-by: Richard Leitner m...@g0hl1n.net --- drivers/i2c/busses/i2c-ali1563.c | 83 ++-- 1 file changed, 45 insertions(+), 38 deletions(-) diff --git a/drivers/i2c/busses/i2c-ali1563.c b/drivers/i2c/busses/i2c-ali1563.c

Re: [PATCH] i2c: nomadik: Fixup system suspend

2014-04-10 Thread Linus Walleij
On Thu, Apr 10, 2014 at 3:59 PM, Ulf Hansson ulf.hans...@linaro.org wrote: For !CONFIG_PM_RUNTIME, the device were never put back into active state while resuming. For CONFIG_PM_RUNTIME, we blindly trusted the device to be inactive while we were about to handle it at suspend late, which is

Re: [PATCH RFC] i2c algo, Add i2c-algo-i801 driver [v1]

2014-04-10 Thread Prarit Bhargava
On 04/09/2014 01:09 PM, Matthew Garrett wrote: On Wed, 2014-04-09 at 13:02 -0400, Prarit Bhargava wrote: On 04/09/2014 12:36 PM, Matthew Garrett wrote: On Wed, 2014-04-09 at 12:22 -0400, Prarit Bhargava wrote: RFC and a work in progress ... I need to go through and do a bunch of error

Re: [PATCH RFC] i2c algo, Add i2c-algo-i801 driver [v1]

2014-04-10 Thread Matthew Garrett
On Thu, 2014-04-10 at 15:15 -0400, Prarit Bhargava wrote: On 04/09/2014 01:09 PM, Matthew Garrett wrote: Not really. These are an internal implementation detail, not an exported interface. We try to write drivers for exported interfaces, even if they're not documented. Aren't the

[PATCH V2] i2c-designware: Mask all interrupts during i2c controller enable

2014-04-10 Thread Du, Wenkai
Hi all, Updated problem descriptions from Mika's feedback and new test data: There have been i2c_designware 80860F41:00: controller timed out errors on a number of Baytrail platforms. The issue is caused by incorrect value in Interrupt Mask Register (DW_IC_INTR_MASK) when i2c core is being

RE: [PATCH] i2c-designware: Mask interrupts during i2c controller enable

2014-04-10 Thread Du, Wenkai
-Original Message- From: Westerberg, Mika Sent: Thursday, April 10, 2014 2:08 AM To: Du, Wenkai Cc: One Thousand Gnomes; linux-i2c@vger.kernel.org; Wolfram Sang; linux- ker...@vger.kernel.org Subject: Re: [PATCH] i2c-designware: Mask interrupts during i2c controller enable Can

[PATCH] I2C: rcar: add R-Car Gen2 and r8a7791 support for DT

2014-04-10 Thread Kuninori Morimoto
From: Kuninori Morimoto kuninori.morimoto...@renesas.com Signed-off-by: Kuninori Morimoto kuninori.morimoto...@renesas.com --- drivers/i2c/busses/i2c-rcar.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/i2c/busses/i2c-rcar.c b/drivers/i2c/busses/i2c-rcar.c index

[PATCH 1/2] i2c/ACPI: Support for multiple serial bus addresses

2014-04-10 Thread Srinivas Pandruvada
ACPI specification allows multiple i2c addresses defined under one ACPI device object. These addresses are defined using _CRS method. The current implementation will pickup the last entry in _CRS, and create an i2C device, ignoring all other previous entries for addresses. The ACPI specification

Re: [PATCH] I2C: rcar: add R-Car Gen2 and r8a7791 support for DT

2014-04-10 Thread Kuninori Morimoto
Hi Wolfram Please ignore this I noticed that it is already included on linux-next From: Kuninori Morimoto kuninori.morimoto...@renesas.com Signed-off-by: Kuninori Morimoto kuninori.morimoto...@renesas.com --- drivers/i2c/busses/i2c-rcar.c |2 ++ 1 file changed, 2 insertions(+)