Re: [Resend Patch 0/9] I2C ACPI operation region handler support

2014-04-23 Thread Adam Williamson
On Tue, 2014-04-22 at 14:24 +0800, Lan Tianyu wrote: > ACPI 5.0 spec(5.5.2.4.5) defines GenericSerialBus(i2c, spi, uart) operation > region. It allows ACPI aml code able to access such kind of devices to > implement some ACPI standard method. > > On the Asus T100TA, Bios use GenericSerialBus opera

Re: [PATCH v2 0/7] Add cros_ec changes for newer boards

2014-04-23 Thread Stephen Warren
On 04/23/2014 06:32 AM, Lee Jones wrote: > On Tue, 22 Apr 2014, Doug Anderson wrote: > >> This series adds the most critical cros_ec changes for newer boards >> using cros_ec. Specifically: >> * Fixes timing/locking issues with the previously upstreamed (but >> never used upstream) cros_ec_spi

Re: [PATCH v2 6/7] i2c: ChromeOS EC tunnel driver

2014-04-23 Thread Lee Jones
On Tue, 22 Apr 2014, Doug Anderson wrote: > On ARM Chromebooks we have a few devices that are accessed by both the > AP (the main "Application Processor") and the EC (the Embedded > Controller). These are: > * The battery (sbs-battery). > * The power management unit tps65090. > > On the original

Re: [PATCH v2 0/7] Add cros_ec changes for newer boards

2014-04-23 Thread Lee Jones
On Tue, 22 Apr 2014, Doug Anderson wrote: > This series adds the most critical cros_ec changes for newer boards > using cros_ec. Specifically: > * Fixes timing/locking issues with the previously upstreamed (but > never used upstream) cros_ec_spi driver. > * Updates the cros_ec header file to th

RE: [PATCH] i2c: s3c2410: resume race fix

2014-04-23 Thread Kukjin Kim
Doug Anderson wrote: > > From: Olof Johansson > > Don't unmark the device as suspended until after it's been re-setup. > > The main race would be w.r.t. an i2c driver that gets resumed at the same > time (asyncronously), that is allowed to do a transfer since suspended > is set to 0 before rein

Re: [Resend Patch 9/9] I2C/ACPI: Add CONFIG_I2C_ACPI config

2014-04-23 Thread Mika Westerberg
On Wed, Apr 23, 2014 at 06:47:05AM +, Zheng, Lv wrote: > Hi, Tianyu > > > From: Lan, Tianyu > > Sent: Wednesday, April 23, 2014 1:40 PM > > > > On 2014年04月22日 19:45, Mika Westerberg wrote: > > > On Tue, Apr 22, 2014 at 02:24:15PM +0800, Lan Tianyu wrote: > > >> This patch is to add CONFIG_I2C

Re: [Resend Patch 7/9] I2C/ACPI: Add i2c ACPI operation region support

2014-04-23 Thread Lan Tianyu
On 2014年04月23日 15:28, Mika Westerberg wrote: > On Wed, Apr 23, 2014 at 09:53:21AM +0800, Lan Tianyu wrote: >> Hi Mika: >> Thanks a lot for your review. >> >> On 2014年04月22日 19:36, Mika Westerberg wrote: > + > + client.adapter = adapter; > + client.addr = sb->slave_address; > +

Re: [PATCH 22/33] ARM: shmobile: Use r8a7740 suffix for i2c, mmcif, fsi2 compat strings

2014-04-23 Thread Geert Uytterhoeven
Hi Wolfram, On Wed, Apr 23, 2014 at 9:18 AM, Wolfram Sang wrote: >> > - compatible = "renesas,rmobile-iic"; >> > + compatible = "renesas,iic-r8a7740", "renesas,rmobile-iic"; >> >> I see an opportunity for improvement here: this driver doesn't seem to have >> any bindin

Re: [Resend Patch 7/9] I2C/ACPI: Add i2c ACPI operation region support

2014-04-23 Thread Mika Westerberg
On Wed, Apr 23, 2014 at 09:53:21AM +0800, Lan Tianyu wrote: > Hi Mika: > Thanks a lot for your review. > > On 2014年04月22日 19:36, Mika Westerberg wrote: > >> > + > >> > +client.adapter = adapter; > >> > +client.addr = sb->slave_address; > >> > +client.flags = 0; > > I'

Re: [PATCH 22/33] ARM: shmobile: Use r8a7740 suffix for i2c, mmcif, fsi2 compat strings

2014-04-23 Thread Wolfram Sang
On Wed, Apr 23, 2014 at 09:09:49AM +0200, Geert Uytterhoeven wrote: > On Wed, Apr 23, 2014 at 3:25 AM, Simon Horman > wrote: > > From: Ulrich Hecht > > > > Add "renesas,*-r8a7740" to the compatible strings for consistency with other > > devices. > > > diff --git a/arch/arm/boot/dts/r8a7740.dtsi

Re: [PATCH 22/33] ARM: shmobile: Use r8a7740 suffix for i2c, mmcif, fsi2 compat strings

2014-04-23 Thread Geert Uytterhoeven
On Wed, Apr 23, 2014 at 3:25 AM, Simon Horman wrote: > From: Ulrich Hecht > > Add "renesas,*-r8a7740" to the compatible strings for consistency with other > devices. > diff --git a/arch/arm/boot/dts/r8a7740.dtsi b/arch/arm/boot/dts/r8a7740.dtsi > index 8280884..9f65986 100644 > --- a/arch/arm/bo