Re: [PATCH] of: Transactional DT support.

2014-06-25 Thread Grant Likely
On Wed, 25 Jun 2014 12:20:16 -0700, Dan Malek wrote: > > On Jun 25, 2014, at 7:48 AM, Pantelis Antoniou > wrote: > > >>> +int of_transaction_commit(struct of_transaction *oft); > >> > >> How about of_transaction_apply()? > >> > > > > Sure. > > LOL! Panto, you give in too easily :) > > An

[PATCH 2/2 v2] i2c: exynos5: remove extra line and fix an assignment

2014-06-25 Thread Naveen Krishna Chatradhi
This patch does the following in exynos5_i2c_message_start() function 1. Fixes an assignment As, "i2c_auto_conf" is initialized to '0' at the beginning of the function and HSI2C_READ_WRITE is defined as (1u << 16) Using "|=" for the first assignment is more readable. 2. Removes an extra

[PATCH 1/2 v2] i2c: exynos5: remove an unnecessary read of FIFO_STATUS register

2014-06-25 Thread Naveen Krishna Chatradhi
This patch removes an extra read of FIFO_STATUS register in the interrrupt service routine. Which is read again before the actual use. Signed-off-by: Naveen Krishna Chatradhi --- Changes since v1: None drivers/i2c/busses/i2c-exynos5.c |1 - 1 file changed, 1 deletion(-) diff --git a/driver

Re: [PATCH 2/2] i2c: exynos5: fix minor styling nits

2014-06-25 Thread Naveen Krishna Ch
Hello Sachin, On 25 June 2014 16:19, Sachin Kamat wrote: > Hi Naveen, > > On Wed, Jun 25, 2014 at 4:08 PM, Naveen Krishna Chatradhi > wrote: >> This patch removes an extra line and fixes a styling nit >> in exynos5_i2c_message_start() >> >> Signed-off-by: Naveen Krishna Chatradhi >> --- >> dri

Re: [PATCH v2] i2c: s3c2410: resume the I2C controller earlier

2014-06-25 Thread Javier Martinez Canillas
Hello Doug, On 06/25/2014 01:56 AM, Doug Anderson wrote: > From: Vincent Palatin > > When the wake-up is triggered by the PMIC RTC, the RTC driver is trying > to read the PMIC interrupt status over I2C and fails because the I2C > controller is not resumed yet. > Let's resume the I2C controller e

Re: [PATCH 1/1] i2c: Kconfig: Enable HSI2C for Exynos5 platform

2014-06-25 Thread Doug Anderson
Sachin, On Wed, Jun 25, 2014 at 3:02 AM, Sachin Kamat wrote: > All Exynos5 platforms have HSI2C controllers and are needed by > various IPs connected to the boards based on these SoCs. Thus > select this by default for Exynos5 platforms. > > Signed-off-by: Sachin Kamat > Cc: Doug Anderson > ---

[PATCH v3] i2c: exynos5: Properly use the "noirq" variants of suspend/resume

2014-06-25 Thread Doug Anderson
The original code for the exynos i2c controller registered for the "noirq" variants. However during review feedback it was moved to SIMPLE_DEV_PM_OPS without anyone noticing that it meant we were no longer actually "noirq" (despite functions named exynos5_i2c_suspend_noirq and exynos5_i2c_resume_n

Re: [PATCH v2] i2c: exynos5: Properly use the "noirq" variants of suspend/resume

2014-06-25 Thread Doug Anderson
Kukjin, On Wed, Jun 25, 2014 at 4:13 AM, Kukjin Kim wrote: > Doug Anderson wrote: >> >> The original code for the exynos i2c controller registered for the >> "noirq" variants. However during review feedback it was moved to >> SIMPLE_DEV_PM_OPS without anyone noticing that it meant we were no >>

Re: Need to use a I2C EEPROM on normal x86 architecture

2014-06-25 Thread Vijai Kumar
Hi Christian, I am facing the same issue with at24 driver. Can I know what patches you did to the driver. I tried the above changes but still I was not able to R/W the eeprom. Can you provide the full source code?? -- To unsubscribe from this list: send the line "unsubscribe linux-i

RE: [PATCH v2] i2c: exynos5: Properly use the "noirq" variants of suspend/resume

2014-06-25 Thread Kukjin Kim
Doug Anderson wrote: > > The original code for the exynos i2c controller registered for the > "noirq" variants. However during review feedback it was moved to > SIMPLE_DEV_PM_OPS without anyone noticing that it meant we were no > longer actually "noirq" (despite functions named > exynos5_i2c_susp

Re: [PATCH 2/2] i2c: exynos5: fix minor styling nits

2014-06-25 Thread Sachin Kamat
Hi Naveen, On Wed, Jun 25, 2014 at 4:08 PM, Naveen Krishna Chatradhi wrote: > This patch removes an extra line and fixes a styling nit > in exynos5_i2c_message_start() > > Signed-off-by: Naveen Krishna Chatradhi > --- > drivers/i2c/busses/i2c-exynos5.c |3 +-- > 1 file changed, 1 insertion(

[PATCH 2/2] i2c: exynos5: fix minor styling nits

2014-06-25 Thread Naveen Krishna Chatradhi
This patch removes an extra line and fixes a styling nit in exynos5_i2c_message_start() Signed-off-by: Naveen Krishna Chatradhi --- drivers/i2c/busses/i2c-exynos5.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-exynos5.c b/drivers/i2c/busses/i2c-

[PATCH 1/2] i2c: exynos5: remove an unnecessary read of FIFO_STATUS register

2014-06-25 Thread Naveen Krishna Chatradhi
This patch removes an extra read of FIFO_STATUS register in the interrrupt service routine. Which is read again before the actual use. Signed-off-by: Naveen Krishna Chatradhi --- drivers/i2c/busses/i2c-exynos5.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-exynos5

RE: [PATCH 1/1] i2c: Kconfig: Enable HSI2C for Exynos5 platform

2014-06-25 Thread Kukjin Kim
Sachin Kamat wrote: > > All Exynos5 platforms have HSI2C controllers and are needed by > various IPs connected to the boards based on these SoCs. Thus > select this by default for Exynos5 platforms. > Yeah right, even upcoming exynos5 SoCs have only HS-I2C not I2C ;-) > Signed-off-by: Sachin Kam

[PATCH 1/1] i2c: Kconfig: Enable HSI2C for Exynos5 platform

2014-06-25 Thread Sachin Kamat
All Exynos5 platforms have HSI2C controllers and are needed by various IPs connected to the boards based on these SoCs. Thus select this by default for Exynos5 platforms. Signed-off-by: Sachin Kamat Cc: Doug Anderson --- drivers/i2c/busses/Kconfig |4 ++-- 1 file changed, 2 insertions(+), 2

Re: [PATCH 5/6] OF: Utility helper functions for dynamic nodes

2014-06-25 Thread Grant Likely
On Tue, 24 Jun 2014 10:10:01 +0200, Alexander Sverdlin wrote: > Hi Pantelis, Grant, > > On 23/06/14 20:33, Ioan Nicu wrote: > >>> On 22/06/14 11:40, ext Pantelis Antoniou wrote: > Introduce helper functions for working with the live DT tree, > all of them related to dynamically adding/