> One possibility is to switch to tabs and shift all columns (but the
> first) by 4 to the right. This rules out the addition of a column in
> the future, but otherwise fulfills your desire.
I'd like that. Plus, I am not so strict with the 80 char limit. If there
is another feature, then be it on
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Thanks Dan!
Updated and a bit refactored patch is attached.
Michal
On 07/17/2014 02:56 AM, Danielle Costantino wrote:
> you need to add this after the #else , before the err = system...
> to accommodate for systems that have i2c-dev.ko built in, not
On Thu, 17 Jul 2014 10:41:57 +0200, Wolfram Sang wrote:
>
> > One possibility is to switch to tabs and shift all columns (but the
> > first) by 4 to the right. This rules out the addition of a column in
> > the future, but otherwise fulfills your desire.
>
> I'd like that. Plus, I am not so stric
On Thu, Jun 26, 2014 at 10:44:58AM +0530, Naveen Krishna Chatradhi wrote:
> This patch does the following in exynos5_i2c_message_start() function
> 1. Fixes an assignment
>As, "i2c_auto_conf" is initialized to '0' at the beginning of the
>function and HSI2C_READ_WRITE is defined as (1u << 1
On Thu, Jun 26, 2014 at 10:44:57AM +0530, Naveen Krishna Chatradhi wrote:
> This patch removes an extra read of FIFO_STATUS register in the interrrupt
> service routine. Which is read again before the actual use.
>
> Signed-off-by: Naveen Krishna Chatradhi
Applied to for-next, thanks!
signatu
Hi Wolfram,
Are you going to take a lot at this set?
> As previously discussed I believe it should be okay for an I2C device
> driver _not_ supply an I2C ID table to match to. The I2C subsystem
> should be able to match via other means, such as via OF tables. The
> blocking factor during our pr
Hi Bastian,
On Sat, Jul 12, 2014 at 01:49:27PM +0200, Bastian Hecht wrote:
> i2c transfer requests come in very uncontrolled, like from interrupt routines.
> We might be suspended when this happens. To avoid i2c timeouts caused by
> powered down busses we check for suspension.
>
> Signed-off-by:
On Thu, Jul 17, 2014 at 11:23:42AM +0100, Lee Jones wrote:
> Hi Wolfram,
>
> Are you going to take a lot at this set?
Sure thing, yet I won't make it for 3.17, sadly :( It has high priority
for 3.18, though.
signature.asc
Description: Digital signature
A long name broke the alignment, shift the columns a bit to fix it and
make the table look nice again. While we're here, switch to the
standard comment style to make checkpatch happy, and use tabs instead
of spaces for column alignment.
Signed-off-by: Jean Delvare
Cc: James Ralston
Cc: Wolfram S
On Thu, Jul 17, 2014 at 03:00:48PM +0200, Wolfram Sang wrote:
> Hi Bastian,
>
> On Sat, Jul 12, 2014 at 01:49:27PM +0200, Bastian Hecht wrote:
> > i2c transfer requests come in very uncontrolled, like from interrupt
> > routines.
> > We might be suspended when this happens. To avoid i2c timeouts
Signed-off-by: Jean Delvare
Cc: James Ralston
Cc: Wolfram Sang
---
Untested, but the datasheet show full compatibility with previous
chipsets.
Changes since v1:
* Rebased, no other change
Documentation/i2c/busses/i2c-i801 |1 +
drivers/i2c/busses/Kconfig|1 +
drivers/i2c/buss
On Mon, Jul 07, 2014 at 07:23:03AM -0700, Guenter Roeck wrote:
> SMBus block commands are different to I2C block commands since
> the returned data is not normally accessible with byte or word
> commands on other command offsets. Add linked list of 'block'
> commands to support those commands.
>
>
On Thu, Jul 10, 2014 at 08:23:25PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam
>
> When building multi_v7_defconfig with CONFIG_ARM_LPAE=y the following warning
> is seen:
>
> drivers/i2c/busses/i2c-st.c:818:2: warning: format '%x' expects argument of
> type
> 'unsigned int', but argument
On Fri, Jul 11, 2014 at 10:50:14AM +0200, Uwe Kleine-König wrote:
> Olof Johansson pointed out that usually the company name is picked as
> namespace prefix to specific properties. So expect "energymicro,location"
> but fall back to the previously introduced name "efm32,location".
>
> Cc: Olof Joh
On Thu, 17 Jul 2014 15:21:35 +0200, Wolfram Sang wrote:
> On Mon, Jul 07, 2014 at 07:23:03AM -0700, Guenter Roeck wrote:
> > SMBus block commands are different to I2C block commands since
> > the returned data is not normally accessible with byte or word
> > commands on other command offsets. Add l
Hi Wolfram,
thanks for the review.
2014-07-17 15:00 GMT+02:00 Wolfram Sang :
> Hi Bastian,
>
> On Sat, Jul 12, 2014 at 01:49:27PM +0200, Bastian Hecht wrote:
>> i2c transfer requests come in very uncontrolled, like from interrupt
>> routines.
>> We might be suspended when this happens. To avoid
We now take care of suspension in the i2c core code. So we can remove this
check here.
Signed-off-by: Bastian Hecht
---
same as v1
drivers/i2c/busses/i2c-exynos5.c | 20 +---
1 file changed, 1 insertion(+), 19 deletions(-)
diff --git a/drivers/i2c/busses/i2c-exynos5.c b/drivers
We now take care of suspension in the i2c core code. So we can remove this
check here.
Signed-off-by: Bastian Hecht
---
same as v1
drivers/i2c/busses/i2c-tegra.c | 19 +--
1 file changed, 1 insertion(+), 18 deletions(-)
diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/
We now take care of suspension in the i2c core code. So we can remove this
check here.
Signed-off-by: Bastian Hecht
---
same as v1
drivers/i2c/busses/i2c-s3c2410.c | 16
1 file changed, 16 deletions(-)
diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2
We now take care of suspension in the i2c core code. So we can remove this
check here.
Signed-off-by: Bastian Hecht
---
same as v1
drivers/i2c/busses/i2c-eg20t.c | 15 ---
1 file changed, 15 deletions(-)
diff --git a/drivers/i2c/busses/i2c-eg20t.c b/drivers/i2c/busses/i2c-eg20t.c
i
i2c transfer requests come in very uncontrolled, like from interrupt routines.
We might be suspended when this happens. To avoid i2c timeouts caused by
powered down busses we check for suspension.
Several bus drivers handle this problem on their own. We can clean things up
by moving the protection
I want to add the remark that I can't help further on the patch series
in the next month about. So this is free to be taken/ignored/modified
without any approval by my side.
Have fun coding,
Bastian
2014-07-17 16:48 GMT+02:00 Bastian Hecht :
> i2c transfer requests come in very uncontrolled, l
On Thu, Jul 17, 2014 at 04:48:40PM +0200, Bastian Hecht wrote:
[...]
> #ifdef CONFIG_PM_SLEEP
> -static int tegra_i2c_suspend(struct device *dev)
> -{
> - struct tegra_i2c_dev *i2c_dev = dev_get_drvdata(dev);
> -
> - i2c_lock_adapter(&i2c_dev->adapter);
> - i2c_dev->is_suspended = true
On Thu, Jul 17, 2014 at 04:58:17PM +0200, Bastian Hecht wrote:
> I want to add the remark that I can't help further on the patch series
> in the next month about. So this is free to be taken/ignored/modified
> without any approval by my side.
Good to know. I'd like to get some Tested-by tags befor
On Thu, Jul 10, 2014 at 01:46:22PM +0200, Wolfram Sang wrote:
> This driver has been flagged to drop class based instantiation. The removal
> improves boot-up time and is unneeded for embedded controllers. Users have
> been
> warned to switch for some time now, so we can actually do the removal. K
SMBus block commands are different to I2C block commands since
the returned data is not normally accessible with byte or word
commands on other command offsets. Add linked list of 'block'
commands to support those commands.
Access mechanism is quite simple: Block commands must be written
before th
2014-07-17 16:59 GMT+02:00 Thierry Reding :
> On Thu, Jul 17, 2014 at 04:48:40PM +0200, Bastian Hecht wrote:
> [...]
>> #ifdef CONFIG_PM_SLEEP
>> -static int tegra_i2c_suspend(struct device *dev)
>> -{
>> - struct tegra_i2c_dev *i2c_dev = dev_get_drvdata(dev);
>> -
>> - i2c_lock_adapter(&i
2014-07-17 16:48 GMT+02:00 Bastian Hecht :
> We now take care of suspension in the i2c core code. So we can remove this
> check here.
>
> Signed-off-by: Bastian Hecht
> ---
> same as v1
>
> drivers/i2c/busses/i2c-exynos5.c | 20 +---
> 1 file changed, 1 insertion(+), 19 deletions(
On Thu, Jul 17, 2014 at 09:56:03AM -0700, Guenter Roeck wrote:
> SMBus block commands are different to I2C block commands since
> the returned data is not normally accessible with byte or word
> commands on other command offsets. Add linked list of 'block'
> commands to support those commands.
>
>
On Thu, Jul 10, 2014 at 12:45:11PM +0200, Jean Delvare wrote:
> This makes initialization, cleanup and look-up easier.
>
> Signed-off-by: Jean Delvare
> Cc: Guenter Roeck
Applied to for-next, thanks!
signature.asc
Description: Digital signature
On Thu, Jul 10, 2014 at 12:56:59PM +0200, Jean Delvare wrote:
> Some chips implement banked register ranges. This allows implementing
> more registers than the limited 8-bit address space originally allows.
> In order to access a register on these chips, you must first select
> the proper bank. Add
On Sun, Jul 13, 2014 at 05:17:17PM +0200, Jean Delvare wrote:
> I2C block transfers can have a size up to 32 bytes. If starting close
Shouldn't that be "256 bytes"? 32 is SMBUS transfer size? Otherwise I
don't understand the patch.
> to the end of the address space, there may not be enough room t
On Thu, Jul 17, 2014 at 03:04:41PM +0200, Jean Delvare wrote:
> Signed-off-by: Jean Delvare
> Cc: James Ralston
> Cc: Wolfram Sang
Applied to for-next, thanks!
signature.asc
Description: Digital signature
On Thu, Jul 17, 2014 at 03:03:24PM +0200, Jean Delvare wrote:
> A long name broke the alignment, shift the columns a bit to fix it and
> make the table look nice again. While we're here, switch to the
> standard comment style to make checkpatch happy, and use tabs instead
> of spaces for column ali
On Thu, Jul 17, 2014 at 07:27:20PM +0200, Wolfram Sang wrote:
> On Sun, Jul 13, 2014 at 05:17:17PM +0200, Jean Delvare wrote:
> > I2C block transfers can have a size up to 32 bytes. If starting close
>
> Shouldn't that be "256 bytes"? 32 is SMBUS transfer size? Otherwise I
> don't understand the p
On Thu, Jul 17, 2014 at 03:40:00PM +0200, Wolfram Sang wrote:
> On Fri, Jul 11, 2014 at 10:50:14AM +0200, Uwe Kleine-König wrote:
> > Olof Johansson pointed out that usually the company name is picked as
> > namespace prefix to specific properties. So expect "energymicro,location"
> > but fall back
On Thu, 17 Jul 2014 10:57:49 -0700, Guenter Roeck wrote:
> On Thu, Jul 17, 2014 at 07:27:20PM +0200, Wolfram Sang wrote:
> > On Sun, Jul 13, 2014 at 05:17:17PM +0200, Jean Delvare wrote:
> > > I2C block transfers can have a size up to 32 bytes. If starting close
> >
> > Shouldn't that be "256 byte
37 matches
Mail list logo
