On Monday, September 08, 2014 at 08:04:22 PM, Janusz Użycki wrote:
Thanks, but the Subject of the email doesn't make much sense. Also, a short
commit message exlaining what you did and why you did it would be nice.
While the patch is obvious and obviously correct, can you please fix those two
m
On Monday, September 08, 2014 at 08:06:12 PM, Janusz Użycki wrote:
> Subject: [PATCH 2/2] i2c-mxs: fixed PIO NACK error instead of timeout
> (1000ms)
>
> i2cdetect scanned i2c bus very slow if address was not occupied by any
> device.
Shouldn't this check be used only after the 'SELECT' command
Subject: [PATCH 2/2] i2c-mxs: fixed PIO NACK error instead of timeout
(1000ms)
i2cdetect scanned i2c bus very slow if address was not occupied by any
device.
Signed-off-by: Janusz Uzycki
---
linux-3.14.17/drivers/i2c/busses/i2c-mxs.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/li
Signed-off-by: Janusz Uzycki
---
linux-3.14.17/drivers/i2c/busses/i2c-mxs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/linux-3.14.17/drivers/i2c/busses/i2c-mxs.c
b/linux-3.14.17/drivers/i2c/busses/i2c-mxs.c
index 0cde4e6..87ee72d 100644
--- a/linux-3.14.17/drivers/i2c/
On Mon, Sep 08, 2014 at 08:15:07PM +0300, Octavian Purdila wrote:
> Just one more question on this subject: is the following allowed:
>
> int ret, len;
>
> or should it be:
>
> int ret;
> int len;
I try to avoid it, at least unless obviously related such as min/max or
x/y.
Johan
--
To unsubsc
On Mon, Sep 8, 2014 at 7:30 PM, Johan Hovold wrote:
> On Mon, Sep 08, 2014 at 06:57:29PM +0300, Octavian Purdila wrote:
>> On Mon, Sep 8, 2014 at 5:44 PM, Johan Hovold wrote:
>>
>>
>>
>> Hi Johan,
>>
>> Again, thanks for the detailed review, I am addressing your review
>> comments as we speak. S
On Fri, Sep 05, 2014 at 06:17:59PM +0300, Octavian Purdila wrote:
> --- /dev/null
> +++ b/drivers/gpio/gpio-dln2.c
> @@ -0,0 +1,537 @@
> +/*
> + * Driver for the Diolan DLN-2 USB-GPIO adapter
> + *
> + * Copyright (c) 2014 Intel Corporation
> + *
> + * This program is free software; you can redist
On Mon, Sep 08, 2014 at 06:57:29PM +0300, Octavian Purdila wrote:
> On Mon, Sep 8, 2014 at 5:44 PM, Johan Hovold wrote:
>
>
>
> Hi Johan,
>
> Again, thanks for the detailed review, I am addressing your review
> comments as we speak. Some questions below.
>
>
>
> > > + int ret, len;
> >
On Fri, Sep 05, 2014 at 06:17:59PM +0300, Octavian Purdila wrote:
> From: Daniel Baluta
>
> This patch adds GPIO and IRQ support for the Diolan DLN-2 GPIO module.
>
> Information about the USB protocol interface can be found in the
> Programmer's Reference Manual [1], see section 2.9 for the GPI
On Mon, Sep 8, 2014 at 4:39 AM, Javier Martinez Canillas
wrote:
> Hello Lee,
>
> On 09/04/2014 10:34 AM, Lee Jones wrote:
>> On Mon, 25 Aug 2014, Javier Martinez Canillas wrote:
>>> From: Andrew Bresticker
>>>
>>> When an EC command returns EC_RES_IN_PROGRESS, we need to query
>>> the state of th
On Mon, Sep 8, 2014 at 5:44 PM, Johan Hovold wrote:
Hi Johan,
Again, thanks for the detailed review, I am addressing your review
comments as we speak. Some questions below.
> > + int ret, len;
> > + struct tx_data {
> > + u8 port;
> > + u8 addr;
> > +
On Fri, Sep 05, 2014 at 06:17:58PM +0300, Octavian Purdila wrote:
> From: Laurentiu Palcu
>
> This patch adds support for the Diolan DLN-2 I2C master module. Due
> to hardware limitations it does not support SMBUS quick commands.
>
> Information about the USB protocol interface can be found in t
On Mon, Sep 08, 2014 at 04:20:34PM +0300, Octavian Purdila wrote:
> On Mon, Sep 8, 2014 at 2:32 PM, Johan Hovold wrote:
> > > +static bool find_free_slot(struct dln2_mod_rx_slots *rxs, int *slot)
> > > +{
> > > + unsigned long flags;
> > > +
> > > + spin_lock_irqsave(&rxs->lock, flags);
>
On Mon, 08 Sep 2014, Octavian Purdila wrote:
> On Mon, Sep 8, 2014 at 2:32 PM, Johan Hovold wrote:
> >
> > On Fri, Sep 05, 2014 at 06:17:57PM +0300, Octavian Purdila wrote:
> > > This patch implements the USB part of the Diolan USB-I2C/SPI/GPIO
> > > Master Adapter DLN-2. Details about the device
On Mon, Sep 8, 2014 at 2:32 PM, Johan Hovold wrote:
>
> On Fri, Sep 05, 2014 at 06:17:57PM +0300, Octavian Purdila wrote:
> > This patch implements the USB part of the Diolan USB-I2C/SPI/GPIO
> > Master Adapter DLN-2. Details about the device can be found here:
> >
>
> First of all, this is much
On Mon, 08 Sep 2014, Javier Martinez Canillas wrote:
> On 09/04/2014 10:34 AM, Lee Jones wrote:
> > On Mon, 25 Aug 2014, Javier Martinez Canillas wrote:
> >> From: Andrew Bresticker
> >>
> >> When an EC command returns EC_RES_IN_PROGRESS, we need to query
> >> the state of the EC until it indicat
On Mon, Sep 08, 2014 at 01:32:33PM +0200, Johan Hovold wrote:
> On Fri, Sep 05, 2014 at 06:17:57PM +0300, Octavian Purdila wrote:
> > +static int _dln2_transfer(struct dln2_dev *dln2, u16 handle, u16 cmd,
> > + void *obuf, int obuf_len, void *ibuf, int *ibuf_len)
> > +{
> >
Hello Lee,
On 09/04/2014 10:34 AM, Lee Jones wrote:
> On Mon, 25 Aug 2014, Javier Martinez Canillas wrote:
>> From: Andrew Bresticker
>>
>> When an EC command returns EC_RES_IN_PROGRESS, we need to query
>> the state of the EC until it indicates that it is no longer busy.
>> Do this in cros_ec_c
On Fri, Sep 05, 2014 at 06:17:57PM +0300, Octavian Purdila wrote:
> This patch implements the USB part of the Diolan USB-I2C/SPI/GPIO
> Master Adapter DLN-2. Details about the device can be found here:
>
> https://www.diolan.com/i2c/i2c_interface.html.
>
> Information about the USB protocol can b
Hello Lee,
Sorry for the delay but had been on holidays last week.
On 09/04/2014 10:25 AM, Lee Jones wrote:
>>
>> -static const struct mfd_cell cros_devs[] = {
>> -{
>> -.name = "cros-ec-keyb",
>> -.id = 1,
>> -.of_compatible = "google,cros-ec-keyb",
>> -
20 matches
Mail list logo
