Re: [PATCH 2/2] i2c-mxs: fixed PIO NACK error instead of timeout

2014-09-09 Thread Marek Vasut
On Tuesday, September 09, 2014 at 05:05:24 PM, Janusz Użycki wrote: [...] > >> If it is too fast a slave has possibility to inform by setting SCL low. > > > > Do you mean clock stretching ? > > Yes, I didn't notice it is the same. OK > >> However I haven't seen any driver which supports the m

Re: [PATCH] i2c-mxs: fixed PIO NACK error instead of timeout (1000ms)

2014-09-09 Thread Marek Vasut
On Tuesday, September 09, 2014 at 06:19:31 PM, Janusz Uzycki wrote: > i2cdetect scanned i2c bus very slow if address was not occupied by any > device. This still fails to explain how the patch fixes the issue. You see, I don't want to abuse you unnecessarily, but the commit message serves mostly

[PATCH v4 1/3] mfd: add support for Diolan DLN-2 devices

2014-09-09 Thread Octavian Purdila
This patch implements the USB part of the Diolan USB-I2C/SPI/GPIO Master Adapter DLN-2. Details about the device can be found here: https://www.diolan.com/i2c/i2c_interface.html. Information about the USB protocol can be found in the Programmer's Reference Manual [1], see section 1.7. Because th

[PATCH v4 0/3] mfd: add support for Diolan DLN-2

2014-09-09 Thread Octavian Purdila
This patch series adds support for Diolan USB-I2C/GPIO Master Adapter DLN-2. Details about device can be found here: https://www.diolan.com/i2c/i2c_interface.html. Changes since v3: * Mostly addressing latest review comments from Johan * MFD driver: more message size checks for responses, swi

[PATCH v4 2/3] i2c: add support for Diolan DLN-2 USB-I2C adapter

2014-09-09 Thread Octavian Purdila
From: Laurentiu Palcu This patch adds support for the Diolan DLN-2 I2C master module. Due to hardware limitations it does not support SMBUS quick commands. Information about the USB protocol interface can be found in the Programmer's Reference Manual [1], see section 6.2.2 for the I2C master mod

[PATCH v4 3/3] gpio: add support for the Diolan DLN-2 USB GPIO driver

2014-09-09 Thread Octavian Purdila
From: Daniel Baluta This patch adds GPIO and IRQ support for the Diolan DLN-2 GPIO module. Information about the USB protocol interface can be found in the Programmer's Reference Manual [1], see section 2.9 for the GPIO module commands and responses. [1] https://www.diolan.com/downloads/dln-api

Re: [RFC 2/4] i2c: slave: add eeprom simulator driver

2014-09-09 Thread Wolfram Sang
> +config I2C_SLAVE_EEPROM > + bool "I2C eeprom slave driver" This should be "tristate". Fixed in my branch. signature.asc Description: Digital signature

[PATCH] i2c-mxs: fixed error message in pio transfer

2014-09-09 Thread Janusz Uzycki
If I2C_M_RD flag is set SELECT command is sent and afterward READ command. The patch fixes READ command to return READ failure error message instead of SELECT failure error message. Signed-off-by: Janusz Uzycki --- drivers/i2c/busses/i2c-mxs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-

[PATCH] i2c-mxs: fixed PIO NACK error instead of timeout (1000ms)

2014-09-09 Thread Janusz Uzycki
i2cdetect scanned i2c bus very slow if address was not occupied by any device. Signed-off-by: Janusz Uzycki --- drivers/i2c/busses/i2c-mxs.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/i2c/busses/i2c-mxs.c b/drivers/i2c/busses/i2c-mxs.c index 87ee72d..35ae448 100644 --- a/dri

[RFC 1/4] i2c: core changes for slave support

2014-09-09 Thread Wolfram Sang
From: Wolfram Sang Signed-off-by: Wolfram Sang --- drivers/i2c/i2c-core.c | 44 include/linux/i2c.h| 22 ++ 2 files changed, 66 insertions(+) diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c index 632057a44615..67

Re: [PATCH 2/2] i2c-mxs: fixed PIO NACK error instead of timeout

2014-09-09 Thread Janusz Użycki
W dniu 2014-09-09 15:59, Marek Vasut pisze: On Tuesday, September 09, 2014 at 03:10:25 PM, Janusz Użycki wrote: W dniu 2014-09-09 14:48, Marek Vasut pisze: Shouldn't this check be used only after the 'SELECT' command ? It looks |||mxs_i2c_isr()| for DMA transfer does not differentiate command

[RFC 2/4] i2c: slave: add eeprom simulator driver

2014-09-09 Thread Wolfram Sang
From: Wolfram Sang Signed-off-by: Wolfram Sang --- drivers/i2c/Kconfig| 10 +++ drivers/i2c/Makefile | 1 + drivers/i2c/i2c-slave-eeprom.c | 152 + 3 files changed, 163 insertions(+) create mode 100644 drivers/i2c/i2c-slave-eepro

[RFC 3/4] i2c: rcar: add slave support

2014-09-09 Thread Wolfram Sang
From: Wolfram Sang Signed-off-by: Wolfram Sang --- drivers/i2c/busses/i2c-rcar.c | 122 ++ 1 file changed, 113 insertions(+), 9 deletions(-) diff --git a/drivers/i2c/busses/i2c-rcar.c b/drivers/i2c/busses/i2c-rcar.c index 1cc146cfc1f3..fe875d994441 10064

[RFC 4/4] ARM: shmobile: r8a7790: adapt DTS for I2C slave support

2014-09-09 Thread Wolfram Sang
From: Wolfram Sang Not for upstream! Signed-off-by: Wolfram Sang --- arch/arm/boot/dts/r8a7790-lager.dts | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/arch/arm/boot/dts/r8a7790-lager.dts b/arch/arm/boot/dts/r8a7790-lager.dts index 856b4236b674..12aa2f21e

[RFC 0/4] i2c: slave support framework for Linux devices

2014-09-09 Thread Wolfram Sang
Finally, here is my take on the often desired feature that Linux can not only be an I2C master, but also an I2C slave. Compared to my draft sent out last week, this RFC has been tested on hardware (Renesas Lager board) and works \o/ One big part still missing is documentation, so brave ones need t

Re: [PATCH 2/2] i2c-mxs: fixed PIO NACK error instead of timeout

2014-09-09 Thread Marek Vasut
On Tuesday, September 09, 2014 at 03:10:25 PM, Janusz Użycki wrote: > W dniu 2014-09-09 14:48, Marek Vasut pisze: > >>> Shouldn't this check be used only after the 'SELECT' command ? > >> > >> It looks |||mxs_i2c_isr()| for DMA transfer does not differentiate > >> commands also > >> and does not m

Re: [PATCH 2/2] i2c-mxs: fixed PIO NACK error instead of timeout

2014-09-09 Thread Janusz Użycki
W dniu 2014-09-09 14:48, Marek Vasut pisze: Shouldn't this check be used only after the 'SELECT' command ? It looks |||mxs_i2c_isr()| for DMA transfer does not differentiate commands also and does not mask irqs for each command. |STAT_GOT_A_NAK| is a separate bit.|CTRL1_NO_SLAVE_ACK_IRQ can b

Re: [PATCH 1/2] i2c-mxs: fixed error message in pio transfer

2014-09-09 Thread Marek Vasut
On Tuesday, September 09, 2014 at 10:16:34 AM, Janusz Użycki wrote: > W dniu 2014-09-08 20:14, Marek Vasut pisze: > > On Monday, September 08, 2014 at 08:04:22 PM, Janusz Użycki wrote: > > > > Thanks, but the Subject of the email doesn't make much sense. Also, a > > short commit message exlaining

Re: [PATCH 2/2] i2c-mxs: fixed PIO NACK error instead of timeout

2014-09-09 Thread Marek Vasut
On Tuesday, September 09, 2014 at 11:27:36 AM, Janusz Użycki wrote: > W dniu 2014-09-08 20:33, Marek Vasut pisze: > > On Monday, September 08, 2014 at 08:06:12 PM, Janusz Użycki wrote: > >> Subject: [PATCH 2/2] i2c-mxs: fixed PIO NACK error instead of timeout > >> > >>(1000ms) > >> > >> i2cde

[PATCH v4 5/9] i2c: core: Convert to dev_pm_domain_attach|detach()

2014-09-09 Thread Ulf Hansson
Previously only the ACPI PM domain was supported by the i2c bus. Let's convert to the common attach/detach functions for PM domains, which currently means we are extending the support to include the generic PM domain as well. Cc: linux-i2c@vger.kernel.org Signed-off-by: Ulf Hansson Reviewed-by:

Re: [PATCH v3 3/3] gpio: add support for the Diolan DLN-2 USB GPIO driver

2014-09-09 Thread Octavian Purdila
On Tue, Sep 9, 2014 at 12:36 PM, Johan Hovold wrote: > On Fri, Sep 05, 2014 at 07:04:51PM +0300, Octavian Purdila wrote: >> On Fri, Sep 5, 2014 at 6:38 PM, Johan Hovold wrote: >> > On Fri, Sep 05, 2014 at 06:17:59PM +0300, Octavian Purdila wrote: > >> > In general, how well have these patches bee

Re: [PATCH v3 3/3] gpio: add support for the Diolan DLN-2 USB GPIO driver

2014-09-09 Thread Johan Hovold
On Fri, Sep 05, 2014 at 07:04:51PM +0300, Octavian Purdila wrote: > On Fri, Sep 5, 2014 at 6:38 PM, Johan Hovold wrote: > > On Fri, Sep 05, 2014 at 06:17:59PM +0300, Octavian Purdila wrote: > > In general, how well have these patches been tested with disconnect > > events? At least gpiolib is kno

Re: [PATCH 2/2] i2c-mxs: fixed PIO NACK error instead of timeout

2014-09-09 Thread Janusz Użycki
W dniu 2014-09-08 20:33, Marek Vasut pisze: On Monday, September 08, 2014 at 08:06:12 PM, Janusz Użycki wrote: Subject: [PATCH 2/2] i2c-mxs: fixed PIO NACK error instead of timeout (1000ms) i2cdetect scanned i2c bus very slow if address was not occupied by any device. Shouldn't this check b

Re: [PATCH v3 2/3] i2c: add support for Diolan DLN-2 USB-I2C adapter

2014-09-09 Thread Lee Jones
On Mon, 08 Sep 2014, Octavian Purdila wrote: > On Mon, Sep 8, 2014 at 7:30 PM, Johan Hovold wrote: > > On Mon, Sep 08, 2014 at 06:57:29PM +0300, Octavian Purdila wrote: > >> On Mon, Sep 8, 2014 at 5:44 PM, Johan Hovold wrote: > >> > >> > >> > >> Hi Johan, > >> > >> Again, thanks for the detaile

Re: [PATCH 1/2] i2c-mxs: fixed error message in pio transfer

2014-09-09 Thread Janusz Użycki
W dniu 2014-09-08 20:14, Marek Vasut pisze: On Monday, September 08, 2014 at 08:04:22 PM, Janusz Użycki wrote: Thanks, but the Subject of the email doesn't make much sense. Also, a short commit message exlaining what you did and why you did it would be nice. While the patch is obvious and obvi