Re: [PATCH v4 2/3] i2c: iproc: Add Broadcom iProc I2C Driver

2015-01-17 Thread Uwe Kleine-König
Hello, On Fri, Jan 16, 2015 at 02:09:28PM -0800, Ray Jui wrote: > On 1/15/2015 12:41 AM, Uwe Kleine-König wrote: > > On Wed, Jan 14, 2015 at 02:23:32PM -0800, Ray Jui wrote: > >> + */ > >> + val = 1 << M_CMD_START_BUSY_SHIFT; > >> + if (msg->flags & I2C_M_RD) { > >> + val |= (M_CMD_PR

Re: [PATCH v4 2/3] i2c: iproc: Add Broadcom iProc I2C Driver

2015-01-17 Thread Ray Jui
On 1/17/2015 8:01 AM, Uwe Kleine-König wrote: > Hello, > > On Fri, Jan 16, 2015 at 02:09:28PM -0800, Ray Jui wrote: >> On 1/15/2015 12:41 AM, Uwe Kleine-König wrote: >>> On Wed, Jan 14, 2015 at 02:23:32PM -0800, Ray Jui wrote: + */ + val = 1 << M_CMD_START_BUSY_SHIFT; + if (ms

Re: [PATCH v4 2/3] i2c: iproc: Add Broadcom iProc I2C Driver

2015-01-17 Thread Uwe Kleine-König
Hello, On Sat, Jan 17, 2015 at 11:58:33AM -0800, Ray Jui wrote: > On 1/17/2015 8:01 AM, Uwe Kleine-König wrote: > > On Fri, Jan 16, 2015 at 02:09:28PM -0800, Ray Jui wrote: > >> On 1/15/2015 12:41 AM, Uwe Kleine-König wrote: > >>> On Wed, Jan 14, 2015 at 02:23:32PM -0800, Ray Jui wrote: > +

Re: [PATCH v4 2/3] i2c: iproc: Add Broadcom iProc I2C Driver

2015-01-17 Thread Ray Jui
On 1/17/2015 12:18 PM, Uwe Kleine-König wrote: > Hello, > > On Sat, Jan 17, 2015 at 11:58:33AM -0800, Ray Jui wrote: >> On 1/17/2015 8:01 AM, Uwe Kleine-König wrote: >>> On Fri, Jan 16, 2015 at 02:09:28PM -0800, Ray Jui wrote: On 1/15/2015 12:41 AM, Uwe Kleine-König wrote: > On Wed, Jan

Re: [PATCH v4 2/3] i2c: iproc: Add Broadcom iProc I2C Driver

2015-01-17 Thread Uwe Kleine-König
Hello, On Sat, Jan 17, 2015 at 12:51:50PM -0800, Ray Jui wrote: > On 1/17/2015 12:18 PM, Uwe Kleine-König wrote: > > Hello, > > > > On Sat, Jan 17, 2015 at 11:58:33AM -0800, Ray Jui wrote: > >> On 1/17/2015 8:01 AM, Uwe Kleine-König wrote: > >>> On Fri, Jan 16, 2015 at 02:09:28PM -0800, Ray Jui w

Re: [PATCH v4 2/3] i2c: iproc: Add Broadcom iProc I2C Driver

2015-01-17 Thread Ray Jui
On 1/17/2015 1:10 PM, Uwe Kleine-König wrote: > Hello, > > On Sat, Jan 17, 2015 at 12:51:50PM -0800, Ray Jui wrote: >> On 1/17/2015 12:18 PM, Uwe Kleine-König wrote: >>> Hello, >>> >>> On Sat, Jan 17, 2015 at 11:58:33AM -0800, Ray Jui wrote: On 1/17/2015 8:01 AM, Uwe Kleine-König wrote: >>>

Re: [PATCH v4 2/3] i2c: iproc: Add Broadcom iProc I2C Driver

2015-01-17 Thread Russell King - ARM Linux
On Sat, Jan 17, 2015 at 01:26:41PM -0800, Ray Jui wrote: > time_left = wait_for_completion_timeout(&iproc_i2c->done, time_left); > > /* disable all interrupts */ > writel(0, iproc_i2c->base + IE_OFFSET); > > if (!time_left && !atomic_read(&iproc_i2c->transfer_is_successful

Re: [PATCH v4 2/3] i2c: iproc: Add Broadcom iProc I2C Driver

2015-01-17 Thread Ray Jui
On 1/17/2015 2:40 PM, Russell King - ARM Linux wrote: > On Sat, Jan 17, 2015 at 01:26:41PM -0800, Ray Jui wrote: >> time_left = wait_for_completion_timeout(&iproc_i2c->done, time_left); >> >> /* disable all interrupts */ >> writel(0, iproc_i2c->base + IE_OFFSET); >> >> if (!ti

Re: [RFC 1/3] i2c: Enhancement of i2c API to address circular lock dependency problem

2015-01-17 Thread Tomasz Figa
Hi, [CCing more people] 2015-01-16 23:39 GMT+09:00 Paul Osmialowski : > This enhancement of i2c API is designed to address following problem > caused by circular lock dependency: > > -> #1 (prepare_lock){+.+.+.}: > [2.730502][] __lock_acquire+0x3c0/0x8a4 > [2.735970][] loc