Re: [PATCH-v5 5/5] i2c: pxa: Add ILCR (tLow & tHigh) configuration support

2015-08-05 Thread Vaibhav Hiremath
On Thursday 06 August 2015 12:41 AM, Robert Jarzmik wrote: My next slot is probably this comming Sunday. I'll do the test and report Thanks a lot. Thanks, Vaibhav -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majord...@vger.kernel.org Mor

Re: [RFT 1/2] i2c: rcar: add support for r8a7795 (R-Car H3)

2015-08-05 Thread Wolfram Sang
> My bad. I should go to bed. And so should you by the way ;-) Acked-by: Wolfram Sang signature.asc Description: Digital signature

Re: [PATCH v2 4/4] i2c: arb-gpio-challenge: use of_get_i2c_adapter_by_node interface

2015-08-05 Thread Wolfram Sang
On Mon, Jul 27, 2015 at 05:30:51PM +0300, Vladimir Zapolskiy wrote: > This change is needed to properly lock I2C parent bus driver. > > Prior to this change i2c_put_adapter() is misused, which may lead > to an overflow over zero of I2C bus driver user counter. > > By the way added a missing of_no

Re: [PATCH v2 3/4] i2c: core: add and export of_get_i2c_adapter_by_node() interface

2015-08-05 Thread Wolfram Sang
On Mon, Jul 27, 2015 at 05:30:50PM +0300, Vladimir Zapolskiy wrote: > of_find_i2c_adapter_by_node() call requires quite often missing > put_device(), and i2c_put_adapter() releases a device locked by > i2c_get_adapter() only. In general module_put(adapter->owner) and > put_device(dev) are not inter

Re: [PATCH v2 2/4] i2c: core: manage i2c bus device refcount in i2c_[get|put]_adapter

2015-08-05 Thread Wolfram Sang
On Mon, Jul 27, 2015 at 05:30:49PM +0300, Vladimir Zapolskiy wrote: > In addition to module_get()/module_put() add get_device()/put_device() > calls into i2c_get_adapter()/i2c_put_adapter() exported > interfaces. This is done to lock I2C bus device, if it is in use by a > client. > > Signed-off-by

Re: [RFT 1/2] i2c: rcar: add support for r8a7795 (R-Car H3)

2015-08-05 Thread Laurent Pinchart
On Thursday 06 August 2015 02:38:49 Wolfram Sang wrote: > On Thu, Aug 06, 2015 at 03:34:05AM +0300, Laurent Pinchart wrote: > > Hi Wolfram, > > > > Thank you for the patch. > > > > On Wednesday 05 August 2015 15:18:25 Wolfram Sang wrote: > > > From: Wolfram Sang > > > > > > Enable the I2C core

Re: [RFT 1/2] i2c: rcar: add support for r8a7795 (R-Car H3)

2015-08-05 Thread Wolfram Sang
On Thu, Aug 06, 2015 at 03:34:05AM +0300, Laurent Pinchart wrote: > Hi Wolfram, > > Thank you for the patch. > > On Wednesday 05 August 2015 15:18:25 Wolfram Sang wrote: > > From: Wolfram Sang > > > > Enable the I2C core for this SoC. I add a new type because this version > > has new features (

Re: [RFT 1/2] i2c: rcar: add support for r8a7795 (R-Car H3)

2015-08-05 Thread Laurent Pinchart
Hi Wolfram, Thank you for the patch. On Wednesday 05 August 2015 15:18:25 Wolfram Sang wrote: > From: Wolfram Sang > > Enable the I2C core for this SoC. I add a new type because this version > has new features (e.g. DMA) which will be added somewhen later. > > Signed-off-by: Wolfram Sang > --

Re: [RFT 1/2] i2c: rcar: add support for r8a7795 (R-Car H3)

2015-08-05 Thread Simon Horman
On Wed, Aug 05, 2015 at 03:18:25PM +0200, Wolfram Sang wrote: > From: Wolfram Sang > > Enable the I2C core for this SoC. I add a new type because this version > has new features (e.g. DMA) which will be added somewhen later. Minor nit: s/somewhen/sometime/ or: s/somewhen // > Signed-off-by: Wol

Re: [PATCH-v5 5/5] i2c: pxa: Add ILCR (tLow & tHigh) configuration support

2015-08-05 Thread Robert Jarzmik
Vaibhav Hiremath writes: > Robert, > > It would be helpful if you can test this patch-series and confirm that > it now fixes the NULL pointer deference issue. > > Thanks, > Vaibhav Hi Vaibhav, My next slot is probably this comming Sunday. I'll do the test and report. Cheers. -- Robert -- To u

Re: [PATCH-v5 1/5] Documentation: binding: add new property 'disable_after_xfer' to i2c-pxa

2015-08-05 Thread Matt Porter
On Wed, Aug 05, 2015 at 10:49:18AM +0200, Wolfram Sang wrote: > > > Yeah, we could start i2c.txt, probably better to have separate new > > patch all together. > > I will start such a file today as part of the i2c slave framework > update which introduces flags to the reg property. Will post to th

Re: [PATCH-v5 1/5] Documentation: binding: add new property 'disable_after_xfer' to i2c-pxa

2015-08-05 Thread Vaibhav Hiremath
On Wednesday 05 August 2015 07:50 PM, Matt Porter wrote: On Wed, Aug 05, 2015 at 12:04:25PM +0530, Vaibhav Hiremath wrote: On Monday 27 July 2015 07:39 PM, Matt Porter wrote: On Tue, Jul 21, 2015 at 06:11:02PM +0530, Vaibhav Hiremath wrote: Driver will now supports enable/disable across ms

Re: [PATCH-v5 1/5] Documentation: binding: add new property 'disable_after_xfer' to i2c-pxa

2015-08-05 Thread Matt Porter
On Wed, Aug 05, 2015 at 12:04:25PM +0530, Vaibhav Hiremath wrote: > > > On Monday 27 July 2015 07:39 PM, Matt Porter wrote: > >On Tue, Jul 21, 2015 at 06:11:02PM +0530, Vaibhav Hiremath wrote: > >>Driver will now supports enable/disable across msg xfer, which user > >>can control it by new DT pro

Re: [PATCH] i2c: allow specifying separate wakeup interrupt in device tree

2015-08-05 Thread Tony Lindgren
* Dmitry Torokhov [150803 13:05]: > On Mon, Aug 03, 2015 at 03:21:21AM -0700, Tony Lindgren wrote: > > > > Hmm why do we need the check for if (device_can_wakeup(&client->dev)))? > > Because of the code in device_wakeup_attach_irq(): > > ws = dev->power.wakeup; > if (!ws) { >

[RFT 0/2] i2c: add support for r8a7795 (RCar H3)

2015-08-05 Thread Wolfram Sang
Here are the driver updates to support this new SoC. Since I don't have HW access, this is a request for testing. The IP cores are backwards compatible to Gen2. So, as long as the clocks are properly setup and the bus speed is OK, the rest should work out of the box. Question: Shall I prototype th

[RFT 1/2] i2c: rcar: add support for r8a7795 (R-Car H3)

2015-08-05 Thread Wolfram Sang
From: Wolfram Sang Enable the I2C core for this SoC. I add a new type because this version has new features (e.g. DMA) which will be added somewhen later. Signed-off-by: Wolfram Sang --- Documentation/devicetree/bindings/i2c/i2c-rcar.txt | 1 + drivers/i2c/busses/i2c-rcar.c

[RFT 2/2] i2c: sh_mobile: add support for r8a7795 (R-Car H3)

2015-08-05 Thread Wolfram Sang
From: Wolfram Sang Enable the I2C core for this SoC. It is compitable to Gen2 SoCs, so reuse the settings. Signed-off-by: Wolfram Sang --- Documentation/devicetree/bindings/i2c/i2c-sh_mobile.txt | 1 + drivers/i2c/busses/i2c-sh_mobile.c | 1 + 2 files changed, 2 insertions

Re: [PATCH-v5 2/5] i2c: pxa: enable/disable i2c module across msg xfer

2015-08-05 Thread Vaibhav Hiremath
On Wednesday 05 August 2015 04:16 PM, Shubhrajyoti Datta wrote: hi , On Tue, Jul 21, 2015 at 6:11 PM, Vaibhav Hiremath wrote: From: Yi Zhang Enable i2c module/unit before transmission and disable when it finishes. why? It's because the i2c bus may be disturbed if the slave device, typicall

Re: [PATCH-v5 2/5] i2c: pxa: enable/disable i2c module across msg xfer

2015-08-05 Thread Shubhrajyoti Datta
hi , On Tue, Jul 21, 2015 at 6:11 PM, Vaibhav Hiremath wrote: > From: Yi Zhang > > Enable i2c module/unit before transmission and disable when it > finishes. > > why? > It's because the i2c bus may be disturbed if the slave device, > typically a touch, powers on. Why should that be an issue? Is

Re: [PATCH-v5 1/5] Documentation: binding: add new property 'disable_after_xfer' to i2c-pxa

2015-08-05 Thread Vaibhav Hiremath
On Wednesday 05 August 2015 02:19 PM, Wolfram Sang wrote: I will start such a file today as part of the i2c slave framework update which introduces flags to the reg property. Will post to the i2c list this week. Great and thanks for taking this. I believe, better to wait for your patch and t

Re: [PATCH-v5 5/5] i2c: pxa: Add ILCR (tLow & tHigh) configuration support

2015-08-05 Thread Vaibhav Hiremath
On Tuesday 21 July 2015 06:11 PM, Vaibhav Hiremath wrote: With addition of PXA910 family of devices, the TWSI module supports SCL clock adjustment using ILCR register. This patch enables the control and configuration of ICLR through DT properties, i2c-sclk-high-time-ns: SCLK high time (tHi

Re: [PATCH-v5 1/5] Documentation: binding: add new property 'disable_after_xfer' to i2c-pxa

2015-08-05 Thread Wolfram Sang
> Yeah, we could start i2c.txt, probably better to have separate new > patch all together. I will start such a file today as part of the i2c slave framework update which introduces flags to the reg property. Will post to the i2c list this week. signature.asc Description: Digital signature