Re: [PATCH] i2c: s3c2410: remove superfluous runtime PM calls

2015-12-17 Thread Charles Keepax
x27;t seem to have any adverse effect on them that I can find. Tested-by: Charles Keepax > IIRC client's pm_runtime* calls return error if their parent device's > runtime PM is not enabled. Also enabling runtime PM on the i2c adapter > allows propagating runtime PM calls up to its

Re: Handling clocks on external busses

2015-12-02 Thread Charles Keepax
On Tue, Nov 24, 2015 at 05:37:18PM +, Charles Keepax wrote: > Hi, > > When a clock driver is controlling a clock that is controlled > over I2C / SPI, we need to perform a write on that bus to enable > the clock. However, such busses often have their own clocks that > must

Handling clocks on external busses

2015-11-24 Thread Charles Keepax
Hi, When a clock driver is controlling a clock that is controlled over I2C / SPI, we need to perform a write on that bus to enable the clock. However, such busses often have their own clocks that must be enabled. Since all clock prepares are controlled under one large mutex this easily causes dead

[PATCH v2] i2c: Mark adapter devices with pm_runtime_no_callbacks

2015-04-16 Thread Charles Keepax
have any. Signed-off-by: Charles Keepax --- Changes since v1: - Simple mark all adapter devices with pm_runtime_no_callbacks in the i2c core Thanks, Charles drivers/i2c/i2c-core.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c

Re: [PATCH] i2c: s3c2410: Don't enable PM runtime on the adapter device

2015-04-16 Thread Charles Keepax
On Thu, Apr 16, 2015 at 12:39:43PM +0200, Lars-Peter Clausen wrote: > On 04/16/2015 12:33 PM, Sylwester Nawrocki wrote: >> On 16/04/15 12:10, Charles Keepax wrote: >>> Commit 523c5b89640e ("i2c: Remove support for legacy PM") removed the PM >>> ops from the bus

[PATCH] i2c: s3c2410: Don't enable PM runtime on the adapter device

2015-04-16 Thread Charles Keepax
ce in the driver and adding some stub callbacks for runtime suspend and resume. Signed-off-by: Charles Keepax --- drivers/i2c/busses/i2c-s3c2410.c | 21 - 1 files changed, 16 insertions(+), 5 deletions(-) diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses

Re: [PATCH] I2C: BCM2835: Linking platform nodes to adapter nodes

2013-11-26 Thread Charles Keepax
On Fri, Nov 08, 2013 at 09:59:28AM -0700, Stephen Warren wrote: > On 11/08/2013 02:49 AM, Florian Meier wrote: > > In order to find I2C devices in the device tree, the platform nodes > > have to be known by the I2C core. Analogous to the i2c-omap driver > > this requires setting the dev.of_node par