Re: [PATCHv3 8/8] i2c: omap: cleanup the sysc write

2012-11-05 Thread Cousson, Benoit
On 11/5/2012 3:25 PM, Felipe Balbi wrote: Hi, On Mon, Nov 05, 2012 at 07:53:45PM +0530, Shubhrajyoti wrote: On Monday 05 November 2012 07:44 PM, Felipe Balbi wrote: - dev->syscstate); - } not sure if this will work. What abo

Re: [PATCH] I2C: OMAP: fix build breakage when CONFIG_OF is not set

2012-02-08 Thread Cousson, Benoit
Hi Luca, On 2/8/2012 12:25 PM, Luciano Coelho wrote: On Wed, 2012-02-08 at 16:42 +0530, Shubhrajyoti Datta wrote: On Wed, Feb 8, 2012 at 4:34 PM, Luciano Coelho wrote: On Wed, 2012-02-08 at 12:59 +0200, Felipe Balbi wrote: On Wed, Feb 08, 2012 at 12:56:52PM +0200, Luciano Coelho wrote: Sinc

Re: [PATCHv8 4/5] OMAP: I2C: Remove the reset in the init path

2012-01-12 Thread Cousson, Benoit
On 1/11/2012 4:22 PM, Paul Walmsley wrote: On Wed, 11 Jan 2012, Cousson, Benoit wrote: Something that puzzle me on that point is most architecture does not use plateform_device and thus does not have any pdata to hack some custom function pointers here an there. It means that there is probably

Re: [PATCHv8 4/5] OMAP: I2C: Remove the reset in the init path

2012-01-11 Thread Cousson, Benoit
On 1/11/2012 2:29 PM, Paul Walmsley wrote: On Wed, 11 Jan 2012, Shubhrajyoti wrote: On Tuesday 10 January 2012 08:56 PM, Kevin Hilman wrote: "Datta, Shubhrajyoti" writes: On Tue, Jan 10, 2012 at 11:53 AM, Datta, Shubhrajyoti wrote: On Fri, Dec 16, 2011 at 2:29 PM, Shubhrajyoti wrote:

Re: [PATCH v4 03/12] mfd: twl-core: Add initial DT support for twl4030/twl6030

2012-01-03 Thread Cousson, Benoit
On 1/2/2012 10:04 AM, Grant Likely wrote: > On Thu, Dec 22, 2011 at 03:56:37PM +0100, Benoit Cousson wrote: >> Add initial device-tree support for twl familly chips. >> The current version is missing the regulator entries due >> to the lack of DT regulator bindings for the moment. >> Only the simpl

Re: [PATCHv8 3/5] OMAP: I2C: Reset support

2011-12-16 Thread Cousson, Benoit
Hi Shubhro, On 12/13/2011 11:55 AM, Shubhrajyoti D wrote: Under some error conditions the i2c driver may do a reset. Adding a reset field and support in the device-specific code to aid error-recovery. Signed-off-by: Shubhrajyoti D --- arch/arm/plat-omap/i2c.c |2 ++ include/linux/i2c-oma

Re: [PATCH V2] I2C: Fix for suspend/resume issue in i2c-core

2010-09-04 Thread Cousson, Benoit
Hi Vishwa, I just have a couple of minors comments: On 9/4/2010 10:48 AM, Sripathy, Vishwanath wrote: In current i2c core driver, call to pm_runtime_set_active from i2c_device_pm_resume will unconditionally enable i2c module and increment child count of the parent. Because of this, in CPU Idle