Re: touchscreen: edt-ft5x06: Prevent DMA driver from mapping an area on stack

On Sat, Dec 12, 2015 at 06:13:55PM +0100, Wolfram Sang wrote: > > > Frankly speaking I do not know where the fix should actually be. I2C IMX > > driver somehow taking care of this or the users of I2C, touchscreen drivers > > in this case. In my opinion, the fix should be with the touchscreen

Re: [PATCH] i2c: core: fix wakeup irq parsing

On Thu, Nov 12, 2015 at 03:42:26PM +0200, Grygorii Strashko wrote: > This patch fixes obvious copy-past error in wake up irq parsing > code which leads to the fact that dev_pm_set_wake_irq() will > be called with wrong IRQ number when "wakeup" IRQ is not > defined in DT. &g

Re: [PATCH v2] i2c: return probe deferred status on dev_pm_domain_attach

On Mon, Oct 12, 2015 at 12:49 PM, Kieran Bingham wrote: > A change of return status was introduced in commit 3fffd1283927 > ("i2c: allow specifying separate wakeup interrupt in device tree") > > The commit prevents the defer status being passed up the call stack >

Re: [PATCH v3] i2c: return probe deferred status on dev_pm_domain_attach

k > appropriately when dev_pm_domain_attach returns -EPROBE_DEFER. > > Catch the PROBE_DEFER and clear up the IRQ wakeup status > > Signed-off-by: Kieran Bingham <kieranbing...@gmail.com> > Fixes: 3fffd1283927 ("i2c: allow specifying separate wakeup > interrupt in dev

Re: [PATCH] i2c: allow specifying separate wakeup interrupt in device tree

Hi Wolfram, On Wed, Aug 19, 2015 at 10:43 AM, Wolfram Sang w...@the-dreams.de wrote: @@ -659,20 +662,47 @@ static int i2c_device_probe(struct device *dev) if (!device_can_wakeup(client-dev)) device_init_wakeup(client-dev,

[PATCH v2] i2c: allow specifying separate wakeup interrupt in device tree

interrupt for the device should use named interrupt syntax in their DTSes: interrupt-parent = intc1; interrupts = 5 0, 6 0; interrupt-names = irq, wakeup; This patch is inspired by work done by Vignesh R vigne...@ti.com for pixcir_i2c_ts driver. Signed-off-by: Dmitry

Re: [PATCH] i2c: allow specifying separate wakeup interrupt in device tree

On Sun, Aug 09, 2015 at 05:22:55PM +0200, Wolfram Sang wrote: On Thu, Jul 30, 2015 at 01:14:31PM -0700, Dmitry Torokhov wrote: Instead of having each i2c driver individually parse device tree data in case it or platform supports separate wakeup interrupt, and handle enabling and disabling

Re: [PATCH] i2c: allow specifying separate wakeup interrupt in device tree

Hi Tony, On Mon, Aug 03, 2015 at 03:21:21AM -0700, Tony Lindgren wrote: * Vignesh R vigne...@ti.com [150731 04:00]: On 07/31/2015 01:44 AM, Dmitry Torokhov wrote: Instead of having each i2c driver individually parse device tree data in case it or platform supports separate wakeup

[PATCH] i2c: allow specifying separate wakeup interrupt in device tree

interrupt for the device should use named interrupt syntax in their DTSes: interrupt-parent = intc1; interrupts = 5 0, 6 0; interrupt-names = irq, wakeup; This patch is inspired by work done by Vignesh R vigne...@ti.com for pixcir_i2c_ts driver. Signed-off-by: Dmitry

Re: [PATCH 00/27] Export I2C and OF module aliases in missing drivers

Hi Javier, On Thu, Jul 30, 2015 at 06:18:25PM +0200, Javier Martinez Canillas wrote: Hello, Short version: This series add the missing MODULE_DEVICE_TABLE() for OF and I2C tables to export that information so modules have the correct aliases built-in and autoloading works correctly.

Re: [PATCH 00/27] Export I2C and OF module aliases in missing drivers

On Thu, Jul 30, 2015 at 09:35:17AM -0700, Dmitry Torokhov wrote: Hi Javier, On Thu, Jul 30, 2015 at 06:18:25PM +0200, Javier Martinez Canillas wrote: Hello, Short version: This series add the missing MODULE_DEVICE_TABLE() for OF and I2C tables to export that information so

Re: [PATCH] of/irq: introduce of_has_named_irqs helper

On Tue, Jul 28, 2015 at 06:53:52PM +0530, Vignesh R wrote: Hi Dmitry, On 07/25/2015 01:46 AM, Dmitry Torokhov wrote: On Fri, Jul 24, 2015 at 12:26:19PM -0700, Dmitry Torokhov wrote: On Fri, Jul 24, 2015 at 02:14:57PM -0500, Rob Herring wrote: On Fri, Jul 24, 2015 at 1:26 PM, Dmitry

Re: [PATCH] of/irq: introduce of_has_named_irqs helper

On Tue, Jul 28, 2015 at 11:16:44PM +0530, R, Vignesh wrote: Hi, On 7/28/2015 10:53 PM, Dmitry Torokhov wrote: On Tue, Jul 28, 2015 at 06:53:52PM +0530, Vignesh R wrote: Hi Dmitry, On 07/25/2015 01:46 AM, Dmitry Torokhov wrote: On Fri, Jul 24, 2015 at 12:26:19PM -0700, Dmitry Torokhov

Re: [PATCH] of/irq: introduce of_has_named_irqs helper

On Fri, Jul 24, 2015 at 12:26:19PM -0700, Dmitry Torokhov wrote: On Fri, Jul 24, 2015 at 02:14:57PM -0500, Rob Herring wrote: On Fri, Jul 24, 2015 at 1:26 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: Sometimes drivers might wish to transition from index-based to named interrupt

Re: [PATCH v2 0/2] Fix OF match for adxl34x driver

On Thu, May 21, 2015 at 01:42:24PM +0200, Geert Uytterhoeven wrote: Hi Dmitry, This is a resent of a series by Laurent Pinchart to fix OF matching for the adxl34x driver. According to the discussion in response to that series, we were under the impression this was going in through

[PATCH] i2c: rk3x: report number of messages transmitted

master_xfer() method should return number of i2c messages transferred, but on Rockchip we were usually returning just 1, which caused trouble with users that actually check number of transferred messages vs. checking for negative error codes. Signed-off-by: Dmitry Torokhov dmitry.torok

Re: Bug in i2c-core?

On Fri, Feb 27, 2015 at 08:59:44AM -0800, Dmitry Torokhov wrote: On Fri, Feb 27, 2015 at 12:09:51PM +0100, Sébastien SZYMANSKI wrote: Hi, I am writing an I2C touchscreen driver for an i.MX6 based board. I compiled it as a module and when I unload it, I get the following warning

Re: Bug in i2c-core?

On Fri, Feb 27, 2015 at 12:09:51PM +0100, Sébastien SZYMANSKI wrote: Hi, I am writing an I2C touchscreen driver for an i.MX6 based board. I compiled it as a module and when I unload it, I get the following warning: # modprobe sx8654 [ 46.261494] input: SX8654 I2C Touchscreen as

Re: Bug in i2c-core?

On February 27, 2015 6:37:25 AM PST, Thomas Petazzoni thomas.petazz...@free-electrons.com wrote: Dear Sébastien SZYMANSKI, On Fri, 27 Feb 2015 12:09:51 +0100, Sébastien SZYMANSKI wrote: error = input_register_device(sx8654-input); if (error) return error;

Re: [v7,2/3] i2c: iproc: Add Broadcom iProc I2C Driver

On Fri, Feb 6, 2015 at 2:31 PM, Kevin Cernekee cerne...@chromium.org wrote: On Mon, Jan 19, 2015 at 01:51:49PM -0800, Ray Jui wrote: + + dev_dbg(iproc_i2c-device, xfer %c, addr=0x%02x, len=%d\n, + (msg-flags I2C_M_RD) ? 'R' : 'W', msg-addr, + msg-len); +

[PATCH] i2c: do not try to load modules for of-registered devices

, as well as I2C itself when not using device tree, do not try to load modules, but rather rely on the standard infrastructure (udev) to execute module loading, and we should be doing the same. Signed-off-by: Dmitry Torokhov dmitry.torok...@gmail.com --- drivers/i2c/i2c-core.c | 2 -- 1 file changed

Re: [PATCH v2 2/2] input: adxl34x: Add OF match support

On Thu, Jan 15, 2015 at 06:45:33PM +0100, Geert Uytterhoeven wrote: On Thu, Jan 15, 2015 at 3:54 PM, Laurent Pinchart laurent.pinchart+rene...@ideasonboard.com wrote: The I2C subsystem can match devices without explicit OF support based on the part of their compatible property after the

Re: [PATCH v2 1/2] DT: i2c: Deprecate adi,adxl34x compatible string

On Thu, Jan 15, 2015 at 06:02:09PM +0100, Wolfram Sang wrote: On Thu, Jan 15, 2015 at 04:54:14PM +0200, Laurent Pinchart wrote: DT nodes should use the more specific adi,adxl345 and adi,adxl346 compatible values instead. As the ADXL346 is backward-compatible with the ADXL345, ADXL346 nodes

Re: [PATCH v2 2/2] input: adxl34x: Add OF match support

On Thu, Jan 15, 2015 at 10:34:29PM +0200, Laurent Pinchart wrote: On Thursday 15 January 2015 21:00:37 Geert Uytterhoeven wrote: On Thu, Jan 15, 2015 at 7:54 PM, Dmitry Torokhov wrote: I still do not understand what we are trying to fix here. Why is adi,adxl34x compatible string no good

Re: [PATCH v2 2/2] input: adxl34x: Add OF match support

On Thu, Jan 15, 2015 at 11:34:00PM +0200, Laurent Pinchart wrote: On Thursday 15 January 2015 13:06:32 Dmitry Torokhov wrote: On Thu, Jan 15, 2015 at 10:34:29PM +0200, Laurent Pinchart wrote: On Thursday 15 January 2015 21:00:37 Geert Uytterhoeven wrote: On Thu, Jan 15, 2015 at 7:54 PM

Re: [PATCH v2 0/7] Second batch of cleanups for cros_ec

On Mon, Aug 25, 2014 at 03:40:01PM +0200, Javier Martinez Canillas wrote: This is a second batch of cleanups patches for the mfd cros_ec driver and its subdevices drivers. The first batch of cleanups was posted by Doug Anderson [0] and have already been merged. The patches were picked from the

Re: [PATCH v2 0/7] Second batch of cleanups for cros_ec

On Mon, Aug 25, 2014 at 07:28:01PM +0200, Javier Martinez Canillas wrote: Hello Dmitry, On 08/25/2014 07:05 PM, Dmitry Torokhov wrote: Patches #1, #2, #6 and #7 do not depend of others so they can be merged independently but patches #3, #4 and #5 have to be merged in that specific

Re: [PATCH v3] i2c: rk3x: fix bug that cause transfer fails in master receive mode

Hi Addy, On Fri, Aug 22, 2014 at 09:13:11AM +0800, Addy Ke wrote: In rk3x SOC, the I2C controller can receive/transmit up to 32 bytes data in one chunk, so the size of data to be write/read to/from TXDATAx/RXDATAx must be less than or equal 32 bytes at a time. Tested on rk3288-pinky board,

Re: [PATCH v2 07/10] mfd: cros_ec: cleanup: Remove EC wrapper functions

Reviewed-by: Simon Glass s...@chromium.org For the I2C part: Acked-by: Wolfram Sang w...@the-dreams.de I'm good with input bits as well. Acked-by: Dmitry Torokhov dmitry.torok...@gmail.com Thanks. -- Dmitry -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body

[PATCH] I2C: i2c-pxa - remove incorrect __exit annotations

The remove() methods should not be marked __exit unless we are using platform_driver_probe() which disables unbinding device from driver via sysfs. Signed-off-by: Dmitry Torokhov dmitry.torok...@gmail.com --- Compiled only, no hardware. drivers/i2c/busses/i2c-pxa.c | 4 ++-- 1 file changed, 2

Re: [PATCH] I2C: add i2c_master_send_exact() and friends

On Sat, Feb 16, 2013 at 10:25:24PM +0100, Jean Delvare wrote: Hi Dmitry, On Fri, 15 Feb 2013 18:42:35 -0800, Dmitry Torokhov wrote: Many i2c users consider short transfers to be an error and would prefer getting -EIO instead of a positive return value and having to convert it to error

[PATCH] I2C: add i2c_master_send_exact() and friends

() i2c_transfer_exact() Signed-off-by: Dmitry Torokhov dmitry.torok...@gmail.com --- Resending to Wolfram's new address... drivers/i2c/i2c-core.c | 69 include/linux/i2c.h| 11 2 files changed, 80 insertions(+) diff --git a/drivers/i2c/i2c

Re: [PATCH v2] Support Elan Touchscreen eKTF product.

On Thu, Oct 25, 2012 at 12:32:39PM +0800, 劉嘉駿 wrote: Hi Dmitry, Thanks for review. -Original Message- From: Dmitry Torokhov [mailto:dmitry.torok...@gmail.com] Sent: Thursday, October 25, 2012 2:13 AM To: Scott Liu Cc: linux-in...@vger.kernel.org; linux-i2c

Re: [PATCH v2] Support Elan Touchscreen eKTF product.

Hi Scott, On Wed, Oct 24, 2012 at 09:41:43AM +0800, Scott Liu wrote: This patch is for Elan eKTF Touchscreen product, I2C adpater module. Signed-off-by: Scott Liu scott@emc.com.tw --- Hi, v2 revision I have fixed some bug as your advise. 1. To target the mainline

Re: [PATCH v1] Support Elan Touchscreen eKTF product.

On Mon, Oct 22, 2012 at 11:47:42AM +0800, Jian-Jhong Ding wrote: Scott Liu scott@emc.com.tw writes: + +struct mt_device { + struct mt_slot curdata; /* placeholder of incoming data */ + __u8 num_received; /* how many contacts we received */ + __u8 num_expected; /*

Re: [PATCH 2/4] input: Convert struct i2c_msg initialization to C99 format

On Wed, Oct 10, 2012 at 05:05:39PM +0530, Shubhrajyoti Datta wrote: On Wed, Oct 10, 2012 at 2:32 PM, Jean Delvare kh...@linux-fr.org wrote: On Tue, 9 Oct 2012 17:01:18 +0530, Shubhrajyoti D wrote: [...] Acked-by: Jean Delvare kh...@linux-fr.org thanks updated patch below From

Re: [PATCH v1] i2c-hid: introduce HID over i2c specification implementation

Hi Benjamin, A few random comments... On Fri, Sep 14, 2012 at 03:41:43PM +0200, benjamin.tissoires wrote: From: Benjamin Tissoires benjamin.tissoi...@enac.fr Microsoft published the protocol specification of HID over i2c:

Re: [PATCH V2] input:ad7879-i2c use swapped varient of i2c_smbus_read_word_data

On Fri, Oct 21, 2011 at 05:14:45PM +0100, Jonathan Cameron wrote: On 10/21/11 17:09, Dmitry Torokhov wrote: On Fri, Oct 21, 2011 at 12:57:16PM +0100, Jonathan Cameron wrote: This varient was introduced in i2c: boilerplate function for byte swapped smbus_write/read_word_data This also

Re: [PATCH] input/keyboard: Remove obsolete cleanup for clientdata

Sang w.s...@pengutronix.de Cc: Dmitry Torokhov dmitry.torok...@gmail.com Cc: Bo Shen voice.s...@atmel.com Cc: Axel Lin axel@gmail.com Acked-by: Jean Delvare kh...@linux-fr.org Applied, thanks Wolfram. -- Dmitry -- To unsubscribe from this list: send the line unsubscribe linux-i2c

Re: [PATCH 1/2] pwm: Add stubs for pwm operations

On Wed, May 18, 2011 at 10:48:45AM +0530, Mohan Pallaka wrote: Chip drivers that support both pwm and non-pwm modes would encounter compilation errors if the platform doesn't have support for pwm, even though the chip is programmed to work in non-pwm mode. Add stubs for pwm functions to avoid

Re: [PATCH 1/2] pwm: Add __weak attributed functions for pwm operations

On Fri, May 13, 2011 at 06:13:21PM +0530, Mohan Pallaka wrote: For chip drivers that support both pwm and non-pwm modes would encounter compilation errors if the platform doesn't have support for pwm though the chip is programmed to work in non-pwm mode. Add __weak attributed pwm functions to

Re: [PATCH 1/2] pwm: Add __weak attributed functions for pwm operations

On Fri, May 13, 2011 at 06:13:21PM +0530, Mohan Pallaka wrote: For chip drivers that support both pwm and non-pwm modes would encounter compilation errors if the platform doesn't have support for pwm though the chip is programmed to work in non-pwm mode. Add __weak attributed pwm functions to

Re: [PATCH] Driver for TC35894XBG keypad controller

On Tue, Oct 05, 2010 at 05:19:18PM +0100, Alan Cox wrote: + +/* + * Largest keycode that the chip can send, plus one, + * so keys can be mapped directly at the index of the + * TC35894XBG keycode instead of subtracting one. + */ +#define TC35894XBG_KEYMAP_SIZE (0x7f + 1) + +#define

Re: [PATCH 1/3] drivers: misc: ak8974 / ami305 magnetometer driver

have a mix of submissions pending which variously use misc + sysfs sysfs input (reporting X Y Z etc axes) About year ago I send driver for the same chip with input-device interface. During that time I asked from Dmitry Torokhov that is that a correct interface

Re: [PATCH] i2c: cyttsp i2c touchscreen driver init submit

On Tue, Jul 13, 2010 at 01:01:32PM +0530, Trilok Soni wrote: Hi Kevin, Thanks for posting this driver. Adding Jean Delvar for i2c bits. On 7/13/2010 2:26 AM, Kevin McNeely wrote: From: Fred f...@ubuntu.linuxcertified.com E-mail id looks wrong. Do you mean f...@cypress.com?

Re: [PATCH] drivers: remove all i2c_set_clientdata(client, NULL)

On Mon, May 31, 2010 at 10:48:32PM +0100, Richard Purdie wrote: On Mon, 2010-05-31 at 12:09 -0700, Dmitry Torokhov wrote: On Mon, May 31, 2010 at 02:55:48PM +0200, Wolfram Sang wrote: I2C-drivers can use the clientdata-pointer to point to private data. As I2C devices are not really

Re: your mail

On Thu, Apr 15, 2010 at 07:41:22PM -0400, Rafi Rubin wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 + if (ts-tc.event_sended == false) { We set event_sended to false immediately before calling cy8ctmg110_send_event() so I do not see the point of this flag. On that note: $

Re: [PATCH 06/24] input/keyboard: fix dangling pointers

Hi Wolfram, On Sat, Mar 20, 2010 at 03:12:47PM +0100, Wolfram Sang wrote: Fix I2C-drivers which missed setting clientdata to NULL before freeing the structure it points to. Also fix drivers which do this _after_ the structure was freed already. I am not sure if setting clientdata to NULL

Re: Threaded interrupts for synaptic touchscreen in HTC dream

Hi Thomas, On Wed, Jul 22, 2009 at 02:58:24PM +0200, Thomas Gleixner wrote: Mark, On Wed, 22 Jul 2009, Mark Brown wrote: On Wed, Jul 22, 2009 at 12:44:01PM +0200, Thomas Gleixner wrote: On Tue, 21 Jul 2009, Mark Brown wrote: I'll need to have a more detailed look at that but

Re: Threaded interrupts for synaptic touchscreen in HTC dream

On Tue, Jul 21, 2009 at 01:49:33PM +0100, Mark Brown wrote: On Tue, Jul 21, 2009 at 06:00:07PM +0530, Trilok Soni wrote: Hopefully, this thread can give all details about threaded irq discussion. http://lkml.org/lkml/2009/2/27/255 Yes, I'm aware of that - I read it at the time. It

Re: Threaded interrupts for synaptic touchscreen in HTC dream

On Tue, Jul 21, 2009 at 10:30:26PM +0200, Thomas Gleixner wrote: On Tue, 21 Jul 2009, Dmitry Torokhov wrote: On Tue, Jul 21, 2009 at 01:49:33PM +0100, Mark Brown wrote: On Tue, Jul 21, 2009 at 06:00:07PM +0530, Trilok Soni wrote: Hopefully, this thread can give all details about