Re: [PATCH 0/8] i2c: img-scb: fixes to support i2c on pistachio

2015-09-07 Thread Ezequiel Garcia
On 7 September 2015 at 10:50, Wolfram Sang wrote: > >> > That sounds like good testing \o/ If you are happy with i2ctransfer, >> > then please consider adding Tested-by tags to the i2ctransfer patches, >> > so Jean gets a more cosy feeling to include them to i2ctools. >> > >> >> Definitely! i2ctra

Re: [PATCH 0/8] i2c: img-scb: fixes to support i2c on pistachio

2015-09-07 Thread Ezequiel Garcia
Wolfram, Jean: On 31 July 2015 at 08:12, Wolfram Sang wrote: > On Mon, Jul 27, 2015 at 12:47:13PM +0100, Sifan Naeem wrote: >> Following patches are required to fix the existing driver to >> support i2c on pistachio. >> >> Tested on Pistachio bub using an Adafruit I2C Non-Volatile FRAM Breakout >

Re: [PATCH v2 1/2] i2c: add i2c-lpc2k driver

2015-08-17 Thread Ezequiel Garcia
d}_poll_timeout_{atomic} here. Ccing Ariel, maybe he can help with a test. -- Ezequiel Garcia, VanguardiaSur www.vanguardiasur.com.ar -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC] i2c: designware: Avoid initcall and initialize the driver like a regular one

2014-12-23 Thread Ezequiel Garcia
i2c_designware >> drivers/i2c/busses/i2c-designware-pcidrv.c:MODULE_ALIAS("i2c_designware-pci"); >> drivers/i2c/busses/i2c-designware-platdrv.c:MODULE_ALIAS("platform:i2c_designware"); >> drivers/i2c/busses/i2c-designware-platdrv.c:.name = >&g

Re: [RFC] i2c: designware: Avoid initcall and initialize the driver like a regular one

2014-12-23 Thread Ezequiel Garcia
nes instead. However, a quick look shows there aren't any! $ git grep i2c_designware drivers/i2c/busses/i2c-designware-pcidrv.c:MODULE_ALIAS("i2c_designware-pci"); drivers/i2c/busses/i2c-designware-platdrv.c:MODULE_ALIAS("platform:i2c_designware"); drivers/i2c/busses/i2c-designware

Re: [PATCH] i2c: img-scb: Allow building for MIPS

2014-11-20 Thread Ezequiel Garcia
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/19/2014 06:07 AM, Wolfram Sang wrote: > On Wed, Nov 19, 2014 at 12:03:08AM +, James Hogan wrote: >> On Tue, Nov 18, 2014 at 03:58:33PM -0800, Andrew Bresticker >> wrote: >>> The SCB is present on IMG SoCs other than the META-based >>> TZ109

[PATCH v7 1/2] i2c: Add Imagination Technologies I2C SCB driver

2014-11-13 Thread Ezequiel Garcia
From: James Hogan Add support for the IMG I2C Serial Control Bus (SCB) found on the Pistachio and TZ1090 SoCs. Signed-off-by: James Hogan [Ezequiel: code cleaning and rebasing] Signed-off-by: Ezequiel Garcia --- drivers/i2c/busses/Kconfig | 10 + drivers/i2c/busses/Makefile

Re: [PATCH v6 1/2] i2c: Add Imagination Technologies I2C SCB driver

2014-11-13 Thread Ezequiel Garcia
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/13/2014 02:38 PM, Wolfram Sang wrote: > Hi, > > Thank you for this submission! Wow, this is a lot of code and I > have only very minor comments. Good work and thanks to all > previous reviewers! > >> @@ -0,0 +1,1415 @@ +/* + * I2C adapter for

[PATCH v6 2/2] DT: i2c: Add binding document for IMG I2C SCB

2014-11-13 Thread Ezequiel Garcia
From: James Hogan Introduce a devicetree binding for Imagination Technologies I2C SCB controller. Reviewed-by: Andrew Bresticker Signed-off-by: James Hogan Signed-off-by: Ezequiel Garcia --- .../devicetree/bindings/i2c/i2c-img-scb.txt| 26 ++ 1 file changed, 26

[PATCH v6 1/2] i2c: Add Imagination Technologies I2C SCB driver

2014-11-13 Thread Ezequiel Garcia
From: James Hogan Add support for the IMG I2C Serial Control Bus (SCB) found on the Pistachio and TZ1090 SoCs. Reviewed-by: Andrew Bresticker Signed-off-by: James Hogan [Ezequiel: code cleaning and rebasing] Signed-off-by: Ezequiel Garcia --- drivers/i2c/busses/Kconfig | 10

[PATCH v6 0/2] i2c: Imagination Technologies I2C adapter driver

2014-11-13 Thread Ezequiel Garcia
Changes from v5: * Checked the return value of wait_for_completion_timeout * Removed the bus-delay devicetree parameter. After reviewing this logic in detail, we found a bug in the formulae involving the bus delay. Moreover, this parameter is not used by any product in the wild. *

Re: [PATCH v5 2/2] DT: i2c: Add binding document for IMG I2C SCB

2014-11-11 Thread Ezequiel Garcia
On 11/10/2014 05:22 PM, Andrew Bresticker wrote: > Hi Ezequiel, James, > > On Mon, Nov 10, 2014 at 11:30 AM, Ezequiel Garcia > wrote: >> From: James Hogan >> >> Introduce a devicetree binding for Imagination Technologies >> I2C SCB controller. >> &g

Re: [PATCH v5 1/2] i2c: Add Imagination Technologies I2C SCB driver

2014-11-11 Thread Ezequiel Garcia
On 11/10/2014 04:30 PM, Ezequiel Garcia wrote: [..] > +static int img_i2c_init(struct img_i2c *i2c) > +{ > + unsigned int clk_khz, bitrate_khz, clk_period, tckh, tckl, tsdh; > + unsigned int i, ret, data, prescale, inc, int_bitrate; > + unsigned int filt, filt_disab

Re: [PATCH v5 1/2] i2c: Add Imagination Technologies I2C SCB driver

2014-11-11 Thread Ezequiel Garcia
On 11/10/2014 05:53 PM, Andrew Bresticker wrote: > Hi Ezequiel, > > On Mon, Nov 10, 2014 at 11:30 AM, Ezequiel Garcia > wrote: >> From: James Hogan >> >> Add support for the IMG I2C Serial Control Bus (SCB) found on the >> Pistachio and TZ1090 So

[PATCH v5 0/2] i2c: Imagination Technologies I2C adapter driver

2014-11-10 Thread Ezequiel Garcia
Changes from v4: * Fixed the MODULE_LICENSE to "GPL v2", as per the comment at the top of the driver. Changes from v3: * Checked for the return value of clk_enable and clk_prepare_enable calls. Changes from v2: * Removed support for the "linux,i2c-index" devicetree property. Changes

[PATCH v5 1/2] i2c: Add Imagination Technologies I2C SCB driver

2014-11-10 Thread Ezequiel Garcia
From: James Hogan Add support for the IMG I2C Serial Control Bus (SCB) found on the Pistachio and TZ1090 SoCs. Signed-off-by: James Hogan [Ezequiel: code cleaning and rebasing] Signed-off-by: Ezequiel Garcia --- drivers/i2c/busses/Kconfig | 10 + drivers/i2c/busses/Makefile

[PATCH v5 2/2] DT: i2c: Add binding document for IMG I2C SCB

2014-11-10 Thread Ezequiel Garcia
From: James Hogan Introduce a devicetree binding for Imagination Technologies I2C SCB controller. Signed-off-by: James Hogan Signed-off-by: Ezequiel Garcia --- .../devicetree/bindings/i2c/i2c-img-scb.txt| 29 ++ 1 file changed, 29 insertions(+) create mode 100644

Re: [PATCH v4 0/2] i2c: Imagination Technologies I2C adapter driver

2014-11-10 Thread Ezequiel Garcia
On 11/10/2014 04:20 PM, Ezequiel Garcia wrote: > Changes from v3: > > * Checked for the return value of clk_enable and clk_prepare_enable calls. > > * Fixed the MODULE_LICENSE to "GPL v2", as per the comment at the top of > the driver. > Actually,

[PATCH v4 1/2] i2c: Add Imagination Technologies I2C SCB driver

2014-11-10 Thread Ezequiel Garcia
From: James Hogan Add support for the IMG I2C Serial Control Bus (SCB) found on the Pistachio and TZ1090 SoCs. Signed-off-by: James Hogan [Ezequiel: code cleaning and rebasing] Signed-off-by: Ezequiel Garcia --- drivers/i2c/busses/Kconfig | 10 + drivers/i2c/busses/Makefile

[PATCH v4 2/2] DT: i2c: Add binding document for IMG I2C SCB

2014-11-10 Thread Ezequiel Garcia
From: James Hogan Introduce a devicetree binding for Imagination Technologies I2C SCB controller. Signed-off-by: James Hogan Signed-off-by: Ezequiel Garcia --- .../devicetree/bindings/i2c/i2c-img-scb.txt| 29 ++ 1 file changed, 29 insertions(+) create mode 100644

[PATCH v4 0/2] i2c: Imagination Technologies I2C adapter driver

2014-11-10 Thread Ezequiel Garcia
Changes from v3: * Checked for the return value of clk_enable and clk_prepare_enable calls. * Fixed the MODULE_LICENSE to "GPL v2", as per the comment at the top of the driver. Changes from v2: * Removed support for the "linux,i2c-index" devicetree property. Changes from v1: * Cle

Re: [PATCH v3 1/2] i2c: Add Imagination Technologies I2C SCB driver

2014-11-06 Thread Ezequiel Garcia
On 11/06/2014 01:51 PM, Vladimir Zapolskiy wrote: > Hi Ezequiel, > > On 05.11.2014 22:21, Ezequiel Garcia wrote: >> From: James Hogan >> >> Add support for the IMG I2C Serial Control Bus (SCB) found on the >> Pistachio and TZ1090 SoCs. >> >> S

[PATCH v3 2/2] DT: i2c: Add binding document for IMG I2C SCB

2014-11-05 Thread Ezequiel Garcia
From: James Hogan Introduce a devicetree binding for Imagination Technologies I2C SCB controller. Signed-off-by: James Hogan Signed-off-by: Ezequiel Garcia --- .../devicetree/bindings/i2c/i2c-img-scb.txt| 29 ++ 1 file changed, 29 insertions(+) create mode 100644

[PATCH v3 1/2] i2c: Add Imagination Technologies I2C SCB driver

2014-11-05 Thread Ezequiel Garcia
From: James Hogan Add support for the IMG I2C Serial Control Bus (SCB) found on the Pistachio and TZ1090 SoCs. Signed-off-by: James Hogan [Ezequiel: code cleaning and rebasing] Signed-off-by: Ezequiel Garcia --- drivers/i2c/busses/Kconfig | 10 + drivers/i2c/busses/Makefile

[PATCH v3 0/2] i2c: Imagination Technologies I2C adapter driver

2014-11-05 Thread Ezequiel Garcia
Changes from v2: * Removed support for the "linux,i2c-index" devicetree property. Changes from v1: * Cleaned-up the clock filter configuration by adding some macros. * Dropped the ISR_ATOMIC macro since it wasn't used anywhere and instead just return 0. * Rename some functions with

Re: [PATCH v2 1/2] i2c: Add Imagination Technologies I2C SCB driver

2014-11-05 Thread Ezequiel Garcia
On 11/05/2014 04:37 AM, Vladimir Zapolskiy wrote: > Hi Ezequiel, > > On 04.11.2014 22:37, Ezequiel Garcia wrote: >> From: James Hogan >> >> Add support for the IMG I2C Serial Control Bus (SCB) found on the >> Pistachio and TZ1090 SoCs. >> >> S

[PATCH v2 2/2] DT: i2c: Add binding document for IMG I2C SCB

2014-11-04 Thread Ezequiel Garcia
From: James Hogan Introduce a devicetree binding for Imagination Technologies I2C SCB controller. Signed-off-by: James Hogan Signed-off-by: Ezequiel Garcia --- .../devicetree/bindings/i2c/i2c-img-scb.txt| 29 ++ 1 file changed, 29 insertions(+) create mode 100644

[PATCH v2 1/2] i2c: Add Imagination Technologies I2C SCB driver

2014-11-04 Thread Ezequiel Garcia
From: James Hogan Add support for the IMG I2C Serial Control Bus (SCB) found on the Pistachio and TZ1090 SoCs. Signed-off-by: James Hogan [Ezequiel: code cleaning and rebasing] Signed-off-by: Ezequiel Garcia --- drivers/i2c/busses/Kconfig | 10 + drivers/i2c/busses/Makefile

[PATCH v2 0/2] i2c: Imagination Technologies I2C adapter driver

2014-11-04 Thread Ezequiel Garcia
Changes from v1: * Cleaned-up the clock filter configuration by adding some macros. * Dropped the ISR_ATOMIC macro since it wasn't used anywhere and instead just return 0. * Rename some functions with the img_i2c_ prefix to follow the rest of the driver style. * Make img_i2c_{re

Re: [PATCH 1/2] i2c: Add Imagination Technologies I2C SCB driver

2014-11-04 Thread Ezequiel Garcia
Andrew, On 10/31/2014 06:17 PM, Andrew Bresticker wrote: >> From: James Hogan >> >> Add support for the IMG I2C Serial Control Bus (SCB) found on the >> Pistachio and TZ1090 SoCs. >> >> Signed-off-by: James Hogan >> [Ezequiel: code cleaning and r

Re: [PATCH 2/2] DT: i2c: Add binding document for IMG I2C SCB

2014-10-30 Thread Ezequiel Garcia
Hi Andrew, On 10/29/2014 08:32 PM, Andrew Bresticker wrote: > Hi Ezequiel, > >> From: James Hogan >> >> Introduce a devicetree binding for Imagination Technologies >> I2C SCB controller. >> >> Signed-off-by: James Hogan > > This should have your S-o-B as well. > Sure, although I haven't writ

Re: I2C OF IRQ parsing issue due to probe ordering

2014-10-30 Thread Ezequiel Garcia
probes the hdmi@39 device and gets > client->irq set to 0. > > We can't control the probe order. Maybe I'm missing something, but I think your i2c adapter is probed with a subsys_initcall (as many other adapters). Otherwise, I can't see why it would be probed before the the gpio c

[PATCH 1/2] i2c: Add Imagination Technologies I2C SCB driver

2014-10-29 Thread Ezequiel Garcia
From: James Hogan From: James Hogan Add support for the IMG I2C Serial Control Bus (SCB) found on the Pistachio and TZ1090 SoCs. Signed-off-by: James Hogan [Ezequiel: code cleaning and rebasing] Signed-off-by: Ezequiel Garcia --- drivers/i2c/busses/Kconfig | 10 + drivers/i2c

[PATCH 2/2] DT: i2c: Add binding document for IMG I2C SCB

2014-10-29 Thread Ezequiel Garcia
From: James Hogan From: James Hogan Introduce a devicetree binding for Imagination Technologies I2C SCB controller. Signed-off-by: James Hogan --- Documentation/devicetree/bindings/i2c/i2c-img-scb.txt | 14 ++ 1 file changed, 14 insertions(+) create mode 100644 Documentation/dev

[PATCH 0/2] i2c: Imagination Technologies I2C adapter driver

2014-10-29 Thread Ezequiel Garcia
This patchset adds a new adapter driver supporting the Imagination Technologies I2C Serial Control Bus (SCB) controller. The driver supports the usual FIFO-based mode of operation (so-called automatic in the driver), and also a set lower-level modes of operation that is used for 0-length writes an

Re: [RESEND/PATCH] i2c: pxa: Use suspend() and resume() instead of the _noirq hooks

2014-10-22 Thread Ezequiel Garcia
On 10/20/2014 06:07 PM, Kevin Hilman wrote: > Ezequiel Garcia writes: > >> The _noirq were previously chosen to make sure all the users of the >> adapter were suspended by the time the adapter itself enters the >> suspended state. >> >> The {suspend,resum

[RESEND/PATCH] i2c: pxa: Use suspend() and resume() instead of the _noirq hooks

2014-10-20 Thread Ezequiel Garcia
, and resumed after it. In other words, there's no need to use the _noirq hooks to get a suspend/resume device/adapter order. This commit changes this by using the suspend/resume PM hooks in the I2C adapter. Signed-off-by: Ezequiel Garcia --- Tested on a PXA CM-X300 board with a vendor-pro

[RFC/PATCH] i2c: pxa: Use suspend() and resume() instead of the _noirq hooks

2014-10-13 Thread Ezequiel Garcia
it. In other words, there's no need to use the _noirq hooks to get a suspend/resume device/adapter order. This commit changes this by using the suspend/resume PM hooks in the I2C adapter. Signed-off-by: Ezequiel Garcia --- drivers/i2c/busses/i2c-pxa.c | 8 1 file changed, 4 inser

Re: [PATCH v5 3/3] ARM: dts: mvebu: Introduce a new compatible string for mv64xxx-i2c

2013-08-09 Thread Ezequiel Garcia
On Fri, Aug 09, 2013 at 11:18:27AM +0200, Gregory CLEMENT wrote: > On 09/08/2013 11:13, Ezequiel Garcia wrote: > > (Sending to devicetree) > > As written in the cover letter this patch was already taken, > so I am not sure you have to send it again on the devicetree > ma

Re: [PATCH v5 3/3] ARM: dts: mvebu: Introduce a new compatible string for mv64xxx-i2c

2013-08-09 Thread Ezequiel Garcia
(Sending to devicetree) On Fri, Aug 09, 2013 at 11:05:58AM +0200, Gregory CLEMENT wrote: > The mv64xxx-i2c embedded in the Armada XP have a new feature to > offload i2c transaction. This new version of the IP come also with > some errata. This lead to the introduction to a another compatible > str