Hi David,
Am Mittwoch, 9. Dezember 2015, 17:11:46 schrieb David Wu:
> 1. support highspeed.
> 2. check i2c bus idle status.
Listing two separate changes in one patch is a big indicator that it should be
split up into two patches. Also please be more verbose (aka explain more) what
patches do -
Am Donnerstag, 9. Oktober 2014, 14:47:15 schrieb Addy Ke:
> As show in I2C specification:
> - Standard-mode: the minimum HIGH period of the scl clock is 4.0us
> the minimum LOW period of the scl clock is 4.7us
> - Fast-mode: the minimum HIGH period of the scl clock is 0.6us
>
Am Freitag, 8. August 2014, 17:41:40 schrieb Addy Ke:
> If slave holds scl, I2C_IPD[7] will be set 1 by controller
> for debugging. Driver must ignore it.
>
> [5.752391] rk3x-i2c ff16.i2c: unexpected irq in WRITE: 0x80
> [5.939027] rk3x-i2c ff16.i2c: timeout, ipd: 0x80, state: 4
>
;
> Changes since v2:
> - support for the new GRF syscon mapping by Heiko Stübner
> - probe error handling improvements by Heiko Stübner
> - fixed wrong remove() order found by Heiko Stübner
> - removed unnecessary clk_enable() during probe
> - removed switch back
Am Montag, 19. Mai 2014, 02:37:57 schrieb Max Schwarz:
> Driver for the native I2C adapter found in Rockchip RK3xxx SoCs.
>
> Configuration is only possible through devicetree. The driver is
> interrupt driven and supports the I2C_M_IGNORE_NAK mangling bit.
>
> Signed-off-by: Max Schwarz
Acked-
thus does not contain this switch.
In the referenced commit I've also moved some init stuff around, which I'll
explain a bit more inline below.
[0]
https://github.com/mmind/linux-rockchip/commit/9305a8a55ed9d97a07d0195d79d178ce6f97e77e
Am Mittwoch, 30. April 2014, 00:34:36 schrieb Hei
e Radxa Rock board, which is based on RK3188.
>
> Signed-off-by: Max Schwarz
> ---
>
> changes since v1:
> - dt property names "rockchip,*" suggested by Heiko Stübner
> - fixed overly specific RK3188 comment (Heiko Stübner)
>
> The dts files needed
Hi Max,
first of all, thanks for working on this :-)
I saw some general things inlined below, but I guess Wolfram is the better
person to check the i2c-specifics.
Am Sonntag, 27. April 2014, 21:38:49 schrieb Max Schwarz:
> Driver for the native I2C adapter found in Rockchip RK3xxx SoCs.
[...]
Am Sonntag, 14. April 2013, 14:20:35 schrieb Wolfram Sang:
> On Thu, Apr 11, 2013 at 02:04:50AM +0200, Arnd Bergmann wrote:
> > No other file in the kernel besides i2c-s3c2410.c uses the current
> > plat/regs-iic.h, so we can simply move the header file to live in the
> > same directory as the driv
Hi Arnd,
Am Donnerstag, 11. April 2013, 23:37:20 schrieb Arnd Bergmann:
> No other file in the kernel besides i2c-s3c2410.c uses the current
> plat/regs-iic.h, so we can simply move the header file to live in the
> same directory as the driver, as a preparation to multiplatform builds.
There is a
Make them conform more to established standards.
Signed-off-by: Heiko Stuebner
---
changes since v1: none
drivers/i2c/busses/i2c-s3c2410.c | 50 ++---
1 files changed, 24 insertions(+), 26 deletions(-)
diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2
The register definitions are only used in the driver itself.
This also removes the last dependency on plat/ includes from the
i2c driver.
Signed-off-by: Heiko Stuebner
Acked-by: Kukjin Kim
---
changes since v1: rebased against 3.9-rc3
arch/arm/mach-s3c24xx/mach-rx1950.c |1 -
arc
Hi Wolfram,
Am Donnerstag, 21. März 2013, 10:57:58 schrieb Wolfram Sang:
> On Fri, Feb 08, 2013 at 12:57:00AM +0100, Heiko Stübner wrote:
> > The register definitions are only used in the driver itself.
> > This also removes the last dependency on plat/ includes from the
Am Donnerstag, 21. März 2013, 11:00:32 schrieb Wolfram Sang:
> On Mon, Mar 04, 2013 at 07:12:53PM +0530, Thomas Abraham wrote:
> > With device core now able to setup the default pin configuration,
> > the call to devm_pinctrl_get_select_default can be removed. And
> > the pin configuration code bas
Hi Thomas,
Am Montag, 4. März 2013, 14:42:53 schrieb Thomas Abraham:
> With device core now able to setup the default pin configuration,
> the call to devm_pinctrl_get_select_default can be removed. And
> the pin configuration code based on the deprecated Samsung specific
> gpio bindings is also r
Am Sonntag, 24. Februar 2013, 23:39:44 schrieb Linus Walleij:
> On Sun, Feb 24, 2013 at 6:00 PM, Tomasz Figa wrote:
> >> > Note that we are talking here about a temporary solution. The legacy
> >> > DT- based pin configuration will go away after all the DT-enabled
> >> > platforms using this drive
Am Sonntag, 24. Februar 2013, 23:42:32 schrieb Linus Walleij:
> On Sun, Feb 24, 2013 at 11:34 PM, Heiko Stübner wrote:
> > [Me]
> >
> >> This make me suspect that you have this ugly patch in some
> >> private repo and I will be seeing it again and again :-(
>
Am Sonntag, 24. Februar 2013, 01:40:58 schrieb Linus Walleij:
> On Sat, Feb 23, 2013 at 6:56 PM, Heiko Stübner wrote:
> > Currently the fallback functions when pinctrl is not being built do
> > return either NULL or 0, either no pinctrl handle or no error,
> > maki
When pinctrl is not built the fallback functions fail silently
and emit either 0 error codes or NULL pinctrl handles.
Therefore it's needed to also check for this NULL-handle when
falling back to parsing the i2c gpios from devicetree.
Signed-off-by: Heiko Stuebner
---
drivers/i2c/busses/i2c-s3c
Currently the fallback functions when pinctrl is not being built do
return either NULL or 0, either no pinctrl handle or no error,
making them fail silently.
All drivers using pinctrl do only test for error conditions, which
made for example the i2c-s3c2410 driver fail on a devicetree based
machin
Hi,
while implementing devicetree support for the s3c2416 I noticed a fault
in the i2c-s3c2410 driver. The s3c2416 does not support pinctrl at the
moment (and will probably for a while), so the fallback functions in
pinctrl/consumer.h were used. These functions fail silently and the
relevant pinct
Make them conform more to established standards.
Signed-off-by: Heiko Stuebner
---
drivers/i2c/busses/i2c-s3c2410.c | 50 ++---
1 files changed, 24 insertions(+), 26 deletions(-)
diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c
i
The register definitions are only used in the driver itself.
This also removes the last dependency on plat/ includes from the
i2c driver.
Signed-off-by: Heiko Stuebner
---
arch/arm/mach-s3c24xx/mach-rx1950.c |1 -
arch/arm/plat-samsung/devs.c |1 -
arch/arm/pla
Am Samstag 21 Januar 2012, 21:38:13 schrieb Sylwester Nawrocki:
> On 01/21/2012 07:31 PM, Mark Brown wrote:
> > On Sat, Jan 21, 2012 at 04:52:58PM +0100, Sylwester Nawrocki wrote:
> >> On 01/21/2012 02:28 PM, Mark Brown wrote:
> > that the rather serious problems with getting I2C patches applied I'
Am Montag, 5. Dezember 2011, 15:06:06 schrieb Mark Brown:
> Add stub runtime_pm calls which go through the flow of enabling and
> disabling but don't actually do anything with the device itself as
> there's nothing useful we can do. This provides the core PM framework
> with information about when
Am Dienstag 17 Mai 2011, 13:59:40 schrieb Heiko Stübner:
> I'm trying to find the best way on implementing an i80 interface
> (especially the command mode) between a s3c2416 and an AUO-K1900 (epaper
> controller).
>
> On the host side it is usable at least in all Samsun
Hi,
I'm trying to find the best way on implementing an i80 interface (especially
the command mode) between a s3c2416 and an AUO-K1900 (epaper controller).
On the host side it is usable at least in all Samsung SoCs following the
S3C2443 and on the device side I've found, apart from the K1900, fo
27 matches
Mail list logo