RE: [PATCH 1/2] i2c-piix4: Add support for AMD ML and CZ SMBus changes

2014-01-27 Thread Huang, Shane
Hi Jean, > > > BTW it would be really great if we could have access to the > > > documentation for these new AMD chipsets. I looked for both Hudson and > > > FCH at http://developer.amd.com/ but these searches returned nothing. I > > > could help better if I had access to the documentation / datas

RE: [PATCH 1/2] i2c-piix4: Add support for AMD ML and CZ SMBus changes

2014-01-23 Thread Huang, Shane
Hi Jean, > As the mask used for smb_en_status doesn't depend on the value of > "aux", this implies that on the Hudson-2, a single bit controls if both > SMBus controllers are enabled. It's not possible to enable one and > disable the other. Is it correct, or is it an overlook? Good question. This

RE: [PATCH RESEND] i2c-piix4: AMD new SMBus base address location changed

2014-01-21 Thread Huang, Shane
Hi Jean, > Sorry for the late review. Here we go... Thanks for your comments, I agree with all of them and will submit V2 later. Regards, Shane -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majord...@vger.kernel.org More majordomo info at h

RE: [PATCH RESEND 2/3] ahci: add AMD CZ SATA device ID

2013-06-03 Thread Huang, Shane
Bjorn, > Let me know if anybody objects. Otherwise, I'll merge it into my > -next branch tomorrow. The change is fine with me, thanks to you and Sergei. Shane -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majord...@vger.kernel.org More majo

RE: [PATCH 3/3] i2c-piix4: add AMD CZ SMBus device ID

2013-05-31 Thread Huang, Shane
> Can you show the exact message? checkpatch doesn't complain here, and I > can't think of any reason why it would care about that. $ ./scripts/checkpatch.pl 0003-i2c-piix4-add-AMD-CZ-SMBus-device-ID.patch WARNING: Avoid CamelCase: #52: FILE: drivers/i2c/busses/i2c-piix4.c:25: + AMD Hudson-

RE: [PATCH 3/3] i2c-piix4: add AMD CZ SMBus device ID

2013-05-30 Thread Huang, Shane
Hi Jean, > Please don't change the case. This makes your patch larger and > increases the risk of conflict with other patches, for no good reason. > > Other than that, the patch looks OK. I didn't want to change it but checkpatch.pl warns due to "Hudson-2" in i2c-piix4.c Thanks, Shane -- To u