Re: [PATCH v3] i2c: s3c2410: enable RuntimePM before registering to the core

2015-10-12 Thread Kukjin Kim
re, move drvdata, too. > > Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> Looks good to me, Acked-by: Kukjin Kim <kg...@kernel.org> Thanks, Kukjin > --- > > Changes since v2: don't call runtime pm on adaper if it wasn't registered > > Thanks

RE: [PATCH v4 1/2] i2c: s3c2410: Handle i2c sys_cfg register in i2c driver

2014-11-21 Thread Kukjin Kim
Pankaj Dubey wrote: On Friday 21 November 2014 12:55 PM, Wolfram Sang wrote: On Thu, Oct 30, 2014 at 01:34:29PM +0530, Pankaj Dubey wrote: Let's handle i2c interrupt re-configuration in i2c driver. This will help us in removing some soc specific checks from machine files and will help

RE: [PATCH v4 1/2] i2c: s3c2410: Handle i2c sys_cfg register in i2c driver

2014-11-21 Thread Kukjin Kim
Wolfram Sang wrote: Hi Wolfram, I usually don't take DTS patches. They should go via arm-soc. Please say so if there are reasons I should take them. I CC'ed to you because same patch contains changes in i2c driver. Yes, those should absolutely go via my I2C tree. You need to make a

RE: [PATCH 1/1] i2c: Kconfig: Enable HSI2C for Exynos5 platform

2014-06-25 Thread Kukjin Kim
sachin.ka...@samsung.com Cc: Doug Anderson diand...@chromium.org Acked-by: Kukjin Kim kgene@samsung.com Thanks, Kukjin --- drivers/i2c/busses/Kconfig |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig index

RE: [PATCH v2] i2c: exynos5: Properly use the noirq variants of suspend/resume

2014-06-25 Thread Kukjin Kim
= exynos5_i2c_resume_noirq, + .poweroff_noirq = exynos5_i2c_suspend_noirq, + .restore_noirq = exynos5_i2c_resume_noirq, +#endif +}; static struct platform_driver exynos5_i2c_driver = { .probe = exynos5_i2c_probe, -- 2.0.0.526.g5318336 Others look good to me, Acked-by: Kukjin Kim kgene

RE: [PATCH] i2c: s3c2410: resume race fix

2014-04-23 Thread Kukjin Kim
before reinit, but really should have seen the -EIO return instead. Signed-off-by: Olof Johansson o...@lixom.net Signed-off-by: Doug Anderson diand...@chromium.org Acked-by: Kukjin Kim kgene@samsung.com Thanks, Kukjin --- drivers/i2c/busses/i2c-s3c2410.c | 2 +- 1 file changed, 1

Re: [PATCH] ARM: DTS: exynos5420: Rename hsi2c compatible to exynos5250-hsi2c

2014-02-13 Thread Kukjin Kim
On 02/06/14 21:07, Naveen Krishna Chatradhi wrote: As per the changes submitted for the i2c-exynos5.c driver with the compatible string being named after the first SoC it is observed on. This patch modifes the existing hsi2c compatible strings in arch/arm/boot/dts. Signed-off-by: Naveen Krishna

Re: [PATCH 08/33] drivers/i2c/busses: don't check resource with devm_ioremap_resource

2013-05-20 Thread Kukjin Kim
On 05/16/13 20:15, Wolfram Sang wrote: devm_ioremap_resource does sanity checks on the given resource. No need to duplicate this in the driver. Signed-off-by: Wolfram Sangw...@the-dreams.de For i2c-s3c2410: Acked-by: Kukjin Kim kgene@samsung.com Thanks. - Kukjin --- drivers/i2c

RE: [PATCH 1/2] i2c: s3c2410: move mach/regs-iic.h into i2c-s3c2410 device driver

2013-02-12 Thread Kukjin Kim
S3C2410 as baseline hardware, anything else is supported via quirks */ #define QUIRK_S3C2440(1 0) #define QUIRK_HDMIPHY(1 1) -- 1.7.2.3 Looks good to me on this series: Acked-by: Kukjin Kim kgene@samsung.com Hi Wolfram, if you're ok on this, please pick

RE: [PATCH 1/2] i2c: s3c2410: move mach/regs-iic.h into i2c-s3c2410 device driver

2013-02-12 Thread Kukjin Kim
Kukjin Kim wrote: Heiko Stübner wrote: The register definitions are only used in the driver itself. This also removes the last dependency on plat/ includes from the i2c driver. Signed-off-by: Heiko Stuebner he...@sntech.de --- arch/arm/mach-s3c24xx/mach-rx1950.c

[PATCH v2 re-send] i2c: s3c2410: Add quirk to exclude GPIO config for exynos5440

2013-01-24 Thread Kukjin Kim
From: Giridhar Maruthy giridha...@samsung.com Signed-off-by: Giridhar Maruthy giridha...@samsung.com Signed-off-by: Kukjin Kim kgene@samsung.com --- Resending due to line wrapped from e-mail client. Documentation/devicetree/bindings/i2c/i2c-s3c2410.txt |2 ++ drivers/i2c/busses/i2c

RE: PATCH v2] i2c: s3c2410: Add quirk to exclude GPIO config for exynos5440

2013-01-24 Thread Kukjin Kim
Wolfram Sang wrote: On Tue, Jan 22, 2013 at 06:47:39PM -0800, Kukjin Kim wrote: From: Giridhar Maruthy giridha...@samsung.com Signed-off-by: Giridhar Maruthy giridha...@samsung.com Signed-off-by: Kukjin Kim kgene@samsung.com Looks OK but is line wrapped, can't apply. Oh, OK. Re

PATCH v2] i2c: s3c2410: Add quirk to exclude GPIO config for exynos5440

2013-01-22 Thread Kukjin Kim
From: Giridhar Maruthy giridha...@samsung.com Signed-off-by: Giridhar Maruthy giridha...@samsung.com Signed-off-by: Kukjin Kim kgene@samsung.com --- Changes since v1: - added documentation of device tree bindings for i2c-s3c2410, as per Tomasz's suggestion - changed ordering

RE: [PATCH] i2c: s3c2410: Add quirk to exclude GPIO config for exynos5440

2013-01-20 Thread Kukjin Kim
Tomasz Figa wrote: Hi Kukjin, Hi, You should also add the new compatible value to the documentation of device tree bindings for i2c-s3c2410. Yeah, agreed. (Documentation/devicetree/bindings/i2c/i2c-s3c2410.txt) Giridhar, please address comments from Tomasz. Thanks. - Kukjin -- To

[PATCH] i2c: s3c2410: Add quirk to exclude GPIO config for exynos5440

2013-01-18 Thread Kukjin Kim
From: Giridhar Maruthy giridha...@samsung.com Signed-off-by: Giridhar Maruthy giridha...@samsung.com Signed-off-by: Kukjin Kim kgene@samsung.com --- drivers/i2c/busses/i2c-s3c2410.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses

RE: [PATCH v2 1/6] ARM: EXYNOS5: Clock settings for SATA and SATA PHY

2012-11-23 Thread Kukjin Kim
Vasanth Ananthan wrote: Hi, Missed to include Ben, for I2C patch, including him and copying others. Vasanth, you didn't my reply? I already applied this 1st and 2nd patches. Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team

RE: [PATCH 2/2] i2c: s3c2410: Get the i2c bus number from alias id

2012-11-22 Thread Kukjin Kim
said, the patch for adding aliases for exynos4 should still be fine to apply. OK, I see. Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from this list: send the line unsubscribe

RE: [PATCH 2/2] i2c: s3c2410: Get the i2c bus number from alias id

2012-11-21 Thread Kukjin Kim
-by: Padmavathi Venna padm...@samsung.com Signed-off-by: Doug Anderson diand...@chromium.org Acked-by: Kukjin Kim kgene@samsung.com Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. --- drivers/i2c/busses

RE: [PATCH] ARM: exynos: dt: add all i2c busses to auxdata

2012-11-21 Thread Kukjin Kim
-hdmiphy-i2c, NULL), OF_DEV_AUXDATA(samsung,exynos5250-dw-mshc, EXYNOS5_PA_DWMCI0, -- 1.7.7.3 Looks ok to me, applied. Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. -- To unsubscribe from

RE: [PATCH 1/2] ARM: EXYNOS: Add aliases for i2c controller for exynos4

2012-11-21 Thread Kukjin Kim
@@ status = disabled; }; - i2c@138D { + i2c_7: i2c@138D { #address-cells = 1; #size-cells = 0; compatible = samsung,s3c2440-i2c; -- 1.7.7.3 Applied, thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior

RE: [PATCH RESEND] drivers: i2c: s3c2410: add support for HDMIPHY dedicated controller

2011-10-11 Thread Kukjin Kim
kyungmin.p...@samsung.com Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com Acked-by: Kukjin Kim kgene@samsung.com Hi Ben, If you're ok with this, please apply this to go to upstream via your i2c tree. Thanks. Best regards, Kgene. -- Kukjin Kim kgene@samsung.com, Senior Engineer, SW

[PATCH] i2c-s3c2410: Fix typo 'i2s' - 'i2c'

2011-06-23 Thread Kukjin Kim
From: Huisung Kang hs1218.k...@samsung.com Signed-off-by: Huisung Kang hs1218.k...@samsung.com Signed-off-by: Kukjin Kim kgene@samsung.com --- drivers/i2c/busses/i2c-s3c2410.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/i2c/busses/i2c-s3c2410.c b

[PATCH] i2c-s3c2410: Remove useless break code

2011-06-23 Thread Kukjin Kim
From: Jonghwan Choi jhbird.c...@samsung.com Signed-off-by: Jonghwan Choi jhbird.c...@samsung.com Signed-off-by: Kukjin Kim kgene@samsung.com --- drivers/i2c/busses/i2c-s3c2410.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/i2c/busses/i2c-s3c2410.c b

RE: [PATCH v3 3/3] ARM: SAMSUNG: i2c/busses: Add HAVE_S3C2410_I2C option to include I2C for Samsung SoCs

2010-07-29 Thread Kukjin Kim
Kyungmin Park wrote: On Thu, Jul 29, 2010 at 6:42 PM, Kukjin Kim kgene@samsung.com wrote: From: Naveen Krishna Ch ch.nav...@samsung.com This patch adds HAVE_S3C2410_I2C to control inclusion of I2C bus driver on Samsung SoCs and makes I2C bus driver dependency SoC specific instead

RE: [PATCH v3 3/3] ARM: SAMSUNG: i2c/busses: Add HAVE_S3C2410_I2C option to include I2C for Samsung SoCs

2010-07-29 Thread Kukjin Kim
-Original Message- From: kyungmi...@gmail.com [mailto:kyungmi...@gmail.com] On Behalf Of Kyungmin Park Sent: Friday, July 30, 2010 11:43 AM To: Kukjin Kim Cc: linux-arm-ker...@lists.infradead.org; linux-samsung-...@vger.kernel.org; linux-i2c@vger.kernel.org; ben-li...@fluff.org

[PATCH v2 2/3] ARM: S5PV210: Add support for I2C devices on SMDKV210 and SMDKC110

2010-07-21 Thread Kukjin Kim
From: Naveen Krishna Ch ch.nav...@samsung.com This patch adds support I2C-0/1/2 devices to the SMDKV210/SMDKC110. Signed-off-by: Naveen Krishna Ch ch.nav...@samsung.com Signed-off-by: Kukjin Kim kgene@samsung.com --- Changes since v1: - Fixed the wrong name as per Kyungmin Park's comments

RE: [PATCH 2/3] ARM: S5PV210: Add support for I2C devices on SMDKV210 and SMDKC110

2010-07-18 Thread Kukjin Kim
Kyungmin Park wrote: On Fri, Jul 16, 2010 at 10:13 PM, Kukjin Kim kgene@samsung.com wrote: From: Naveen Krishna Ch ch.nav...@samsung.com This patch adds support I2C-0/1/2 devices to the SMDKV210/SMDKC110. Signed-off-by: Naveen Krishna Ch ch.nav...@samsung.com Signed-off

[PATCH 3/3] i2c/busses: Select I2C bus support for S5PV210 and S5P6440.

2010-07-16 Thread Kukjin Kim
From: Naveen Krishna Ch ch.nav...@samsung.com This patch is to select support I2C channels 0, 1 and 2 for S5PV210 and S5P6440. Signed-off-by: Naveen Krishna Ch ch.nav...@samsung.com Signed-off-by: Kukjin Kim kgene@samsung.com --- drivers/i2c/busses/Kconfig |2 +- 1 files changed, 1

[PATCH 1/3] ARM: S5P6440: Add support for I2C channel 0 and 1 on SMDK6440

2010-07-16 Thread Kukjin Kim
From: Naveen Krishna Ch ch.nav...@samsung.com This patch adds helper functions for I2C channel 0 and 1, GPIO configurations for I2C on S5P6440 and support I2C-0/1 devices on SMDK6440. Signed-off-by: Naveen Krishna Ch ch.nav...@samsung.com Signed-off-by: Kukjin Kim kgene@samsung.com --- arch

[PATCH 2/3] ARM: S5PV210: Add support for I2C devices on SMDKV210 and SMDKC110

2010-07-16 Thread Kukjin Kim
From: Naveen Krishna Ch ch.nav...@samsung.com This patch adds support I2C-0/1/2 devices to the SMDKV210/SMDKC110. Signed-off-by: Naveen Krishna Ch ch.nav...@samsung.com Signed-off-by: Kukjin Kim kgene@samsung.com --- arch/arm/mach-s5pv210/Kconfig |8 arch/arm/mach