ric...@st.com>
Acked-by: Linus Walleij <linus.wall...@linaro.org>
Rafael you can merge this into the ACPI tree.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majord...@vger.kernel.org
More majordomo i
PTR_ERR(i2c_imx->pinctrl) == -EPROBE_DEFER) {
This is one of the evils of deferred probe: you never know if
something will eventually turn up. It feels wrong to bail out
on deferred probe...
I have no better idea though.
Acked-by
Yours,
Linus Walleij
--
To unsubscribe from this list: send the
tree without any bad side effects. Is this correct?
In that case I will apply them.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
evche...@linux.intel.com>
Patch applied.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
nux.intel.com>
Patch applied.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
ux.intel.com>
Paging Gregory, Grygorii, Graeme on this patch too.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
evche...@linux.intel.com>
Gregory, Grygorii, Graeme: can I get some help in reviewing these
PCA patches for ACPI support?
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majord...@vger.kernel.org
More majordomo info
g.samsung.com>
Acked-by: Linus Walleij <linus.wall...@linaro.org>
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
'd like to see implemented a separate pinctrl set
> for bitbanging instead of relying on the sleep state being the right
> thing to enable gpio functionality.
This sounds right but I need to see the two different code sets
to understand. Now my head is all fuzzy...
Yours,
Linus Walleij
--
To uns
traffic, it is a mode related to I2C,
and if this mode is called GPIO mode in the data sheet
is irrelevant, because it is obviously not used for the generic
input/output but the specific I2C. The terminology should be
made familiar to whoever needs to go in and read the code later.
Yours,
Linus
contracts.
All in all, it's not impossible for another OS to work with the DT
information that begins its life in Linux, but it's not really easy.
Let's maker this better.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord
on at compile time. We
discarded that development path years ago. We have no clue, this
is resolved at runtime. Alas, people still create super-optimized
systems using exactly this knowledge, but it is not our main target
here, it is a special optimization case.
Yours,
Linus Walleij
--
To unsubscribe from
On Thu, Jun 11, 2015 at 6:40 PM, Alexander Holler hol...@ahsoftware.de wrote:
Am 11.06.2015 um 14:30 schrieb Linus Walleij:
Certainly it is possible to create deadlocks in this scenario, but the
scope is not to create an ubreakable system.
IAnd what happens if you run into a deadlock? Do you
On Thu, Jun 11, 2015 at 12:17 PM, Alexander Holler hol...@ahsoftware.de wrote:
Am 11.06.2015 um 10:12 schrieb Linus Walleij:
On Wed, Jun 10, 2015 at 10:28 AM, Alexander Holler hol...@ahsoftware.de
wrote:
You would end up with the same problem of deadlocks as currently, and you
would still
On Wed, Jun 10, 2015 at 12:19 PM, Tomeu Vizoso
tomeu.viz...@collabora.com wrote:
On 10 June 2015 at 09:30, Linus Walleij linus.wall...@linaro.org wrote:
regulator_get(...) - not available, so:
- identify target regulator provider - this will need instrumentation
- probe it
It then turns out
On Tue, Jun 2, 2015 at 12:14 PM, Tomeu Vizoso
tomeu.viz...@collabora.com wrote:
On 2 June 2015 at 10:48, Linus Walleij linus.wall...@linaro.org wrote:
This is what systemd is doing in userspace for starting services:
ask for your dependencies and wait for them if they are not
there. So
(!) and DMA channels for example.)
So if this should be solved it should be solved in an abstract way
in the device driver core available for all, then have calls calling
out to DT, ACPI, possibly even PCI or USB (as these
enumerate devices themselves) to obtain a certain
dependency.
Yours,
Linus
need to catch up with
using GPIO descriptors.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
...@osadl.org
Acked-by: Linus Walleij linus.wall...@linaro.org
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sun, Feb 8, 2015 at 1:34 PM, Nicholas Mc Guire hof...@osadl.org wrote:
return type of read_i2c() is int not u32. As the assignments to status
are consistent with int here its type is changed to int.
Signed-off-by: Nicholas Mc Guire hof...@osadl.org
Acked-by: Linus Walleij linus.wall
= *((u32 *)buf[440]);
+ gpio-out_gpio = drive0 | drive1;
+ gpio-out_value = drive1;
+ gpio-in_gpio = *((u32 *)buf[444]);
These offsets seem horribly arbitrary. Is there a spec of the packet
format to reference in that comment?
Yours,
Linus Walleij
--
To unsubscribe from
MFD alone from the GPIO side
of things.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
term and maintenance
of your driver, but it's your pick.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
. Rebase and you can drop this patch.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Manual [1], see section 2.9 for the GPIO
module commands and responses.
[1] https://www.diolan.com/downloads/dln-api-manual.pdf
Signed-off-by: Daniel Baluta daniel.bal...@intel.com
Signed-off-by: Octavian Purdila octavian.purd...@intel.com
Looks good to me.
Acked-by: Linus Walleij linus.wall
adding interfaces with no users, but
this seems very useful, so patch applied. I guess your driver will
appear on v3.19+ so then you can rely on this having been merged
for v3.18.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message
GPIOLIB_IRQCHIP or grep the git
log to see how this works in practice.
You need to use some container_of() operations.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
the removal. Keep
the
DEPRECATED flag, so the core can inform users that the behaviour finally
changed now. After another transition period, this flag can go, too.
Signed-off-by: Wolfram Sang w...@the-dreams.de
Acked-by: Linus Walleij linus.wall...@linaro.org
Yours,
Linus Walleij
--
To unsubscribe
Sang w...@the-dreams.de
Acked-by: Linus Walleij linus.wall...@linaro.org
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Jun 4, 2014 at 8:09 AM, Michael Lawnick ml.lawn...@gmx.de wrote:
Am 03.06.2014 13:18, schrieb Linus Walleij:
On Mon, Jun 2, 2014 at 4:29 PM, Michael Lawnick ml.lawn...@gmx.de wrote:
Am 02.06.2014 14:16, schrieb Linus Walleij:
Is this really so useful on embedded systems?
I
Davis jim.ep...@gmail.com
Signed-off-by: Linus Walleij linus.wall...@linaro.org
---
drivers/i2c/muxes/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/i2c/muxes/Kconfig b/drivers/i2c/muxes/Kconfig
index f7f9865b8b89..f6d313e528de 100644
--- a/drivers/i2c/muxes/Kconfig
+++ b/drivers
for this to Wolfram and the i2c discuss list.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
desktops with temperature monitors and EEPROMs
on some I2C link on the PCB, usage entirely optional and fun
for userspace hacks.
And when we say people use it do we mean sensors-detect
uses it, on desktops, really?
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe
guess... but passing a compatible
string to that same file is a bit arbitrarily ambigous. So we'd rather
add a new instatiation file named new_device_of_compatible or so?
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord
On Wed, May 7, 2014 at 6:29 AM, Jingoo Han jg1@samsung.com wrote:
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.
Signed-off-by: Jingoo Han jg1@samsung.com
Acked-by: Linus Walleij linus.wall...@linaro.org
Yours,
Linus
On Tue, May 6, 2014 at 11:32 AM, Ulf Hansson ulf.hans...@linaro.org wrote:
On 10 April 2014 16:19, Ulf Hansson ulf.hans...@linaro.org wrote:
devm_ioremap() returns NULL on error, not an error.
Cc: Alessandro Rubini rub...@unipv.it
Cc: Linus Walleij linus.wall...@linaro.org
Signed-off-by: Ulf
when
a transfer occurs during the early phases of system suspend the device
will be kept active after the transfer.
To handle both issues above, use pm_runtime_force_suspend|resume() from
the system suspend|resume callbacks.
Cc: Alessandro Rubini rub...@unipv.it
Cc: Linus Walleij linus.wall
On Mon, Feb 24, 2014 at 10:13 AM, Wolfram Sang w...@the-dreams.de wrote:
On Mon, Feb 24, 2014 at 09:57:05AM +0100, Linus Walleij wrote:
I can easily fix that up ipso facto by modifying the device trees to
state 400kHz for them.
Then lets do it this way.
After a check I see
are
unlikely to support deepsleep in any capacity, and if they do they are
ill-designed from the top level as this needs to be taken into account
when devising the hardware :-/
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message
On Mon, Feb 3, 2014 at 11:27 AM, Linus Walleij linus.wall...@linaro.org wrote:
Move the former platform data struct nmk_i2c_controller into the
per-device state container struct i2c_nmk_client, and remove all
the platform data probe path hacks.
Cc: Lee Jones lee.jo...@linaro.org
Signed-off
On Mon, Feb 10, 2014 at 11:04 AM, Wolfram Sang w...@the-dreams.de wrote:
Warn users that class based instantiation is going away soon in favour
of more robust probing and faster bootup times.
Signed-off-by: Wolfram Sang w...@the-dreams.de
Cc: Linus Walleij linus.wall...@linaro.org
Walleij linus.wall...@linaro.org
---
This patch is a suggestion. Looking for an ack by someone who actually uses
the driver.
Acked-by: Linus Walleij linus.wall...@linaro.org
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message
...@linaro.org
Acked-by: Linus Walleij linus.wall...@linaro.org
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Feb 4, 2014 at 4:58 PM, Ulf Hansson ulf.hans...@linaro.org wrote:
Use devm_* functions to simplify code and error handling.
Cc: Alessandro Rubini rub...@unipv.it
Cc: Linus Walleij linus.wall...@linaro.org
Cc: Wolfram Sang w...@the-dreams.de
Signed-off-by: Ulf Hansson ulf.hans
them
handle the resources accordingly, including the clock.
Cc: Alessandro Rubini rub...@unipv.it
Cc: Linus Walleij linus.wall...@linaro.org
Cc: Wolfram Sang w...@the-dreams.de
Signed-off-by: Ulf Hansson ulf.hans...@linaro.org
Hm do I read it right as patch 13 breaks runtime PM by leaving
On Tue, Jan 21, 2014 at 3:55 AM, Alexandre Courbot gnu...@gmail.com wrote:
On Sat, Jan 18, 2014 at 7:43 AM, Linus Walleij linus.wall...@linaro.org
wrote:
1. Today this OPEN_DRAIN flag is not even passed down to
the driver so how could it say anything about it :-( it's a pure gpiolib
gpiod_input_always_valid(const struct gpio_desc *desc);
And leave it up to the core to look at flags, driver characteristics
etc and determine whether the input can be trusted?
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord
this mean that you applied patch 1/3 and 2/3?
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sat, Dec 14, 2013 at 1:19 AM, Linus Walleij linus.wall...@linaro.org wrote:
On Thu, Nov 28, 2013 at 11:12 PM, Linus Walleij
linus.wall...@linaro.org wrote:
The Nomadik I2C is now configured from the device tree on all platforms
using this controller. Delete the platform data header
On Sat, Dec 14, 2013 at 1:20 AM, Linus Walleij linus.wall...@linaro.org wrote:
On Thu, Nov 28, 2013 at 11:12 PM, Linus Walleij
linus.wall...@linaro.org wrote:
Move the former platform data struct nmk_i2c_controller into the
per-device state container struct i2c_nmk_client, and remove all
On Thu, Nov 28, 2013 at 11:11 PM, Linus Walleij
linus.wall...@linaro.org wrote:
The Nomadik I2C controller needs to have the slave set-up time
configured based off the clock used to drive the I2C bus block.
Currently this is done with static assignments assuming that the
block is clocked
On Thu, Nov 28, 2013 at 11:12 PM, Linus Walleij
linus.wall...@linaro.org wrote:
The Nomadik I2C is now configured from the device tree on all platforms
using this controller. Delete the platform data header and move the
definitions into the driver so it is all contained in one single file
On Thu, Nov 28, 2013 at 11:12 PM, Linus Walleij
linus.wall...@linaro.org wrote:
Move the former platform data struct nmk_i2c_controller into the
per-device state container struct i2c_nmk_client, and remove all
the platform data probe path hacks.
Cc: Lee Jones lee.jo...@linaro.org
Signed-off
The Nomadik I2C is now configured from the device tree on all platforms
using this controller. Delete the platform data header and move the
definitions into the driver so it is all contained in one single file.
Cc: Lee Jones lee.jo...@linaro.org
Signed-off-by: Linus Walleij linus.wall
Move the former platform data struct nmk_i2c_controller into the
per-device state container struct i2c_nmk_client, and remove all
the platform data probe path hacks.
Cc: Lee Jones lee.jo...@linaro.org
Signed-off-by: Linus Walleij linus.wall...@linaro.org
---
drivers/i2c/busses/i2c-nomadik.c
that, so the
devices it supports won't get lost in a deferred probe.
Signed-off-by: Wolfram Sang w...@the-dreams.de
Cc: Linus Walleij linus.wall...@linaro.org
Acked-by: Linus Walleij linus.wall...@linaro.org
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux
the
conversions just to have it NAKed at the last minute.
With the direction we've discussed here atleast I won't be
doing any NACKing if it's of any help...
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More
On Mon, Sep 23, 2013 at 10:29 PM, Thierry Reding
thierry.red...@gmail.com wrote:
On Mon, Sep 23, 2013 at 09:14:30PM +0200, Linus Walleij wrote:
I think it is better to first go over the call sites and make them
all handle negative return numbers rather than pushing the
obscure __interface
+subsystems and it's just plain work.
So do that first.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
the first patch to use a wrapper.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
in a NULL resource.
I second this comment.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
for compiler- and linker related things,
like __packed; or __init.
I would prefer irq_of_parse_and_map_strict() or something
like that.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info
hard to spot, so we should keep an eye out for this
once this probing scheme is in place.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
think I have the whole picture, but
Wolfram has serious doubts about this and say we have
to be careful
Wolfram, do you have some ideas on how we should
proceed or ar you happy with merging this as-is?
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-i2c
drivers
and when they probe, and dependencies trying to take
a pinctrl handle before the pin controller is available
will be deferred. Even by those grabbed in the core
by drivers/base/pinctrl.c.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body
boot)
and I'm happy to patch it if it disturbs anything, it is
*really* not important for this driver.
Do you guys need a low footprint? Else there is no
use to have platform_driver_probe() in there.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-i2c
to yourself ;-)
Acked-by: Linus Walleij linus.wall...@linaro.org
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Jun 18, 2013 at 9:33 AM, Wolfram Sang w...@the-dreams.de wrote:
On Mon, Jun 17, 2013 at 11:15:30PM +0100, Grant Likely wrote:
On Mon, Jun 17, 2013 at 5:33 PM, Linus Walleij linus.wall...@linaro.org
wrote:
OK that works for me, I'm not in any hurry.
Deferring by a merge window isn't
Wolfram (the i2c maintainer) on the To: line.
Tuomas Tynkkynen (2):
mfd: tps65910: Fix crash in i2c_driver .probe
regulator: tps62360: Fix crash in i2c_driver .probe
Nice :-)
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message
enough time for everyone to get
a heads-up on fixing any drivers with a similar problem, rather than
trying to cram all that in immediately before the merge window.
OK that works for me, I'm not in any hurry.
Wolfram get to decide how to handle this...
Yours,
Linus Walleij
--
To unsubscribe from
like
decorating the device tree representation and it was just ...
ouch.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
different given
the way the FDT works :-/
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
variant data in the same
manner as other PrimeCells, and switch code path depending
on version.
Tested on the S8815 Nomadik dongle.
Signed-off-by: Linus Walleij linus.wall...@linaro.org
---
drivers/i2c/busses/i2c-nomadik.c | 43 ++--
1 file changed, 41 insertions
, and
the semantic effect on systems with only Nomadik I2C blocks
will be none - instead of increasing the number atomically
in the driver itself, it is done in the I2C core.
Signed-off-by: Linus Walleij linus.wall...@linaro.org
---
drivers/i2c/busses/i2c-nomadik.c | 10 +++---
1 file changed, 3
and
sleep states, but you may see even further...
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, May 22, 2013 at 9:56 AM, Linus Walleij linus.wall...@linaro.org wrote:
On Mon, May 13, 2013 at 10:18 PM, Linus Walleij
linus.wall...@linaro.org wrote:
This tries to address an issue found when writing an MFD driver
for the Nomadik STw481x PMICs: as the platform is using device
tree
On Mon, May 13, 2013 at 10:18 PM, Linus Walleij
linus.wall...@linaro.org wrote:
This tries to address an issue found when writing an MFD driver
for the Nomadik STw481x PMICs: as the platform is using device
tree exclusively I want to specify the driver matching like
,
i2c_match_id(driver-id_table, client));
If the device has an of_node it surely should not be using the
id_table and it'd be correct to pass NULL, right?
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
rob.herr...@calxeda.com
Cc: Grant Likely grant.lik...@linaro.org
Signed-off-by: Linus Walleij linus.wall...@linaro.org
---
I would need some device tree core people to confirm that I am
on the right track with this. I was s confused when I found
that .of_match_table could not be used with I2C
;
Just u16?
The specification allows 16 GPIOs for this device, therefore this seems
to be the right size. Would it be better to use another type instead?
Ah, I was just asking you to use u16 instead of uint16_t.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe
On Tue, Apr 9, 2013 at 6:41 PM, Guenter Roeck li...@roeck-us.net wrote:
On Tue, Apr 09, 2013 at 10:46:15AM +0200, Linus Walleij wrote:
On Mon, Apr 8, 2013 at 7:15 PM, Kevin Strasser
kevin.stras...@linux.intel.com wrote:
From: Michael Brunner michael.brun...@kontron.com
Add gpio support
+#include linux/gpio.h
+#include linux/mfd/kempld.h
+#include linux/seq_file.h
+
+#include gpio-kempld.h
(...)
+
Most comments concern the other driver too.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord
On Mon, Mar 18, 2013 at 8:22 AM, Barry Song barry.s...@csr.com wrote:
From: Barry Song baohua.s...@csr.com
hardcode set i2c pin group to i2c function before, here we
move to use standard pinctrl API to get pins of the group.
Signed-off-by: Barry Song baohua.s...@csr.com
Cc: Linus Walleij
On Wed, Mar 27, 2013 at 11:36 AM, Barry Song 21cn...@gmail.com wrote:
2013/3/27 Linus Walleij linus.wall...@linaro.org:
You only need to fetch pinctrl handles in drivers if you're
using anything else than the default state.
well. missed this recent commit.
it should mean we hould drop all
is also removed.
Signed-off-by: Thomas Abraham thomas.abra...@linaro.org
Acked-by: Linus Walleij linus.wall...@linaro.org
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
the platforms relying on the legacy DT GPIO support should have
been already migrated to pin control, so ideally instead of fixing the
drivers to continue supporting the deprecated method, such platforms
should be fixed.
I agree.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line
come across as too harsh and then I feel bad about
that :-(
I really want spare-time contributors, they are often more valueable
in addition to the corporate ones since they provide an outside view
of things.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-i2c
core
The right solution is to simply revert commit
2693ac69880a33d4d9df6f128415b65e745f00ba
i2c: s3c2410: Add support for pinctrl
Tomasz are you OK with this, or will you add more
fine-grained pinctrl (like runtime PM etc) to this driver?
Yours,
Linus Walleij
--
To unsubscribe from this list
now?
Plus, I think that now that the device core is handling pin control you
should be able to just remove all this default-enabling from your
drivers.
*NO* using of pinctrl to check if do we need to do it some other
way.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line
{
bool use_that_old_gpio_interface;
(...)
};
Instead of trying to semi-guess if the pinctrl framework is there?
Surely you know this when setting up the pdata from your machine?
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message
a temporary solution. The legacy DT-
based pin configuration will go away after all the DT-enabled platforms
using this driver get migrated to pin control and so will the need to
check if pin control is available.
So use AUXDATA, and you get a pdata for that driver?
Yours,
Linus Walleij
instance.
And luckily the base is zero. Not elegant maybe, but the
global GPIO numberspace is not elegant by nature.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
are referenced by ampersand gpio0 1 2
notation referring to the instance, so as you realize DT itself
has no need for that number.
Further it is not OS-neutral.
You have to find another way to handle this in the driver code.
In worst case: use AUXDATA.
Yours,
Linus Walleij
--
To unsubscribe from
i2c xfer
- sleep on suspend()
This should make it possible to optimize energy usage for the pins
both for the suspend/resume cycle, and for runtime cases inbetween
I2C transfers.
Signed-off-by: Patrice Chotard patrice.chot...@stericsson.com
Signed-off-by: Linus Walleij linus.wall...@linaro.org
On Wed, Jan 23, 2013 at 1:50 PM, Wolfram Sang w.s...@pengutronix.de wrote:
On Wed, Jan 23, 2013 at 01:24:52PM +0100, Linus Walleij wrote:
On Wed, Jan 23, 2013 at 7:32 AM, Liu Ying ying@freescale.com wrote:
This patch adds at24c512b eeprom support.
The datasheet of at24c512b can be found
Bergmann is the misc maintainer, route this by him.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-i2c in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
i2c xfer
- sleep on suspend()
This should make it possible to optimize energy usage for the pins
both for the suspend/resume cycle, and for runtime cases inbetween
I2C transfers.
Signed-off-by: Patrice Chotard patrice.chot...@stericsson.com
Signed-off-by: Linus Walleij linus.wall...@linaro.org
On Sat, Oct 6, 2012 at 3:30 PM, Wolfram Sang w.s...@pengutronix.de wrote:
err_add_adap:
+ clk_unprepare(dev-clk);
+ err_prep_clk:
This is unrelated, right? And it is also unneeded because of Ulf
Hansson's patch?
True. I'll roll out a v3 based on the latest i2c code.
Yours,
Linus
i2c xfer
- sleep on suspend()
This should make it possible to optimize energy usage for the pins
both for the suspend/resume cycle, and for runtime cases inbetween
I2C transfers.
Signed-off-by: Patrice Chotard patrice.chot...@stericsson.com
Signed-off-by: Linus Walleij linus.wall...@linaro.org
i2c xfer
- sleep on suspend()
This should make it possible to optimize energy usage for the pins
both for the suspend/resume cycle, and for runtime cases inbetween
I2C transfers.
Signed-off-by: Patrice Chotard patrice.chot...@stericsson.com
Signed-off-by: Linus Walleij linus.wall...@linaro.org
1 - 100 of 244 matches
Mail list logo
