Sorry forget this one, I have sent an old version.
On Thu, Dec 03, 2015 at 10:53:51AM +0100, Ludovic Desroches wrote:
> The hold field allows to configure the data hold time which can be set
> with the help of the generic binding 'i2c-sda-hold-time-ns'. This
> feature has b
The hold field allows to configure the data hold time which can be set
with the help of the generic binding 'i2c-sda-hold-time-ns'. This
feature has been introduced with SAMA5D4 SoC family.
Signed-off-by: Ludovic Desroches
---
drivers/i2c/busses/i2c-a
The hold field allows to configure the data hold time which can be set
with the help of the generic binding 'i2c-sda-hold-time-ns'. This
feature has been introduced with SAMA5D4 SoC family.
Signed-off-by: Ludovic Desroches
---
drivers/i2c/busses/i2c-a
The i2c-sda-hold-time-ns property is supported from atmel,sama5d4-i2c.
Signed-off-by: Ludovic Desroches
Acked-by: Rob Herring
---
Documentation/devicetree/bindings/i2c/i2c-at91.txt | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/i2c/i2c
Data have to be held longer for the PMIC device. The ACT8945A
datasheet claims that minimum SDA data hold time is about 300 ns.
Signed-off-by: Ludovic Desroches
---
arch/arm/boot/dts/at91-sama5d2_xplained.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/at91
A new compatible string has been introduced: atmel,sama5d4-i2c. It
allows to use the i2c-sda-hold-time-ns property if needed.
Signed-off-by: Ludovic Desroches
---
arch/arm/boot/dts/sama5d4.dtsi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/sama5d4
Changes:
- from v1:
- fix typos,
- change MAX_HOLD macro to follow Nicolas' advice,
- make it clear that sama5d2 also support i2c-sda-hold-time-ns.
Ludovic Desroches (4):
i2c: at91: add support for the HOLD field
i2c: at91: update bindings documention
ARM: at91/dt: sama5d4: updat
Data have to been hold longer for the PMIC device.
Signed-off-by: Ludovic Desroches
---
arch/arm/boot/dts/at91-sama5d2_xplained.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts
b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
index ad6de73
A new compatible string has been introduced: atmel,sama5d4-i2c. It
allows to use the i2c-sda-hold-time-ns property if needed.
Signed-off-by: Ludovic Desroches
---
arch/arm/boot/dts/sama5d4.dtsi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/sama5d4
The i2c-sda-hold-time-ns property is supported from atmel,sama5d4-i2c.
Signed-off-by: Ludovic Desroches
---
Documentation/devicetree/bindings/i2c/i2c-at91.txt | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/i2c/i2c-at91.txt
b
The hold field allows to configure the data hold time which can be set
with the help of the generic binding 'i2c-sda-hold-time-ns'. This
feature has been introduced with SAMA5D4 SoC family.
Signed-off-by: Ludovic Desroches
---
drivers/i2c/busses/i2c-a
On Mon, Nov 30, 2015 at 04:13:20PM +0100, Wolfram Sang wrote:
> On Tue, Nov 24, 2015 at 02:47:40PM +0100, Ludovic Desroches wrote:
> > From: Wenyou Yang
> >
> > Add the HOLD field management. Some i2c devices need a longer data hold
> > time than the one given in the i
From: Wenyou Yang
Specify the device tree property "atmel,twd-hold-cycles" to 25
to adapt to the PMIC ACT8945A.
Signed-off-by: Wenyou Yang
---
arch/arm/boot/dts/at91-sama5d2_xplained.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts
b/arch/arm
From: Wenyou Yang
Add a DT property "atmel,twd-hold-cycles" to specify the HOLD
filed of TWIHS_CWGR register to increase the TWD hold time.
Signed-off-by: Wenyou Yang
Signed-off-by: Ludovic Desroches
---
Documentation/devicetree/bindings/i2c/i2c-at91.txt | 4
1 file
enyou Yang
Signed-off-by: Ludovic Desroches
---
drivers/i2c/busses/i2c-at91.c | 14 +++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/busses/i2c-at91.c
index 10835d1..b3595ea 100644
--- a/drivers/i2c/busses/i2c-at91.c
+++ b/d
-off-by: Ludovic Desroches
Fixes: 93563a6a71bb ("i2c: at91: fix a race condition when using the DMA
controller")
Reported-by: Peter Rosin
Tested-by: Peter Rosin
Cc: sta...@vger.kernel.org #4.1
---
Changes from v2:
- fix smatch warning: variable 'sr' set but not used
drivers
-off-by: Ludovic Desroches
Fixes: 93563a6a71bb ("i2c: at91: fix a race condition when using the DMA
controller")
Reported-by: Peter Rosin
Tested-by: Peter Rosin
Cc: sta...@vger.kernel.org #4.1
---
drivers/i2c/busses/i2c-at91.c | 33 +
1 file changed, 25
eter Rosin
Signed-off-by: Ludovic Desroches
Tested-by: Peter Rosin
Cc: sta...@vger.kernel.org #4.1
---
drivers/i2c/busses/i2c-at91.c | 58 +--
1 file changed, 50 insertions(+), 8 deletions(-)
diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/busses/
On Wed, Oct 21, 2015 at 09:42:40AM +0200, Peter Rosin wrote:
> On 2015-10-21 09:21, Peter Rosin wrote:
> > On 2015-10-20 15:27, Ludovic Desroches wrote:
> >> On Mon, Oct 19, 2015 at 12:49:03PM +0200, Peter Rosin wrote:
> >>> On 2015-10-19 10:51, Ludovic De
On Mon, Oct 19, 2015 at 12:49:03PM +0200, Peter Rosin wrote:
> On 2015-10-19 10:51, Ludovic Desroches wrote:
> > Hi Peter,
> >
> > On Fri, Oct 16, 2015 at 11:08:42AM +0200, Peter Rosin wrote:
> >> On 2015-10-16 01:47, Peter Rosin wrote:
> >>> On
Hi Peter,
On Fri, Oct 16, 2015 at 11:08:42AM +0200, Peter Rosin wrote:
> On 2015-10-16 01:47, Peter Rosin wrote:
> > On 2015-10-14 07:43, Ludovic Desroches wrote:
> >> On Tue, Oct 13, 2015 at 08:01:34PM +0200, Peter Rosin wrote:
> >>> On 2015-10-13 18:47, Cyrille
On Tue, Oct 13, 2015 at 08:01:34PM +0200, Peter Rosin wrote:
> On 2015-10-13 18:47, Cyrille Pitchen wrote:
> > Le 13/10/2015 17:19, Peter Rosin a écrit :
> >> On 2015-10-13 16:21, Ludovic Desroches wrote:
> >>> From: Cyrille Pitchen
> >>>
> >>>
eter Rosin
Signed-off-by: Ludovic Desroches
Cc: sta...@vger.kernel.org #4.1
---
drivers/i2c/busses/i2c-at91.c | 58 +--
1 file changed, 50 insertions(+), 8 deletions(-)
diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/busses/i2c-at91.c
index 1c758c
From: Wenyou Yang
Add a DT property "atmel,twd-hold-cycles" to specify the HOLD
field of TWIHS_CWGR register to increase the TWD hold time.
Signed-off-by: Wenyou Yang
Signed-off-by: Ludovic Desroches
---
Documentation/devicetree/bindings/i2c/i2c-at91.txt | 3 +++
1 file changed, 3
Signed-off-by: Ludovic Desroches
---
drivers/i2c/busses/i2c-at91.c | 16 +---
1 file changed, 13 insertions(+), 3 deletions(-)
diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/busses/i2c-at91.c
index 1c758cd..06e66ef 100644
--- a/drivers/i2c/busses/i2c-at91.c
+++ b/drivers/i2c/
On Thu, Jun 11, 2015 at 11:16:32AM +0200, Cyrille Pitchen wrote:
> buf_len is a size_t, so unsigned but was tested with '<= 0'.
>
> Signed-off-by: Cyrille Pitchen
Acked-by: Ludovic Desroches
Thanks
> ---
> drivers/i2c/busses/i2c-at91.c | 6 +++---
> 1 f
On Tue, Jun 09, 2015 at 10:46:20PM +0300, Sergei Shtylyov wrote:
> Hello.
>
> On 06/09/2015 07:22 PM, Cyrille Pitchen wrote:
>
> >The probe() function now prints the hardware version of the I2C
> >controller.
>
> >Signed-off-by: Cyrille Pitchen
> >---
> > drivers/i2c/busses/i2c-at91.c | 5
For the whole set of patches:
Acked-by: Ludovic Desroches
Thanks Cyrille
On Wed, Jun 03, 2015 at 06:25:16PM +0200, Cyrille Pitchen wrote:
> ChangeLog
>
> v5:
> - print I2C controller version in an already existing dev_info() instead of
> adding a new one.
>
> v4:
> -
On Wed, Jun 03, 2015 at 12:36:28AM +0900, Wolfram Sang wrote:
>
> > If you send a new version, could you add stable in Cc to patch 3/6:
>
> No need to send a new version just because of an additional ack. I can
> apply that. However...
>
> > Cc: sta...@vger.kernel.org #3.10 and later
> > If not,
Hi Cyrille,
For the whole serie:
Acked-by: Ludovic Desroches
If you send a new version, could you add stable in Cc to patch 3/6:
Cc: sta...@vger.kernel.org #3.10 and later
If not, Wolfram could you do it please?
Thanks
Ludovic
On Tue, Jun 02, 2015 at 03:18:30PM +0200, Cyrille Pitchen wrote
Hi Cyrille,
Could you split the patch about the new alternative command mode?
Reading some comments in your code, you also fixes bad management of the
interrupt flags. It would be great if we can send this as fixes for previous
kernels.
Thanks
Ludovic
On Mon, Jun 01, 2015 at 05:49:10PM +0200,
Hi Cyrille,
Some comments otherwise
Acked-by: Ludovic Desroches
On Fri, May 29, 2015 at 03:50:10PM +0200, Cyrille Pitchen wrote:
> When FIFOs are available and enabled, the driver now configures the Atmel
> eXtended DMA Controller to perform word accesses instead of byte accesses
On Fri, May 29, 2015 at 03:50:09PM +0200, Cyrille Pitchen wrote:
> The probe() function now prints the hardware version of the I2C controller
>
> Signed-off-by: Cyrille Pitchen
Acked-by: Ludovic Desroches
> ---
> drivers/i2c/busses/i2c-at91.c | 4
> 1 file cha
Hi Cyrille,
Some remarks, questions below.
On Fri, May 29, 2015 at 03:50:08PM +0200, Cyrille Pitchen wrote:
> The alternative command mode was introduced to simplify the transmission of
> STOP conditions and to solve timing and latency issues around them.
>
> This mode relies on a new register,
Hi Wolfram,
You can add my
Acked-by and Tested-By: Ludovic Desroches
Tested on sama5d3, some problems with at24 eeprom on sama5d4 but it
doesn't come from the i2c quirks patch series.
Regards
Ludovic
On Sun, Mar 08, 2015 at 09:28:45AM +0100, Wolfram Sang wrote:
> On Wed, Feb 25, 20
Hi Wolfram,
On Sun, Mar 08, 2015 at 09:28:45AM +0100, Wolfram Sang wrote:
> On Wed, Feb 25, 2015 at 05:01:54PM +0100, Wolfram Sang wrote:
> > From: Wolfram Sang
> >
> > Signed-off-by: Wolfram Sang
>
> Hi Ludovic,
>
> if you have a few minutes, could you please test this series? I'd like to
>
On Sun, Feb 08, 2015 at 11:12:07AM -0500, Nicholas Mc Guire wrote:
> Return type of wait_for_completion_timeout is unsigned long not int. This
> patch adds a timeout variable of appropriate type and fixes up the assignment.
>
> Signed-off-by: Nicholas Mc Guire
Acked-by: Ludov
Hi Wolfram,
On Fri, Jan 09, 2015 at 06:21:32PM +0100, Wolfram Sang wrote:
> Let the core do the checks if HW quirks prevent a transfer. Saves code
> from drivers and adds consistency.
>
> Signed-off-by: Wolfram Sang
> ---
> drivers/i2c/i2c-core.c | 53
>
Hi Douglas,
On Thu, Jan 01, 2015 at 01:02:13PM -0500, Douglas Gilbert wrote:
> With lk 3.19.0-rc2 and a at91sam9g25 (9x5) based system I
> connected a NXP SC16IS750 I2C to serial bridge. After
> routing the 750's IRQ back to the sc16is7xx driver and some
> simple successful test, it was time for s
If dma controller is not probed, defer i2c probe.
Signed-off-by: Ludovic Desroches
---
Arnd,
It's a combination of the first patch I sent and yours. As you said that my
patch "looks wrong but actually it's ok" I didn't dare to add your
signed-off-by.
drivers/i
From: Arnd Bergmann
Since at91sam9g45 is now DT-only, all DMA capable users of this driver
are using the DT case, and the legacy support can be removed.
Signed-off-by: Arnd Bergmann
Signed-off-by: Ludovic Desroches
---
Hi,
I have split the legacy dma support removing and probe deferring. I
On Wed, Nov 19, 2014 at 10:47:15AM +0100, Arnd Bergmann wrote:
> On Wednesday 19 November 2014 10:16:47 Wolfram Sang wrote:
> > On Fri, Nov 14, 2014 at 02:47:59PM +0100, Ludovic Desroches wrote:
> > > Return probe defer if requesting a dma channel without a dma contro
On Wed, Nov 19, 2014 at 10:16:47AM +0100, Wolfram Sang wrote:
> On Fri, Nov 14, 2014 at 02:47:59PM +0100, Ludovic Desroches wrote:
> > Return probe defer if requesting a dma channel without a dma controller
> > probed.
> >
> > Signed-off-by: Ludovic Desroches
> >
Return probe defer if requesting a dma channel without a dma controller probed.
Signed-off-by: Ludovic Desroches
---
drivers/i2c/busses/i2c-at91.c | 22 --
1 file changed, 16 insertions(+), 6 deletions(-)
diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/busses/i2c
On Mon, Nov 03, 2014 at 09:16:16PM +0100, Wolfram Sang wrote:
> iowait is for blkio [1]. I2C shouldn't use it.
>
> [1] https://lkml.org/lkml/2014/11/3/317
>
> Signed-off-by: Wolfram Sang
Acked-by: Ludovic Desroches
Thanks
> ---
> drivers/i2c/busses/i2c-at91.c |
For the whole serie
Acked-by: Ludovic Desroches
On Fri, Oct 24, 2014 at 02:50:14PM +0800, Wenyou Yang wrote:
> Hi Wolfram,
>
> The patches is to add the PM functions support for the at91 i2c controller.
>
> It is based on the i2c/for-next branch of
> git://git.kernel.org/pu
Hi,
On Thu, Oct 23, 2014 at 09:28:55AM -0400, Mark Roszko wrote:
> Hi Ludovic,
>
> Wolfram took in the patch quietly awhile back. It's in the 3.17 kernel
> and backported to some of the older trees.
> https://github.com/torvalds/linux/commit/75b81f339c6af43f6f4a1b3eabe0603321dade65
Great, sorry
gt; allowing RHR to be read to clear the RXRDY interrupt.
>
> Tested agaisnt a SMBus compliant battery.
>
> Signed-off-by: Marek Roszko
> Acked-by: Ludovic Desroches
> ---
> Change from v1:
> fixed typo in commit message
> reworded message slightly to be specifically s
Adding Kevin in the CC list since he had some comments about the PM
runtime support for the SPI driver.
On Mon, Oct 20, 2014 at 02:39:14PM +0200, Ludovic Desroches wrote:
> Hi Wenyou,
>
> On Mon, Oct 20, 2014 at 11:42:12AM +0800, Wenyou Yang wrote:
> > Drivers should put the
Adding Kevin in the CC list since he had some comments about the PM
runtime support for the SPI driver.
On Mon, Oct 20, 2014 at 02:42:42PM +0200, Ludovic Desroches wrote:
> On Mon, Oct 20, 2014 at 11:42:13AM +0800, Wenyou Yang wrote:
> > Signed-off-by: Wenyou Yang
>
> Ac
)
>
> This should make it possible to optimize energy usage for the pins
> both for the suspend/resume cycle
>
> Signed-off-by: Wenyou Yang
Acked by: Ludovic Desroches
> ---
> drivers/i2c/busses/i2c-at91.c | 12 +++-
> 1 file changed, 11 insertions(+), 1 de
On Mon, Oct 20, 2014 at 11:42:13AM +0800, Wenyou Yang wrote:
> Signed-off-by: Wenyou Yang
Acked by: Ludovic Desroches
> ---
> drivers/i2c/busses/i2c-at91.c | 30 ++
> 1 file changed, 30 insertions(+)
>
> diff --git a/drivers/i2c/busses/i2c-at
Hi Wenyou,
On Mon, Oct 20, 2014 at 11:42:12AM +0800, Wenyou Yang wrote:
> Drivers should put the device into low power states proactively whenever the
> device is not in use. Thus implement support for runtime PM and use the
> autosuspend feature to make sure that we can still perform well in case
shutting down the transfer and
> disabling the interrupts.
>
> Signed-off-by: Simon Lindgren
Acked-by: Ludovic Desroches
Thanks for this fix.
> ---
> drivers/i2c/busses/i2c-at91.c |4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/driver
d this patch.
Seems good, no objection to include this patch.
Only one comment: s/recieved/received otherwise
Acked-By: Ludovic Desroches
Sorry for the delay.
Ludovic
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majord...@vger.kernel.o
On Mon, Jul 21, 2014 at 11:42:03AM +0200, Wolfram Sang wrote:
> dma_{un}map_* uses 'enum dma_data_direction' not 'enum
> dma_transfer_direction'.
>
> Signed-off-by: Wolfram Sang
Acked-by: Ludovic Desroches
Thanks Wolfram.
> ---
> drivers/i2c/busses/i2
the removal. Keep
> the
> DEPRECATED flag, so the core can inform users that the behaviour finally
> changed now. After another transition period, this flag can go, too.
>
> Signed-off-by: Wolfram Sang
Acked-by: Ludovic Desroches
Thanks
> ---
> drivers/i2c/busses/i2c-a
lt to the previously used define of 100KHz.
>
> Signed-off-by: Marek Roszko
Acked-by: Ludovic Desroches
Thanks
> ---
> v2:
> -fixed return code usage and check to not compare agaisnt less than zero
>
> ---
> Documentation/devicetree/bindings/i2c/i2c-at
rty is not set, the
> clock
> frequency will default to the previously used define of 100KHz.
>
> Signed-off-by: Marek Roszko
Acked-by: Ludovic Desroches
> ---
> Documentation/devicetree/bindings/i2c/i2c-at91.txt |2 ++
> drivers/i2c/busses/i2c-at91.c
On Mon, Feb 10, 2014 at 11:03:58AM +0100, Wolfram Sang wrote:
> Warn users that class based instantiation is going away soon in favour
> of more robust probing and faster bootup times.
>
> Signed-off-by: Wolfram Sang
> Cc: Ludovic Desroches
Acked-by: Ludovic Des
On Tue, Dec 17, 2013 at 04:54:04PM +0100, Boris BREZILLON wrote:
> Document the clock properties required by the at91 i2c bus driver.
>
> Signed-off-by: Boris BREZILLON
Acked-by: Ludovic Desroches
> ---
> Documentation/devicetree/bindings/i2c/i2c-at91.txt |2 ++
>
61 matches
Mail list logo
