[PATCH] NFC: PN544: Add missing regulator.

2011-02-17 Thread Matti J. Aaltonen
Add regulator VSim to the regulator array. Signed-off-by: Matti J. Aaltonen matti.j.aalto...@nokia.com --- drivers/nfc/pn544.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/nfc/pn544.c b/drivers/nfc/pn544.c index bae6472..724f65d 100644 --- a/drivers/nfc

[PATCH v3 0/1] PN544 NFC driver.

2010-11-04 Thread Matti J. Aaltonen
', but argument 6 has type 'size_t' Fixed. On Fri, 2010-10-29 at 14:35 -0700, ext Andrew Morton wrote: On Fri, 29 Oct 2010 09:26:09 +0300 Matti J. Aaltonen matti.j.aalto...@nokia.com wrote: +static void __exit pn544_exit(void) +{ + flush_scheduled_work(); You said this had been removed

Re: [PATCH v2 0/1] PN544 NFC driver.

2010-11-01 Thread Matti J. Aaltonen
Hi. On Fri, 2010-10-29 at 14:33 -0700, ext Andrew Morton wrote: On Fri, 29 Oct 2010 09:26:08 +0300 Matti J. Aaltonen matti.j.aalto...@nokia.com wrote: Hello. And thanks to Andrew for the comments. include/linux/pn544.h | 99 ++ Is drivers/misc/ the best place

Re: [PATCH v2 1/1] NFC: Driver for NXP Semiconductors PN544 NFC chip.

2010-11-01 Thread Matti J. Aaltonen
On Fri, 2010-10-29 at 14:35 -0700, ext Andrew Morton wrote: On Fri, 29 Oct 2010 09:26:09 +0300 Matti J. Aaltonen matti.j.aalto...@nokia.com wrote: +static void __exit pn544_exit(void) +{ + flush_scheduled_work(); You said this had been removed. Did you send the correct version? I

Re: [PATCH v2 0/1] PN544 NFC driver.

2010-11-01 Thread Matti J. Aaltonen
On Fri, 2010-10-29 at 23:50 +0100, ext Mark Brown wrote: On Fri, Oct 29, 2010 at 02:33:33PM -0700, Andrew Morton wrote: Another consideration here is that if we do expect more NFC devices and drivers for them, then we should aim for some standardisation of the interface, from day one.

[PATCH v2 0/1] PN544 NFC driver.

2010-10-29 Thread Matti J. Aaltonen
if it's at all useful. Otherwise it should be enabled with a Kconfig variable, not via a code edit. Removed the test... + flush_scheduled_work(); This seems unneeded? We're trying to get rid of flush_scheduled_work(), btw. Removed flush_scheduled_work... Cheers, Matti Matti J. Aaltonen

[PATCH v2 1/1] NFC: Driver for NXP Semiconductors PN544 NFC chip.

2010-10-29 Thread Matti J. Aaltonen
This is a driver for the pn544 NFC device. The driver transfers ETSI messages between the device and the user space. Signed-off-by: Matti J. Aaltonen matti.j.aalto...@nokia.com --- Documentation/nfc/nfc-pn544.txt | 105 + drivers/Kconfig |2 + drivers/Makefile

[PATCH RFC] Misc: Driver for NXP Semiconductors PN544 NFC chip.

2010-10-25 Thread Matti J. Aaltonen
This is a driver for the pn544 NFC device. The driver transfers ETSI messages between the device and the user space. Signed-off-by: Matti J. Aaltonen matti.j.aalto...@nokia.com --- drivers/misc/Kconfig | 12 + drivers/misc/Makefile |1 + drivers/misc/pn544.c | 912

Re: [PATCH 2/4] leds: Driver for National Semiconductors LP5523 chip

2010-09-27 Thread Matti J. Aaltonen
Hello. My original intention was to send my comment directly to Samu. So an apology to all of you who don't understand Finnish. Basically I was commenting the use braces in the code fragments below... Regards, Matti On Mon, 2010-09-27 at 13:54 +0300, Matti J. Aaltonen wrote: Moi. On Thu

Re: [PATCH RFC 1/1] MISC: Broadcom BCM4751 GPS driver

2010-09-13 Thread Matti J. Aaltonen
On Fri, 2010-09-10 at 20:59 +0200, ext Andy Isaacson wrote: On Fri, Sep 03, 2010 at 02:07:27PM +0300, Matti J. Aaltonen wrote: On Mon, 2010-08-23 at 16:00 +0200, Aaltonen Matti.J (Nokia-MS/Tampere) wrote: Driver for Broadcom BCM4751 GPS chip. I sent this a while ago but didn't get any

Re: [PATCH RFC 1/1] MISC: Broadcom BCM4751 GPS driver

2010-08-27 Thread Matti J. Aaltonen
On Thu, 2010-08-26 at 22:09 +0200, ext Pavel Machek wrote: On Thu 2010-08-26 12:31:15, Matti J. Aaltonen wrote: Hello. On Wed, 2010-08-25 at 08:07 +0200, ext Pavel Machek wrote: On Mon 2010-08-23 17:00:26, Matti J. Aaltonen wrote: Driver for Broadcom BCM4751 GPS chip

Re: [PATCH RFC 1/1] MISC: Broadcom BCM4751 GPS driver

2010-08-26 Thread Matti J. Aaltonen
Hello. On Wed, 2010-08-25 at 08:07 +0200, ext Pavel Machek wrote: On Mon 2010-08-23 17:00:26, Matti J. Aaltonen wrote: Driver for Broadcom BCM4751 GPS chip. Uhuh. Tell us more... like what's the interface to userspace? NMEA data over char device

[PATCH RFC 0/1] MISC: Broadcom BCM4751 GPS driver

2010-08-23 Thread Matti J. Aaltonen
Hello, This is a driver for Broadcom's BCM4751 GPS chip and this is the first time this driver is sent for review, all comments are welcome. Thanks, Matti A. Matti J. Aaltonen (1): MISC: Broadcom BCM4751 GPS driver drivers/misc/Kconfig| 11 + drivers/misc/Makefile

[PATCH RFC 1/1] MISC: Broadcom BCM4751 GPS driver

2010-08-23 Thread Matti J. Aaltonen
Driver for Broadcom BCM4751 GPS chip. Signed-off-by: Matti J. Aaltonen matti.j.aalto...@nokia.com --- drivers/misc/Kconfig| 11 + drivers/misc/Makefile |1 + drivers/misc/bcm4751-gps.c | 490 +++ include/linux/i2c/bcm4751