Re: [PATCH 3/8] i2c: omap: fix error checking

2012-10-25 Thread Michael Trimarchi
Hi On 10/25/2012 12:10 PM, Felipe Balbi wrote: > Hi, > > On Wed, Oct 24, 2012 at 04:41:11PM +0200, Michael Trimarchi wrote: >> Hi >> >> On 10/22/2012 11:46 AM, Felipe Balbi wrote: >>> It's impossible to have Arbitration Lost, >>> Read Overflow, a

Re: [PATCH 3/8] i2c: omap: fix error checking

2012-10-24 Thread Michael Trimarchi
Hi On 10/22/2012 11:46 AM, Felipe Balbi wrote: > It's impossible to have Arbitration Lost, > Read Overflow, and Tranmist Underflow all > asserted at the same time. > > Those error conditions are mutually exclusive > so what the code should be doing, instead, is > check each error flag separataly.

[RFC] Fix stuck on cpm-i2c driver

2009-06-19 Thread Michael Trimarchi
meout with wait_event_timeout, leaving the signals to be handled in other points on the upper layers. Signed-off-by: Bruno Morelli Signed-off-by: Michael Trimarchi --- diff --git a/drivers/i2c/busses/i2c-cpm.c b/drivers/i2c/busses/i2c-cpm.c index b5db8b8..9c2e100 100644 --- a/drivers/i2c/busses/i2c-cpm.c +++