Re: [PATCH 2/2] i2c: exynos5: fix minor styling nits

2014-06-25 Thread Naveen Krishna Ch
Hello Sachin, On 25 June 2014 16:19, Sachin Kamat spk.li...@gmail.com wrote: Hi Naveen, On Wed, Jun 25, 2014 at 4:08 PM, Naveen Krishna Chatradhi ch.nav...@samsung.com wrote: This patch removes an extra line and fixes a styling nit in exynos5_i2c_message_start() Signed-off-by: Naveen

Re: [PATCH] i2c: exynos5: add support for HSI2C on Exynos5260 SoC

2014-05-21 Thread Naveen Krishna Ch
Hello Wolfram, On 21 May 2014 16:04, Wolfram Sang w...@the-dreams.de wrote: On Mon, Apr 28, 2014 at 02:29:58PM +0530, Naveen Krishna Chatradhi wrote: HSI2C module on Exynos5260 differs from current modules in following ways: 1. HSI2C on Exynos5260 has fifo_depth of 16bytes 2. Module needs

Re: [PATCH] i2c: exynos5: Initialise Samsung High Speed I2C controller early

2014-05-21 Thread Naveen Krishna Ch
Hello Wolfram, On 21 May 2014 15:55, Wolfram Sang w...@the-dreams.de wrote: On Fri, May 09, 2014 at 03:54:25PM +0100, Mark Brown wrote: On Fri, May 09, 2014 at 08:12:47PM +0530, Naveen Krishna Ch wrote: On 9 May 2014 19:21, Mark Brown broo...@kernel.org wrote: On Fri, May 09, 2014 at 05:50

Re: [PATCH] i2c: exynos5: Initialise Samsung High Speed I2C controller early

2014-05-09 Thread Naveen Krishna Ch
Hello Mark, On 24 April 2014 21:55, Mark Brown broo...@kernel.org wrote: On Thu, Apr 24, 2014 at 08:18:36PM +0530, Naveen Krishna Chatradhi wrote: This patch moves initialization code to subsys_initcall() to ensure that the i2c bus is available early so the regulators can be quickly probed

Re: [PATCH] i2c: exynos5: Initialise Samsung High Speed I2C controller early

2014-05-09 Thread Naveen Krishna Ch
Hello Mark, On 9 May 2014 19:21, Mark Brown broo...@kernel.org wrote: On Fri, May 09, 2014 at 05:50:00PM +0530, Naveen Krishna Ch wrote: On 24 April 2014 21:55, Mark Brown broo...@kernel.org wrote: Such solution has been proposed by Mark Brown to fix the problem of the regulators

Re: [PATCH 2/2 v4] i2c: exynos5: configure fifo_depth based on HSI2C module variant

2014-04-28 Thread Naveen Krishna Ch
Hello Wolfram, On 13 March 2014 00:50, Wolfram Sang w...@the-dreams.de wrote: On Fri, Feb 07, 2014 at 10:13:15AM +0530, Naveen Krishna Chatradhi wrote: fifo_depth of the HSI2C is not constant Exynos5420 and Exynos5250 supports fifo_depth of 64bytes Exynos5260 supports fifo_depth of 16bytes.

Re: [PATCH 1/2 v4] i2c: exynos5: add support for HSI2C on Exynos5260 SoC

2014-04-28 Thread Naveen Krishna Ch
Hello Wolfram, On 13 March 2014 00:48, Wolfram Sang w...@the-dreams.de wrote: On Fri, Feb 07, 2014 at 10:12:51AM +0530, Naveen Krishna Chatradhi wrote: This patch adds a new compatible and uses variant struct to support HSI2C module on Exynos5260. Updates the Documentation dt bindings. Also

Re: [PATCH 2/2] i2c: exynos5: remove unnecessary cast of void pointer

2014-03-12 Thread Naveen Krishna Ch
Hello Mr. Han, On 11 March 2014 10:22, Jingoo Han jg1@samsung.com wrote: Remove unnecessary cast of void pointer, because 'algo_data' of 'struct i2c_adapter' is a void pointer. Casting the void pointer is redundant. The conversion from void pointer to any other pointer type is guaranteed

Re: [PATCH 1/2] i2c-s3c2410: Leave the bus disabled unless it is in use

2014-02-07 Thread Naveen Krishna Ch
Hello Wolfram, Sorry for a replying after really long time. On 24 January 2013 17:50, Wolfram Sang w.s...@pengutronix.de wrote: On Thu, Nov 29, 2012 at 10:35:34AM +0530, Naveen Krishna Chatradhi wrote: From: Simon Glass s...@chromium.org There is a rather odd feature of the exynos i2c

Re: [PATCH 2/2] i2c: exynos5: configure fifo_depth based on HSI2C module version

2013-12-09 Thread Naveen Krishna Ch
Hello Tomasz, On 9 December 2013 22:01, Tomasz Figa t.f...@samsung.com wrote: Hi Naveen, On Friday 22 of November 2013 11:44:11 Naveen Krishna Chatradhi wrote: fifo_depth of the HSI2C is not constant Exynos5420 and Exynos5250 supports fifo_depth of 64bytes Exynos5260 supports

Re: [PATCH 1/2 v2] i2c: exynos5: add support for HSI2C on Exynos5260 SoC

2013-11-26 Thread Naveen Krishna Ch
Hello Sachin, On 26 November 2013 16:59, Sachin Kamat sachin.ka...@linaro.org wrote: On 26 November 2013 09:56, Naveen Krishna Chatradhi ch.nav...@samsung.com wrote: This patch adds new compatible to support HSI2C module on Exynos5260 HSI2C module on Exynos5260 needs to be reset during during

Re: [PATCH v3] i2c: s3c2410: dont need CPU_FREQ transitions for exynos series

2013-11-25 Thread Naveen Krishna Ch
Hello Doug, On 26 November 2013 05:11, Doug Anderson diand...@chromium.org wrote: Naveen, On Mon, Nov 18, 2013 at 10:18 PM, Naveen Krishna Chatradhi ch.nav...@samsung.com wrote: For Exynos4 and Exynos5 SoCs from Samsung the i2c clock is based on a fixed 66 MHz peripheral clock, and

Re: [PATCH 1/2] i2c: exynos5: add support for HSI2C on Exynos5260 SoC

2013-11-21 Thread Naveen Krishna Ch
Hello Yuvaraj, On 22 November 2013 12:16, Yuvaraj Cd yuvaraj.l...@gmail.com wrote: On Fri, Nov 22, 2013 at 11:42 AM, Naveen Krishna Chatradhi ch.nav...@samsung.com wrote: This patch adds new compatible to support HSI2C module on Exynos5260 HSI2C module on Exynos5260 needs to be reset during

Re: [PATCH 1/1] i2c: exynos5: Remove incorrect clk_disable_unprepare

2013-11-07 Thread Naveen Krishna Ch
On 6 November 2013 15:09, Sachin Kamat sachin.ka...@linaro.org wrote: clk_disable_unprepare in remove causes an imbalance and hence gives the below crash on module remove. While at it also remove some duplicate code from probe. / $ rmmod i2c-exynos5 [6.996374] [ cut here

Re: [PATCH 1/1] i2c: exynos5: Use reinit_completion instead of INIT_COMPLETION

2013-11-05 Thread Naveen Krishna Ch
On 5 November 2013 14:57, Sachin Kamat sachin.ka...@linaro.org wrote: INIT_COMPLETION was replaced by reinit_completion vide commit 2c9627cca471 (tree-wide: use reinit_completion instead of INIT_COMPLETION). Use it to avoid the following build error: drivers/i2c/busses/i2c-exynos5.c:538:9:

Re: [PATCH 1/3 v3] exynos: i2c: Fix i2c driver to handle NACKs properly

2013-10-15 Thread Naveen Krishna Ch
On 15 October 2013 11:36, Heiko Schocher h...@denx.de wrote: Hello Naveen, Am 15.10.2013 07:12, schrieb Naveen Krishna Chatradhi: The Exynos5 i2c driver does not handle NACKs properly. This change: - fixes the NACK processing problem (do not continue transaction if address cycle was

Re: [PATCH] i2c: s3c2410: dont need CPU_FREQ transitions for exynos series

2013-10-12 Thread Naveen Krishna Ch
On 12 October 2013 11:12, Tomasz Figa t.f...@samsung.com wrote: On Saturday 12 of October 2013 04:28:51 Tomasz Figa wrote: [Fixing incorrent mail addresses and dropping the old DT ML.] On Saturday 12 of October 2013 04:22:04 Tomasz Figa wrote: Hi Naveen, On Friday 11 of October 2013

Re: [PATCH v9] i2c: exynos5: add High Speed I2C controller driver

2013-05-23 Thread Naveen Krishna Ch
On 17 May 2013 15:40, Naveen Krishna Chatradhi ch.nav...@samsung.com wrote: Adds support for High Speed I2C driver found in Exynos5 and later SoCs from Samsung. Driver only supports Device Tree method. Changes since v1: 1. Added FIFO functionality 2. Added High speed mode functionality 3.

Re: Fwd: [PATCH v7] i2c: exynos5: add High Speed I2C controller driver

2013-05-02 Thread Naveen Krishna Ch
On 2 May 2013 16:57, Wolfram Sang w...@the-dreams.de wrote: Hi, + - Samsung GPIO variant (deprecated): +- gpios: The order of the gpios should be the following: SDA, SCL. + The gpio specifier depends on the gpio controller. Huh? Why should we support a deprecated method with

Fwd: [PATCH v7] i2c: exynos5: add High Speed I2C controller driver

2013-05-01 Thread Naveen Krishna Ch
On 16 April 2013 15:59, Wolfram Sang w...@the-dreams.de wrote: Hi, thanks for the submission. On Thu, Apr 04, 2013 at 09:52:01PM -0700, Naveen Krishna Chatradhi wrote: From: Naveen Krishna Chatradhi ch.nav...@samsung.com Adds support for High Speed I2C driver found in Exynos5 and later

Re: [PATCH v7] i2c: exynos5: add High Speed I2C controller driver

2013-04-12 Thread Naveen Krishna Ch
On 5 April 2013 10:22, Naveen Krishna Chatradhi naveenkrishna...@gmail.com wrote: From: Naveen Krishna Chatradhi ch.nav...@samsung.com Adds support for High Speed I2C driver found in Exynos5 and later SoCs from Samsung. This driver currently supports Auto mode. Driver only supports Device

Re: [PATCH v3] i2c: exynos5: add High Speed I2C controller driver

2013-01-22 Thread Naveen Krishna Ch
On 28 December 2012 16:57, Naveen Krishna Chatradhi ch.nav...@samsung.com wrote: Adds support for High Speed I2C driver found in Exynos5 and later SoCs from Samsung. This driver currently supports Auto mode. Driver only supports Device Tree method of passing platform data. Note: Added debugfs

Re: [PATCH v3] i2c: exynos5: add High Speed I2C controller driver

2013-01-14 Thread Naveen Krishna Ch
On 28 December 2012 22:06, Naveen Krishna Ch naveenkrishna...@gmail.com wrote: On 28 December 2012 16:57, Naveen Krishna Chatradhi ch.nav...@samsung.com wrote: Adds support for High Speed I2C driver found in Exynos5 and later SoCs from Samsung. This driver currently supports Auto mode

Re: [PATCH v3] i2c: exynos5: add High Speed I2C controller driver

2012-12-28 Thread Naveen Krishna Ch
On 28 December 2012 16:57, Naveen Krishna Chatradhi ch.nav...@samsung.com wrote: Adds support for High Speed I2C driver found in Exynos5 and later SoCs from Samsung. This driver currently supports Auto mode. Driver only supports Device Tree method of passing platform data. Note: Added debugfs

Re: [PATCH 2/2] i2c-s3c2410: Add bus arbitration implementation

2012-12-03 Thread Naveen Krishna Ch
On 4 December 2012 05:41, Olof Johansson o...@lixom.net wrote: On Sat, Dec 1, 2012 at 5:26 AM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Thu, Nov 29, 2012 at 10:14:58PM -0800, Olof Johansson wrote: On Thu, Nov 29, 2012 at 6:13 PM, Simon Glass s...@chromium.org wrote: It was

Re: [PATCH 1/3] i2c: exynos5: add High Speed I2C controller driver

2012-11-27 Thread Naveen Krishna Ch
Hello Felipe, Thomas, Thanks for your time and valuable comments, I will post the next version with you comments addressed. On 27 November 2012 19:04, Thomas Abraham thomas.abra...@linaro.org wrote: On 27 November 2012 18:30, Naveen Krishna Chatradhi ch.nav...@samsung.com wrote: Adds