will go
into arm-soc. It'll be queued in at91-4.5-dt branch soon.
Acked-by: Nicolas Ferre
> ---
> arch/arm/boot/dts/sama5d4.dtsi | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/sama5d4.dtsi b/arch/arm/boot/dts/sama5d4
.5-dt branch
soon.
Acked-by: Nicolas Ferre
Thanks, bye.
> ---
> arch/arm/boot/dts/at91-sama5d2_xplained.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts
> b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
> index ad6de73
Le 03/12/2015 10:53, Ludovic Desroches a écrit :
> The i2c-sda-hold-time-ns property is supported from atmel,sama5d4-i2c.
>
> Signed-off-by: Ludovic Desroches
> Acked-by: Rob Herring
Acked-by: Nicolas Ferre
> ---
> Documentation/devicetree/bindings/i2c/i2c-at91.txt |
ovic Desroches
Acked-by: Nicolas Ferre
> ---
> drivers/i2c/busses/i2c-at91.c | 53
> ---
> 1 file changed, 50 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/busses/i2c-at91.c
> index 10835d1.
i2c-sda-hold-time-ns = <350>;
> status = "okay";
>
> pmic: act8865@5b {
>
--
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Le 02/12/2015 11:39, Ludovic Desroches a écrit :
> A new compatible string has been introduced: atmel,sama5d4-i2c. It
> allows to use the i2c-sda-hold-time-ns property if needed.
>
> Signed-off-by: Ludovic Desroches
Acked-by: Nicolas Ferre
Ok, we'll need to synchronize with
amples :
> @@ -52,6 +53,7 @@ i2c0: i2c@f8034600 {
> #size-cells = <0>;
> clocks = <&flx0>;
> atmel,fifo-size = <16>;
> + i2c-sda-hold-time-ns = <336>;
>
> wm8731: wm8731@1a {
> compatible = "wm8731";
>
--
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
ama5d2_config = {
> @@ -861,6 +905,7 @@ static struct at91_twi_pdata sama5d2_config = {
> .clk_offset = 4,
> .has_unre_flag = true,
> .has_alt_cmd = true,
> + .has_hold_field = true,
> };
>
> static const struct of_device_id atmel_twi_dt_ids[] = {
> @@ -883,6 +928,9 @@ stat
= {
> .clk_max_div = 5,
> .clk_offset = 4,
> .has_unre_flag = false,
> + .has_alt_cmd = false,
> };
>
> static struct at91_twi_pdata at91sam9260_config = {
> .clk_max_div = 7,
> .clk_offset = 4,
> .has_unre_flag = false,
> +
interrupts = <19 IRQ_TYPE_LEVEL_HIGH 7>;
> + dmas = <&dma0
> + (AT91_XDMAC_DT_MEM_IF(0) | AT91_XDMAC_DT_PER_IF(1))
> + AT91_XDMAC_DT_PERID(11)>,
> + <&dma0
> + (AT91_XDMAC_DT_MEM_IF(0) | AT91_XDMAC_DT_PER_
On 15/01/2014 11:24, Jean-Jacques Hiblot :
> Signed-off-by: Jean-Jacques Hiblot
Acked-by: Nicolas Ferre
Thanks Jean-Jacques.
Side note: do not forget i2c maintainer and ml.
> ---
> drivers/i2c/busses/i2c-at91.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/
On 17/12/2013 16:54, Boris BREZILLON :
> Document the clock properties required by the at91 i2c bus driver.
>
> Signed-off-by: Boris BREZILLON
Acked-by: Nicolas Ferre
> ---
> Documentation/devicetree/bindings/i2c/i2c-at91.txt |2 ++
> 1 file changed, 2 insertions(+)
On 02/12/2013 09:42, Nicolas Ferre :
On 22/11/2013 17:08, ludovic.desroc...@atmel.com :
From: Ludovic Desroches
With some devices, transfer hangs during I2C frame transmission. This issue
disappears when reducing the internal frequency of the TWI IP. Even if it is
indicated that internal
have
oversampling on I2C signals making TWI believe that a transfer in progress
is done.
This fix has no impact on the I2C bus frequency.
Cc: #3.10+
Acked-by: Nicolas Ferre
Signed-off-by: Ludovic Desroches
added to at91-3.14-dt branch.
thanks,
---
v2: update commit message
arch/arm
= AT91_PMC_PCR_DIV2,
+ .div= AT91_PMC_PCR_DIV8,
};
static struct clk mmc0_clk = {
.name = "mci0_clk",
--
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a messa
essage IMO :)
Ok I'll update it.
Ludo, you can also add my:
Acked-by: Nicolas Ferre
Bye,
Thanks for the review Wolfram.
Regards
Ludovic
--
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to major
On 04/19/2013 11:11 AM, ludovic.desroc...@atmel.com :
> From: Ludovic Desroches
>
> Use generic DMA DT helper. Platforms booting with or without DT populated are
> both supported.
>
> Signed-off-by: Ludovic Desroches
> Acked-by: Jean-Christophe PLAGNIOL-VILLARD
> Acke
On 04/23/2013 05:44 AM, Vinod Koul :
> On Mon, Apr 22, 2013 at 12:22:32PM +0200, Nicolas Ferre wrote:
>> On 04/19/2013 11:11 AM, ludovic.desroc...@atmel.com :
>>> From: Ludovic Desroches
>
>>> +#ifdef CONFIG_OF
>>> +static bool at_dma_filter(struct dma
gt; Signed-off-by: Ludovic Desroches
> Acked-by: Nicolas Ferre
> Acked-by: Jean-Christophe PLAGNIOL-VILLARD
> Acked-by: Arnd Bergmann
Hi Vinod,
As you were not in copy of the patch, I send you a little reminder for
it. It is part of a series by Ludovic and is adding the generic slave
DMA d
ma phandle name]
Acked-by: Nicolas Ferre
And stacked in at91-3.10-soc.
thanks,
> ---
> arch/arm/boot/dts/at91sam9n12.dtsi | 6 ++
> arch/arm/boot/dts/at91sam9x5.dtsi | 9 +
> arch/arm/boot/dts/sama5d3.dtsi | 9 +
> 3 files changed, 24 insertions(+)
>
ma phandle name]
Acked-by: Nicolas Ferre
And stacked in at91-3.10-soc.
thanks,
> ---
> arch/arm/boot/dts/at91sam9g45.dtsi | 4
> arch/arm/boot/dts/at91sam9n12.dtsi | 2 ++
> arch/arm/boot/dts/at91sam9x5.dtsi | 4
> arch/arm/boot/dts/sama5d3.dtsi | 6 ++
>
On 04/19/2013 11:11 AM, ludovic.desroc...@atmel.com :
> From: Ludovic Desroches
>
> Moving to generic DMA DT binding involves to set #dma-cells to 2.
>
> Signed-off-by: Ludovic Desroches
Acked-by: Nicolas Ferre
And stacked in at91-3.10-soc.
thanks,
> ---
> arch/arm
gt; Signed-off-by: Ludovic Desroches
> Acked-by: Nicolas Ferre
> Acked-by: Jean-Christophe PLAGNIOL-VILLARD
I plan to make this whole series go forward for 3.10 because of the
sensitive nature of DMA bindings and the expectations of everybody on
this topic ;-)
Arnd,
Do you feel like giving your &
On 04/15/2013 02:16 PM, ludovic.desroc...@atmel.com :
> From: Ludovic Desroches
>
> Use generic DMA DT helper. Platforms booting with or without DT populated are
> both supported.
>
> Signed-off-by: Ludovic Desroches
Acked-by: Nicolas Ferre
> ---
> drivers/m
gt; Signed-off-by: Ludovic Desroches
Some minor comments but the overall is good: so, after adding a little
more explanation to documentation:
Acked-by: Nicolas Ferre
Very nice and concise patch for adding such an important feature: kudos!
> ---
> .../devicetree/bindings/dma/atmel-dma.txt
On 03/15/2013 04:32 PM, ludovic.desroc...@atmel.com :
> From: Ludovic Desroches
>
> Create an entry for atmel i2c driver: i2c-at91.c
>
> Signed-off-by: Ludovic Desroches
Acked-by: Nicolas Ferre
> ---
> Hello,
>
> If there are no objections, I'll take the ma
ng this should cause to send the
> STOP command too late and then to get extra data in the receive
> register.
>
> Signed-off-by: Ludovic Desroches
Even nicer ;-)
Acked-by: Nicolas Ferre
> ---
> drivers/i2c/busses/i2c-at91.c | 306
> ++
ce... You know my preferences ;-)
> Signed-off-by: Ludovic Desroches
Ok, then:
Acked-by: Nicolas Ferre
> ---
> drivers/i2c/busses/i2c-at91.c | 30 +++---
> 1 file changed, 15 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-at91.c b/dr
On 11/14/2012 05:44 PM, ludovic.desroc...@atmel.com :
> From: Ludovic Desroches
>
> Signed-off-by: Ludovic Desroches
Acked-by: Nicolas Ferre
Maybe tell Wolfram to remove this one from the series and add it to his
3.7 tree...
Bye,
> ---
> drivers/i2c/busses/i2c-at91.c |
ng this should cause to send the
> STOP command too late and then to get extra data in the receive
> register.
>
> Signed-off-by: Ludovic Desroches
Acked-by: Nicolas Ferre
Nice work Ludo ;-) !
Bye,
> ---
> drivers/i2c/busses/i2c-at91.c | 326
> +
On 10/15/2012 10:26 AM, Bo Shen :
> Hi Nicolas,
>
> On 10/15/2012 16:12, Nicolas Ferre wrote:
>> On 10/15/2012 04:09 AM, Bo Shen :
>>> Hi Joachim Eastwood,
>>>
>>> On 10/13/2012 1:42, Joachim Eastwood wrote:
>>>> Hi Bo Shen,
>>>>
c you might want to fix
>> them as well.
>
> Thanks for your information.
> After I test these boards, I will send patches to fix them, while not in
> this patch.
I am in favor of doing a comprehensive patch series that covers all
aspects of this issue:
- each boards
- both
sam9rl.c| 4 +-
> arch/arm/mach-at91/at91sam9rl_devices.c| 2 +-
> arch/arm/mach-at91/at91sam9x5.c| 6 +-
> drivers/i2c/busses/Kconfig | 6 +
> drivers/i2c/busses/i2c-at91.c | 217
> +
ubject, it is actually the
real v12 patch series from Nikolaus.
BTW, I suspect that you were not in copy...
In addition to the "Tested-By" tag by Ludovic, you can add my:
Reviewed-by: Nicolas Ferre
> Nikolaus Voss (4):
> drivers/i2c/busses/i2c-at91.c: remove old polling driver
dts: add twi nodes for atmel boards
For the whole patch series (with Jean-Christophe remarks about *dts
modifications*):
Acked-by: Nicolas Ferre
> .../devicetree/bindings/i2c/atmel-i2c.txt | 30 +++
> arch/arm/boot/dts/at91sam9260.dtsi | 23 +--
> ar
and break the Calao
Yes, Ludovic shall keep i2c-gpio at the side of the new twi driver.
But for the platform, the platform maintainer will have to choose the
one or the other.
Bye,
--
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message
no issue on the hw
> IP. For hte onther one keep both in the dtsi
Yes, I agree with this.
Bye,
--
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
; as we need to touch the driver to add a new soc
So what? We still keep the compatibility if the new SoC has it
compatibility assured with previous revision: there is nothing to modify.
> please use platform data
No, it does not have to be exposed to the user: these data are highly
dependent
On 08/21/2012 04:32 PM, ludovic.desroc...@atmel.com :
> From: Ludovic Desroches
>
> Use the atmel twi instead of gpio for i2c stuff.
>
> Signed-off-by: Ludovic Desroches
Seems good. Maybe we will have to test wm8731 a little bit more.
Acked-by: Nicolas Ferre
> ---
&g
On 08/21/2012 04:29 PM, ludovic.desroc...@atmel.com :
> From: Ludovic Desroches
>
> Add twi nodes for atmel SOCs and remove i2c-gpio ones.
>
> Signed-off-by: Ludovic Desroches
Yes, we will move to it once people test it a little bit...
Acked-by: Nicolas Ferre
> ---
&g
On 08/21/2012 04:29 PM, ludovic.desroc...@atmel.com :
> From: Ludovic Desroches
>
> Signed-off-by: Ludovic Desroches
Acked-by: Nicolas Ferre
> ---
> arch/arm/mach-at91/at91sam9260.c | 1 +
> arch/arm/mach-at91/at91sam9263.c | 1 +
> arch/arm/mach-at91/at91sam9g45.c |
91_twi_pm_ops NULL
> #endif
>
> +#ifdef CONFIG_OF
> +static const struct of_device_id at91_twi_dt_ids[] = {
> + { .compatible = "atmel,at91rm9200-i2c", },
> + { .compatible = "atmel,at91sam9260-i2c", },
> + { .compatible = "atmel,at91sam9261-i2c&q
offset);
> + ckdiv = fls(div >> 8);
> + cdiv = div >> ckdiv;
> +
> + if (ckdiv > max_ckdiv) {
> + dev_warn(dev->dev, "%d exceeds ckdiv max value which is %d.\n",
> + ckdiv, max_ckdiv);
> +
and has worked for ages.
Do you think it is related to the need to be able to compile the
driver for any SoC in the case of multi-SoC zImage support?
Best regards,
- --
Nicolas Ferre
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - htt
iver falls under
> his jurisdiction. But for what it's worth, I consider the small-steps
> rule void when it comes to fixing a plain broken driver by almost fully
> rewriting it. The reviewer should really review the resulting code
> rather than the patch. If it makes everybody happier,
45 matches
Mail list logo
