Re: [PATCH] i2c: i2c-sh_mobile device tree support

2012-04-18 Thread Paul Mundt
On Wed, Apr 18, 2012 at 04:08:39PM +0200, Wolfram Sang wrote: > Hi Paul, > > > > Of course, if you think it is cramping your SH device tree style then > > > we can easily add a "renesas-shmobile-iic" entry as well. > > > > > I obviously don't mind if you wish to use the rmobile naming convention

Re: [PATCH] i2c: i2c-sh_mobile device tree support

2012-03-30 Thread Paul Mundt
On Fri, Mar 30, 2012 at 05:53:35PM +0900, Magnus Damm wrote: > On Fri, Mar 30, 2012 at 5:47 PM, Paul Mundt wrote: > > On Fri, Mar 30, 2012 at 05:44:02PM +0900, Magnus Damm wrote: > >> +static const struct of_device_id sh_mobile_i2c_dt_ids[] __devinitconst = { > >> + ?

Re: [PATCH] i2c: i2c-sh_mobile device tree support

2012-03-30 Thread Paul Mundt
On Fri, Mar 30, 2012 at 05:44:02PM +0900, Magnus Damm wrote: > +static const struct of_device_id sh_mobile_i2c_dt_ids[] __devinitconst = { > + { .compatible = "renesas,rmobile-iic", }, > + {}, > +}; > +MODULE_DEVICE_TABLE(of, sh_mobile_i2c_dt_ids); > + Given that this block predates R-Mobil

Re: [PATCH 1/2] i2c: i2c-riic: add support for Renesas RIIC

2011-07-10 Thread Paul Mundt
On Mon, Jul 11, 2011 at 08:03:35AM +0200, Jean Delvare wrote: > On Mon, 11 Jul 2011 14:52:21 +0900, Paul Mundt wrote: > > On Fri, Jul 01, 2011 at 10:00:42AM +0900, Yoshihiro Shimoda wrote: > > > This driver supports the RIIC module. The SH7757 has it. > > > The driver

Re: [PATCH 1/2] i2c: i2c-riic: add support for Renesas RIIC

2011-07-10 Thread Paul Mundt
On Fri, Jul 01, 2011 at 10:00:42AM +0900, Yoshihiro Shimoda wrote: > This driver supports the RIIC module. The SH7757 has it. > The driver doesn't use any IRQ handler. > > Signed-off-by: Yoshihiro Shimoda > --- > drivers/i2c/busses/Kconfig|9 + > drivers/i2c/busses/Makefile |1 + >

Re: [PATCH] i2c: i2c-sh_mobile bus speed platform data

2011-04-27 Thread Paul Mundt
On Thu, Apr 28, 2011 at 11:46:37AM +0900, Magnus Damm wrote: > On Thu, Apr 28, 2011 at 11:22 AM, Paul Mundt wrote: > > On Thu, Apr 28, 2011 at 10:18:01AM +0900, Simon Horman wrote: > >> On Thu, Apr 28, 2011 at 10:06:38AM +0900, Magnus Damm wrote: > >> > On Thu,

Re: [PATCH] i2c: i2c-sh_mobile bus speed platform data

2011-04-27 Thread Paul Mundt
On Thu, Apr 28, 2011 at 10:18:01AM +0900, Simon Horman wrote: > On Thu, Apr 28, 2011 at 10:06:38AM +0900, Magnus Damm wrote: > > On Thu, Apr 28, 2011 at 7:14 AM, Simon Horman wrote: > > > I believe that on the sh73a0 and so far only the sh73a0 > > > denom needs to be doubled. > > > > Uhm, I don't

Re: [PATCH 1/2] sh: fix SD / MMC configuration dependencies on ecovec

2011-04-18 Thread Paul Mundt
On Fri, Apr 15, 2011 at 08:03:17PM +0200, Guennadi Liakhovetski wrote: > Update CONFIG_MMC_TMIO to the new CONFIG_MMC_SDHI symbol and fix > MMCIF to also function in modular builds for ecovec. On Fri, Apr 15, 2011 at 08:04:12PM +0200, Guennadi Liakhovetski wrote: > arch/sh/configs/ecovec24_defcon

Re: [PATCH] Input: tca6416-keypad: Change to module_init()

2011-03-22 Thread Paul Mundt
On Wed, Mar 23, 2011 at 12:43:54AM +0900, Magnus Damm wrote: > On Wed, Mar 23, 2011 at 12:32 AM, Paul Mundt wrote: > > On Wed, Mar 23, 2011 at 12:22:05AM +0900, Magnus Damm wrote: > >> I believe all other i2c keyboard drivers use module_init(). > >> > > We do no

Re: [PATCH] Input: tca6416-keypad: Change to module_init()

2011-03-22 Thread Paul Mundt
On Wed, Mar 23, 2011 at 12:22:05AM +0900, Magnus Damm wrote: > On Tue, Mar 22, 2011 at 11:33 PM, Paul Mundt wrote: > > On Tue, Mar 22, 2011 at 02:28:55PM +, Mark Brown wrote: > >> On Tue, Mar 22, 2011 at 11:26:19PM +0900, Magnus Damm wrote: > >> > >> >

Re: [PATCH] Input: tca6416-keypad: Change to module_init()

2011-03-22 Thread Paul Mundt
On Tue, Mar 22, 2011 at 02:28:55PM +, Mark Brown wrote: > On Tue, Mar 22, 2011 at 11:26:19PM +0900, Magnus Damm wrote: > > > The tca6416 driver makes use of the I2C bus for chatting > > with the actual hardware device. Without this patch both > > the I2C bus driver and the tca6416 driver are i

Re: [PATCH] sh: i2c-sh7760: Replase from ctrl_* to __raw_*

2010-10-25 Thread Paul Mundt
On Tue, Oct 26, 2010 at 07:43:07AM +0100, Ben Dooks wrote: > On Tue, Oct 26, 2010 at 01:02:03PM +0900, Paul Mundt wrote: > > On Tue, Oct 26, 2010 at 09:08:12AM +0900, Nobuhiro Iwamatsu wrote: > > > 2010/10/25 Ben Dooks : > > > > On Mon, Oct 25, 2010 at 08:1

Re: [PATCH] sh: i2c-sh7760: Replase from ctrl_* to __raw_*

2010-10-25 Thread Paul Mundt
On Tue, Oct 26, 2010 at 09:08:12AM +0900, Nobuhiro Iwamatsu wrote: > 2010/10/25 Ben Dooks : > > On Mon, Oct 25, 2010 at 08:13:25PM +0900, Paul Mundt wrote: > >> On Mon, Oct 25, 2010 at 11:47:18AM +0100, Ben Dooks wrote: > >> > On Mon, Oct 25, 2010 at 10:58:35AM +0900,

Re: [PATCH] sh: i2c-sh7760: Replase from ctrl_* to __raw_*

2010-10-25 Thread Paul Mundt
On Mon, Oct 25, 2010 at 11:47:18AM +0100, Ben Dooks wrote: > On Mon, Oct 25, 2010 at 10:58:35AM +0900, Paul Mundt wrote: > > On Sat, Oct 23, 2010 at 07:07:00AM +0900, Nobuhiro Iwamatsu wrote: > > > ctrl_* is deprecated. We should to use __raw_*. > > > > > &

Re: [PATCH] sh: i2c-sh7760: Replase from ctrl_* to __raw_*

2010-10-24 Thread Paul Mundt
On Sat, Oct 23, 2010 at 07:07:00AM +0900, Nobuhiro Iwamatsu wrote: > ctrl_* is deprecated. We should to use __raw_*. > > Signed-off-by: Nobuhiro Iwamatsu Applied, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majord...@vger.kernel.org

Re: idr_get_new_exact ?

2010-09-23 Thread Paul Mundt
On Mon, Sep 20, 2010 at 11:26:47PM +0200, Tejun Heo wrote: > Hello, > > On 09/20/2010 10:35 PM, Roland Dreier wrote: > > Looks fine to me as an improvement over the status quo, but I wonder how > > many of these places could use the radix_tree stuff instead? If you're > > not using the ability of

Re: [PATCH] i2c: i2c-sh_mobile irq rollback fix

2010-08-04 Thread Paul Mundt
On Mon, Aug 02, 2010 at 04:16:37PM +0900, Magnus Damm wrote: > From: Magnus Damm > > Update the i2c-sh_mobile driver to properly free > interrupts. The function sh_mobile_i2c_hook_irqs() > is fixed so module both unload and load are working > as expected. > > Signed-off-by: Magnus Damm Applied

Re: [PATCH] ARM: mach-shmobile: add INTCS macros

2010-04-07 Thread Paul Mundt
On Thu, Mar 11, 2010 at 02:30:30PM +0900, Magnus Damm wrote: > Add SH-Mobile ARM INTCS macros for the INTCS controller. On Thu, Mar 11, 2010 at 03:52:33PM +0900, Magnus Damm wrote: > Add support for the sh7367 INTCS interrupt controller. > > INTCS is the interrupt controller for the sh7367 SuperH

Re: [PATCH 00/03] i2c: i2c-sh_mobile update for SH-Mobile ARM

2010-04-06 Thread Paul Mundt
On Mon, Mar 15, 2010 at 06:30:05AM +, Ben Dooks wrote: > On Thu, Mar 11, 2010 at 07:05:26PM +0900, Magnus Damm wrote: > > i2c: i2c-sh_mobile update for SH-Mobile ARM > > > > [PATCH 01/03] i2c: i2c-sh_mobile register access code break out > > [PATCH 02/03] i2c: i2c-sh_mobile support for new ICI

Re: [PATCH] i2c/highlander: remover superflous variable

2010-02-02 Thread Paul Mundt
d_write can > only be 0 or 1 anyhow. So, we remove the flaw by simplifying the code. > > Reported-by: d binderman > Signed-off-by: Wolfram Sang > Cc: Paul Mundt > Cc: Jean Delvare > Cc: Ben Dooks Fine with me. Acked-by: Paul Mundt -- To unsubscribe from this list: send

[PATCH] i2c: Renesas SDK7786 FPGA I2C/SMBus support.

2010-01-14 Thread Paul Mundt
abstraction and leave it to the board code (which already has FPGA versioning information available to it) to figure out what it wants. These are fairly simple controllers, only supporting control and data registers, with no IRQ to speak of. Signed-off-by: Paul Mundt --- Note that the board support for

Re: [PATCH] i2c: Simplified CONFIG_I2C=n interface.

2009-05-27 Thread Paul Mundt
On Wed, May 27, 2009 at 09:18:31AM +0200, Jean Delvare wrote: > On Wed, 27 May 2009 16:08:50 +0900, Paul Mundt wrote: > > Another day, another module-related failure due to the i2c interface > > being used in code that optionally uses it: > > > > ERROR: "i2c_

[PATCH] i2c: Simplified CONFIG_I2C=n interface.

2009-05-27 Thread Paul Mundt
defs in to every driver that supports an optional i2c interface, this provides a stubbed set of interfaces for the CONFIG_I2C=n case. I've covered the obvious ones that cause the majority of the build failures, anything more involved really ought to have its dependencies fixed instead. Signed-o

Re: [patch 2/2] i2c: trivial endian casting fixes in i2c-highlander.c

2008-12-08 Thread Paul Mundt
On Mon, Dec 08, 2008 at 09:21:15AM +0100, Jean Delvare wrote: > On Mon, 8 Dec 2008 12:07:58 +0900, Paul Mundt wrote: > > On Fri, Dec 05, 2008 at 02:46:05PM +0100, Jean Delvare wrote: > > > Ben, Paul, any comment on this? > > > > > It's fine with me, do you

Re: [patch 2/2] i2c: trivial endian casting fixes in i2c-highlander.c

2008-12-07 Thread Paul Mundt
; > - *(u16 *)dst = cpu_to_be16p(src++); > > + *(__be16 *)dst = cpu_to_be16p(src++); > > dst += 2; > > } > > > > Ben, Paul, any comment on this? > It's fine with me, do you want to take this, or should I fold it in to my tree? Acked-by: Paul Mundt <[EMAIL PROTECTED]> -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html